loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Don't iterate over vertex pairs twice

Browse Source 
This doesn't actually improve performance for me, as EdgeCreatesCycle() tends to fail fast, but it's less obviously slow.
This commit is contained in:
Oliver Hamlet
2018-09-09 21:02:28 +01:00
parent 7dbda624ef
commit 264c6756a0
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/sorting/plugin_sorter.cpp
+5 -8
View File
@@ -720,19 +720,16 @@ void PluginSorter::AddTieBreakEdges() {
// possible result. This can be enforced by adding edges between all vertices
// that aren't already linked. Use existing load order to decide the direction
// of these edges.
for (const auto& vertex :
boost::make_iterator_range(boost::vertices(graph_))) {
vertex_it vit, vitend;
for (tie(vit, vitend) = boost::vertices(graph_); vit != vitend; ++vit) {
vertex_t vertex = *vit;
if (logger_) {
logger_->trace("Adding tie-break edges to vertex for \"{}\"",
graph_[vertex].GetName());
}
for (const auto& otherVertex :
boost::make_iterator_range(boost::vertices(graph_))) {
if (vertex == otherVertex ||
boost::edge(vertex, otherVertex, graph_).second ||
boost::edge(otherVertex, vertex, graph_).second)
continue;
for (vertex_it vit2 = std::next(vit); vit2 != vitend; ++vit2) {
vertex_t otherVertex = *vit2;
vertex_t toVertex, fromVertex;
if (ComparePlugins(graph_[vertex].GetName(),