linuxmsm/qdl
0
0
Fork 0
mirror of https://github.com/linux-msm/qdl.git synced 2026-02-25 13:12:25 -08:00
Code Issues Packages Projects Releases Wiki Activity

program: Clean up error handling in program_load

Browse Source 
Main difference is cleaning up 'doc' in case of errors.
This commit is contained in:
Luca Weiss
2024-05-10 07:44:33 +02:00
committed by Konrad Dybcio
parent 7cc2748c61
commit 0132a8eb5a
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
program.c
View File

@@ -127,7 +127,7 @@ int program_load(const char *program_file, bool is_nand)
xmlNode *node;
xmlNode *root;
xmlDoc *doc;
int errors;
int errors = 0;
doc = xmlReadFile(program_file, NULL, 0);
if (!doc) {
@@ -140,8 +140,6 @@ int program_load(const char *program_file, bool is_nand)
if (node->type != XML_ELEMENT_NODE)
continue;
errors = -EINVAL;
if (!xmlStrcmp(node->name, (xmlChar *)"erase"))
errors = load_erase_tag(node, is_nand);
else if (!xmlStrcmp(node->name, (xmlChar *)"program"))
@@ -152,12 +150,13 @@ int program_load(const char *program_file, bool is_nand)
}
if (errors)
return errors;
goto out;
}
out:
xmlFreeDoc(doc);
return 0;
return errors;
}
int program_execute(struct qdl_device *qdl, int (*apply)(struct qdl_device *qdl, struct program *program, int fd),