linuxmsm/pd-mapper
0
0
Fork 0
mirror of https://github.com/linux-msm/pd-mapper.git synced 2026-02-25 13:12:10 -08:00
Code Issues Packages Projects Releases Wiki Activity

correct SIGSEGV when firmware is not present

Browse Source 
pd-mapper will fail to start due to a SIGSEGV when any of the firmware
for the various remoteprocs are not present. ltrace isolated where the
problem was:

    ....
    strlen("qcom/sc8280xp/LENOVO/21BX/qcadsp"...)                                       = 41
    dirname(0xfffff9b66450, 0xfffff9b683b0, 36, 0xfffffff)                              = 0xfffff9b66450
    strcat("/lib/firmware/", "qcom/sc8280xp/LENOVO/21BX")                               = "/lib/firmware/qcom/sc8280xp/LENO"...
    opendir("/lib/firmware/qcom/sc8280xp/LENO"...)                                      = nil
    readdir(nil <no return ...>
    --- SIGSEGV (Segmentation fault) ---
    +++ killed by SIGSEGV +++

With this fix, pd-mapper now displays the following messages when the
firmware is not present:

    pd-mapper: Cannot open /lib/firmware/qcom/sc8280xp/LENOVO/21BX: No such file or directory
    pd-mapper: Cannot open /lib/firmware/qcom/sc8280xp/LENOVO/21BX: No such file or directory
    no pd maps available

Signed-off-by: Brian Masney <bmasney@redhat.com>
This commit is contained in:
Brian Masney
2022-10-12 07:44:03 -04:00
committed by Bjorn Andersson
parent a500e63481
commit b4c1e362f1
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pd-mapper.c
View File

@@ -251,6 +251,11 @@ static int pd_enumerate_jsons(struct assoc *json_set)
strcat(path, dirname(firmware_value));
fw_dir = opendir(path);
if (!fw_dir) {
warn("Cannot open %s", path);
continue;
}
while ((fw_de = readdir(fw_dir)) != NULL) {
if (!strcmp(fw_de->d_name, ".") || !strcmp(fw_de->d_name, ".."))
continue;