Niklas Schnelle 76631ffa2f
s390/ism: Fix and simplify add()/remove() callback handling ...
Previously the clients_lock was protecting the clients array against
concurrent addition/removal of clients but was also accessed from IRQ
context. This meant that it had to be a spinlock and that the add() and
remove() callbacks in which clients need to do allocation and take
mutexes can't be called under the clients_lock. To work around this these
callbacks were moved to workqueues. This not only introduced significant
complexity but is also subtly broken in at least one way.
In ism_dev_init() and ism_dev_exit() clients[i]->tgt_ism is used to
communicate the added/removed ISM device to the work function. While
write access to client[i]->tgt_ism is protected by the clients_lock and
the code waits that there is no pending add/remove work before and after
setting clients[i]->tgt_ism this is not enough. The problem is that the
wait happens based on per ISM device counters. Thus a concurrent
ism_dev_init()/ism_dev_exit() for a different ISM device may overwrite
a clients[i]->tgt_ism between unlocking the clients_lock and the
subsequent wait for the work to finnish.
Thankfully with the clients_lock no longer held in IRQ context it can be
turned into a mutex which can be held during the calls to add()/remove()
completely removing the need for the workqueues and the associated
broken housekeeping including the per ISM device counters and the
clients[i]->tgt_ism.
Fixes: 89e7d2ba61schnelle@linux.ibm.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2023-07-08 10:07:14 +01:00
2023-05-31 19:01:32 +01:00
2023-06-16 16:46:30 +02:00
2023-06-22 09:43:40 +02:00
2023-06-16 12:27:04 -06:00
2023-06-26 12:47:20 -07:00
2023-07-04 19:42:27 +01:00
2023-05-31 20:27:24 +01:00
2023-05-30 18:58:43 -05:00
2023-06-29 10:11:10 -07:00
2023-07-03 12:46:47 -07:00
2023-06-26 17:07:53 -07:00
2023-06-19 15:06:07 -04:00
2023-06-05 09:56:36 +01:00
2023-07-03 10:55:04 -07:00
2023-06-29 21:01:17 -07:00
2023-06-28 16:43:10 -07:00
2023-06-12 08:04:04 -06:00
2023-06-22 19:41:01 -07:00
2023-06-27 10:47:08 -04:00
2023-06-28 10:59:38 -07:00
2023-07-03 12:46:47 -07:00
2023-06-28 13:32:47 -07:00
2023-07-04 13:50:38 -07:00
2023-06-29 15:28:33 -07:00
2023-06-21 16:31:44 +05:30
2023-06-29 10:11:10 -07:00
2023-07-01 14:38:25 -07:00
2023-05-30 11:20:02 +02:00
2023-06-22 08:59:56 +02:00
2023-07-03 13:23:10 -07:00
2023-06-26 17:11:53 -07:00
2023-07-03 12:56:23 -07:00
2023-06-12 12:17:22 -05:00
2023-06-21 18:44:56 +02:00
2023-07-01 07:04:29 -04:00
2023-05-26 13:43:52 +02:00
2023-06-05 09:57:21 +02:00
2023-06-16 10:08:09 -06:00
2023-06-30 11:57:07 -07:00
2023-06-28 16:09:41 -06:00
2023-06-26 12:47:20 -07:00
2023-06-14 20:24:03 -06:00
2023-06-13 15:15:08 -07:00
2023-05-31 13:06:57 +02:00
2023-06-09 10:38:43 +01:00
2023-06-12 08:04:04 -06:00
2023-06-29 13:39:51 -07:00
2023-06-19 16:19:20 -07:00
2023-06-12 08:04:05 -06:00
2023-06-28 10:28:11 -07:00
2023-06-26 11:14:18 +02:00
2023-06-26 08:55:22 -07:00
2023-06-19 16:19:28 -07:00
2023-07-04 13:50:38 -07:00
2023-06-26 11:14:18 +02:00
2023-06-05 09:57:20 +02:00
2023-06-05 09:57:20 +02:00
2023-06-15 08:50:23 +01:00
2023-05-25 09:26:19 +02:00
2023-06-26 13:59:56 -07:00
2023-06-15 18:15:25 +02:00
2023-06-26 13:59:56 -07:00
2023-06-05 09:57:20 +02:00
2023-06-23 16:15:36 +08:00
2023-06-26 07:54:23 -06:00
2023-06-09 17:44:16 -07:00
2023-05-29 23:23:04 +09:00
2023-06-12 08:04:05 -06:00
2023-07-04 13:50:38 -07:00
2023-06-16 18:24:13 -04:00
2023-06-19 16:19:23 -07:00
2023-06-19 16:19:20 -07:00
2023-06-05 09:36:38 +02:00
2023-06-30 21:35:52 -07:00
2023-06-15 14:55:15 +02:00
2023-06-22 21:17:10 +09:00
2023-06-22 21:21:06 +09:00
2023-06-30 16:38:27 -07:00
2023-06-09 16:25:23 -07:00
2023-06-15 10:45:17 +02:00
2023-06-26 11:14:18 +02:00
2023-06-06 17:05:21 +02:00
2023-07-04 11:02:34 -07:00
2023-06-06 21:39:55 +09:00
2023-06-19 16:19:05 -07:00
2023-06-29 13:39:51 -07:00
2023-06-19 18:18:04 +02:00
2023-06-14 10:41:07 -07:00
2023-06-22 10:39:16 -04:00
2023-06-06 11:42:51 -07:00
2023-06-09 16:25:24 -07:00
2023-06-13 16:49:23 +02:00
2023-06-19 09:02:51 +02:00
2023-05-26 20:45:39 +02:00
2023-06-05 13:51:00 +02:00
2023-06-23 16:59:33 -07:00
2023-06-08 06:41:17 -07:00
2023-06-09 17:30:47 +02:00
2023-06-08 10:11:17 -04:00
2023-06-20 20:18:39 -07:00
2023-06-22 19:52:09 +02:00
2023-06-28 12:47:30 -07:00
2023-05-24 18:46:20 +02:00
2023-05-30 22:04:46 +03:00
2023-05-25 08:54:06 -06:00
2023-06-05 15:35:27 +02:00
2023-06-16 12:22:35 +01:00
2023-05-24 11:39:44 +02:00
2023-06-26 11:14:18 +02:00
2023-06-26 07:47:11 +02:00
2023-07-08 10:07:14 +01:00
2023-06-26 19:35:13 -04:00
2023-06-05 09:57:20 +02:00
2023-06-08 12:27:20 -07:00
2023-06-09 16:25:19 -07:00
2023-06-09 17:44:17 -07:00
2023-07-03 09:27:12 +01:00
2023-06-08 15:42:02 -07:00
2023-06-29 15:06:32 +01:00
2023-06-16 17:08:01 +02:00
2023-07-01 07:20:04 -04:00
2023-07-03 11:26:05 -07:00
2023-06-30 11:57:07 -07:00
2023-06-27 14:14:30 -07:00
2023-06-27 14:14:30 -07:00
2023-06-09 16:25:46 -07:00
2023-06-05 21:11:06 +02:00
2023-06-09 17:44:22 -07:00
2023-05-29 21:46:53 -07:00
2023-06-19 16:19:05 -07:00
2023-06-19 16:19:35 -07:00
2023-06-19 16:19:04 -07:00
2023-06-19 16:19:12 -07:00
2023-06-23 16:59:31 -07:00
2023-06-19 16:19:35 -07:00
2023-07-03 09:50:57 -07:00
2023-06-09 16:25:31 -07:00
2023-06-28 10:28:11 -07:00
2023-07-03 12:56:23 -07:00
2023-05-26 15:10:18 -07:00
2023-06-28 10:59:38 -07:00
2023-06-20 20:17:10 -07:00
2023-06-20 20:18:39 -07:00
2023-05-24 18:08:49 +02:00
2023-06-26 11:14:18 +02:00
2023-06-18 11:16:00 +01:00
2023-06-24 15:50:13 -07:00
2023-06-24 14:52:28 -07:00
2023-06-26 13:27:51 +02:00
2023-06-08 13:42:33 +02:00
2023-06-12 11:32:44 +01:00
2023-06-19 15:08:12 -04:00
2023-06-19 12:10:48 -04:00
2023-06-19 16:25:29 -07:00
2023-06-07 13:42:02 -07:00
2023-06-12 10:36:55 -07:00
2023-05-26 13:52:19 -07:00
2023-05-29 16:14:28 +01:00
2023-06-19 16:19:00 -07:00
2023-06-09 16:25:53 -07:00
2023-06-23 16:59:30 -07:00
2023-06-09 17:44:15 -07:00
2023-07-03 12:46:47 -07:00
2023-06-30 15:06:45 -07:00
2023-06-23 15:05:28 -05:00
2023-06-23 15:05:28 -05:00
2023-05-31 12:26:53 -05:00
2023-06-08 19:19:50 -07:00
2023-05-28 20:45:46 +02:00
2023-06-05 09:36:39 +02:00
2023-07-04 13:50:38 -07:00
2023-07-01 08:58:41 -07:00
2023-06-19 16:19:25 -07:00
2023-06-02 23:20:31 -07:00
2023-06-27 09:33:54 -07:00
2023-06-30 09:04:01 -07:00
2023-06-07 14:26:09 -06:00
2023-06-22 21:21:06 +09:00
2023-06-26 11:14:18 +02:00
2023-06-15 13:34:30 +02:00
2023-06-20 09:02:33 +01:00
2023-06-19 16:19:04 -07:00
2023-06-05 21:11:03 +02:00
2023-07-04 13:50:38 -07:00
2023-06-05 15:28:42 -07:00
2023-06-06 21:39:55 +09:00
2023-06-05 10:55:20 -06:00
2023-06-26 11:14:18 +02:00
2023-06-23 16:59:28 -07:00
2023-06-28 10:28:11 -07:00
2023-06-06 14:04:01 +01:00
2023-06-05 21:11:03 +02:00
2023-06-21 17:55:53 +02:00
2023-05-31 10:46:59 +01:00
2023-06-10 00:11:41 -07:00
2023-07-04 13:50:38 -07:00
2023-06-05 09:36:39 +02:00
2023-06-24 15:50:13 -07:00
2023-06-26 11:14:18 +02:00
2023-06-28 16:43:10 -07:00
2023-07-04 13:50:38 -07:00
2023-06-20 20:44:38 -07:00
2023-06-12 20:14:22 +03:00
2023-06-12 20:14:21 +03:00
2023-06-05 15:31:12 -07:00
2023-06-28 10:28:11 -07:00
2023-06-23 16:59:29 -07:00
2023-06-19 16:19:12 -07:00
2023-06-07 15:06:34 +02:00
2023-06-28 10:28:11 -07:00
2023-06-18 02:32:54 -07:00
2023-06-09 17:44:16 -07:00
2023-06-16 09:53:27 +03:00
2023-06-09 17:44:17 -07:00
2023-06-06 21:39:55 +09:00
2023-06-06 21:39:55 +09:00
2023-06-06 21:39:55 +09:00
2023-06-28 10:59:38 -07:00
2023-05-31 19:00:26 +01:00
2023-06-28 16:43:10 -07:00
2023-06-08 15:41:34 -07:00
2023-05-23 21:08:33 -04:00
2023-06-19 16:19:28 -07:00
2023-05-23 15:49:03 -06:00
2023-06-27 10:47:08 -04:00
2023-06-27 10:47:09 -04:00
2023-06-06 10:47:04 +02:00
2023-06-23 12:08:14 -07:00
2023-06-19 16:19:27 -07:00
Niklas Schnelle
76631ffa2f