mirror of
https://github.com/linux-msm/laptops-kernel.git
synced 2026-08-13 14:19:53 -07:00
ntfs: fix variable dereferenced before check ni in ntfs_attr_open()
Smatch warnings: ntfs_attr_open() warn: variable dereferenced before check 'ni' Moves the ntfs_debug() call after the NULL pointer checks to ensure safe access to the structure members. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
This commit is contained in:
+3
-3
@@ -2913,12 +2913,12 @@ int ntfs_attr_open(struct ntfs_inode *ni, const __le32 type,
|
||||
struct ntfs_inode *base_ni;
|
||||
int err;
|
||||
|
||||
ntfs_debug("Entering for inode %lld, attr 0x%x.\n",
|
||||
(unsigned long long)ni->mft_no, type);
|
||||
|
||||
if (!ni || !ni->vol)
|
||||
return -EINVAL;
|
||||
|
||||
ntfs_debug("Entering for inode %lld, attr 0x%x.\n",
|
||||
ni->mft_no, type);
|
||||
|
||||
if (NInoAttr(ni))
|
||||
base_ni = ni->ext.base_ntfs_ino;
|
||||
else
|
||||
|
||||
Reference in New Issue
Block a user