linuxmsm/laptops-kernel
0
0
Fork 0
mirror of https://github.com/linux-msm/laptops-kernel.git synced 2026-08-13 14:19:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

leds: multicolor: Change intensity_value to unsigned int

Browse Source 
Using min to compare the intensity_value with led_dev->max_brightness
causes a signedness error:

	drivers/leds/led-class-multicolor.c: In function 'multi_intensity_store':
	././include/linux/compiler_types.h:630:45: error:
	  call to '__compiletime_assert_195' declared with attribute error:
	    min(intensity_value[i], led_cdev->max_brightness) signedness error

Change the type of intensity_value to unsigned int to fix the signedness
error.

intensity_value is used to set mcled_cdev->subled_info[i].intensity,
which is unsigned int, too.

Fixes: 129f82752bce ("leds: multicolor: Limit intensity to max_brightness of LED")
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Link: https://patch.msgid.link/20260206-leds-multicolor-fix-signedness-error-v1-1-48a00ed33c07@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Michael Tretter
2026-03-10 09:22:53 +00:00
committed by Lee Jones
parent 6de23f81a5
commit b5227947e6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/leds/led-class-multicolor.c
+2 -2
View File
@@ -34,14 +34,14 @@ static ssize_t multi_intensity_store(struct device *dev,
struct led_classdev *led_cdev = dev_get_drvdata(dev);
struct led_classdev_mc *mcled_cdev = lcdev_to_mccdev(led_cdev);
int nrchars, offset = 0;
int intensity_value[LED_COLOR_ID_MAX];
unsigned int intensity_value[LED_COLOR_ID_MAX];
int i;
ssize_t ret;
mutex_lock(&led_cdev->led_access);
for (i = 0; i < mcled_cdev->num_colors; i++) {
ret = sscanf(buf + offset, "%i%n",
ret = sscanf(buf + offset, "%u%n",
&intensity_value[i], &nrchars);
if (ret != 1) {
ret = -EINVAL;