linuxmsm/laptops-kernel
0
0
Fork 0
mirror of https://github.com/linux-msm/laptops-kernel.git synced 2026-08-13 14:19:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

ata: libata-scsi: add support for the REMOVE ELEMENT AND MODIFY ZONES command

Browse Source 
Define the translation for the REMOVE ELEMENT AND MODIFY ZONES command
(SERVICE ACTION IN command with service action
SAI_REMOVE_ELEMENT_AND_MODIFY_ZONES) into the ATA command
ATA_CMD_REMOVE_ELEMENT_AND_MODIFY_ZONES with the new function
ata_scsi_remove_element_and_modify_zones_xlat()

The array of supported commands ata_supported_cmds is modified to add a
new entry for this command. ata_scsi_cmd_is_supported() is also modify to
correctly handle this new entry depending on the target device flag
ATA_DFLAG_DEPOP being set, and the target device being a ZAC zoned device.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
This commit is contained in:
Damien Le Moal
2026-07-18 10:09:15 +09:00
parent 1e307ca61a
commit b448bb42bd
2 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/ata/libata-scsi.c
+39
View File
@@ -3739,6 +3739,11 @@ static const struct ata_scsi_cmd ata_supported_cmds[] = {
.sa_valid = true,
.sa = SAI_RESTORE_ELEMENTS_AND_REBUILD
},
{
.op = SERVICE_ACTION_IN_16, .cdb_len = 16,
.sa_valid = true,
.sa = SAI_REMOVE_ELEMENT_AND_MODIFY_ZONES
},
{ .op = REPORT_LUNS, .cdb_len = 12 },
{ .op = ATA_12, .cdb_len = 12 },
{ .op = SECURITY_PROTOCOL_IN, .cdb_len = 12 },
@@ -3826,6 +3831,8 @@ static bool ata_scsi_cmd_is_supported(struct ata_device *dev, u8 op, u16 sa,
return dev->flags & ATA_DFLAG_DEPOP;
case SAI_RESTORE_ELEMENTS_AND_REBUILD:
return dev->flags & ATA_DFLAG_DEPOP_RESTORE;
case SAI_REMOVE_ELEMENT_AND_MODIFY_ZONES:
return dev->flags & ATA_DFLAG_DEPOP_MODIFY;
default:
return true;
}
@@ -4787,6 +4794,36 @@ ata_scsi_remove_element_and_truncate_xlat(struct ata_queued_cmd *qc)
return 0;
}
static unsigned int
ata_scsi_remove_element_and_modify_zones_xlat(struct ata_queued_cmd *qc)
{
struct scsi_cmnd *scmd = qc->scsicmd;
const u8 *cdb = scmd->cmnd;
struct ata_device *dev = qc->dev;
struct ata_taskfile *tf = &qc->tf;
u32 id;
if (!(dev->flags & ATA_DFLAG_DEPOP_MODIFY)) {
ata_scsi_set_sense(dev, scmd, ILLEGAL_REQUEST, 0x20, 0x0);
return 1;
}
id = get_unaligned_be32(&cdb[10]);
tf->protocol = ATA_PROT_NODATA;
tf->command = ATA_CMD_REMOVE_ELEMENT_AND_MODIFY_ZONES;
tf->hob_feature = (id >> 24) & 0xff;
tf->feature = (id >> 16) & 0xff;
tf->hob_nsect = (id >> 8) & 0xff;
tf->nsect = id & 0xff;
tf->device = ATA_LBA;
tf->flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE | ATA_TFLAG_LBA48;
qc->flags |= ATA_QCFLAG_RESULT_TF;
return 0;
}
static unsigned int
ata_scsi_restore_elements_and_rebuild_xlat(struct ata_queued_cmd *qc)
{
@@ -4895,6 +4932,8 @@ static inline ata_xlat_func_t ata_get_xlat_func(struct ata_device *dev,
return ata_scsi_get_phys_element_status_xlat;
if (sa == SAI_REMOVE_ELEMENT_AND_TRUNCATE)
return ata_scsi_remove_element_and_truncate_xlat;
if (sa == SAI_REMOVE_ELEMENT_AND_MODIFY_ZONES)
return ata_scsi_remove_element_and_modify_zones_xlat;
if (sa == SAI_RESTORE_ELEMENTS_AND_REBUILD)
return ata_scsi_restore_elements_and_rebuild_xlat;
break;
include/linux/ata.h
+1
View File
@@ -292,6 +292,7 @@ enum {
ATA_CMD_GET_PHYS_ELEMENT_STATUS = 0x12,
ATA_CMD_REMOVE_ELEMENT_AND_TRUNCATE = 0x7c,
ATA_CMD_RESTORE_ELEMENTS_AND_REBUILD = 0x7d,
ATA_CMD_REMOVE_ELEMENT_AND_MODIFY_ZONES = 0x7e,
/* marked obsolete in the ATA/ATAPI-7 spec */
ATA_CMD_RESTORE = 0x10,