mirror of
https://github.com/linux-msm/laptops-kernel.git
synced 2026-08-13 14:19:53 -07:00
net: prevent possible UAF in rtnl_prop_list_size()
I was mistaken by synchronize_rcu() [1] call in netdev_name_node_alt_destroy(), giving a false sense of RCU safety at delete times. We have to use list_del_rcu() to not confuse potential readers in rtnl_prop_list_size(). [1] This synchronize_rcu() call was later removed in commit723de3ebef("net: free altname using an RCU callback"). Fixes:9f30831390("net: add rcu safety to rtnl_prop_list_size()") Signed-off-by: Eric Dumazet <edumazet@google.com> Link: https://patch.msgid.link/20260502124102.499204-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
committed by
Jakub Kicinski
parent
9d7ebff0c3
commit
ac0841d7d2
+1
-1
@@ -371,7 +371,7 @@ static void netdev_name_node_alt_free(struct rcu_head *head)
|
||||
static void __netdev_name_node_alt_destroy(struct netdev_name_node *name_node)
|
||||
{
|
||||
netdev_name_node_del(name_node);
|
||||
list_del(&name_node->list);
|
||||
list_del_rcu(&name_node->list);
|
||||
call_rcu(&name_node->rcu, netdev_name_node_alt_free);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user