mirror of
https://github.com/linux-msm/laptops-kernel.git
synced 2026-08-13 14:19:53 -07:00
pwm: Fix invalid state detection
Commit9dd42d019e("pwm: Allow pwm state transitions from an invalid state") intended to allow some state transitions that were not allowed before. The idea is sane and back then I also got the code comment right, but the check for enabled is bogus. This resulted in state transitions for enabled states to be allowed to have invalid duty/period settings and thus it can happen that low-level drivers get requests for invalid states🙄. Invert the check to allow state transitions for disabled states only. Fixes:9dd42d019e("pwm: Allow pwm state transitions from an invalid state") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Link: https://lore.kernel.org/r/20250704172416.626433-2-u.kleine-koenig@baylibre.com Cc: stable@vger.kernel.org Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
This commit is contained in:
committed by
Uwe Kleine-König
parent
19272b37aa
commit
9ee124caae
+1
-1
@@ -596,7 +596,7 @@ static bool pwm_state_valid(const struct pwm_state *state)
|
||||
* and supposed to be ignored. So also ignore any strange values and
|
||||
* consider the state ok.
|
||||
*/
|
||||
if (state->enabled)
|
||||
if (!state->enabled)
|
||||
return true;
|
||||
|
||||
if (!state->period)
|
||||
|
||||
Reference in New Issue
Block a user