linuxmsm/laptops-kernel
0
0
Fork 0
mirror of https://github.com/linux-msm/laptops-kernel.git synced 2026-08-13 14:19:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

PCI/pwrctrl: generic: Simplify dev_err_probe() usage

Browse Source 
dev_err_probe() returns the error code passed to it, so this:

  dev_err_probe(dev, ret, "Failed to get slot regulators\n");
  return ret;

is equivalent to this:

  return dev_err_probe(dev, ret, "Failed to get slot regulators\n");

Simplify by using the latter.

Suggested-by: Bartosz Golaszewski <brgl@kernel.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20260220-topic-sm8650-ayaneo-pocket-s2-base-v5-2-1ad79caa1efa@linaro.org
This commit is contained in:
Neil Armstrong
2026-03-18 12:11:14 -05:00
committed by Bjorn Helgaas
parent ff124bbbca
commit 0862e2b06c
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/pci/pwrctrl/generic.c
+3 -6
View File
@@ -88,18 +88,15 @@ static int slot_pwrctrl_probe(struct platform_device *pdev)
ret = of_regulator_bulk_get_all(dev, dev_of_node(dev),
&slot->supplies);
if (ret < 0) {
dev_err_probe(dev, ret, "Failed to get slot regulators\n");
return ret;
}
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to get slot regulators\n");
slot->num_supplies = ret;
slot->clk = devm_clk_get_optional(dev, NULL);
if (IS_ERR(slot->clk)) {
if (IS_ERR(slot->clk))
return dev_err_probe(dev, PTR_ERR(slot->clk),
"Failed to enable slot clock\n");
}
skip_resources:
slot->pwrctrl.power_on = slot_pwrctrl_power_on;