Replace iovec-based packet assembly with direct linear copy in
queue_push_ndlc_flow(). The scatter-gather approach was creating
temporary stack variables and looping through iovecs unnecessarily
for simple header + msg + tail construction.
Scatter-gather makes sense for zero-copy I/O, not for building
new packets from scratch.
Signed-off-by: Madrajib Lab <madhabsharma94@gmail.com>
strncpy() stops at the first null byte, which truncates the abstract
socket name "\0diag" to an empty string. This will result in a
"Diag response: Bad command" failure, fix this by using memcpy to
copy the full 5 bytes including the leading null that marks the
abstract namespace.
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Register a QRTR peripheral for the SoC control processor so diag-router
can communicate with the soccp subsystem. One can rely on the following
commands to trigger SSR on SoCCP using send_data.
error fatal: send_data 75 37 03 152 00
wdog bite: send_data 75 37 03 152 01
Software exception (Null pointer): send_data 75 37 03 152 02
software exception (div by 0): send_data 75 37 03 152 03
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Added the support of NHDLC mode.DIAG packets using the newer
non‑HDLC framing format instead of full HDLC encoding to
reduce overhead and redundancy on reliable transports like USB.
Signed-off-by: Kyle Deng <chunkai.deng@oss.qualcomm.com>
Introduce a new queue push mechanism to build NHDLC frames and enqueue
them via the scatter-gather push function. This approach reduces memory
copies and improves performance for framed message transmission.
Signed-off-by: Kyle Deng <chunkai.deng@oss.qualcomm.com>
strncpy() will directly stop at the \0 of "\0diag".
This will result in a completely zero'ed address.
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Adding support for Diag-ID handshake and storing the information.
Diag-ID indicates and indexes the identity of the clients.
Signed-off-by: Kyle Deng <quic_chunkaid@quicinc.com>
The artifical timeout of 10 seconds on select() seems to be a
development remnant and causes a system in sleep to wake up
unnecessarily. Remove this and rely on the registered wake events.
Reported-by: Sreelakshmi Gownipalli <sgownipa@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Introduce a flow control context per peripheral and pass this to
dm_broadcast() for data channels in order for any queued messages to be
accounted for in the flow control context.
Associate the same flow control context with the read watcher for the
peripheral's incoming data descriptors to make the watch runner
selectively read from the given peripheral only when the number of
outstanding, queued, messages are below the threshold.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Allow users of dm_broadcast() to pass a flow context, which will
associate the created mbufs with the given flow.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Allow a flow context to be associated to a read queue and consider the
flow blockage when deciding to evaluate the associated file descriptor
for incoming data.
This allows clients to associate a read queue with the same flow context
as they will associate mbufs to be flow controlled with.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Introduce helpers for creating flow control object and allow these to be
associated with mbufs. The flow is incremented as the object is added to
a queue and decremented as the object is transmitted off the queue.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
The writeq needs to be removed when the remote goes away, so that we're
not trying to operate on stale queues.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
diag_ffs_recv copies mbuf->offset bytes into a fixed 16k buffer.
watch_handle_eventfd sets pending_aio->offset to ev->res, assuming
that ev->res represents the number of bytes read. But res can be
negative in error cases. This causes diag_ffs_recv to copy a very
large amount into a 16k buffer, smashing the stack.
Avoid populating pending_aio->offset if the result is failure.
Also, it appears that if the status code is EAGAIN, the I/O is
actually still in the system, and comes back later.
Signed-off-by: Evan Green <evangreen86@gmail.com>
For some reason, this string seems to need to be set to diag_dun rather
than DIAG to get QXDM and other tools fired up.
Signed-off-by: Evan Green <evangreen86@gmail.com>
Our compiler complains about the following:
router/common_cmds.c:142:49: warning: taking address of
packed member 'num_items' of class or structure 'diag_log_cmd_mask' may
result in an unaligned pointer value [-Waddress-of-packed-member]
Avoid directly passing the address of this member to a subroutine, and
instead do the passing via a local.
Signed-off-by: Evan Green <evangreen86@gmail.com>
If CFLAGS is set in the environment, it should be used. The Makefile
was previously clobbering it. Now it adds -Wall -g -O2 only if CFLAGS
was not specified.
Signed-off-by: Evan Green <evangreen86@gmail.com>
This commit has following changes
1) Add version number command support.
2) Set the event mask state correctly.
3) Check for packet header for the packets received on
data channel.
4) Send mask update control packets after sending feature mask to
peripheral.
Signed-off-by: Sreelakshmi Gownipalli <sgownipa@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
The DIAG client is supposed to register the DCI, while the remote will
register DCI_CMD. Update this to trigger the SDM845 modem to actually
initiate the communication, something that 8996 isn't so picky about.
Also add a comment describing the unusual handling of instance
identifier in DIAG.
Fixes: c96d6445c7 ("qrtr: Introduce initial qrtr support")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Include needed headers to fix following errors
| router/dm.h:41:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?
| ssize_t dm_send(struct diag_client *dm, const void *ptr, size_t len);
| ^~~~~~~
tools/send_data.c:55:9: error: variable 'tv' has initializer but
incomplete type
struct timeval tv = {5, 0};
^~~~~~~
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Add initial version with some notes on how to set up USB ConfigFS
GadgetFS and launch diag-router.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Default to support both QRTR based and RPMSG based communication, rather
than none. This default configuration allow us to run the binary on both
SDM845 and DB820c; but still make it possible to disable the RPMSG based
peripheral support when the host doesn't have the cross compile
environment for libudev.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Madrajib Lab
Sibi Sankar
Kyle Deng
Alexander Couzens
KyleDengChunkai
Jami Kettunen
Khem Raj
Bjorn Andersson
Evan Green
Sreelakshmi Gownipalli