linuxmsm/cdba
0
0
Fork 0
mirror of https://github.com/linux-msm/cdba.git synced 2026-02-25 13:11:56 -08:00
Code Issues Packages Projects Releases Wiki Activity

conmux: fix -Wsign-compare

Browse Source 
Code should avoid comparing signed and unsigned integers, because of
implicit case.  Explicit casts are safe because 'buf' size is 256.

  conmux.c: In function ‘registry_lookup’:
  conmux.c:169:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
    169 |         if (ret >= sizeof(buf))
        |                 ^~

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Krzysztof Kozlowski
2023-05-07 11:51:41 +02:00
committed by Bjorn Andersson
parent f47098ba58
commit edb41596e5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
conmux.c
View File

@@ -166,7 +166,7 @@ static int registry_lookup(const char *service, struct conmux_lookup *result)
err(1, "failed to connect to registry");
ret = snprintf(buf, sizeof(buf), "LOOKUP service=%s\n", service);
if (ret >= sizeof(buf))
if (ret >= (int)sizeof(buf))
errx(1, "service name too long for registry lookup request");
n = write(fd, buf, ret + 1);
@@ -273,7 +273,7 @@ void *conmux_open(struct device *dev)
err(1, "failed to connect to conmux instance");
ret = snprintf(req, sizeof(req), "CONNECT id=cdba:%s to=console\n", user);
if (ret >= sizeof(req))
if (ret >= (int)sizeof(req))
errx(1, "unable to fit connect request in buffer");
n = write(fd, req, ret + 1);