izzy/xemu
0
0
Fork 0
mirror of https://github.com/izzy2lost/xemu.git synced 2026-07-06 00:20:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

nv2a: Handle value in NV_PVIDEO_STOP writes

Browse Source 
Interprets the value written to the `NV_PVIDEO_STOP` register in a manner more
consistent with hardware. Specifically, if the low bit of the value is not set,
the PVIDEO overlay should remain active.

Fixes #1049

[Test](https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/pvideo_tests.cpp)
Note that, as this is testing video behavior, this test is interactive and
the value passed to the final SetPvideoStop call needs to be mutated and the
behavior observed.
This commit is contained in:
Erik Abair
2022-07-18 11:14:15 -07:00
committed by mborgerson
parent f29c2ff42c
commit ea0a906707
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hw/xbox/nv2a/pvideo.c
+5 -1
View File
@@ -62,7 +62,11 @@ void pvideo_write(void *opaque, hwaddr addr, uint64_t val, unsigned int size)
pvideo_vga_invalidate(d);
break;
case NV_PVIDEO_STOP:
d->pvideo.regs[NV_PVIDEO_BUFFER] = 0;
// PVIDEO_STOP may be set many times during the course of video playback
// but the overlay is only torn down if the 0th bit is 1.
if (val & 0x01) {
d->pvideo.regs[NV_PVIDEO_BUFFER] = 0;
}
// d->vga.enable_overlay = false;
pvideo_vga_invalidate(d);
break;