mirror of
https://github.com/izzy2lost/xemu.git
synced 2026-07-06 00:20:22 -07:00
qemu-config: never call the callback after an error, fix leak
Ensure that the callback to qemu_config_foreach is never called upon
an error, by moving the invocation before the "out" label.
Cc: armbru@redhat.com
Fixes: 3770141139 ("qemu-config: parse configuration files to a QDict", 2021-06-04)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
+2
-2
@@ -417,12 +417,12 @@ static int qemu_config_foreach(FILE *fp, QEMUConfigCB *cb, void *opaque,
|
||||
return res;
|
||||
}
|
||||
res = count;
|
||||
out:
|
||||
if (qdict) {
|
||||
cb(group, qdict, opaque, errp);
|
||||
qobject_unref(qdict);
|
||||
}
|
||||
out:
|
||||
loc_pop(&loc);
|
||||
qobject_unref(qdict);
|
||||
return res;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user