mirror of
https://github.com/izzy2lost/xemu.git
synced 2026-07-06 00:20:22 -07:00
bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx
The 'hwaddr' type is defined in "exec/hwaddr.h" as:
hwaddr is the type of a physical address
(its size can be different from 'target_ulong').
All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx:
$ fgrep define include/exec/hwaddr.h
#define HWADDR_H
#define HWADDR_BITS 64
#define HWADDR_MAX UINT64_MAX
#define TARGET_FMT_plx "%016" PRIx64
^^^^^^
#define HWADDR_PRId PRId64
#define HWADDR_PRIi PRIi64
#define HWADDR_PRIo PRIo64
#define HWADDR_PRIu PRIu64
#define HWADDR_PRIx PRIx64
#define HWADDR_PRIX PRIX64
Since hwaddr's size can be *different* from target_ulong, it is
very confusing to read one of its format using the 'TARGET_FMT_'
prefix, normally used for the target_long / target_ulong types:
$ fgrep TARGET_FMT_ include/exec/cpu-defs.h
#define TARGET_FMT_lx "%08x"
#define TARGET_FMT_ld "%d"
#define TARGET_FMT_lu "%u"
#define TARGET_FMT_lx "%016" PRIx64
#define TARGET_FMT_ld "%" PRId64
#define TARGET_FMT_lu "%" PRIu64
Apparently this format was missed during commit a8170e5e97
("Rename target_phys_addr_t to hwaddr"), so complete it by
doing a bulk-rename with:
$ sed -i -e s/TARGET_FMT_plx/HWADDR_FMT_plx/g $(git grep -l TARGET_FMT_plx)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230110212947.34557-1-philmd@linaro.org>
[thuth: Fix some warnings from checkpatch.pl along the way]
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
committed by
Thomas Huth
parent
6e6761d8fb
commit
883f2c591f
+1
-1
@@ -1142,7 +1142,7 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx,
|
||||
&xlat, &sz, full->attrs, &prot);
|
||||
assert(sz >= TARGET_PAGE_SIZE);
|
||||
|
||||
tlb_debug("vaddr=" TARGET_FMT_lx " paddr=0x" TARGET_FMT_plx
|
||||
tlb_debug("vaddr=" TARGET_FMT_lx " paddr=0x" HWADDR_FMT_plx
|
||||
" prot=%x idx=%d\n",
|
||||
vaddr, full->phys_addr, prot, mmu_idx);
|
||||
|
||||
|
||||
+12
-12
@@ -151,7 +151,7 @@ static uint64_t strongarm_pic_mem_read(void *opaque, hwaddr offset,
|
||||
case ICPR:
|
||||
return s->pending;
|
||||
default:
|
||||
printf("%s: Bad register offset 0x" TARGET_FMT_plx "\n",
|
||||
printf("%s: Bad register offset 0x" HWADDR_FMT_plx "\n",
|
||||
__func__, offset);
|
||||
return 0;
|
||||
}
|
||||
@@ -173,7 +173,7 @@ static void strongarm_pic_mem_write(void *opaque, hwaddr offset,
|
||||
s->int_idle = (value & 1) ? 0 : ~0;
|
||||
break;
|
||||
default:
|
||||
printf("%s: Bad register offset 0x" TARGET_FMT_plx "\n",
|
||||
printf("%s: Bad register offset 0x" HWADDR_FMT_plx "\n",
|
||||
__func__, offset);
|
||||
break;
|
||||
}
|
||||
@@ -333,7 +333,7 @@ static uint64_t strongarm_rtc_read(void *opaque, hwaddr addr,
|
||||
((qemu_clock_get_ms(rtc_clock) - s->last_hz) << 15) /
|
||||
(1000 * ((s->rttr & 0xffff) + 1));
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
@@ -375,7 +375,7 @@ static void strongarm_rtc_write(void *opaque, hwaddr addr,
|
||||
break;
|
||||
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -581,7 +581,7 @@ static uint64_t strongarm_gpio_read(void *opaque, hwaddr offset,
|
||||
return s->status;
|
||||
|
||||
default:
|
||||
printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset);
|
||||
printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset);
|
||||
}
|
||||
|
||||
return 0;
|
||||
@@ -626,7 +626,7 @@ static void strongarm_gpio_write(void *opaque, hwaddr offset,
|
||||
break;
|
||||
|
||||
default:
|
||||
printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset);
|
||||
printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -782,7 +782,7 @@ static uint64_t strongarm_ppc_read(void *opaque, hwaddr offset,
|
||||
return s->ppfr | ~0x7f001;
|
||||
|
||||
default:
|
||||
printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset);
|
||||
printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset);
|
||||
}
|
||||
|
||||
return 0;
|
||||
@@ -817,7 +817,7 @@ static void strongarm_ppc_write(void *opaque, hwaddr offset,
|
||||
break;
|
||||
|
||||
default:
|
||||
printf("%s: Bad offset 0x" TARGET_FMT_plx "\n", __func__, offset);
|
||||
printf("%s: Bad offset 0x" HWADDR_FMT_plx "\n", __func__, offset);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1164,7 +1164,7 @@ static uint64_t strongarm_uart_read(void *opaque, hwaddr addr,
|
||||
return s->utsr1;
|
||||
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
@@ -1221,7 +1221,7 @@ static void strongarm_uart_write(void *opaque, hwaddr addr,
|
||||
break;
|
||||
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1443,7 +1443,7 @@ static uint64_t strongarm_ssp_read(void *opaque, hwaddr addr,
|
||||
strongarm_ssp_fifo_update(s);
|
||||
return retval;
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
break;
|
||||
}
|
||||
return 0;
|
||||
@@ -1509,7 +1509,7 @@ static void strongarm_ssp_write(void *opaque, hwaddr addr,
|
||||
break;
|
||||
|
||||
default:
|
||||
printf("%s: Bad register 0x" TARGET_FMT_plx "\n", __func__, addr);
|
||||
printf("%s: Bad register 0x" HWADDR_FMT_plx "\n", __func__, addr);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -645,7 +645,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset,
|
||||
|
||||
error_flash:
|
||||
qemu_log_mask(LOG_UNIMP, "%s: Unimplemented flash cmd sequence "
|
||||
"(offset " TARGET_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)"
|
||||
"(offset " HWADDR_FMT_plx ", wcycle 0x%x cmd 0x%x value 0x%x)"
|
||||
"\n", __func__, offset, pfl->wcycle, pfl->cmd, value);
|
||||
|
||||
mode_read_array:
|
||||
|
||||
@@ -63,7 +63,7 @@ static uint64_t digic_uart_read(void *opaque, hwaddr addr,
|
||||
default:
|
||||
qemu_log_mask(LOG_UNIMP,
|
||||
"digic-uart: read access to unknown register 0x"
|
||||
TARGET_FMT_plx "\n", addr << 2);
|
||||
HWADDR_FMT_plx "\n", addr << 2);
|
||||
}
|
||||
|
||||
return ret;
|
||||
@@ -101,7 +101,7 @@ static void digic_uart_write(void *opaque, hwaddr addr, uint64_t value,
|
||||
default:
|
||||
qemu_log_mask(LOG_UNIMP,
|
||||
"digic-uart: write access to unknown register 0x"
|
||||
TARGET_FMT_plx "\n", addr << 2);
|
||||
HWADDR_FMT_plx "\n", addr << 2);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -113,7 +113,7 @@ ser_read(void *opaque, hwaddr addr, unsigned int size)
|
||||
break;
|
||||
default:
|
||||
r = s->regs[addr];
|
||||
D(qemu_log("%s " TARGET_FMT_plx "=%x\n", __func__, addr, r));
|
||||
D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr, r));
|
||||
break;
|
||||
}
|
||||
return r;
|
||||
@@ -127,7 +127,7 @@ ser_write(void *opaque, hwaddr addr,
|
||||
uint32_t value = val64;
|
||||
unsigned char ch = val64;
|
||||
|
||||
D(qemu_log("%s " TARGET_FMT_plx "=%x\n", __func__, addr, value));
|
||||
D(qemu_log("%s " HWADDR_FMT_plx "=%x\n", __func__, addr, value));
|
||||
addr >>= 2;
|
||||
switch (addr)
|
||||
{
|
||||
|
||||
+4
-4
@@ -1059,7 +1059,7 @@ ssize_t rom_add_file(const char *file, const char *fw_dir,
|
||||
rom->mr = mr;
|
||||
snprintf(devpath, sizeof(devpath), "/rom@%s", file);
|
||||
} else {
|
||||
snprintf(devpath, sizeof(devpath), "/rom@" TARGET_FMT_plx, addr);
|
||||
snprintf(devpath, sizeof(devpath), "/rom@" HWADDR_FMT_plx, addr);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1243,10 +1243,10 @@ static void rom_print_one_overlap_error(Rom *last_rom, Rom *rom)
|
||||
"\nThe following two regions overlap (in the %s address space):\n",
|
||||
rom_as_name(rom));
|
||||
error_printf(
|
||||
" %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n",
|
||||
" %s (addresses 0x" HWADDR_FMT_plx " - 0x" HWADDR_FMT_plx ")\n",
|
||||
last_rom->name, last_rom->addr, last_rom->addr + last_rom->romsize);
|
||||
error_printf(
|
||||
" %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n",
|
||||
" %s (addresses 0x" HWADDR_FMT_plx " - 0x" HWADDR_FMT_plx ")\n",
|
||||
rom->name, rom->addr, rom->addr + rom->romsize);
|
||||
}
|
||||
|
||||
@@ -1600,7 +1600,7 @@ HumanReadableText *qmp_x_query_roms(Error **errp)
|
||||
rom->romsize,
|
||||
rom->name);
|
||||
} else if (!rom->fw_file) {
|
||||
g_string_append_printf(buf, "addr=" TARGET_FMT_plx
|
||||
g_string_append_printf(buf, "addr=" HWADDR_FMT_plx
|
||||
" size=0x%06zx mem=%s name=\"%s\"\n",
|
||||
rom->addr, rom->romsize,
|
||||
rom->isrom ? "rom" : "ram",
|
||||
|
||||
+2
-2
@@ -269,7 +269,7 @@ static void sysbus_dev_print(Monitor *mon, DeviceState *dev, int indent)
|
||||
|
||||
for (i = 0; i < s->num_mmio; i++) {
|
||||
size = memory_region_size(s->mmio[i].memory);
|
||||
monitor_printf(mon, "%*smmio " TARGET_FMT_plx "/" TARGET_FMT_plx "\n",
|
||||
monitor_printf(mon, "%*smmio " HWADDR_FMT_plx "/" HWADDR_FMT_plx "\n",
|
||||
indent, "", s->mmio[i].addr, size);
|
||||
}
|
||||
}
|
||||
@@ -289,7 +289,7 @@ static char *sysbus_get_fw_dev_path(DeviceState *dev)
|
||||
}
|
||||
}
|
||||
if (s->num_mmio) {
|
||||
return g_strdup_printf("%s@" TARGET_FMT_plx, qdev_fw_name(dev),
|
||||
return g_strdup_printf("%s@" HWADDR_FMT_plx, qdev_fw_name(dev),
|
||||
s->mmio[0].addr);
|
||||
}
|
||||
if (s->num_pio) {
|
||||
|
||||
@@ -2041,7 +2041,7 @@ static uint64_t cirrus_vga_mem_read(void *opaque,
|
||||
} else {
|
||||
val = 0xff;
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"cirrus: mem_readb 0x" TARGET_FMT_plx "\n", addr);
|
||||
"cirrus: mem_readb 0x" HWADDR_FMT_plx "\n", addr);
|
||||
}
|
||||
return val;
|
||||
}
|
||||
@@ -2105,7 +2105,7 @@ static void cirrus_vga_mem_write(void *opaque,
|
||||
}
|
||||
} else {
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"cirrus: mem_writeb 0x" TARGET_FMT_plx " "
|
||||
"cirrus: mem_writeb 0x" HWADDR_FMT_plx " "
|
||||
"value 0x%02" PRIx64 "\n", addr, mem_value);
|
||||
}
|
||||
}
|
||||
|
||||
+2
-2
@@ -320,7 +320,7 @@ static uint64_t g364fb_ctrl_read(void *opaque,
|
||||
break;
|
||||
default:
|
||||
{
|
||||
error_report("g364: invalid read at [" TARGET_FMT_plx "]",
|
||||
error_report("g364: invalid read at [" HWADDR_FMT_plx "]",
|
||||
addr);
|
||||
val = 0;
|
||||
break;
|
||||
@@ -424,7 +424,7 @@ static void g364fb_ctrl_write(void *opaque,
|
||||
break;
|
||||
default:
|
||||
error_report("g364: invalid write of 0x%" PRIx64
|
||||
" at [" TARGET_FMT_plx "]", val, addr);
|
||||
" at [" HWADDR_FMT_plx "]", val, addr);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
+4
-4
@@ -875,7 +875,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val)
|
||||
uint32_t write_mask, bit_mask, set_mask;
|
||||
|
||||
#ifdef DEBUG_VGA_MEM
|
||||
printf("vga: [0x" TARGET_FMT_plx "] = 0x%02x\n", addr, val);
|
||||
printf("vga: [0x" HWADDR_FMT_plx "] = 0x%02x\n", addr, val);
|
||||
#endif
|
||||
/* convert to VGA memory offset */
|
||||
memory_map_mode = (s->gr[VGA_GFX_MISC] >> 2) & 3;
|
||||
@@ -909,7 +909,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val)
|
||||
assert(addr < s->vram_size);
|
||||
s->vram_ptr[addr] = val;
|
||||
#ifdef DEBUG_VGA_MEM
|
||||
printf("vga: chain4: [0x" TARGET_FMT_plx "]\n", addr);
|
||||
printf("vga: chain4: [0x" HWADDR_FMT_plx "]\n", addr);
|
||||
#endif
|
||||
s->plane_updated |= mask; /* only used to detect font change */
|
||||
memory_region_set_dirty(&s->vram, addr, 1);
|
||||
@@ -925,7 +925,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val)
|
||||
}
|
||||
s->vram_ptr[addr] = val;
|
||||
#ifdef DEBUG_VGA_MEM
|
||||
printf("vga: odd/even: [0x" TARGET_FMT_plx "]\n", addr);
|
||||
printf("vga: odd/even: [0x" HWADDR_FMT_plx "]\n", addr);
|
||||
#endif
|
||||
s->plane_updated |= mask; /* only used to detect font change */
|
||||
memory_region_set_dirty(&s->vram, addr, 1);
|
||||
@@ -1003,7 +1003,7 @@ void vga_mem_writeb(VGACommonState *s, hwaddr addr, uint32_t val)
|
||||
(((uint32_t *)s->vram_ptr)[addr] & ~write_mask) |
|
||||
(val & write_mask);
|
||||
#ifdef DEBUG_VGA_MEM
|
||||
printf("vga: latch: [0x" TARGET_FMT_plx "] mask=0x%08x val=0x%08x\n",
|
||||
printf("vga: latch: [0x" HWADDR_FMT_plx "] mask=0x%08x val=0x%08x\n",
|
||||
addr * 4, write_mask, val);
|
||||
#endif
|
||||
memory_region_set_dirty(&s->vram, addr << 2, sizeof(uint32_t));
|
||||
|
||||
+17
-17
@@ -269,34 +269,34 @@ static void channel_load_c(struct fs_dma_ctrl *ctrl, int c)
|
||||
|
||||
static void channel_load_d(struct fs_dma_ctrl *ctrl, int c)
|
||||
{
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA);
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA);
|
||||
|
||||
/* Load and decode. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr));
|
||||
/* Load and decode. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr));
|
||||
cpu_physical_memory_read(addr, &ctrl->channels[c].current_d,
|
||||
sizeof(ctrl->channels[c].current_d));
|
||||
|
||||
D(dump_d(c, &ctrl->channels[c].current_d));
|
||||
ctrl->channels[c].regs[RW_DATA] = addr;
|
||||
D(dump_d(c, &ctrl->channels[c].current_d));
|
||||
ctrl->channels[c].regs[RW_DATA] = addr;
|
||||
}
|
||||
|
||||
static void channel_store_c(struct fs_dma_ctrl *ctrl, int c)
|
||||
{
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_GROUP_DOWN);
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_GROUP_DOWN);
|
||||
|
||||
/* Encode and store. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr));
|
||||
D(dump_d(c, &ctrl->channels[c].current_d));
|
||||
/* Encode and store. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr));
|
||||
D(dump_d(c, &ctrl->channels[c].current_d));
|
||||
cpu_physical_memory_write(addr, &ctrl->channels[c].current_c,
|
||||
sizeof(ctrl->channels[c].current_c));
|
||||
}
|
||||
|
||||
static void channel_store_d(struct fs_dma_ctrl *ctrl, int c)
|
||||
{
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA);
|
||||
hwaddr addr = channel_reg(ctrl, c, RW_SAVED_DATA);
|
||||
|
||||
/* Encode and store. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" TARGET_FMT_plx "\n", __func__, c, addr));
|
||||
/* Encode and store. FIXME: handle endianness. */
|
||||
D(printf("%s ch=%d addr=" HWADDR_FMT_plx "\n", __func__, c, addr));
|
||||
cpu_physical_memory_write(addr, &ctrl->channels[c].current_d,
|
||||
sizeof(ctrl->channels[c].current_d));
|
||||
}
|
||||
@@ -574,8 +574,8 @@ static inline int channel_in_run(struct fs_dma_ctrl *ctrl, int c)
|
||||
|
||||
static uint32_t dma_rinvalid (void *opaque, hwaddr addr)
|
||||
{
|
||||
hw_error("Unsupported short raccess. reg=" TARGET_FMT_plx "\n", addr);
|
||||
return 0;
|
||||
hw_error("Unsupported short raccess. reg=" HWADDR_FMT_plx "\n", addr);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static uint64_t
|
||||
@@ -603,7 +603,7 @@ dma_read(void *opaque, hwaddr addr, unsigned int size)
|
||||
|
||||
default:
|
||||
r = ctrl->channels[c].regs[addr];
|
||||
D(printf ("%s c=%d addr=" TARGET_FMT_plx "\n",
|
||||
D(printf("%s c=%d addr=" HWADDR_FMT_plx "\n",
|
||||
__func__, c, addr));
|
||||
break;
|
||||
}
|
||||
@@ -613,7 +613,7 @@ dma_read(void *opaque, hwaddr addr, unsigned int size)
|
||||
static void
|
||||
dma_winvalid (void *opaque, hwaddr addr, uint32_t value)
|
||||
{
|
||||
hw_error("Unsupported short waccess. reg=" TARGET_FMT_plx "\n", addr);
|
||||
hw_error("Unsupported short waccess. reg=" HWADDR_FMT_plx "\n", addr);
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -686,7 +686,7 @@ dma_write(void *opaque, hwaddr addr,
|
||||
break;
|
||||
|
||||
default:
|
||||
D(printf ("%s c=%d " TARGET_FMT_plx "\n",
|
||||
D(printf("%s c=%d " HWADDR_FMT_plx "\n",
|
||||
__func__, c, addr));
|
||||
break;
|
||||
}
|
||||
|
||||
+7
-7
@@ -1373,7 +1373,7 @@ static void pl330_iomem_write(void *opaque, hwaddr offset,
|
||||
pl330_exec(s);
|
||||
} else {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: write of illegal value %u "
|
||||
"for offset " TARGET_FMT_plx "\n", (unsigned)value,
|
||||
"for offset " HWADDR_FMT_plx "\n", (unsigned)value,
|
||||
offset);
|
||||
}
|
||||
break;
|
||||
@@ -1384,7 +1384,7 @@ static void pl330_iomem_write(void *opaque, hwaddr offset,
|
||||
s->dbg[1] = value;
|
||||
break;
|
||||
default:
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad write offset " TARGET_FMT_plx
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad write offset " HWADDR_FMT_plx
|
||||
"\n", offset);
|
||||
break;
|
||||
}
|
||||
@@ -1409,7 +1409,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque,
|
||||
chan_id = offset >> 5;
|
||||
if (chan_id >= s->num_chnls) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset "
|
||||
TARGET_FMT_plx "\n", offset);
|
||||
HWADDR_FMT_plx "\n", offset);
|
||||
return 0;
|
||||
}
|
||||
switch (offset & 0x1f) {
|
||||
@@ -1425,7 +1425,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque,
|
||||
return s->chan[chan_id].lc[1];
|
||||
default:
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset "
|
||||
TARGET_FMT_plx "\n", offset);
|
||||
HWADDR_FMT_plx "\n", offset);
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
@@ -1434,7 +1434,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque,
|
||||
chan_id = offset >> 3;
|
||||
if (chan_id >= s->num_chnls) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset "
|
||||
TARGET_FMT_plx "\n", offset);
|
||||
HWADDR_FMT_plx "\n", offset);
|
||||
return 0;
|
||||
}
|
||||
switch ((offset >> 2) & 1) {
|
||||
@@ -1456,7 +1456,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque,
|
||||
chan_id = offset >> 2;
|
||||
if (chan_id >= s->num_chnls) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset "
|
||||
TARGET_FMT_plx "\n", offset);
|
||||
HWADDR_FMT_plx "\n", offset);
|
||||
return 0;
|
||||
}
|
||||
return s->chan[chan_id].fault_type;
|
||||
@@ -1495,7 +1495,7 @@ static inline uint32_t pl330_iomem_read_imp(void *opaque,
|
||||
return s->debug_status;
|
||||
default:
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "pl330: bad read offset "
|
||||
TARGET_FMT_plx "\n", offset);
|
||||
HWADDR_FMT_plx "\n", offset);
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -456,7 +456,7 @@ static uint64_t axidma_read(void *opaque, hwaddr addr,
|
||||
break;
|
||||
default:
|
||||
r = s->regs[addr];
|
||||
D(qemu_log("%s ch=%d addr=" TARGET_FMT_plx " v=%x\n",
|
||||
D(qemu_log("%s ch=%d addr=" HWADDR_FMT_plx " v=%x\n",
|
||||
__func__, sid, addr * 4, r));
|
||||
break;
|
||||
}
|
||||
@@ -509,7 +509,7 @@ static void axidma_write(void *opaque, hwaddr addr,
|
||||
}
|
||||
break;
|
||||
default:
|
||||
D(qemu_log("%s: ch=%d addr=" TARGET_FMT_plx " v=%x\n",
|
||||
D(qemu_log("%s: ch=%d addr=" HWADDR_FMT_plx " v=%x\n",
|
||||
__func__, sid, addr * 4, (unsigned)value));
|
||||
s->regs[addr] = value;
|
||||
break;
|
||||
|
||||
@@ -211,7 +211,7 @@ static uint32_t xlnx_csu_dma_read(XlnxCSUDMA *s, uint8_t *buf, uint32_t len)
|
||||
if (result == MEMTX_OK) {
|
||||
xlnx_csu_dma_data_process(s, buf, len);
|
||||
} else {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " TARGET_FMT_plx
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " HWADDR_FMT_plx
|
||||
" for mem read", __func__, addr);
|
||||
s->regs[R_INT_STATUS] |= R_INT_STATUS_AXI_BRESP_ERR_MASK;
|
||||
xlnx_csu_dma_update_irq(s);
|
||||
@@ -241,7 +241,7 @@ static uint32_t xlnx_csu_dma_write(XlnxCSUDMA *s, uint8_t *buf, uint32_t len)
|
||||
}
|
||||
|
||||
if (result != MEMTX_OK) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " TARGET_FMT_plx
|
||||
qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad address " HWADDR_FMT_plx
|
||||
" for mem write", __func__, addr);
|
||||
s->regs[R_INT_STATUS] |= R_INT_STATUS_AXI_BRESP_ERR_MASK;
|
||||
xlnx_csu_dma_update_irq(s);
|
||||
|
||||
+2
-2
@@ -224,7 +224,7 @@ static uint64_t mpc_i2c_read(void *opaque, hwaddr addr, unsigned size)
|
||||
break;
|
||||
}
|
||||
|
||||
DPRINTF("%s: addr " TARGET_FMT_plx " %02" PRIx32 "\n", __func__,
|
||||
DPRINTF("%s: addr " HWADDR_FMT_plx " %02" PRIx32 "\n", __func__,
|
||||
addr, value);
|
||||
return (uint64_t)value;
|
||||
}
|
||||
@@ -234,7 +234,7 @@ static void mpc_i2c_write(void *opaque, hwaddr addr,
|
||||
{
|
||||
MPCI2CState *s = opaque;
|
||||
|
||||
DPRINTF("%s: addr " TARGET_FMT_plx " val %08" PRIx64 "\n", __func__,
|
||||
DPRINTF("%s: addr " HWADDR_FMT_plx " val %08" PRIx64 "\n", __func__,
|
||||
addr, value);
|
||||
switch (addr) {
|
||||
case MPC_I2C_ADR:
|
||||
|
||||
+4
-4
@@ -137,7 +137,7 @@ static void mb_add_mod(MultibootState *s,
|
||||
stl_p(p + MB_MOD_END, end);
|
||||
stl_p(p + MB_MOD_CMDLINE, cmdline_phys);
|
||||
|
||||
mb_debug("mod%02d: "TARGET_FMT_plx" - "TARGET_FMT_plx,
|
||||
mb_debug("mod%02d: "HWADDR_FMT_plx" - "HWADDR_FMT_plx,
|
||||
s->mb_mods_count, start, end);
|
||||
|
||||
s->mb_mods_count++;
|
||||
@@ -353,7 +353,7 @@ int load_multiboot(X86MachineState *x86ms,
|
||||
mb_add_mod(&mbs, mbs.mb_buf_phys + offs,
|
||||
mbs.mb_buf_phys + offs + mb_mod_length, c);
|
||||
|
||||
mb_debug("mod_start: %p\nmod_end: %p\n cmdline: "TARGET_FMT_plx,
|
||||
mb_debug("mod_start: %p\nmod_end: %p\n cmdline: "HWADDR_FMT_plx,
|
||||
(char *)mbs.mb_buf + offs,
|
||||
(char *)mbs.mb_buf + offs + mb_mod_length, c);
|
||||
g_free(one_file);
|
||||
@@ -382,8 +382,8 @@ int load_multiboot(X86MachineState *x86ms,
|
||||
stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
|
||||
|
||||
mb_debug("multiboot: entry_addr = %#x", mh_entry_addr);
|
||||
mb_debug(" mb_buf_phys = "TARGET_FMT_plx, mbs.mb_buf_phys);
|
||||
mb_debug(" mod_start = "TARGET_FMT_plx,
|
||||
mb_debug(" mb_buf_phys = "HWADDR_FMT_plx, mbs.mb_buf_phys);
|
||||
mb_debug(" mod_start = "HWADDR_FMT_plx,
|
||||
mbs.mb_buf_phys + mbs.offset_mods);
|
||||
mb_debug(" mb_mods_count = %d", mbs.mb_mods_count);
|
||||
|
||||
|
||||
@@ -516,13 +516,13 @@ static void xen_set_memory(struct MemoryListener *listener,
|
||||
if (xen_set_mem_type(xen_domid, mem_type,
|
||||
start_addr >> TARGET_PAGE_BITS,
|
||||
size >> TARGET_PAGE_BITS)) {
|
||||
DPRINTF("xen_set_mem_type error, addr: "TARGET_FMT_plx"\n",
|
||||
DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n",
|
||||
start_addr);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
if (xen_remove_from_physmap(state, start_addr, size) < 0) {
|
||||
DPRINTF("physmapping does not exist at "TARGET_FMT_plx"\n", start_addr);
|
||||
DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n", start_addr);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -642,8 +642,8 @@ static void xen_sync_dirty_bitmap(XenIOState *state,
|
||||
#endif
|
||||
if (errno == ENODATA) {
|
||||
memory_region_set_dirty(framebuffer, 0, size);
|
||||
DPRINTF("xen: track_dirty_vram failed (0x" TARGET_FMT_plx
|
||||
", 0x" TARGET_FMT_plx "): %s\n",
|
||||
DPRINTF("xen: track_dirty_vram failed (0x" HWADDR_FMT_plx
|
||||
", 0x" HWADDR_FMT_plx "): %s\n",
|
||||
start_addr, start_addr + size, strerror(errno));
|
||||
}
|
||||
return;
|
||||
|
||||
@@ -357,7 +357,7 @@ tryagain:
|
||||
entry->lock++;
|
||||
if (entry->lock == 0) {
|
||||
fprintf(stderr,
|
||||
"mapcache entry lock overflow: "TARGET_FMT_plx" -> %p\n",
|
||||
"mapcache entry lock overflow: "HWADDR_FMT_plx" -> %p\n",
|
||||
entry->paddr_index, entry->vaddr_base);
|
||||
abort();
|
||||
}
|
||||
@@ -404,7 +404,7 @@ ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
|
||||
if (!found) {
|
||||
fprintf(stderr, "%s, could not find %p\n", __func__, ptr);
|
||||
QTAILQ_FOREACH(reventry, &mapcache->locked_entries, next) {
|
||||
DPRINTF(" "TARGET_FMT_plx" -> %p is present\n", reventry->paddr_index,
|
||||
DPRINTF(" "HWADDR_FMT_plx" -> %p is present\n", reventry->paddr_index,
|
||||
reventry->vaddr_req);
|
||||
}
|
||||
abort();
|
||||
@@ -445,7 +445,7 @@ static void xen_invalidate_map_cache_entry_unlocked(uint8_t *buffer)
|
||||
if (!found) {
|
||||
DPRINTF("%s, could not find %p\n", __func__, buffer);
|
||||
QTAILQ_FOREACH(reventry, &mapcache->locked_entries, next) {
|
||||
DPRINTF(" "TARGET_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req);
|
||||
DPRINTF(" "HWADDR_FMT_plx" -> %p is present\n", reventry->paddr_index, reventry->vaddr_req);
|
||||
}
|
||||
return;
|
||||
}
|
||||
@@ -503,7 +503,7 @@ void xen_invalidate_map_cache(void)
|
||||
continue;
|
||||
}
|
||||
fprintf(stderr, "Locked DMA mapping while invalidating mapcache!"
|
||||
" "TARGET_FMT_plx" -> %p is present\n",
|
||||
" "HWADDR_FMT_plx" -> %p is present\n",
|
||||
reventry->paddr_index, reventry->vaddr_req);
|
||||
}
|
||||
|
||||
@@ -562,7 +562,7 @@ static uint8_t *xen_replace_cache_entry_unlocked(hwaddr old_phys_addr,
|
||||
entry = entry->next;
|
||||
}
|
||||
if (!entry) {
|
||||
DPRINTF("Trying to update an entry for "TARGET_FMT_plx \
|
||||
DPRINTF("Trying to update an entry for "HWADDR_FMT_plx \
|
||||
"that is not in the mapcache!\n", old_phys_addr);
|
||||
return NULL;
|
||||
}
|
||||
@@ -570,15 +570,15 @@ static uint8_t *xen_replace_cache_entry_unlocked(hwaddr old_phys_addr,
|
||||
address_index = new_phys_addr >> MCACHE_BUCKET_SHIFT;
|
||||
address_offset = new_phys_addr & (MCACHE_BUCKET_SIZE - 1);
|
||||
|
||||
fprintf(stderr, "Replacing a dummy mapcache entry for "TARGET_FMT_plx \
|
||||
" with "TARGET_FMT_plx"\n", old_phys_addr, new_phys_addr);
|
||||
fprintf(stderr, "Replacing a dummy mapcache entry for "HWADDR_FMT_plx \
|
||||
" with "HWADDR_FMT_plx"\n", old_phys_addr, new_phys_addr);
|
||||
|
||||
xen_remap_bucket(entry, entry->vaddr_base,
|
||||
cache_size, address_index, false);
|
||||
if (!test_bits(address_offset >> XC_PAGE_SHIFT,
|
||||
test_bit_size >> XC_PAGE_SHIFT,
|
||||
entry->valid_mapping)) {
|
||||
DPRINTF("Unable to update a mapcache entry for "TARGET_FMT_plx"!\n",
|
||||
DPRINTF("Unable to update a mapcache entry for "HWADDR_FMT_plx"!\n",
|
||||
old_phys_addr);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
@@ -445,7 +445,7 @@ static uint64_t platform_mmio_read(void *opaque, hwaddr addr,
|
||||
unsigned size)
|
||||
{
|
||||
DPRINTF("Warning: attempted read from physical address "
|
||||
"0x" TARGET_FMT_plx " in xen platform mmio space\n", addr);
|
||||
"0x" HWADDR_FMT_plx " in xen platform mmio space\n", addr);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -454,7 +454,7 @@ static void platform_mmio_write(void *opaque, hwaddr addr,
|
||||
uint64_t val, unsigned size)
|
||||
{
|
||||
DPRINTF("Warning: attempted write of 0x%"PRIx64" to physical "
|
||||
"address 0x" TARGET_FMT_plx " in xen platform mmio space\n",
|
||||
"address 0x" HWADDR_FMT_plx " in xen platform mmio space\n",
|
||||
val, addr);
|
||||
}
|
||||
|
||||
|
||||
@@ -564,7 +564,7 @@ static bool gicd_readl(GICv3State *s, hwaddr offset,
|
||||
/* WO registers, return unknown value */
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"%s: invalid guest read from WO register at offset "
|
||||
TARGET_FMT_plx "\n", __func__, offset);
|
||||
HWADDR_FMT_plx "\n", __func__, offset);
|
||||
*data = 0;
|
||||
return true;
|
||||
default:
|
||||
@@ -773,7 +773,7 @@ static bool gicd_writel(GICv3State *s, hwaddr offset,
|
||||
/* RO registers, ignore the write */
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"%s: invalid guest write to RO register at offset "
|
||||
TARGET_FMT_plx "\n", __func__, offset);
|
||||
HWADDR_FMT_plx "\n", __func__, offset);
|
||||
return true;
|
||||
default:
|
||||
return false;
|
||||
@@ -838,7 +838,7 @@ MemTxResult gicv3_dist_read(void *opaque, hwaddr offset, uint64_t *data,
|
||||
|
||||
if (!r) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"%s: invalid guest read at offset " TARGET_FMT_plx
|
||||
"%s: invalid guest read at offset " HWADDR_FMT_plx
|
||||
" size %u\n", __func__, offset, size);
|
||||
trace_gicv3_dist_badread(offset, size, attrs.secure);
|
||||
/* The spec requires that reserved registers are RAZ/WI;
|
||||
@@ -879,7 +879,7 @@ MemTxResult gicv3_dist_write(void *opaque, hwaddr offset, uint64_t data,
|
||||
|
||||
if (!r) {
|
||||
qemu_log_mask(LOG_GUEST_ERROR,
|
||||
"%s: invalid guest write at offset " TARGET_FMT_plx
|
||||
"%s: invalid guest write at offset " HWADDR_FMT_plx
|
||||
" size %u\n", __func__, offset, size);
|
||||
trace_gicv3_dist_badwrite(offset, data, size, attrs.secure);
|
||||
/* The spec requires that reserved registers are RAZ/WI;
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user