izzy/xemu
0
0
Fork 0
mirror of https://github.com/izzy2lost/xemu.git synced 2026-07-06 00:20:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

ppc/xive: Redistribute phys after pulling of pool context

Browse Source 
After pulling the pool context, if a pool irq had been presented and
was cleared in the process, there could be a pending irq in phys that
should be presented. Process the phys irq ring after pulling pool ring
to catch this case and avoid losing irqs.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Glenn Miles <milesg@linux.ibm.com>
Reviewed-by: Michael Kowal <kowal@linux.ibm.com>
Tested-by: Gautam Menghani <gautam@linux.ibm.com>
Link: https://lore.kernel.org/qemu-devel/20250512031100.439842-43-npiggin@gmail.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Nicholas Piggin
2025-07-21 08:03:53 +02:00
committed by Cédric Le Goater
parent 7a40b50757
commit 565e6d4d21
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hw/intc/xive.c
+3
View File
@@ -320,6 +320,9 @@ static uint64_t xive_tm_pull_pool_ctx(XivePresenter *xptr, XiveTCTX *tctx,
xive_tctx_reset_signal(tctx, TM_QW1_OS);
xive_tctx_reset_signal(tctx, TM_QW2_HV_POOL);
/* Re-check phys for interrupts if pool was disabled */
xive_tctx_pipr_recompute_from_ipb(tctx, TM_QW3_HV_PHYS);
return qw2w2;
}
hw/intc/xive2.c
+14 -2
View File
@@ -683,6 +683,8 @@ static void xive2_redistribute(Xive2Router *xrtr, XiveTCTX *tctx, uint8_t ring)
xive_tctx_reset_signal(tctx, ring);
}
static void xive2_tctx_process_pending(XiveTCTX *tctx, uint8_t sig_ring);
static uint64_t xive2_tm_pull_ctx(XivePresenter *xptr, XiveTCTX *tctx,
hwaddr offset, unsigned size, uint8_t ring)
{
@@ -739,6 +741,18 @@ static uint64_t xive2_tm_pull_ctx(XivePresenter *xptr, XiveTCTX *tctx,
}
}
if (ring == TM_QW2_HV_POOL) {
/* Re-check phys for interrupts if pool was disabled */
nsr = tctx->regs[TM_QW3_HV_PHYS + TM_NSR];
if (xive_nsr_indicates_exception(TM_QW3_HV_PHYS, nsr)) {
/* Ring must be PHYS because POOL would have been redistributed */
g_assert(xive_nsr_exception_ring(TM_QW3_HV_PHYS, nsr) ==
TM_QW3_HV_PHYS);
} else {
xive2_tctx_process_pending(tctx, TM_QW3_HV_PHYS);
}
}
if (xive2_router_get_config(xrtr) & XIVE2_VP_SAVE_RESTORE && do_save) {
xive2_tctx_save_ctx(xrtr, tctx, ring, nvp_blk, nvp_idx);
}
@@ -925,8 +939,6 @@ static uint8_t xive2_tctx_restore_ctx(Xive2Router *xrtr, XiveTCTX *tctx,
return cppr;
}
static void xive2_tctx_process_pending(XiveTCTX *tctx, uint8_t sig_ring);
static void xive2_tctx_need_resend(Xive2Router *xrtr, XiveTCTX *tctx,
uint8_t nvp_blk, uint32_t nvp_idx,
bool do_restore)