izzy/xemu
0
0
Fork 0
mirror of https://github.com/izzy2lost/xemu.git synced 2026-07-06 00:20:22 -07:00
Code Issues Packages Projects Releases Wiki Activity

hw/misc/max78000_aes: Comment Internal Key Storage

Browse Source 
Coverity Scan noted an unusual pattern in the
MAX78000 aes device, with duplicated calls to
set_decrypt. This commit adds a comment noting
why the implementation is correct.

Signed-off-by: Jackson Donaldson <jcksn@duck.com>
Message-id: 20250716002622.84685-1-jcksn@duck.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Jackson Donaldson
2025-07-21 10:07:53 +01:00
committed by Peter Maydell
parent e74aad9f81
commit 30dbcd9283
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hw/misc/max78000_aes.c
+6
View File
@@ -79,6 +79,12 @@ static void max78000_aes_do_crypto(Max78000AesState *s)
keydata += 8;
}
/*
* The MAX78000 AES engine stores an internal key, which it uses only
* for decryption. This results in the slighly odd looking pairs of
* set_encrypt and set_decrypt calls below; s->internal_key is
* being stored for later use in both cases.
*/
AES_KEY key;
if ((s->ctrl & TYPE) == 0) {
AES_set_encrypt_key(keydata, keylen, &key);