Commit Graph
3 Commits
Author SHA1 Message Date
74776bf112 docs: Add Doxygen documentation to all public headers and bridge APIs (#1065)
* docs: add Doxygen documentation comments to public headers

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/ac57bbd2-5ec9-4b74-a1fb-5a893e4bf5c7

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* docs: add Doxygen comments to all remaining classes.h + bridge headers

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/7a4feced-e03b-404a-9f9d-20cbb63b33e1

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* docs: complete Doxygen coverage of all public + bridge headers

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/7a4feced-e03b-404a-9f9d-20cbb63b33e1

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* style: apply clang-format-14 to fix tidy-format-validation failures

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/db20ac85-c1b1-41ef-a1dc-8c72758c0ca8

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* fix: address PR review comments on documentation and Stream::Read signature

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/a77e3bd9-ef1e-43fd-b12f-c73385069307

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* refactor: use Seek for BinaryReader::Read skip instead of allocating temp buffer

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/4153ca67-c4f9-4369-aa3b-f60396eb69ea

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* docs: add Doxygen documentation to ScriptLoader.h

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/b388c2e1-f44b-4db1-bd32-ff694295e657

Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>

* Update include/libultraship/controller/controldeck/ControlDeck.h

* Update include/ship/window/gui/GameOverlay.h

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>
Co-authored-by: Kenix3 <kenixwhisperwind@gmail.com>
2026-04-15 20:16:03 -04:00
CopilotandKenix3 21f82121f0 General code improvements: memory safety, const correctness, bug fixes (#1067)
- CrashHandler: Replace raw new/delete with std::unique_ptr<char[]>
- CrashHandler: Fix broken delegating constructor (was creating temp, not delegating)
- Console::HasCommand: Use std::map::contains() instead of linear search
- Console::GetCommand: Throw on missing key instead of silently inserting via operator[]
- Console::Run: Eliminate redundant map lookup by using iterator
- Context: Add const to all getter methods
- Context: Change string parameters from pass-by-value to const reference
- StringHelper::EndsWith: Replace strlen(c_str()) with size(), add bounds check
- StringHelper::Replace/ReplaceOriginal: Fix infinite loop when from is substring of to
- StringHelper::Sprintf: Remove commented-out dead code

Agent-Logs-Url: https://github.com/Kenix3/libultraship/sessions/9731b978-4aca-4e05-af28-3b6f45b5b09e

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Kenix3 <18299654+Kenix3@users.noreply.github.com>
2026-04-14 21:59:03 -04:00
2782e554d9 restructure files so headers live in /include (#924)
* Un-static variables, private them, and add getters/setters for them.

* ci: temporarily disable iOS

* move all the files

* some cmake error stuff

* glorified stash

* another glorified stash

* some header stuff

* more header progress

* another glorified stash

* it builds

* more

* another

* remove files we shouldn't have there

* more

* move stuff

* bridge stuff

* clang-format

* move

* mac error

* remove commented line

* mac error

* mac probably needs this too

* more mac

* another

* more mac

* mac

* oh mac

* hiding errors

* more mac errors hiding

* mac arc stuff

* ok that wasn't it what's going on

* is it the headers?

* none of this makes sense

* some windows error fixes

* more win error fixes

* missed one

* one more

* another

* more error

* error

* couple more

* fix tidy excludes

* fix some includes tidy caught

* fix cmake stuff found when building soh

* try to get tidy to not complain about stringhelper?

* i hate clang tidy

---------

Co-authored-by: Malkierian <malkierian@gmail.com>
Co-authored-by: briaguya <70942617+briaguya-ai@users.noreply.github.com>
2025-10-08 20:25:04 -04:00