You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
#lockdown Nick.Penwarden #rb None ========================== MAJOR FEATURES + CHANGES ========================== Change 3358140 on 2017/03/22 by Rolando.Caloca DR - Fix copy to cube face - Compile fix when using dump layer - Add new error enum Change 3358301 on 2017/03/22 by Mitchell.Wilson Initial check in of LODs in InfiltratorForward. First pass on optimization in level. Adding a visibility track for SceneCapture2D in tunnel section. Change 3358477 on 2017/03/22 by Mitchell.Wilson Updating Skeletal Mesh DPW_Robot_Export to resolve screen size being too low for LOD1. Cleaned up LOD1 which was showing some visible popping when transitioning. Change 3358529 on 2017/03/22 by Mark.Satterthwaite Globally disable clang's "constant-logical-operand" warning when running under Distcc - it is much easier and less invasive than constantly fixing the code. Change 3358745 on 2017/03/22 by Mark.Satterthwaite Disable another warning (parentheses-equality) under Distcc because again the separation of preprocessing from compilation means it turns up where it isn't expected. Change 3358837 on 2017/03/22 by Joe.Graf Merge of pull request #3214 for the RenderDocPlugin #CodeReview: matt.kuhlenschmidt, marcus.wassmer #rb: marcus.wassmer Change 3359112 on 2017/03/22 by Ben.Salem Update perf monitor to include frame time by default. Also, use only game/PIE world timers when in editor, instead of all worlds combined. #tests Ran several Showdown test runs with plugin! Change 3359363 on 2017/03/22 by Joe.Graf First pass at non-unity & no pch compilation Change 3359449 on 2017/03/22 by Joe.Graf Added missing null check when exporting a EXR on Linux (UE-40268) #CodeReview: dmitry.rekman #rb: n/a Change 3360349 on 2017/03/23 by Guillaume.Abadie Fixes TAA's AA_FORCE_ALPHA_CLAMP causing DOF layouts. #jira UE-42920 Change 3360405 on 2017/03/23 by Marcus.Wassmer Better method for detecting Kepler Change 3360718 on 2017/03/23 by Daniel.Wright Planar reflections handle views smaller than the render target in a general way * Fixes planar reflections with adaptive pixel density (ViewFamily size larger than actual views combined) * Planar reflections are now supported in splitscreen Change 3360758 on 2017/03/23 by Daniel.Wright [Copy] Added new light property bCastVolumetricShadow, which defaults to true for directional and sky lights, but false for point / spot lights as supporting volumetric fog shadowing has significant GPU overhead Change 3360762 on 2017/03/23 by Daniel.Wright [Copy] Texture flags are now properly routed to RHICreateTexture3D from the render target pool Change 3360768 on 2017/03/23 by Daniel.Wright [Copy] Disabled GPUProfiler histogram by default, controlled by r.ProfileGPU.ShowEventHistogram Change 3360770 on 2017/03/23 by Daniel.Wright [Copy] Disabled fast clears on CustomDepth, saves .2ms on xbox Change 3360771 on 2017/03/23 by Daniel.Wright [Copy] Particle lights no longer force tiled deferred lighting. Tiled deferred lighting is only used if enough unshadowed lights + particle lights are on screen. Saves 1.5ms Xbox with one particle light. Change 3360774 on 2017/03/23 by Daniel.Wright [Copy] Distance field cvar comments Change 3360782 on 2017/03/23 by Daniel.Wright [Copy] Disabled selection color on Volume materials Change 3360795 on 2017/03/23 by Daniel.Wright [Copy] Volume materials now specify Albedo and Extinction, which is more intuitive than Scattering and Absorption. Albedo is [0-1] reflectance, while Extinction is a world space density. Change 3360799 on 2017/03/23 by Daniel.Wright [Copy] Cinematic scalability levels get 2x volumetric fog resolution in x and y Change 3360806 on 2017/03/23 by Daniel.Wright [Copy] Fixed volumetric fog being offset when viewport min is not 0 Change 3360809 on 2017/03/23 by Daniel.Wright [Copy] Volumetric fog now adds a bias to the inverse squared light falloff denominator, prevents extreme aliasing from the hotspot. Can be controlled with r.VolumetricFog.InverseSquaredLightDistanceBiasScale. Change 3361651 on 2017/03/23 by Brian.Karis Higher quality sharp SSR at quality 4 Change 3361678 on 2017/03/23 by Brian.Karis Fresnel darkens diffuse for clearcoat. Change 3361683 on 2017/03/23 by Brian.Karis Fixed SSR artifact Change 3361691 on 2017/03/23 by Brian.Karis Chagned min roughness limit Change 3361707 on 2017/03/23 by Brian.Karis Added inverse film tone map Change 3361726 on 2017/03/23 by Brian.Karis Better precision inverse Change 3361758 on 2017/03/23 by Brian.Karis Material flag normal curvature to roughness is no longer forward only. Change 3361765 on 2017/03/23 by Brian.Karis Update ACES Change 3361774 on 2017/03/23 by Brian.Karis Cleaned up alpha support and disabled screen edge clipping. Change 3362478 on 2017/03/24 by Guillaume.Abadie Cherry pick 3316084's PostProcessing.cpp: Fixes a bug in Circle DOF where the apply pass was no longer using the downres DOF's TAA output. #author Brian.Karis #jira UE-42920 Change 3362738 on 2017/03/24 by Rolando.Caloca DR - Hide scene capture on IF Change 3362890 on 2017/03/24 by Guillaume.Abadie Renames r.SceneAlpha to r.PostProcessing.PropagateAlpha Change 3363665 on 2017/03/24 by Mark.Satterthwaite PR #3414: Add command line option "-noheartbeatthread" to disable heart beat thread (Contributed by JeffRous) Change 3363866 on 2017/03/24 by Arne.Schober DR - Updated NVAPI #RB Marcus.Wassmer Change 3364300 on 2017/03/24 by Brian.Karis SSR use dynamic velocity Change 3364372 on 2017/03/24 by Brian.Karis Fix changing off axis projection velocities. Change 3364373 on 2017/03/24 by Brian.Karis Enabled velocity drawing in scene captures Change 3365531 on 2017/03/27 by Guillaume.Abadie Computes the material's screen position material expression directly from the pixel shader SvPosition Change 3365764 on 2017/03/27 by Chris.Bunner Lowering severity of crash for missing values in scalability.ini. #jira UE-41331 Change 3365916 on 2017/03/27 by Guillaume.Abadie Exposes the viewport offset within the view property material expression Change 3365979 on 2017/03/27 by Brian.Karis Fixed skylight intensity from double applying Change 3365987 on 2017/03/27 by Brian.Karis Stopped post process indirect lighting intensity from scaling skylight reflections Change 3365991 on 2017/03/27 by Brian.Karis Fix for static analysis Change 3366028 on 2017/03/27 by Daniel.Wright Volumetric fog supports static shadowing from Stationary lights * Using bilinear on static shadowmap depths + 1 PCF to smooth out results Change 3366029 on 2017/03/27 by Daniel.Wright Static shadow depth maps for Stationary point and spot lights are 2x higher res by default (4x more texels), which is more appropriate for volumetric fog Change 3366055 on 2017/03/27 by Guillaume.Abadie Cherry picks 3251469: Implements scene capture component's CaptureSortPriority to control GPU execution order in order to manage inter dependencies. Change 3366447 on 2017/03/27 by Simon.Tourangeau Fix IES light profile importer. - Bug in the LM-63-1986 format importer. Change3366836on 2017/03/27 by Brian.Karis ClearUAV now supports int types Change 3367435 on 2017/03/28 by Benjamin.Hyder Submitting Decal Automation map for initial approval Change 3367572 on 2017/03/28 by Chris.Bunner Changed ClampedPow {max(abs(x),0.00001)} to PositiveClampedPow {max(x,0)} to give more expected results to Power node in material graphs. #jira UE-42989 Change 3367756 on 2017/03/28 by Olaf.Piesche Niagara material usage flags Change 3367835 on 2017/03/28 by Marcus.Wassmer Fix crash when TileRenderer runs before anything else. Make explicit behavior when rendering at a time when there is no valid scene. Change 3367837 on 2017/03/28 by Marcus.Wassmer Missed a file. Change 3367838 on 2017/03/28 by Richard.Wallis Updated items from original shelved version by Mark Satt: - Added MetalBackend.cpp to change main function string to have an initial crc + code length zero's **Description below taken from Mark Satt's original verison of this in CL3343280** Updated for Dev-Rendering's PSOs & integrates Richard's work on RHI shader libraries. Replace the FShaderCache's cook-time binary shader cache with Dmitriy Dyomin's standalone FShaderCodeLibrary that saves all shader byte-code arrays to files named by the FSHAHash. This de-duplicates shaders so we only ever store the byte code once. Includes optional support for generating a platform specific library file - which Metal implements to provide a single Metal library. The platform-native implementation can perform more de-duplication and in the case of Metal has lower file overheads and will compress more efficiently. - All of the support code for the FShaderCache's cook caching is gone, which affects all platforms. The FShaderCodeLibrary is currently supported by Cook-By-The-Book but can be used with iterate or child cookers - only DLC cooking requires further work. - With further modifications it should be possible to support Cook-on-the-Fly as well (output directories would be needed in FShaderCodeLibrary::InitForCooking) and the file-access pattern should be changed to use async. IO so that Material loading is not considered complete until all required byte-code arrays are loaded into the FShaderCodeLibrary. - For Metal archiving shaders this way will compile with debug information and the FShaderCodeLibrary, with some help from extensions to IShaderFormat, will save the debug information out into separate files during cooking - these can then be used to debug the game without having to locally recompile, recook & repackage but the shipped byte-code is stripped. Global shader caches are also subject to de-duplication in the library in order to support Metal's shader stripping. - File Move operations need to respect the 'Replace' flag - for FShaderCodeLibrary to work we need Move to be atomic. - This bumps the object version and will cause all content to recook. - Native library support is optional - only Metal currently implements one, but so could Vulkan and D3D12. For Metal the big advantages are further de-duplication where different materials generate the same MetalSL text but a different FSHAHash, that the single Metal library has lower overhead and that as a single file it all compresses far better (esp. with LZMA - 5x smaller). Change 3367854 on 2017/03/28 by Mark.Satterthwaite Don't track or record draw call resources for non-OpenGL shader platforms in the shader-cache as it is unnecessary and makes it slower on the CPU than it needs to be. Change 3367877 on 2017/03/28 by Brian.Karis Fixed linux build hopefully Change 3368001 on 2017/03/28 by Mark.Satterthwaite Compile fixes from Richard's checkin caused by not having visibility to all platforms from my original shelves. Change 3368019 on 2017/03/28 by Mark.Satterthwaite And another fix for Windows compilation of MetalShaderFormat. Change 3368042 on 2017/03/28 by Mark.Satterthwaite And a couple of simpler MSVC errors. Change 3368271 on 2017/03/28 by Mark.Satterthwaite Make SceneRenderTargets compile again. Change 3368691 on 2017/03/28 by Daniel.Wright [Copy from BenW] Renamed r.Shadow.MaxCSMShadowResolution to r.Shadow.MaxCSMResolution to match scalability inis Change 3369689 on 2017/03/29 by Marcus.Wassmer Fix non editor compile for now Change 3369862 on 2017/03/29 by Marcus.Wassmer Get the rest of the things compiling again. Change 3369896 on 2017/03/29 by Chris.Bunner Enabling AMD HDR support by default. #jira UE-42113 Change 3370535 on 2017/03/29 by Marcus.Wassmer DR - Fix template explicit instantiation for ClearUAV permutations #RB Brian.Karis, Arne.Schober Change 3370704 on 2017/03/29 by Rolando.Caloca DR - Rewrote GPU Skin Cache - Per section buffers - Limited memory per non-editor worlds (control with r.SkinCache.SceneMemoryLimitInMB) Copied from 3370529 Change 3371389 on 2017/03/30 by Richard.Wallis Remove temp working directories after archive packages built. Change 3371641 on 2017/03/30 by Rolando.Caloca DR - Copy 3371640 (fix mem leak) Change 3372436 on 2017/03/30 by Uriel.Doyon Added flags in UPrimitiveComponent to keep track of its state in the streaming manager. This allows to avoid unnecessary callback and processing in begin destroy reattach and being destroy logic. Removed the limitation of only processing UMeshComponent when handling spawed primitive. This releases the level manager from having to manage dynamic primitives. This improves performance by not having to manage dynamic references in the level manager. Primitives managed as dynamic now have a callback when ever their proxy is udpated, handling many cases automatically where previously a manual callback to notify would have been required. Fixed an issue where primitives with no reference to streaming textures would loose they dynamic state because of lack of references in the streamer. Change 3372740 on 2017/03/30 by Chris.Bunner [Experimental] Partial compute post process pipeline (r.PostProcess.PreferCompute). StencilSceneTexture added to deferred list. A few known issues to be fixed in a follow-up CL. Change 3372765 on 2017/03/30 by Uriel.Doyon Disabled concurrent call to NotifyPrimitiveUpdated while we don't have a safe concurrent update Change 3372979 on 2017/03/30 by Richard.Hinckley #jira UE-43501 The stencil buffer can now use single-channel bitmasks that ignore depth. This makes it possible to detect overlaps between stencil objects. Change 3373053 on 2017/03/30 by Simon.Tourangeau LPV Fade support - mostly integrated from CL 2959511 Change3373272on 2017/03/30 by Uriel.Doyon Added support for the concurrent update of dynamic primitives by the streaming manager. Change 3373450 on 2017/03/30 by Rolando.Caloca DR - FNT - Fix bad data for odd texcoord channels used on skin cache passthrough factory Copy 3373364 #jira UE-43492 Change 3373470 on 2017/03/30 by Marcus.Wassmer Nvidia Aftermath support Change 3374187 on 2017/03/31 by Chris.Bunner Volume texture support for CombineLUTs/Tonemap compute pass. Refactored common param code to shared sub-class in CombineLUTs and Tonemap PS/CS. Skip compute post process out-of-bounds writes. Unsigned type conversion fixes. Trimmed compute post process shader inputs. Change 3374233 on 2017/03/31 by Chris.Bunner Removed several redundant post process compute fences and resource transitions. Added testing CVar to force compute post processes to async (r.PostProcess.ForceAsyncDispatch). Change 3374412 on 2017/03/31 by Rolando.Caloca DR - Fix static analysis Change 3374544 on 2017/03/31 by Richard.Wallis FShaderCache Parallel-Context-Aware Merged with FShaderCache Single Library. Future Work - This was done before Engine PSO were in so this now needs a refector in the recording and playback on pipeline states instead an emulate PSO in OpenGL Driver. - Remove FShaderCacheState and replace the logic with FGraphicsPipelineStateInitializer which should be able to record from the RHI current pipeline state - This would reduce the Locking required as it's naturally per thread/context and only the final record would need a lock Change 3374588 on 2017/03/31 by Richard.Wallis Windows Compile Fixes Change 3374810 on 2017/03/31 by Benjamin.Hyder updating recommended GPU drivers Change 3375207 on 2017/03/31 by Rolando.Caloca DR - vk - Fixed swapchain format selection for some Linux platforms Change 3375248 on 2017/03/31 by Rolando.Caloca DR - vk - Prefer D32S8 Change 3375495 on 2017/03/31 by Rolando.Caloca DR - vk - Update to sdk 1.0.42.2 Change 3375496 on 2017/03/31 by Rolando.Caloca DR - Force compiling with updated Vulkan SDK Change 3375636 on 2017/03/31 by Mark.Satterthwaite Copying Metal improvements from task stream, with some modifications: - Off-by-default implementations for MTLFence & MTLHeap, including some small changes to the RHI interface for parallel contexts. - Support for Apple's Instruments "Points of Interest" tool. - Consolidation of some Mac & iOS compiler, memory and thread handling code. - Fixes for Metal not having implicit buffer SRV typecasting for DistanceField effects. - Improvements to the internal FMetalDebug layer, still off by default. - Limited support for Xcode automatic code-signing for iOS/tvOS. - Minimisation of render-target changes in some rendering code, esp. SceneOcclusion, DBufferDecals. - Added RHISetResourceAliasability_RenderThread to FDynamicRHI for RHIs to implement simple render-target aliasing. - Added FApplePlatformObject, a custom block allocator for Objective-C types (with NSZombie support) which is now used in MetalRHI to decrease allocation costs of Objective-C types. - Smattering of lesser fixes. Change 3375654 on 2017/03/31 by Mark.Satterthwaite Incremental Windows build fix. Change 3375656 on 2017/04/01 by Mark.Satterthwaite Correct extern declaration, including the module export macro which Mac unhelpfully doesn't enforce (for now...). Change 3375797 on 2017/04/01 by Mark.Satterthwaite Nullability qualifiers to fix Mac build-farm compilation: perversely this is not a problem for local builds... Change 3375798 on 2017/04/01 by Mark.Satterthwaite Fix the first mis-merge in ParticleGpuSimulation - these changes clearly weren't properly resolved in the task-stream. Change 3375835 on 2017/04/01 by Mark.Satterthwaite Try again with nullability and fix the occlusion changes as the PSO work wasn't merged correctly. Change 3376143 on 2017/04/02 by Mark.Satterthwaite Switch back to flat dSYMs for Dev-Rendering - they don't work with Instruments etc. but they are required by our build system. Change 3376324 on 2017/04/03 by Chris.Bunner Fixed cvar re-registration log spam and flagged a testing-only cvar as such. Change 3376726 on 2017/04/03 by Benjamin.Hyder Submitting initial HDR test map (WIP) Change 3376756 on 2017/04/03 by Guillaume.Abadie Fixes scene captures ordering's backward compatibility. Before, 2d scene captures were rendered before cube scene captures. The CaptureSortPriority broke backward compatibility by settings this new member to 0 in the USceneCaptureComponent's constructor. Since it is a higher come first policy, this CL set the default of this value to 1 in USceneCaptureComponent2D's constructor. Change 3377378 on 2017/04/03 by Arne.Schober DR - Fix ShaderRecompiling over and over again #RB Chris.Bunner Change 3377512 on 2017/04/03 by Daniel.Wright [Copy] Fixed profilegpu in d3d12 - initialize FLongGPUTaskPS when it is safe to do so, and fixed FSlateRHIRenderer's incorrect usage of draw events Change 3377518 on 2017/04/03 by Daniel.Wright [Copy] Distance field atlas coalesces updates to reduce RHIUpdateTexture3D memory overhead on d3d12 Change 3377526 on 2017/04/03 by Daniel.Wright [Copy] "Ran out of GPU queries!" log only happens once Change 3377535 on 2017/04/03 by Daniel.Wright [Copy] Fixed unreferenced local variable Change 3377539 on 2017/04/03 by Daniel.Wright [Copy] Xbox One RHIGetResourceInfo takes ESRAM into account - fixes render target pool 'VRamInKB request failed' messages Change 3377546 on 2017/04/03 by Daniel.Wright [Copy] Added r.LightMaxDrawDistanceScale for local light scalability Change 3377553 on 2017/04/03 by Daniel.Wright [Copy] Removed NEW_ESRAM_ALLOCATOR define and old unused path Change 3377560 on 2017/04/03 by Daniel.Wright [Copy] Fixed two d3d12 refcounting bugs causing -norhithread crashes Change 3377565 on 2017/04/03 by Daniel.Wright [Copy] Fixed Xbox One deleting GPU resources before the GPU is done reading from them (GRHINeedsExtraDeletionLatency was false) Change 3377572 on 2017/04/03 by Daniel.Wright [Copy] Disabled point / spot lights with MaxDrawDistance on LowPC Change 3377586 on 2017/04/03 by Daniel.Wright Fixed compile error Change 3377699 on 2017/04/03 by David.Hill FFT Code. Moved over from raven and refactored #review-3374589 @guillaume.abadie Change 3377910 on 2017/04/03 by David.Hill GPU FFT: Fix Linux Build adding a missing template<> to an IMPLEMENT_SHADER_TYPE Change 3378751 on 2017/04/04 by Marcus.Wassmer HQ particle lights now spawn attached to the same socket as their parent module. Change 3378819 on 2017/04/04 by Richard.Wallis Should be no need to protect shader cache against RHI thread now. Change 3378823 on 2017/04/04 by Richard.Wallis FRHIShaderLibrary Opaque Type - Base FRHIShaderLibrary has no Create*Shader functions and is passed to Overloaded RHICreate*Shader functions instead of creation directly through the library. - Assumed that only Native libraries will end up in the RHICreate*Shader functions. - ShaderCache and ShaderCode Libraries now inherit from a common factory interface. Change 3378883 on 2017/04/04 by Arne.Schober DR - Fix DCC build Change 3378885 on 2017/04/04 by Richard.Wallis Metal resource cast compile fix post merge. Change 3378946 on 2017/04/04 by Chris.Bunner SM4 assert fix. Change 3378953 on 2017/04/04 by Chris.Bunner Fixed type-correctness on legacy BreakMA material nodes and set more flexible formats to global attributes which should result in much more forgiving graphs for users. Allowed material nodes to opt out of mask-based pin coloration. #tests Compiled most Paragon materials + QAGame test maps. #jira UE-39885 Change 3379189 on 2017/04/04 by Arne.Schober DR - Fix aftermath staging Change 3379229 on 2017/04/04 by Arne.Schober DR - Fix missing include Change 3379374 on 2017/04/04 by Mark.Satterthwaite Revert an accidentally merged change in MacPlatformProcess that relies on further changes from the Metal task stream. Change 3379505 on 2017/04/04 by Rolando.Caloca DR - Fix mismatched interpolators Change 3379539 on 2017/04/04 by Mark.Satterthwaite No FFT for any hlslcc platform - the IR for one or more RWTexture2D isn't quite right... #jira UE-43626 Change 3379561 on 2017/04/04 by Rolando.Caloca DR - Fix root signature issues on D3D12 PC Change 3379590 on 2017/04/04 by Mark.Satterthwaite Back out changelist 3379539 & change the shader slightly instead, the HLSLCC library generates bogus IR when you have an inout RWTexture. #jira UE-43626 Change 3379917 on 2017/04/04 by Uriel.Doyon Fix to input mismatch Change 3380578 on 2017/04/05 by Chris.Bunner Shader type fixes. #jira UE-43652 Change 3380639 on 2017/04/05 by Rolando.Caloca DR - Expose GetOrCreate PSO and document Change 3380821 on 2017/04/05 by Guillaume.Abadie Fixes a crash in USceneCaptureComponent::UpdateDeferredCaptures() #jira UE-43642 Change 3381092 on 2017/04/05 by Guillaume.Abadie Cherry pick 3362517: Implements TAA's scene color unpremultiplication from alpha channel to reduce DOF alpha channel temporal ghosting. This CL take the oportunity to transform AA_ALPHA to an compile time enumeration, and add a basic TAA compile time configuration validation to improve readability of the different TAA passes' configurations. Change 3381300 on 2017/04/05 by Mark.Satterthwaite Quick fix for changes to MetalRHI's render-thread safe texture creation not correctly handling AVFoundation video player handing us an IOSurface. #jira UE-43597 Change3381359on 2017/04/05 by Guillaume.Abadie Back out changelist 3381092 Change 3381421 on 2017/04/05 by Mark.Satterthwaite Amended CL #3380995 from Richard Wallis to address crash in the Material Editor under the validation layer - when there are no textures bound the default pass descriptor assigns store actions, which means we can't override them with our deferred store actions. #jira UE-43689 Change 3381422 on 2017/04/05 by Mark.Satterthwaite Absolute time queries can't be batched in Metal but I also can't rely on them being started with a call to BeginQuery - only EndQuery. #jira UE-43691 Change3381503on 2017/04/05 by Daniel.Wright More intuitive controls for Volumetric Fog * Removed ScatteringScale / AbsorptionScale on Exponential Height Fog and added Albedo / Extinction * InscatteringColorCubemap is now supported by Volumetric Fog * Particle lights have a default VolumetricScatteringIntensity of 0 to avoid trailing * Tweaked GVolumetricFogDepthDistributionScale better for nearby details * Volume Materials have twice the interpolators available Change 3381527 on 2017/04/05 by Mark.Satterthwaite Disable Private GPU storage for PVRTC texture formats on iOS Metal - these require more changes to the blit-encoder usage as PVRTC has strange requirements. Change 3381671 on 2017/04/05 by Mark.Satterthwaite Better error message for failure to compile shaders remotely from PC for Metal. Change 3381769 on 2017/04/05 by Rolando.Caloca DR - Added lock texture array 2d on Vulkan Change 3382003 on 2017/04/05 by Mark.Satterthwaite Remove the automatic Metal aliasing/re-use when releasing some resource types as it doesn't work as intended. Change 3382030 on 2017/04/05 by Zachary.Wilson Fix compiling Metal text shaders from PC broken in merge from task stream. #submitter mark.satterthwaite #jira UE-43652 Change 3382880 on 2017/04/06 by Mark.Satterthwaite Michael Trepka's CL #3379927: VolumetricFogVoxelization implementation for Mac Change 3383315 on 2017/04/06 by Mark.Satterthwaite Partially revert CL #3382003 - the emulated Metal heaps require invoking makeAliasable in order to reclaim memory. #jira UE-43739 Change 3384639 on 2017/04/07 by Marcus.Wassmer Move ShaderResource version bump to RenderingObjectVersion Change 3384704 on 2017/04/07 by Mark.Satterthwaite Compile fix for merge. Change 3384933 on 2017/04/07 by Rolando.Caloca DR - Fix skin cache crash with BP (copy 3384714) Change 3385104 on 2017/04/07 by Mark.Satterthwaite Fix MetalRHI's abs(int2) handling - it can't be translated to fabs(int2) as that won't compile. Also rebuild hlslcc for my sanity. #jira UE-43783 Change 3385105 on 2017/04/07 by Mark.Satterthwaite Force a shader rebuild to ensure that everybody picks up the fix for #jira UE-43783 #jira UE-43783 Change 3385118 on 2017/04/07 by Arne.Schober DR - [OR-37359] - Fix disapearing Decals when StencilLod Fade is enabled #RB none Change 3385149 on 2017/04/07 by Marcus.Wassmer Fix skincache motion blur Change 3385189 on 2017/04/07 by Rolando.Caloca DR - Fix swapchain format for editor on Vulkan Change 3385287 on 2017/04/07 by Mark.Satterthwaite Enable SM5 on Intel as of 10.12.4 and later. Change 3385347 on 2017/04/07 by Rolando.Caloca DR - Temp fix for GL4 corruption on editor #jira UE-43785 Change 3385363 on 2017/04/07 by Rolando.Caloca DR - Actually fix all win platforms for GL bug #jira UE-43785 Change 3385557 on 2017/04/07 by Arne.Schober DR - [UE-43205] - Fix mesh paint #RB none Change3385608on 2017/04/07 by Daniel.Wright Fixed SampleCmp being used on a non-depth texture, causing a d3d error Change 3385980 on 2017/04/10 by Rolando.Caloca DR - Remove transition functions RHIClearColor* RHIClearDepthStencilTexture Change 3386042 on 2017/04/10 by Rolando.Caloca DR - Fix metal merge issue Change 3386157 on 2017/04/10 by Rolando.Caloca DR - Remove VS2013 libs generation off hlslcc & glslang (to match main) Change 3386356 on 2017/04/10 by Chris.Bunner Resolving merge errors. Change 3386414 on 2017/04/10 by Chris.Bunner Resolved merge issue in RendererScene.cpp. Change 3386700 on 2017/04/10 by Mark.Satterthwaite Silence documentation warnings. Change 3387178 on 2017/04/10 by Chris.Bunner Removed invalid mask correction on MakeMA material nodes. Change 3388177 on 2017/04/11 by Marcus.Wassmer Disable ensure that is no longer relevant now that we bind clear colors on texture creation Change 3388261 on 2017/04/11 by Chris.Bunner Static analysis fix. [CL3388266by Chris Bunner in Main branch]
1065 lines
42 KiB
C++
1065 lines
42 KiB
C++
// Copyright 1998-2017 Epic Games, Inc. All Rights Reserved.
|
|
|
|
/*=============================================================================
|
|
PostProcessFFTBlooom.cpp: Post processing blom using an FFT-based convolution.
|
|
=============================================================================*/
|
|
|
|
#include "PostProcess/PostProcessFFTBloom.h"
|
|
#include "PostProcess/RenderingCompositionGraph.h"
|
|
#include "GPUFastFourierTransform.h"
|
|
#include "ScenePrivate.h"
|
|
#include "GlobalShader.h"
|
|
#include "Shader.h"
|
|
|
|
#include "RendererModule.h" // for log
|
|
|
|
|
|
|
|
class FResizeAndCenterTextureCS : public FGlobalShader
|
|
{
|
|
|
|
public:
|
|
DECLARE_SHADER_TYPE(FResizeAndCenterTextureCS, Global);
|
|
|
|
FResizeAndCenterTextureCS() {};
|
|
|
|
FResizeAndCenterTextureCS(const ShaderMetaType::CompiledShaderInitializerType& Initializer)
|
|
: FGlobalShader(Initializer)
|
|
{
|
|
using GPUFFTComputeShaderUtils::FComputeParameterBinder;
|
|
|
|
FComputeParameterBinder Binder(Initializer.ParameterMap);
|
|
|
|
Binder(SrcROTexture, TEXT("SrcTexture"))
|
|
(SrcSampler, TEXT("SrcSampler"))
|
|
(DstRWTexture, TEXT("DstTexture"))
|
|
(DstExtent, TEXT("DstExtent"))
|
|
(ImageExtent, TEXT("ImageExtent"))
|
|
(KernelCenterAndScale, TEXT("KernelCenterAndScale"))
|
|
(DstBufferExtent, TEXT("DstBufferExtent"));
|
|
}
|
|
|
|
static bool ShouldCache(EShaderPlatform Platform)
|
|
{
|
|
return IsFeatureLevelSupported(Platform, ERHIFeatureLevel::SM5);
|
|
}
|
|
|
|
static void ModifyCompilationEnvironment(EShaderPlatform Platform, FShaderCompilerEnvironment& OutEnvironment)
|
|
{
|
|
FGlobalShader::ModifyCompilationEnvironment(Platform, OutEnvironment);
|
|
|
|
OutEnvironment.SetDefine(TEXT("INCLUDE_RESIZE_AND_CENTER"), 1);
|
|
OutEnvironment.SetDefine(TEXT("THREADS_PER_GROUP"), FResizeAndCenterTextureCS::NumThreadsPerGroup());
|
|
|
|
}
|
|
|
|
|
|
// Determine the number of threads used per scanline when writing the physical space kernel
|
|
static int32 NumThreadsPerGroup() { return 32; }
|
|
// Method for use with the FScopedUAVBind
|
|
FShaderResourceParameter& DestinationResourceParamter() { return DstRWTexture; }
|
|
|
|
static const TCHAR* GetSourceFilename() { return TEXT("PostProcessFFTBloom"); }
|
|
static const TCHAR* GetFunctionName() { return TEXT("ResizeAndCenterTextureCS"); }
|
|
|
|
void SetCSParamters(FRHICommandList& RHICmdList, const FRenderingCompositePassContext& Context,
|
|
const FIntPoint& DstExtentValue, const FIntPoint& ImageExtentValue, const float ResizeScaleValue,
|
|
const FVector2D& KernelUVCenter, const FTextureRHIRef& SrcTexture, const FIntPoint& DstBufferExtentValue,
|
|
const bool bForceCenterZero)
|
|
{
|
|
float CenterScale = bForceCenterZero ? 0.f : 1.f;
|
|
const FLinearColor KernelCenterAndScaleValue(KernelUVCenter.X, KernelUVCenter.Y, ResizeScaleValue, CenterScale);
|
|
|
|
const FComputeShaderRHIParamRef ShaderRHI = GetComputeShader();
|
|
|
|
// Set up the input. We have to do this explicitly because the FFT dispatches multiple compute shaders and manages their input/output.
|
|
|
|
GPUFFTComputeShaderUtils::FComputeParamterValueSetter ParamSetter(RHICmdList, ShaderRHI);
|
|
|
|
ParamSetter.Set<ESamplerFilter::SF_Bilinear, ESamplerAddressMode::AM_Wrap>(SrcROTexture, SrcSampler, SrcTexture);
|
|
|
|
ParamSetter(DstExtent, DstExtentValue)
|
|
(ImageExtent, ImageExtentValue)
|
|
(KernelCenterAndScale, KernelCenterAndScaleValue)
|
|
(DstBufferExtent, DstBufferExtentValue);
|
|
}
|
|
|
|
// FShader interface.
|
|
virtual bool Serialize(FArchive& Ar) override
|
|
{
|
|
bool bShaderHasOutdatedParameters = FGlobalShader::Serialize(Ar);
|
|
Ar << SrcROTexture
|
|
<< SrcSampler
|
|
<< DstRWTexture
|
|
<< DstExtent
|
|
<< ImageExtent
|
|
<< KernelCenterAndScale
|
|
<< DstBufferExtent;
|
|
return bShaderHasOutdatedParameters;
|
|
}
|
|
|
|
public:
|
|
|
|
FShaderResourceParameter SrcROTexture;
|
|
FShaderResourceParameter SrcSampler;
|
|
FShaderResourceParameter DstRWTexture;
|
|
FShaderParameter DstExtent;
|
|
FShaderParameter ImageExtent;
|
|
FShaderParameter KernelCenterAndScale;
|
|
FShaderParameter DstBufferExtent;
|
|
};
|
|
|
|
IMPLEMENT_SHADER_TYPE3(FResizeAndCenterTextureCS, SF_Compute);
|
|
|
|
|
|
|
|
class FCaptureKernelWeightsCS : public FGlobalShader
|
|
{
|
|
|
|
public:
|
|
DECLARE_SHADER_TYPE(FCaptureKernelWeightsCS, Global);
|
|
|
|
FCaptureKernelWeightsCS() {};
|
|
|
|
FCaptureKernelWeightsCS(const ShaderMetaType::CompiledShaderInitializerType& Initializer)
|
|
: FGlobalShader(Initializer)
|
|
{
|
|
using GPUFFTComputeShaderUtils::FComputeParameterBinder;
|
|
FComputeParameterBinder Binder(Initializer.ParameterMap);
|
|
|
|
Binder(HalfResKernelSrcROTexture, TEXT("HalfResSrcTexture"))
|
|
(PhysicalKernelSrcROTexture, TEXT("PhysicalSrcTexture"))
|
|
(PhyscalKernelSrcSampler, TEXT("PhysicalSrcSampler"))
|
|
(DstRWTexture, TEXT("DstTexture"))
|
|
(HalfResSumLocation, TEXT("HalfResSumLocation"))
|
|
(UVCenter, TEXT("UVCenter"));
|
|
}
|
|
|
|
static bool ShouldCache(EShaderPlatform Platform)
|
|
{
|
|
return IsFeatureLevelSupported(Platform, ERHIFeatureLevel::SM5);
|
|
}
|
|
|
|
static void ModifyCompilationEnvironment(EShaderPlatform Platform, FShaderCompilerEnvironment& OutEnvironment)
|
|
{
|
|
FGlobalShader::ModifyCompilationEnvironment(Platform, OutEnvironment);
|
|
OutEnvironment.SetDefine(TEXT("INCLUDE_CAPTURE_KERNEL_WEIGHTS"), 1);
|
|
}
|
|
|
|
// Method for use with the FScopedUAVBind
|
|
FShaderResourceParameter& DestinationResourceParamter() { return DstRWTexture; }
|
|
|
|
static const TCHAR* GetSourceFilename() { return TEXT("PostProcessFFTBloom"); }
|
|
static const TCHAR* GetFunctionName() { return TEXT("CaptureKernelWeightsCS"); }
|
|
|
|
|
|
void SetCSParamters(FRHICommandList& RHICmdList, const FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& HalfResKernelRef,
|
|
const FIntPoint& HalfResSumLocationValue,
|
|
const FTextureRHIRef& PhysicalKernelRef,
|
|
const FVector2D& UVCenterValue)
|
|
{
|
|
const FComputeShaderRHIParamRef ShaderRHI = GetComputeShader();
|
|
|
|
|
|
|
|
// Set up the input. We have to do this explicitly because the FFT dispatches multiple compute shaders and manages their input/output.
|
|
GPUFFTComputeShaderUtils::FComputeParamterValueSetter ParamSetter(RHICmdList, ShaderRHI);
|
|
ParamSetter.Set<ESamplerFilter::SF_Bilinear, ESamplerAddressMode::AM_Wrap>(PhysicalKernelSrcROTexture, PhyscalKernelSrcSampler, PhysicalKernelRef);
|
|
|
|
ParamSetter(HalfResKernelSrcROTexture, HalfResKernelRef)
|
|
(HalfResSumLocation, HalfResSumLocationValue)
|
|
(UVCenter, UVCenterValue);
|
|
}
|
|
|
|
// FShader interface.
|
|
virtual bool Serialize(FArchive& Ar) override
|
|
{
|
|
bool bShaderHasOutdatedParameters = FGlobalShader::Serialize(Ar);
|
|
Ar << HalfResKernelSrcROTexture
|
|
<< PhysicalKernelSrcROTexture
|
|
<< PhyscalKernelSrcSampler
|
|
<< DstRWTexture
|
|
<< HalfResSumLocation
|
|
<< UVCenter;
|
|
|
|
return bShaderHasOutdatedParameters;
|
|
}
|
|
|
|
public:
|
|
|
|
FShaderResourceParameter HalfResKernelSrcROTexture;
|
|
FShaderResourceParameter PhysicalKernelSrcROTexture;
|
|
FShaderResourceParameter PhyscalKernelSrcSampler;
|
|
FShaderResourceParameter DstRWTexture;
|
|
FShaderParameter HalfResSumLocation;
|
|
FShaderParameter UVCenter;
|
|
};
|
|
|
|
IMPLEMENT_SHADER_TYPE3(FCaptureKernelWeightsCS, SF_Compute);
|
|
|
|
|
|
class FBlendLowResCS : public FGlobalShader
|
|
{
|
|
|
|
public:
|
|
DECLARE_SHADER_TYPE(FBlendLowResCS, Global);
|
|
|
|
FBlendLowResCS() {};
|
|
|
|
FBlendLowResCS(const ShaderMetaType::CompiledShaderInitializerType& Initializer)
|
|
: FGlobalShader(Initializer)
|
|
{
|
|
using GPUFFTComputeShaderUtils::FComputeParameterBinder;
|
|
|
|
FComputeParameterBinder Binder(Initializer.ParameterMap);
|
|
Binder(FullResSrcROTexture, TEXT("SrcTexture"))
|
|
(HalfResSrcROTexture, TEXT("HalfResSrcTexture"))
|
|
(HalfResSrcSampler, TEXT("HalfResSrcSampler"))
|
|
(CenterWeight, TEXT("CenterWeightTexture"))
|
|
(DstRWTexture, TEXT("DstTexture"))
|
|
(DstRect, TEXT("DstRect"))
|
|
(HalfRect, TEXT("HalfRect"))
|
|
(HalfBufferSize, TEXT("HalfBufferSize"));
|
|
}
|
|
|
|
static bool ShouldCache(EShaderPlatform Platform)
|
|
{
|
|
return IsFeatureLevelSupported(Platform, ERHIFeatureLevel::SM5);
|
|
}
|
|
|
|
static void ModifyCompilationEnvironment(EShaderPlatform Platform, FShaderCompilerEnvironment& OutEnvironment)
|
|
{
|
|
FGlobalShader::ModifyCompilationEnvironment(Platform, OutEnvironment);
|
|
OutEnvironment.SetDefine(TEXT("INCLUDE_BLEND_LOW_RES"), 1);
|
|
OutEnvironment.SetDefine(TEXT("THREADS_PER_GROUP"), FBlendLowResCS::NumThreadsPerGroup());
|
|
}
|
|
|
|
// Method for use with the FScopedUAVBind
|
|
FShaderResourceParameter& DestinationResourceParamter() { return DstRWTexture; }
|
|
|
|
// Determine the number of threads used per scanline when writing the physical space kernel
|
|
static int32 NumThreadsPerGroup() { return 32; }
|
|
|
|
static const TCHAR* GetSourceFilename() { return TEXT("PostProcessFFTBloom"); }
|
|
static const TCHAR* GetFunctionName() { return TEXT("BlendLowResCS"); }
|
|
|
|
|
|
void SetCSParamters(FRHICommandList& RHICmdList, const FRenderingCompositePassContext& Context,
|
|
const FIntRect& TargetRect, const FIntRect& HalfResRect, const FIntPoint& HalfBufferExent, const FTextureRHIRef& CenterWeightTexutreRef,
|
|
const FTextureRHIRef& FullResTextureRef, const FTextureRHIRef& HalfResTextureRef)
|
|
{
|
|
|
|
using GPUFFTComputeShaderUtils::FComputeParamterValueSetter;
|
|
|
|
const FComputeShaderRHIParamRef ShaderRHI = GetComputeShader();
|
|
|
|
|
|
// Set up the input. We have to do this explicitly because the FFT dispatches multiple compute shaders and manages their input/output.
|
|
// We don't need a sampler for this texture ( will use .load)
|
|
SetTextureParameter(RHICmdList, ShaderRHI, CenterWeight, CenterWeightTexutreRef);
|
|
|
|
FComputeParamterValueSetter ParamSetter(RHICmdList, ShaderRHI);
|
|
|
|
ParamSetter.Set<ESamplerFilter::SF_Bilinear, ESamplerAddressMode::AM_Wrap>(HalfResSrcROTexture, HalfResSrcSampler, HalfResTextureRef);
|
|
|
|
ParamSetter(FullResSrcROTexture, FullResTextureRef)
|
|
(DstRect, TargetRect)
|
|
(HalfRect, HalfResRect)
|
|
(HalfBufferSize, HalfBufferExent);
|
|
}
|
|
|
|
// FShader interface.
|
|
virtual bool Serialize(FArchive& Ar) override
|
|
{
|
|
bool bShaderHasOutdatedParameters = FGlobalShader::Serialize(Ar);
|
|
Ar << FullResSrcROTexture
|
|
<< HalfResSrcROTexture
|
|
<< HalfResSrcSampler
|
|
<< CenterWeight
|
|
<< DstRWTexture
|
|
<< DstRect
|
|
<< HalfRect
|
|
<< HalfBufferSize;
|
|
|
|
return bShaderHasOutdatedParameters;
|
|
}
|
|
|
|
public:
|
|
|
|
FShaderResourceParameter FullResSrcROTexture;
|
|
FShaderResourceParameter HalfResSrcROTexture;
|
|
FShaderResourceParameter HalfResSrcSampler;
|
|
FShaderResourceParameter CenterWeight;
|
|
FShaderResourceParameter DstRWTexture;
|
|
FShaderParameter DstRect;
|
|
FShaderParameter HalfRect;
|
|
FShaderParameter HalfBufferSize;
|
|
};
|
|
|
|
IMPLEMENT_SHADER_TYPE3(FBlendLowResCS, SF_Compute);
|
|
|
|
|
|
class FPassThroughCS : public FGlobalShader
|
|
{
|
|
|
|
public:
|
|
DECLARE_SHADER_TYPE(FPassThroughCS, Global);
|
|
|
|
FPassThroughCS() {};
|
|
|
|
FPassThroughCS(const ShaderMetaType::CompiledShaderInitializerType& Initializer)
|
|
: FGlobalShader(Initializer)
|
|
{
|
|
using GPUFFTComputeShaderUtils::FComputeParameterBinder;
|
|
FComputeParameterBinder Binder(Initializer.ParameterMap);
|
|
|
|
Binder(SrcROTexture, TEXT("SrcTexture"))
|
|
(DstRWTexture, TEXT("DstTexture"))
|
|
(DstRect, TEXT("DstRect"))
|
|
(SrcRect, TEXT("SrcRect"));
|
|
}
|
|
|
|
static bool ShouldCache(EShaderPlatform Platform)
|
|
{
|
|
return IsFeatureLevelSupported(Platform, ERHIFeatureLevel::SM5);
|
|
}
|
|
|
|
static void ModifyCompilationEnvironment(EShaderPlatform Platform, FShaderCompilerEnvironment& OutEnvironment)
|
|
{
|
|
FGlobalShader::ModifyCompilationEnvironment(Platform, OutEnvironment);
|
|
OutEnvironment.SetDefine(TEXT("INCLUDE_PASSTHROUGH"), 1);
|
|
OutEnvironment.SetDefine(TEXT("THREADS_PER_GROUP"), FPassThroughCS::NumThreadsPerGroup());
|
|
}
|
|
|
|
// Method for use with the FScopedUAVBind
|
|
FShaderResourceParameter& DestinationResourceParamter() { return DstRWTexture; }
|
|
|
|
static int32 NumThreadsPerGroup() { return 32; }
|
|
|
|
static const TCHAR* GetSourceFilename() { return TEXT("PostProcessFFTBloom"); }
|
|
static const TCHAR* GetFunctionName() { return TEXT("PassThroughCS"); }
|
|
|
|
void SetCSParamters(FRHICommandList& RHICmdList, const FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& SrcTexture, const FIntRect& SrcRectValue, const FIntRect& DstRectValue)
|
|
{
|
|
using GPUFFTComputeShaderUtils::FComputeParamterValueSetter;
|
|
const FComputeShaderRHIParamRef ShaderRHI = GetComputeShader();
|
|
|
|
|
|
|
|
// Set up the input. We have to do this explicitly because the FFT dispatches multiple compute shaders and manages their input/output.
|
|
|
|
FComputeParamterValueSetter ParamSetter(RHICmdList, ShaderRHI);
|
|
ParamSetter(SrcROTexture, SrcTexture)
|
|
(DstRect, DstRectValue)
|
|
(SrcRect, SrcRectValue);
|
|
}
|
|
|
|
// FShader interface.
|
|
virtual bool Serialize(FArchive& Ar) override
|
|
{
|
|
bool bShaderHasOutdatedParameters = FGlobalShader::Serialize(Ar);
|
|
Ar << SrcROTexture
|
|
<< DstRWTexture
|
|
<< DstRect
|
|
<< SrcRect;
|
|
|
|
return bShaderHasOutdatedParameters;
|
|
}
|
|
|
|
public:
|
|
|
|
FShaderResourceParameter SrcROTexture;
|
|
FShaderResourceParameter DstRWTexture;
|
|
FShaderParameter SrcRect;
|
|
FShaderParameter DstRect;
|
|
};
|
|
|
|
IMPLEMENT_SHADER_TYPE3(FPassThroughCS, SF_Compute);
|
|
|
|
/**
|
|
* Used to resample the physical space kernel into the correct sized buffer with the
|
|
* correct periodicity and center
|
|
*
|
|
* Resizes the image, moves the center to to 0,0 and applies periodicity
|
|
* across the full TargetSize (periods TargetSize.x & TargetSize.y)
|
|
*
|
|
* @param Context - container for RHI and ShaderMap
|
|
* @param SrcTexture - SRV for the physical space kernel supplied by user
|
|
* @param SrcImageSize - The extent of the src image
|
|
* @param SrcImageCenterUV - The location of the center in src image (e.g. where the kernel center really is).
|
|
* @param ResizeScale - Affective size of the physical space kernel in units of the ImageExtent.x
|
|
* @param TargetSize - Size of the image produced.
|
|
* @param DstUAV - Holds the result
|
|
* @param DstBufferSize - Size of DstBuffer
|
|
* @param bForceCenterZero - is true only for the experimental 1/2 res version, part of conserving energy
|
|
*/
|
|
void ResizeAndCenterTexture(FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& SrcTexture,
|
|
const FIntPoint& SrcImageSize,
|
|
const FVector2D& SrcImageCenterUV,
|
|
const float ResizeScale,
|
|
const FIntPoint& TargetSize,
|
|
FUnorderedAccessViewRHIRef& DstUAV,
|
|
const FIntPoint& DstBufferSize,
|
|
const bool bForceCenterZero)
|
|
{
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
SCOPED_DRAW_EVENTF(RHICmdList, FRCPassFFTBloom, TEXT("FFT: Pre-process the space kernel to %d by %d"), TargetSize.X, TargetSize.Y);
|
|
|
|
// Clamp the image center
|
|
|
|
FVector2D ClampedImageCenterUV = SrcImageCenterUV;
|
|
ClampedImageCenterUV.X = FMath::Clamp(SrcImageCenterUV.X, 0.f, 1.f);
|
|
ClampedImageCenterUV.Y = FMath::Clamp(SrcImageCenterUV.Y, 0.f, 1.f);
|
|
|
|
TShaderMap<FGlobalShaderType>& ShaderMap = *Context.GetShaderMap();
|
|
// Get a pointer to the shader
|
|
FResizeAndCenterTextureCS* ComputeShader = ShaderMap.GetShader< FResizeAndCenterTextureCS >();
|
|
|
|
//
|
|
SetRenderTarget(RHICmdList, FTextureRHIRef(), FTextureRHIRef());
|
|
RHICmdList.SetComputeShader(ComputeShader->GetComputeShader());
|
|
|
|
// set destination
|
|
check(DstUAV);
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EGfxToCompute, DstUAV);
|
|
|
|
{
|
|
GPUFFTComputeShaderUtils::FScopedUAVBind ScopedBindOutput = GPUFFTComputeShaderUtils::FScopedUAVBind::BindOutput(RHICmdList, *ComputeShader, DstUAV);
|
|
|
|
|
|
ComputeShader->SetCSParamters(RHICmdList, Context, TargetSize, SrcImageSize, ResizeScale, ClampedImageCenterUV, SrcTexture, DstBufferSize, bForceCenterZero);
|
|
|
|
// Use multiple threads per scan line to insure memory coalescing during the write
|
|
const int32 ThreadsPerGroup = ComputeShader->NumThreadsPerGroup();
|
|
const int32 ThreadsGroupsPerScanLine = (DstBufferSize.X % ThreadsPerGroup == 0) ? DstBufferSize.X / ThreadsPerGroup : DstBufferSize.X / ThreadsPerGroup + 1;
|
|
|
|
RHICmdList.DispatchComputeShader(ThreadsGroupsPerScanLine, DstBufferSize.Y, 1);
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
/**
|
|
* Used by experimental energy conserving 1/2 resolution version of the bloom.
|
|
* Captures the sum of the kernel weights represented by the 1/2 res kernel and
|
|
* the Center weight from the physical space kernel.
|
|
*
|
|
* @param Context - container for RHI and ShaderMap
|
|
* @param HalfResKernel - SRV for the pre-transformed 1/2 res kernel
|
|
* @param HalfResSumLocation - The location to sample in the pre-transformed kernel to find the sum of the physical space kernel weights
|
|
* @param PhysicalKernel - SRV for the original physical space kernel
|
|
* @param CenterUV - Where to sample the Physical Kernel for the center weight
|
|
* @param CenterWeightRT - 2x1 float4 buffer that on return will hold result:
|
|
* At (0,0) the center weight of physical kernel, and (1,0) the sum of the 1/2res kernel weights
|
|
*/
|
|
void CaptureKernelWeight(FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& HalfResKernel,
|
|
const FIntPoint& HalfResSumLocation,
|
|
const FTextureRHIRef& PhysicalKernel,
|
|
const FVector2D& CenterUV,
|
|
TRefCountPtr<IPooledRenderTarget>& CenterWeightRT)
|
|
{
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
|
|
SCOPED_DRAW_EVENTF(RHICmdList, FRCPassFFTBloom, TEXT("FFT: Capture Kernel Weights"));
|
|
|
|
FSceneRenderTargetItem& DstTargetItem = CenterWeightRT->GetRenderTargetItem();
|
|
|
|
// Get a pointer to the shader
|
|
TShaderMap<FGlobalShaderType>& ShaderMap = *Context.GetShaderMap();
|
|
// Get a pointer to the shader
|
|
FCaptureKernelWeightsCS* ComputeShader = ShaderMap.GetShader< FCaptureKernelWeightsCS >();
|
|
|
|
|
|
SetRenderTarget(RHICmdList, FTextureRHIRef(), FTextureRHIRef());
|
|
RHICmdList.SetComputeShader(ComputeShader->GetComputeShader());
|
|
|
|
// set destination
|
|
check(DstTargetItem.UAV);
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EGfxToCompute, DstTargetItem.UAV);
|
|
{
|
|
GPUFFTComputeShaderUtils::FScopedUAVBind ScopedBindOutput = GPUFFTComputeShaderUtils::FScopedUAVBind::BindOutput(Context.RHICmdList, *ComputeShader, DstTargetItem.UAV);
|
|
RHICmdList.SetUAVParameter(ComputeShader->GetComputeShader(), ComputeShader->DstRWTexture.GetBaseIndex(), DstTargetItem.UAV);
|
|
|
|
ComputeShader->SetCSParamters(RHICmdList, Context, HalfResKernel, HalfResSumLocation, PhysicalKernel, CenterUV);
|
|
|
|
RHICmdList.DispatchComputeShader(1, 1, 1);
|
|
}
|
|
|
|
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::EReadable, EResourceTransitionPipeline::EComputeToCompute, DstTargetItem.UAV);
|
|
|
|
// Test.
|
|
ensureMsgf(DstTargetItem.TargetableTexture == DstTargetItem.ShaderResourceTexture, TEXT("%s should be resolved to a separate SRV"), *DstTargetItem.TargetableTexture->GetName().ToString());
|
|
}
|
|
|
|
/**
|
|
* Used by energy conserving 1/2 resolution version of the bloom.
|
|
* This blends the results of the low resolution bloom with the full resolution image
|
|
* in an energy conserving manner. Assumes the 1/2-res bloom is done with a kernel that
|
|
* is missing the center pixel (i.e. the self-gather contribution), and this missing contribution
|
|
* is supplied by the full-res image.
|
|
*
|
|
* @param Context - container for RHI and ShaderMap
|
|
* @param FullResImage - Unbloomed full-resolution source image
|
|
* @param FullResImageRect - Region in FullResImage and DstUAV where the image lives
|
|
* @param HaflResConvolvedImage - A 1/2 res image that has been convolved with the bloom kernel minus center.
|
|
* @param HalfResRect - Location of image in the HalfResConvolvedImage buffer
|
|
* @param HalfBufferSize - Full size of the 1/2 Res buffer.
|
|
* @param CenterWeightTexture - Texture that holds the weight between the kernel center and sum of 1/2res kernel weights.
|
|
* needed to correctly composite the 1/2 res bloomed result with the full-res image.
|
|
* @param DstUAV - Destination buffer that will hold the result.
|
|
*/
|
|
void BlendLowRes(FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& FullResImage,
|
|
const FIntRect& FullResImageRect,
|
|
const FTextureRHIRef& HalfResConvolvedImage,
|
|
const FIntRect& HalfResRect,
|
|
const FIntPoint& HalfBufferSize,
|
|
const FTextureRHIRef& CenterWeightTexutre,
|
|
FUnorderedAccessViewRHIRef& DstUAV)
|
|
{
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
SCOPED_DRAW_EVENTF(RHICmdList, FRCPassFFTBloom, TEXT("FFT: Post-process upres and blend"));
|
|
|
|
|
|
// Get a pointer to the shader
|
|
// Get a pointer to the shader
|
|
TShaderMap<FGlobalShaderType>& ShaderMap = *Context.GetShaderMap();
|
|
// Get a pointer to the shader
|
|
FBlendLowResCS* ComputeShader = ShaderMap.GetShader< FBlendLowResCS>();
|
|
|
|
|
|
SetRenderTarget(RHICmdList, FTextureRHIRef(), FTextureRHIRef());
|
|
RHICmdList.SetComputeShader(ComputeShader->GetComputeShader());
|
|
|
|
// set destination
|
|
check(DstUAV);
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EComputeToCompute, DstUAV);
|
|
|
|
{
|
|
GPUFFTComputeShaderUtils::FScopedUAVBind ScopedBindOutput = GPUFFTComputeShaderUtils::FScopedUAVBind::BindOutput(Context.RHICmdList, *ComputeShader, DstUAV);
|
|
ComputeShader->SetCSParamters(RHICmdList, Context, FullResImageRect, HalfResRect, HalfBufferSize, CenterWeightTexutre, FullResImage, HalfResConvolvedImage);
|
|
|
|
FIntPoint TargetExtent = FullResImageRect.Size();
|
|
// Use multiple threads per scan line to insure memory coalescing during the write
|
|
const int32 ThreadsPerGroup = ComputeShader->NumThreadsPerGroup();
|
|
const int32 ThreadsGroupsPerScanLine = (TargetExtent.X % ThreadsPerGroup == 0) ? TargetExtent.X / ThreadsPerGroup : TargetExtent.X / ThreadsPerGroup + 1;
|
|
|
|
RHICmdList.DispatchComputeShader(ThreadsGroupsPerScanLine, TargetExtent.Y, 1);
|
|
}
|
|
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::EReadable, EResourceTransitionPipeline::EComputeToGfx, DstUAV);
|
|
|
|
}
|
|
|
|
/**
|
|
* Used to copy the input image in the event that it is too large to bloom (i.e. doesn't fit in the FFT group shared memory)
|
|
*
|
|
* @param Context - container for RHI and ShaderMap
|
|
* @param SrcTargetItem - The SrcBuffer to be copied.
|
|
* @param SrcRect - The region in the SrcBuffer to copy
|
|
* @param DstUAV - The target buffer for the copy
|
|
* @param DstRect - The location and region in the target buffer for the copy
|
|
*/
|
|
void CopyImageRect(FRenderingCompositePassContext& Context, const FSceneRenderTargetItem& SrcTargetItem, const FIntRect& SrcRect, FUnorderedAccessViewRHIRef& DstUAV, const FIntRect& DstRect)
|
|
{
|
|
|
|
SCOPED_DRAW_EVENTF(Context.RHICmdList, FRCPassFFTBloom, TEXT("FFT: passthrough "));
|
|
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
|
|
|
|
// Get a pointer to the shader
|
|
// Get a pointer to the shader
|
|
// Get a pointer to the shader
|
|
TShaderMap<FGlobalShaderType>& ShaderMap = *Context.GetShaderMap();
|
|
// Get a pointer to the shader
|
|
FPassThroughCS* ComputeShader = ShaderMap.GetShader< FPassThroughCS >();
|
|
|
|
SetRenderTarget(Context.RHICmdList, FTextureRHIRef(), FTextureRHIRef());
|
|
Context.RHICmdList.SetComputeShader(ComputeShader->GetComputeShader());
|
|
|
|
// set destination
|
|
check(DstUAV);
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EGfxToCompute, DstUAV);
|
|
{
|
|
GPUFFTComputeShaderUtils::FScopedUAVBind ScopedBindOutput = GPUFFTComputeShaderUtils::FScopedUAVBind::BindOutput(RHICmdList, *ComputeShader, DstUAV);
|
|
|
|
|
|
ComputeShader->SetCSParamters(RHICmdList, Context, SrcTargetItem.ShaderResourceTexture, SrcRect, DstRect);
|
|
|
|
const FIntPoint DstRectSize = DstRect.Size();
|
|
|
|
// Use multiple threads per scan line to insure memory coalescing during the write
|
|
const int32 ThreadsPerGroup = ComputeShader->NumThreadsPerGroup();
|
|
const int32 ThreadsGroupsPerScanLine = (DstRectSize.X % ThreadsPerGroup == 0) ? DstRectSize.X / ThreadsPerGroup : DstRectSize.X / ThreadsPerGroup + 1;
|
|
|
|
RHICmdList.DispatchComputeShader(ThreadsGroupsPerScanLine, DstRectSize.Y, 1);
|
|
}
|
|
}
|
|
|
|
void FRCPassFFTBloom::InitializeDomainParameters(FRenderingCompositePassContext& Context, const float KernelSupportScale, const float KernelSupportScaleClamp)
|
|
{
|
|
|
|
// We padd by 1/2 the number of pixels the kernel needs in the x-direction
|
|
// so if the kernel is being applied on the edge of the image it will see padding and not periodicity
|
|
// NB: If the kernel padding would force a transform buffer that is too big for group shared memory (> 4096)
|
|
// we clamp it. This could result in a wrap-around in the bloom (from one side of the screen to the other),
|
|
// but since the amplitude of the bloom kernel tails is usually very small, this shouldnt be too bad.
|
|
auto KernelRadiusSupportFunctor = [KernelSupportScale, KernelSupportScaleClamp](const FIntPoint& Size) ->int32 {
|
|
|
|
float ClampedKernelSupportScale = (KernelSupportScaleClamp > 0) ? FMath::Min(KernelSupportScale, KernelSupportScaleClamp) : KernelSupportScale;
|
|
int32 FilterRadius = FMath::CeilToInt(0.5 * ClampedKernelSupportScale * Size.X);
|
|
const int32 MaxFFTSize = GPUFFT::MaxScanLineLength();
|
|
int32 MaxDim = FMath::Max(Size.X, Size.Y);
|
|
if (MaxDim + FilterRadius > MaxFFTSize && MaxDim < MaxFFTSize) FilterRadius = MaxFFTSize - MaxDim;
|
|
|
|
return FilterRadius;
|
|
};
|
|
|
|
const FPooledRenderTargetDesc* InputDesc = GetInputDesc(ePId_Input0);
|
|
|
|
if (!InputDesc)
|
|
{
|
|
// input is not hooked up correctly return dummy kernel
|
|
return;
|
|
}
|
|
|
|
|
|
const FSceneView& View = Context.View;
|
|
|
|
InputBufferSize = InputDesc->Extent;
|
|
|
|
// Get the source
|
|
TRefCountPtr<IPooledRenderTarget> Input = Context.Pass->GetInput(EPassInputId(0))->GetOutput()->RequestInput();
|
|
InputTargetItem = &Input->GetRenderTargetItem();
|
|
const FTextureRHIRef& InputTexture = InputTargetItem->ShaderResourceTexture;
|
|
|
|
// This will be for the actual output.
|
|
|
|
OutputTargetItem = const_cast<FSceneRenderTargetItem*>(&PassOutputs[0].RequestSurface(Context));
|
|
FIntPoint OutputBufferSize = PassOutputs[0].RenderTargetDesc.Extent;
|
|
|
|
|
|
|
|
// Determine the region in the source buffer that we want to copy.
|
|
//
|
|
// e.g. 4 means the input texture is 4x smaller than the buffer size
|
|
const uint32 InputScaleFactor = FMath::DivideAndRoundUp(FSceneRenderTargets::Get(Context.RHICmdList).GetBufferSizeXY().Y, InputBufferSize.Y);
|
|
const uint32 OutputScaleFactor = FMath::DivideAndRoundUp(FSceneRenderTargets::Get(Context.RHICmdList).GetBufferSizeXY().Y, OutputBufferSize.Y);
|
|
|
|
const FIntRect InputRect = View.ViewRect / InputScaleFactor;
|
|
const FIntRect OutputRect = View.ViewRect / OutputScaleFactor;
|
|
|
|
// Capture the region of interest
|
|
ImageRect = InputRect;
|
|
const FIntPoint ImageSize = ImageRect.Size();
|
|
|
|
int32 SpectralPadding = KernelRadiusSupportFunctor(ImageSize);
|
|
|
|
// The following are mathematically equivalent
|
|
// 1) Horizontal FFT / Vertical FFT / Filter / Vertical InvFFT / Horizontal InvFFT
|
|
// 2) Vertical FFT / Horizontal FFT / Filter / Horizontal InvFFT / Vertical InvFFT
|
|
// but we choose the one with the smallest intermediate buffer size
|
|
|
|
// The size of the input image plus padding that accounts for
|
|
// the width of the kernel. The ImageRect is virtually padded
|
|
// with black to account for the gather action of the convolution.
|
|
FIntPoint PaddedImageSize = ImageSize + FIntPoint(SpectralPadding, SpectralPadding);
|
|
FrequencySize = FIntPoint(FMath::RoundUpToPowerOfTwo(PaddedImageSize.X), FMath::RoundUpToPowerOfTwo(PaddedImageSize.Y));
|
|
|
|
// Chose to do to transform in the direction that results in writting the least amount of data to main memory.
|
|
|
|
bDoHorizontalFirst = ((FrequencySize.Y * PaddedImageSize.X) > (FrequencySize.X * PaddedImageSize.Y));
|
|
|
|
//
|
|
bIsInitialized = true;
|
|
}
|
|
|
|
|
|
|
|
bool FRCPassFFTBloom::TransformKernelFFT(FRenderingCompositePassContext& Context, FSceneRenderTargetItem& KernelTargetItem)
|
|
{
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
GPUFFT::FGPUFFTShaderContext FFTContext(RHICmdList, *Context.GetShaderMap());
|
|
|
|
// Create the tmp buffer
|
|
|
|
// Our frequency storage layout adds two elements to the first transform direction.
|
|
const FIntPoint FrequencyPadding = (bDoHorizontalFirst) ? FIntPoint(2, 0) : FIntPoint(0, 2);
|
|
const FIntPoint PaddedFrequencySize = FrequencySize + FrequencyPadding;
|
|
|
|
// Should read / write to PF_G16R16F or PF_G32R32F (float2 formats)
|
|
// Need to set the render target description before we "request surface"
|
|
const EPixelFormat PixelFormat = GPUFFT::PixelFormat();
|
|
FPooledRenderTargetDesc Desc = FPooledRenderTargetDesc::Create2DDesc(PaddedFrequencySize, PixelFormat,
|
|
FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false);
|
|
|
|
// Temp buffer used at intermediate buffer when transforming the world space kernel
|
|
TRefCountPtr<IPooledRenderTarget> TmpRT;
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, Desc, TmpRT, TEXT("FFT Tmp Kernel Buffer"));
|
|
|
|
FIntRect SrcRect(FIntPoint(0, 0), FrequencySize);
|
|
const FTextureRHIRef& SrcImage = KernelTargetItem.ShaderResourceTexture;
|
|
FSceneRenderTargetItem& ResultBuffer = KernelTargetItem;
|
|
|
|
bool SuccessValue = GPUFFT::FFTImage2D(FFTContext, FrequencySize, bDoHorizontalFirst, SrcRect, SrcImage, ResultBuffer, TmpRT->GetRenderTargetItem());
|
|
|
|
// Transition resource
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::EReadable, EResourceTransitionPipeline::EComputeToCompute, ResultBuffer.UAV);
|
|
//RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EComputeToCompute, ResultUAV);
|
|
|
|
return SuccessValue;
|
|
}
|
|
|
|
|
|
bool FRCPassFFTBloom::ConvolveWithKernel(FRenderingCompositePassContext& Context,
|
|
const FTextureRHIRef& SpectralKernelTexture, const FLinearColor& Tint,
|
|
const FTextureRHIRef& SrcTexture, FUnorderedAccessViewRHIRef& ResultUAV,
|
|
const FPreFilter& PreFilter)
|
|
{
|
|
|
|
if (!bIsInitialized )
|
|
{
|
|
// The dimensions have not be calculated.
|
|
return false;
|
|
}
|
|
|
|
FRHICommandListImmediate& RHICmdList = Context.RHICmdList;
|
|
GPUFFT::FGPUFFTShaderContext FFTContext(RHICmdList, *Context.GetShaderMap());
|
|
|
|
// Get Tmp buffers required for the Convolution
|
|
|
|
TRefCountPtr<IPooledRenderTarget> TmpTargets[2];
|
|
|
|
const FIntPoint TmpExtent = GPUFFT::Convolution2DBufferSize(FrequencySize, bDoHorizontalFirst, ImageRect.Size());
|
|
//(bDoHorizontalFirst) ? FIntPoint(FrequencySize.X + 2, ImageRect.Size().Y) : FIntPoint(ImageRect.Size().X, FrequencySize.Y + 2);
|
|
FPooledRenderTargetDesc Desc =
|
|
FPooledRenderTargetDesc::Create2DDesc(TmpExtent, GPUFFT::PixelFormat(), FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false);
|
|
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, Desc, TmpTargets[0], TEXT("Tmp FFT Buffer A"));
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, Desc, TmpTargets[1], TEXT("Tmp FFT Buffer B"));
|
|
|
|
// Get the source
|
|
const FTextureRHIRef& InputTexture = SrcTexture;
|
|
|
|
bool SuccessValue =
|
|
GPUFFT::ConvolutionWithTextureImage2D(FFTContext, FrequencySize, bDoHorizontalFirst,
|
|
SpectralKernelTexture,
|
|
ImageRect/*region of interest*/,
|
|
InputTexture,
|
|
ResultUAV,
|
|
TmpTargets[0]->GetRenderTargetItem(),
|
|
TmpTargets[1]->GetRenderTargetItem(),
|
|
PreFilter);
|
|
|
|
RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EComputeToGfx, ResultUAV);
|
|
|
|
return SuccessValue;
|
|
|
|
}
|
|
|
|
FSceneRenderTargetItem* FRCPassFFTBloom::InitDomainAndGetKernel(FRenderingCompositePassContext& Context)
|
|
{
|
|
|
|
const FSceneView& View = Context.View;
|
|
FSceneViewState* ViewState = (FSceneViewState*)View.State;
|
|
|
|
|
|
|
|
const auto& PPSettings = View.FinalPostProcessSettings;
|
|
|
|
// The kernel parameters on the FinalPostProcess.
|
|
|
|
UTexture2D* BloomConvolutionTexture = PPSettings.BloomConvolutionTexture;
|
|
const float BloomConvolutionSize = PPSettings.BloomConvolutionSize;
|
|
const FVector2D CenterUV = PPSettings.BloomConvolutionCenterUV;
|
|
const float ClampedBloomConvolutionBufferScale = FMath::Clamp(PPSettings.BloomConvolutionBufferScale, 0.f, 1.f);
|
|
|
|
|
|
// The pre-filter boost parameters for bright pixels
|
|
const FVector PreFilter = PPSettings.BloomConvolutionPreFilter;
|
|
|
|
|
|
// Clip the Kernel support (i.e. bloom size) to 100% the screen width
|
|
const float MaxBloomSize = 1.f;
|
|
const float ClampedBloomSizeScale = FMath::Clamp(BloomConvolutionSize, 0.f, MaxBloomSize);
|
|
|
|
// Set up the buffer sizes
|
|
InitializeDomainParameters(Context, ClampedBloomSizeScale, ClampedBloomConvolutionBufferScale);
|
|
|
|
if (bIsInitialized == false) return nullptr;
|
|
|
|
// The transform kernel gets cached in the view state.
|
|
if (!ViewState)
|
|
{
|
|
// input is not hooked up correctly, return a null pointer.
|
|
return nullptr;
|
|
}
|
|
// redundant check
|
|
if (!BloomConvolutionTexture || !BloomConvolutionTexture->Resource) return nullptr;
|
|
|
|
|
|
// The FFT is much slower if not in group shared memory.
|
|
bool bFitsInGroupSharedMemory = GPUFFT::FitsInGroupSharedMemory(FrequencySize.X) && GPUFFT::FitsInGroupSharedMemory(FrequencySize.Y);
|
|
//if (!bFitsInGroupSharedMemory) return nullptr;
|
|
|
|
|
|
|
|
// Our frequency storage layout adds two elements to the first transform direction.
|
|
const FIntPoint FrequencyPadding = (bDoHorizontalFirst) ? FIntPoint(2, 0) : FIntPoint(0, 2);
|
|
const FIntPoint PaddedFrequencySize = FrequencySize + FrequencyPadding;
|
|
|
|
// Should read / write to PF_G16R16F or PF_G32R32F (float2 formats)
|
|
// Need to set the render target description before we "request surface"
|
|
const EPixelFormat PixelFormat = GPUFFT::PixelFormat();
|
|
const FPooledRenderTargetDesc TransformDesc = FPooledRenderTargetDesc::Create2DDesc(PaddedFrequencySize, PixelFormat,
|
|
FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false);
|
|
|
|
|
|
auto& FFTKernel = ViewState->BloomFFTKernel;
|
|
// Get the FFT kernel from the view state (note, this has already been transformed).
|
|
TRefCountPtr<IPooledRenderTarget>& TransformedKernelRT = FFTKernel.Spectral;
|
|
const UTexture2D* CachedKernelPhysical = FFTKernel.Physical;
|
|
const float CachedKernelScale = FFTKernel.Scale;
|
|
const FVector2D& CachedKernelCenterUV = FFTKernel.CenterUV;
|
|
const FIntPoint& CachedImageSize = FFTKernel.ImageSize;
|
|
|
|
const FIntPoint ImageSize = ImageRect.Size();
|
|
// Check if the FFT kernel is dirty
|
|
|
|
bool bCachedKernelIsDirty = true;
|
|
if (TransformedKernelRT)
|
|
{
|
|
FPooledRenderTarget* TransformedTexture = (FPooledRenderTarget*)TransformedKernelRT.GetReference();
|
|
|
|
const bool bSameTexture = (CachedKernelPhysical == static_cast<const UTexture2D*>(BloomConvolutionTexture));
|
|
const bool bSameSpectralBuffer = TransformedTexture->GetDesc().Compare(TransformDesc, true /*exact match*/);
|
|
const bool bSameKernelSize = FMath::IsNearlyEqual(CachedKernelScale, BloomConvolutionSize, float(1.e-6) /*tol*/);
|
|
const bool bSameImageSize = (ImageSize == CachedImageSize);
|
|
const bool bSameKernelCenterUV = CachedKernelCenterUV.Equals(CenterUV, float(1.e-6) /*tol*/);
|
|
const bool bSameMipLevel = bSameTexture && (
|
|
FFTKernel.PhysicalMipLevel == static_cast<FTexture2DResource*>(BloomConvolutionTexture->Resource)->GetCurrentFirstMip());
|
|
|
|
if (bSameTexture && bSameSpectralBuffer && bSameKernelSize && bSameImageSize && bSameKernelCenterUV && bSameMipLevel)
|
|
{
|
|
bCachedKernelIsDirty = false;
|
|
}
|
|
|
|
}
|
|
|
|
|
|
const bool bIsHalfResolutionFFT = bHalfResolutionFFT();
|
|
// Re-transform the kernel if needed.
|
|
if (bCachedKernelIsDirty)
|
|
{
|
|
// Resize the buffer to hold the transformed kernel
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, TransformDesc, TransformedKernelRT, TEXT("FFTKernel"));
|
|
|
|
// NB: SpectralKernelRTItem is member data
|
|
FSceneRenderTargetItem& SpectralKernelRTItem = TransformedKernelRT->GetRenderTargetItem();
|
|
FUnorderedAccessViewRHIRef SpectralKernelUAV = SpectralKernelRTItem.UAV;
|
|
|
|
// Sample the physical space kernel into the resized buffer
|
|
|
|
FTextureRHIRef& PhysicalSpaceKernelTextureRef = BloomConvolutionTexture->Resource->TextureRHI;
|
|
|
|
// Rescale the physical space kernel ( and omit the center if this is a 1/2 resolution fft, it will be added later)
|
|
|
|
ResizeAndCenterTexture(Context, PhysicalSpaceKernelTextureRef, ImageSize, CenterUV, ClampedBloomSizeScale,
|
|
FrequencySize, SpectralKernelRTItem.UAV, PaddedFrequencySize, bIsHalfResolutionFFT);
|
|
|
|
Context.RHICmdList.TransitionResource(EResourceTransitionAccess::ERWBarrier, EResourceTransitionPipeline::EComputeToCompute, SpectralKernelRTItem.UAV);
|
|
|
|
// Two Dimensional FFT of the physical space kernel.
|
|
// Input: SpectralRTItem holds the physical space kernel, on return it will be the spectral space
|
|
|
|
TransformKernelFFT(Context, SpectralKernelRTItem);
|
|
|
|
|
|
|
|
if (bIsHalfResolutionFFT)
|
|
{
|
|
TRefCountPtr<IPooledRenderTarget>& CenterWeightRT = FFTKernel.CenterWeight;
|
|
|
|
const FPooledRenderTargetDesc CenterWeightDesc = FPooledRenderTargetDesc::Create2DDesc(FIntPoint(2, 1), PixelFormat,
|
|
FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false);
|
|
|
|
// Resize the buffer to hold the transformed kernel
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, CenterWeightDesc, CenterWeightRT, TEXT("FFTKernelCenterWeight"));
|
|
|
|
const FTextureRHIRef& HalfResKernelTextureRef = SpectralKernelRTItem.ShaderResourceTexture;
|
|
|
|
const FIntPoint& HalfResKernelExtent = PaddedFrequencySize;
|
|
|
|
const FIntPoint HalfResSumLocation = (bDoHorizontalFirst) ? FIntPoint(HalfResKernelExtent.X, 0) : FIntPoint(0, HalfResKernelExtent.Y);
|
|
// Capture the missing center weight from the kernel and the sum of the existing weights.
|
|
CaptureKernelWeight(Context, HalfResKernelTextureRef, HalfResKernelExtent, PhysicalSpaceKernelTextureRef, CenterUV, CenterWeightRT);
|
|
}
|
|
|
|
// Update the data on the ViewState
|
|
ViewState->BloomFFTKernel.Scale = BloomConvolutionSize;
|
|
ViewState->BloomFFTKernel.ImageSize = ImageSize;
|
|
ViewState->BloomFFTKernel.Physical = BloomConvolutionTexture;
|
|
ViewState->BloomFFTKernel.CenterUV = CenterUV;
|
|
ViewState->BloomFFTKernel.PhysicalMipLevel = static_cast<FTexture2DResource*>(BloomConvolutionTexture->Resource)->GetCurrentFirstMip();
|
|
}
|
|
|
|
// Return pointer to the transformed kernel.
|
|
return &(TransformedKernelRT->GetRenderTargetItem());
|
|
}
|
|
|
|
|
|
bool FRCPassFFTBloom::ConvolveImageWithKernel(FRenderingCompositePassContext& Context)
|
|
{
|
|
|
|
// Init the domain data update the cached kernel if needed.
|
|
FSceneRenderTargetItem* SpectralKernelRTItem = InitDomainAndGetKernel(Context);
|
|
|
|
// was the domain too large? did something else fail?
|
|
if (!SpectralKernelRTItem) return false;
|
|
|
|
// Do the convolution with the kernel
|
|
|
|
const FTextureRHIRef& SpectralKernelTexture = SpectralKernelRTItem->ShaderResourceTexture;
|
|
|
|
const bool bIsHalfResolutionFFT = bHalfResolutionFFT();
|
|
|
|
|
|
const FSceneView& View = Context.View;
|
|
// The pre-filter boost parameters for bright pixels
|
|
const FVector PreFilter = View.FinalPostProcessSettings.BloomConvolutionPreFilter;
|
|
|
|
const FLinearColor Tint(1, 1, 1, 1);
|
|
|
|
if (bIsHalfResolutionFFT)
|
|
{
|
|
|
|
// Get a half-resolution destination buffer.
|
|
TRefCountPtr<IPooledRenderTarget> HalfResConvolutionResult;
|
|
|
|
const EPixelFormat PixelFormat = GPUFFT::PixelFormat();
|
|
|
|
const FPooledRenderTargetDesc HalfResFFTDesc = FPooledRenderTargetDesc::Create2DDesc(InputBufferSize, PixelFormat,
|
|
FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false);
|
|
|
|
GRenderTargetPool.FindFreeElement(Context.RHICmdList, HalfResFFTDesc, HalfResConvolutionResult, TEXT("HalfRes FFT Result"));
|
|
FSceneRenderTargetItem& HalfResConvolutionRTItem = HalfResConvolutionResult->GetRenderTargetItem();
|
|
|
|
// The FFT result buffer is also half res.
|
|
|
|
ConvolveWithKernel(Context, SpectralKernelTexture, Tint, InputTargetItem->ShaderResourceTexture , HalfResConvolutionRTItem.UAV, PreFilter);
|
|
|
|
// The blend weighting parameters from the View State
|
|
|
|
FSceneViewState* ViewState = (FSceneViewState*)View.State;
|
|
auto& FFTKernel = ViewState->BloomFFTKernel;
|
|
|
|
const FTextureRHIRef& CenterWeightTexture = FFTKernel.CenterWeight->GetRenderTargetItem().ShaderResourceTexture;
|
|
|
|
// The output buffer
|
|
// NB: the Target buffer and source buffer have the same extent.
|
|
|
|
FSceneRenderTargetItem& PassOutput = *OutputTargetItem;
|
|
|
|
// Get full resolution source
|
|
|
|
const TRefCountPtr<IPooledRenderTarget>& FullResRT = Context.Pass->GetInput(ePId_Input1)->GetOutput()->RequestInput();
|
|
const FTextureRHIRef& FullResResourceTexture = FullResRT->GetRenderTargetItem().ShaderResourceTexture;
|
|
|
|
// Blend with alpha * SrcBuffer + betta * BloomedBuffer where alpha = Weights[0], beta = Weights[1]
|
|
const FIntPoint& HalfResBufferSize = InputBufferSize;
|
|
BlendLowRes(Context, FullResResourceTexture, View.ViewRect, HalfResConvolutionRTItem.ShaderResourceTexture, ImageRect, HalfResBufferSize, CenterWeightTexture, PassOutput.UAV);
|
|
|
|
|
|
|
|
}
|
|
else
|
|
{
|
|
// Do Convolution directly into the output buffer
|
|
// NB: In this case there is only one input, and the output has matching resolution
|
|
|
|
ConvolveWithKernel(Context, SpectralKernelTexture, Tint, InputTargetItem->ShaderResourceTexture, OutputTargetItem->UAV, PreFilter);
|
|
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void FRCPassFFTBloom::PassThroughImage(FRenderingCompositePassContext& Context)
|
|
{
|
|
// Copy the Image content and location
|
|
const FIntRect& InputRect = ImageRect;
|
|
const FIntRect& OutputRect = ImageRect;
|
|
CopyImageRect(Context, *InputTargetItem, InputRect, OutputTargetItem->UAV, OutputRect);
|
|
Context.RHICmdList.TransitionResource(EResourceTransitionAccess::EReadable, EResourceTransitionPipeline::EComputeToGfx, OutputTargetItem->UAV);
|
|
}
|
|
|
|
|
|
|
|
void FRCPassFFTBloom::Process(FRenderingCompositePassContext& Context)
|
|
{
|
|
bool bSucesss = ConvolveImageWithKernel(Context);
|
|
|
|
// Fail gracefully by just copying the input image without convolution.
|
|
// Currently this will happen if the transform lengths are too large
|
|
// for group shared memory or if the Context.View.State is invalid.
|
|
if (!bSucesss)
|
|
{
|
|
PassThroughImage(Context);
|
|
}
|
|
|
|
}
|
|
|
|
FPooledRenderTargetDesc FRCPassFFTBloom::ComputeOutputDesc(EPassOutputId InPassOutputId) const
|
|
{
|
|
// The optional second input will override the output format and size
|
|
const bool bIsHalfResolutionFFT = bHalfResolutionFFT();
|
|
|
|
EPassInputId PassInputId = (bIsHalfResolutionFFT) ? ePId_Input1 : ePId_Input0;
|
|
|
|
const FPooledRenderTargetDesc& SrcRet = GetInput(PassInputId)->GetOutput()->RenderTargetDesc;
|
|
|
|
// NB: this only resets a limited number of parameters
|
|
//SrcRet.Reset();
|
|
// PF_FloatRGBA
|
|
EPixelFormat Format = SrcRet.Format;
|
|
|
|
FIntPoint Extent = SrcRet.Extent;
|
|
FPooledRenderTargetDesc Ret(FPooledRenderTargetDesc::Create2DDesc(Extent, Format, FClearValueBinding::None, TexCreate_None, TexCreate_RenderTargetable | TexCreate_UAV, false));
|
|
|
|
Ret.DebugName = TEXT("FFTBuffer");
|
|
|
|
return Ret;
|
|
}
|
|
|
|
|
|
bool FRCPassFFTBloom::HasValidPhysicalKernel(FPostprocessContext& Context)
|
|
{
|
|
const FViewInfo& View = Context.View;
|
|
UTexture2D* BloomConvolutionTexture = View.FinalPostProcessSettings.BloomConvolutionTexture;
|
|
|
|
bool bValidSetup = (BloomConvolutionTexture != nullptr && BloomConvolutionTexture->Resource != nullptr);
|
|
|
|
if (bValidSetup && BloomConvolutionTexture->IsFullyStreamedIn() == false)
|
|
{
|
|
UE_LOG(LogRenderer, Warning, TEXT("The Physical Kernel Texture not fully streamed in."));
|
|
}
|
|
|
|
bValidSetup = bValidSetup && (BloomConvolutionTexture->IsFullyStreamedIn() == true);
|
|
|
|
if (bValidSetup && BloomConvolutionTexture->bHasStreamingUpdatePending == true)
|
|
{
|
|
UE_LOG(LogRenderer, Warning, TEXT("The Physical Kernel Texture has pending update."));
|
|
}
|
|
|
|
bValidSetup = bValidSetup && (BloomConvolutionTexture->bHasStreamingUpdatePending == false);
|
|
|
|
return bValidSetup;
|
|
}
|