paul chipchase 7378ca2787 The source control backend can now limit the number of threads that can make concurrent connections. ...

#rb Per.Larsson
#rnx
#jira UE-147948
#preflight 6271209be16e280be60b5a62

- In the worst case scenario (where a machine can only access the source control backend) we will want to limit the potential number of concurrent connections that they can make.
- In testing, not limiting the connections could cause the occasional connection failure and I imagine having a full team running in the worse case scenario would quickly overwhelm the server.
- Currently we default to 8 connections (the limit allowed in UGS)
- The semaphore is a quick and dirty implementation similar to std::counting_semaphore. I am not spending much time on it as the worst case scenario is not expected to be common and if it does occur, the system is going to be painfully slow no matter how good the thread throttling.

### Future work
- This work could be  taken a lot further by either
-- a) reusing connections rather than creating one for each pull, which will require changes to our source control api
-- b) gathering requests from many requesting threads once the limit has been reached and then sending the requests in batches
--c) reserve one connection for the game thread to prevent the user waiting?

[CL 20024594 by paul chipchase in ue5-main branch]

2022-05-03 09:39:48 -04:00

27 KiB

Raw Blame History

View Raw