You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
4bb2e66a88
#rb trivial #jira UE-191791 #rnx - Removed direct references to perforce from the dialog code, those strings are now passed in by the caller. This should make the dialog more usable by other revision control providers at some point. - Make it more obvious that the dialog is related to virtualized assets. - Add more references to the revision control provider name so that people realize which settings they are supposed to be entering. - Removed some debug code for launching the dialog from a console command. - Fixed a bug where clicking the button to reset the ini file settings and use the default connection would reset the settings but then not try to reconnect. - Make better use of the dialog space by increasing the size of the input boxes at the expense of white space, so that longer server addresses can fit on screen. [CL 26769098 by paul chipchase in ue5-main branch]
329 lines
9.9 KiB
C++
329 lines
9.9 KiB
C++
// Copyright Epic Games, Inc. All Rights Reserved.
|
|
|
|
#include "SVirtualizationRevisionControlConnectionDialog.h"
|
|
|
|
#if UE_VA_WITH_SLATE
|
|
|
|
#include "Async/ManualResetEvent.h"
|
|
#include "Framework/Application/SlateApplication.h"
|
|
#include "Framework/Docking/TabManager.h"
|
|
#include "HAL/IConsoleManager.h"
|
|
#include "Misc/App.h"
|
|
#include "Misc/ConfigCacheIni.h"
|
|
#include "SourceControlHelpers.h"
|
|
#include "Widgets/Images/SImage.h"
|
|
#include "Widgets/Input/SButton.h"
|
|
#include "Widgets/Input/SEditableTextBox.h"
|
|
#include "Widgets/Input/SHyperlink.h"
|
|
#include "Widgets/SBoxPanel.h"
|
|
#include "Widgets/Text/STextBlock.h"
|
|
#include "VirtualizationManager.h"
|
|
|
|
#define LOCTEXT_NAMESPACE "Virtualization"
|
|
|
|
namespace UE::Virtualization
|
|
{
|
|
|
|
SRevisionControlConnectionDialog::FResult SRevisionControlConnectionDialog::RunDialog(FStringView RevisionControlName, FStringView ConfigSectionName, FStringView CurrentPort, FStringView CurrentUsername)
|
|
{
|
|
if (FApp::IsUnattended())
|
|
{
|
|
UE_LOG(LogVirtualization, Warning, TEXT("Skipping attempt to show SRevisionControlConnectionDialog as the application is unattended"));
|
|
return FResult();
|
|
}
|
|
|
|
if (!IsInGameThread())
|
|
{
|
|
UE_LOG(LogVirtualization, Warning, TEXT("Attempting to show SRevisionControlConnectionDialog on a worker thread!"));
|
|
return FResult();
|
|
}
|
|
|
|
if (!FSlateApplication::IsInitialized() || FSlateApplication::Get().GetRenderer() == nullptr)
|
|
{
|
|
UE_LOG(LogVirtualization, Warning, TEXT("Attempting to show SRevisionControlConnectionDialog before slate is initialized"));
|
|
return FResult();
|
|
}
|
|
|
|
UE_LOG(LogVirtualization, Display, TEXT("Creating dialog"));
|
|
|
|
FText WindowTitle = FText::Format(LOCTEXT("VASCSettings", "Virtualized Assets - {0} Revision Control Settings"), FText::FromStringView(RevisionControlName));
|
|
|
|
TSharedPtr<SWindow> DialogWindow = SNew(SWindow)
|
|
.Title(MoveTemp(WindowTitle))
|
|
.FocusWhenFirstShown(true)
|
|
.SupportsMinimize(false)
|
|
.SupportsMaximize(false)
|
|
.SizingRule(ESizingRule::Autosized)
|
|
.HasCloseButton(false);
|
|
|
|
TSharedPtr<SRevisionControlConnectionDialog> DialogWidget;
|
|
|
|
TSharedPtr<SBorder> DialogWrapper =
|
|
SNew(SBorder)
|
|
.BorderImage(FAppStyle::GetBrush("ToolPanel.GroupBorder"))
|
|
.Padding(4.0f)
|
|
[
|
|
SNew(SVerticalBox)
|
|
+ SVerticalBox::Slot()
|
|
.AutoHeight()
|
|
.Padding(16.0f, 16.0f, 16.0f, 0.0f)
|
|
[
|
|
SAssignNew(DialogWidget, SRevisionControlConnectionDialog, RevisionControlName, ConfigSectionName, CurrentPort, CurrentUsername)
|
|
.Window(DialogWindow)
|
|
]
|
|
];
|
|
|
|
DialogWindow->SetContent(DialogWrapper.ToSharedRef());
|
|
|
|
UE_LOG(LogVirtualization, Display, TEXT("Connection to revision control for virtualized assets failed. Offering the user the choice to retry or continue anyway"));
|
|
|
|
TSharedPtr<SWindow> ParentWindow = FSlateApplication::Get().GetActiveTopLevelWindow();
|
|
FSlateApplication::Get().AddModalWindow(DialogWindow.ToSharedRef(), ParentWindow);
|
|
|
|
if (DialogWidget->GetResult() == SRevisionControlConnectionDialog::EResult::Retry)
|
|
{
|
|
return FResult(DialogWidget->GetPort(), DialogWidget->GetUserName());
|
|
}
|
|
|
|
return FResult();
|
|
}
|
|
|
|
void SRevisionControlConnectionDialog::Construct(const FArguments& InArgs, FStringView RevisionControlName, FStringView InConfigSectionName, FStringView CurrentPort, FStringView CurrentUsername)
|
|
{
|
|
WindowWidget = InArgs._Window;
|
|
|
|
const FString ConnectionHelpUrl = FVirtualizationManager::GetConnectionHelpUrl();
|
|
ConfigSectionName = InConfigSectionName;
|
|
|
|
FText Message = FText::Format(LOCTEXT("VASCMsg", "Failed to connect to the {0} revision control server.\nThis may prevent you from loading virtualized assets in the future!\n\nPlease enter the correct {1} revision control settings below:"),
|
|
FText::FromStringView(RevisionControlName),
|
|
FText::FromStringView(RevisionControlName));
|
|
|
|
|
|
const FText PortToolTip = FText::Format(LOCTEXT("PortLabel_Tooltip", "The server and port for your {0} server. Usage ServerName:1234."), FText::FromStringView(RevisionControlName));
|
|
const FText UserToolTip = FText::Format(LOCTEXT("UserNameLabel_Tooltip", "{0} username."), FText::FromStringView(RevisionControlName));
|
|
|
|
ChildSlot
|
|
[
|
|
SNew(SVerticalBox)
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 16.0f, 16.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SHorizontalBox)
|
|
+ SHorizontalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 8.0f, 0.0f))
|
|
.HAlign(HAlign_Left)
|
|
.AutoWidth()
|
|
[
|
|
SNew(SVerticalBox)
|
|
+SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 0.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SImage)
|
|
.Image(FAppStyle::GetBrush("Icons.Error"))
|
|
]
|
|
]
|
|
+ SHorizontalBox::Slot()
|
|
[
|
|
SNew(STextBlock)
|
|
.Text(MoveTemp(Message))
|
|
.AutoWrapText(true)
|
|
]
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 16.0f, 16.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SHorizontalBox)
|
|
+ SHorizontalBox::Slot()
|
|
.FillWidth(0.2f)
|
|
.Padding(FMargin(0.0f, 0.0f, 16.0f, 0.0f))
|
|
[
|
|
SNew(SVerticalBox)
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 10.0f))
|
|
.VAlign(VAlign_Center)
|
|
.HAlign(HAlign_Right)
|
|
[
|
|
SNew(STextBlock)
|
|
.Text(LOCTEXT("PortLabel", "Server"))
|
|
.ToolTipText(PortToolTip)
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 10.0f))
|
|
.VAlign(VAlign_Center)
|
|
.HAlign(HAlign_Right)
|
|
[
|
|
SNew(STextBlock)
|
|
.Text(LOCTEXT("UserNameLabel", "User Name"))
|
|
.ToolTipText(UserToolTip)
|
|
]
|
|
]
|
|
+ SHorizontalBox::Slot()
|
|
.FillWidth(0.8f)
|
|
[
|
|
SNew(SVerticalBox)
|
|
+ SVerticalBox::Slot()
|
|
.VAlign(VAlign_Center)
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 10.0f))
|
|
[
|
|
SAssignNew(PortTextWidget, SEditableTextBox)
|
|
.Text(FText::FromString(FString(CurrentPort)))
|
|
.ToolTipText(PortToolTip)
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 10.0f))
|
|
.VAlign(VAlign_Center)
|
|
[
|
|
SAssignNew(UsernameTextWidget, SEditableTextBox)
|
|
.Text(FText::FromString(FString(CurrentUsername)))
|
|
.ToolTipText(UserToolTip)
|
|
]
|
|
]
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 16.0f, 16.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SHorizontalBox)
|
|
+ SHorizontalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 8.0f, 0.0f))
|
|
.HAlign(HAlign_Left)
|
|
.AutoWidth()
|
|
[
|
|
SNew(SVerticalBox)
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 0.0f, 0.0f, 0.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SImage)
|
|
.Image(FAppStyle::GetBrush("Icons.Warning"))
|
|
]
|
|
]
|
|
+ SHorizontalBox::Slot()
|
|
[
|
|
SNew(STextBlock)
|
|
.Text(LOCTEXT("VASCSkipWarning", "Skipping may cause future editor instability if virtualized data is required!"))
|
|
.AutoWrapText(true)
|
|
]
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.HAlign(HAlign_Right)
|
|
.AutoHeight()
|
|
[
|
|
SNew(SHyperlink)
|
|
.Text(LOCTEXT("VASCHelpUrl", "Click here for additional documentation"))
|
|
.ToolTipText(FText::FromString(ConnectionHelpUrl))
|
|
.OnNavigate(this, &SRevisionControlConnectionDialog::OnUrlClicked)
|
|
.Visibility_Lambda([ConnectionHelpUrl] { return !ConnectionHelpUrl.IsEmpty() ? EVisibility::Visible : EVisibility::Hidden; })
|
|
]
|
|
+ SVerticalBox::Slot()
|
|
.Padding(FMargin(0.0f, 16.0f, 16.0f, 16.0f))
|
|
.AutoHeight()
|
|
[
|
|
SNew(SHorizontalBox)
|
|
+ SHorizontalBox::Slot()
|
|
.HAlign(HAlign_Left)
|
|
[
|
|
SNew(SButton)
|
|
.VAlign(VAlign_Center)
|
|
.TextStyle(FAppStyle::Get(), "DialogButtonText")
|
|
.Text(LOCTEXT("VASC_Reset", "Reset To Defaults"))
|
|
.ToolTipText(LOCTEXT("VASC_ResetTip", "Removes connection settings that may be saved to your local ini files and attempts to connect using your environment defaults"))
|
|
.OnClicked(this, &SRevisionControlConnectionDialog::OnResetToDefaults)
|
|
]
|
|
+ SHorizontalBox::Slot()
|
|
.HAlign(HAlign_Right)
|
|
[
|
|
SNew(SHorizontalBox)
|
|
+ SHorizontalBox::Slot()
|
|
.AutoWidth()
|
|
.Padding(FMargin(5.0f, 0.0f))
|
|
[
|
|
SNew(SButton)
|
|
.VAlign(VAlign_Center)
|
|
.ButtonStyle(FAppStyle::Get(), "PrimaryButton")
|
|
.TextStyle(FAppStyle::Get(), "DialogButtonText")
|
|
.Text(LOCTEXT("VASC_Retry", "Retry Connection"))
|
|
.ToolTipText(LOCTEXT("VASC_RetryTip", "Attempts to reconnect to the revision control server with the settings that you entered"))
|
|
.OnClicked(this, &SRevisionControlConnectionDialog::OnRetryConnection)
|
|
]
|
|
+ SHorizontalBox::Slot()
|
|
.AutoWidth()
|
|
.Padding(FMargin(5.0f, 0.0f))
|
|
[
|
|
SNew(SButton)
|
|
.VAlign(VAlign_Center)
|
|
.TextStyle(FAppStyle::Get(), "DialogButtonText")
|
|
.Text(LOCTEXT("VASC_Skip", "Skip"))
|
|
.ToolTipText(LOCTEXT("VASC_SkipTip", "The editor will continue to load but will be unable to pull virtualized data from revision control if needed"))
|
|
.OnClicked(this, &SRevisionControlConnectionDialog::OnSkip)
|
|
]
|
|
]
|
|
]
|
|
];
|
|
}
|
|
|
|
void SRevisionControlConnectionDialog::CloseModalDialog()
|
|
{
|
|
if (WindowWidget.IsValid())
|
|
{
|
|
WindowWidget.Pin()->RequestDestroyWindow();
|
|
}
|
|
}
|
|
|
|
FReply SRevisionControlConnectionDialog::OnResetToDefaults()
|
|
{
|
|
UE_LOG(LogVirtualization, Display, TEXT("User opted to clear the ini file settings and connect using the revision control defaults"));
|
|
GConfig->EmptySection(*ConfigSectionName, SourceControlHelpers::GetSettingsIni());
|
|
|
|
Result = EResult::Retry;
|
|
|
|
Port.Empty();
|
|
UserName.Empty();
|
|
|
|
CloseModalDialog();
|
|
|
|
return FReply::Handled();
|
|
}
|
|
|
|
FReply SRevisionControlConnectionDialog::OnRetryConnection()
|
|
{
|
|
UE_LOG(LogVirtualization, Display, TEXT("User opted to retry connecting to revision control"));
|
|
|
|
Result = EResult::Retry;
|
|
|
|
Port = PortTextWidget->GetText().ToString();
|
|
UserName = UsernameTextWidget->GetText().ToString();
|
|
|
|
CloseModalDialog();
|
|
|
|
return FReply::Handled();
|
|
}
|
|
|
|
FReply SRevisionControlConnectionDialog::OnSkip()
|
|
{
|
|
UE_LOG(LogVirtualization, Warning, TEXT("User opted not to connect to revision control. Virtualized data may not be accessible!"));
|
|
|
|
Result = EResult::Skip;
|
|
|
|
CloseModalDialog();
|
|
|
|
return FReply::Handled();
|
|
}
|
|
|
|
void SRevisionControlConnectionDialog::OnUrlClicked() const
|
|
{
|
|
const FString ConnectionHelpUrl = FVirtualizationManager::GetConnectionHelpUrl();
|
|
|
|
FPlatformProcess::LaunchURL(*ConnectionHelpUrl, nullptr, nullptr);
|
|
}
|
|
|
|
} // namespace UE::Virtualization
|
|
|
|
#undef LOCTEXT_NAMESPACE
|
|
|
|
#endif //UE_VA_WITH_SLATE
|