Files
UnrealEngineUWP/Engine/Source/Editor/UnrealEd/Private/Commandlets/GenerateAssetManifestCommandlet.cpp
robert manuszewski d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00

218 lines
7.4 KiB
C++

// Copyright Epic Games, Inc. All Rights Reserved.
/*=============================================================================
GenerateAssetManifestCommandlet.cpp: Commandlet for generating a filtered
list of assets from the asset registry (intended use is for replacing
assets with cooked version)
=============================================================================*/
#include "Commandlets/GenerateAssetManifestCommandlet.h"
#include "AssetRegistry/AssetRegistryModule.h"
#include "HAL/FileManager.h"
#include "Misc/Paths.h"
#include "AssetRegistry/ARFilter.h"
#include "Engine/World.h"
#include "Misc/FileHelper.h"
DEFINE_LOG_CATEGORY_STATIC(LogGenerateAssetManifestCommandlet, Log, All);
UGenerateAssetManifestCommandlet::UGenerateAssetManifestCommandlet(const FObjectInitializer& ObjectInitializer)
: Super(ObjectInitializer)
{
}
int32 UGenerateAssetManifestCommandlet::Main(const FString& InParams)
{
// Parse command line.
TArray<FString> Tokens;
TArray<FString> Switches;
UCommandlet::ParseCommandLine(*InParams, Tokens, Switches);
// Support standard and BuildGraph style delimeters
static const TCHAR* ParamDelims[] =
{
TEXT(";"),
TEXT("+"),
};
const FString ManifestFileSwitch = TEXT("ManifestFile=");
const FString IncludedPathsSwitch = TEXT("IncludedPaths=");
const FString IncludedClassesSwitch = TEXT("IncludedClasses=");
const FString ExcludedPathsSwitch = TEXT("ExcludedPaths=");
const FString ExcludedClassesSwitch = TEXT("ExcludedClasses=");
const FString ClassBasePathsSwitch = TEXT("ClassBasePaths=");
FString ManifestFile;
TArray<FString> IncludedPaths;
TArray<FString> IncludedClasses;
TArray<FString> ExcludedPaths;
TArray<FString> ExcludedClasses;
TArray<FString> ClassBasePaths;
// Parse parameters
for (int32 SwitchIdx = 0; SwitchIdx < Switches.Num(); ++SwitchIdx)
{
const FString& Switch = Switches[SwitchIdx];
FString SwitchValue;
if (FParse::Value(*Switch, *ManifestFileSwitch, SwitchValue))
{
ManifestFile = SwitchValue;
}
else if (FParse::Value(*Switch, *IncludedPathsSwitch, SwitchValue))
{
SwitchValue.ParseIntoArray(IncludedPaths, ParamDelims, 2);
}
else if (FParse::Value(*Switch, *IncludedClassesSwitch, SwitchValue))
{
SwitchValue.ParseIntoArray(IncludedClasses, ParamDelims, 2);
}
else if (FParse::Value(*Switch, *ExcludedPathsSwitch, SwitchValue))
{
SwitchValue.ParseIntoArray(ExcludedPaths, ParamDelims, 2);
}
else if (FParse::Value(*Switch, *ExcludedClassesSwitch, SwitchValue))
{
SwitchValue.ParseIntoArray(ExcludedClasses, ParamDelims, 2);
}
else if (FParse::Value(*Switch, *ClassBasePathsSwitch, SwitchValue))
{
SwitchValue.ParseIntoArray(ClassBasePaths, ParamDelims, 2);
}
}
// Check that output file path is specified
if (ManifestFile.IsEmpty())
{
UE_LOG(LogGenerateAssetManifestCommandlet, Error, TEXT("Please specify a valid location for -ManifestFile on the commandline"));
return 1;
}
// by default only look for classes within the game project
if (ClassBasePaths.Num() == 0)
{
ClassBasePaths.Add(TEXT("/Game"));
}
TArray<FName> ClassPackagePaths;
for (FString BasePath : ClassBasePaths)
{
ClassPackagePaths.Add(*BasePath);
}
// Load the asset registry module
FAssetRegistryModule& AssetRegistryModule = FModuleManager::LoadModuleChecked<FAssetRegistryModule>(TEXT("AssetRegistry"));
// Update Registry Module
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Searching Asset Registry"));
AssetRegistryModule.Get().SearchAllAssets(true);
TArray<FAssetData> FinalAssetList;
// Get assets from paths and classes that we want to include
if (IncludedPaths.Num() > 0)
{
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Getting Assets from specified paths"));
FARFilter Filter;
Filter.bIncludeOnlyOnDiskAssets = true;
Filter.bRecursivePaths = true;
for (const FString& IncludedPath : IncludedPaths)
{
Filter.PackagePaths.AddUnique(*IncludedPath);
}
TArray<FAssetData> AssetList;
AssetRegistryModule.Get().GetAssets(Filter, AssetList);
for (FAssetData& Asset : AssetList)
{
FinalAssetList.AddUnique(Asset);
}
}
if (IncludedClasses.Num() > 0)
{
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Getting Assets of specified classes"));
FARFilter Filter;
Filter.bIncludeOnlyOnDiskAssets = true;
Filter.PackagePaths = ClassPackagePaths;
Filter.bRecursivePaths = true;
for (const FString& IncludedClass : IncludedClasses)
{
FTopLevelAssetPath IncludedClassPathName = UClass::TryConvertShortTypeNameToPathName<UStruct>(IncludedClass, ELogVerbosity::Error, TEXT("UGenerateAssetManifestCommandlet::Main"));
if (IncludedClassPathName.IsNull())
{
UE_LOG(LogGenerateAssetManifestCommandlet, Error, TEXT("Failed to convert short class name \"%s\" to path name. Please use class path names for IncludedClasses."), *IncludedClass);
}
else
{
Filter.ClassPaths.AddUnique(IncludedClassPathName);
}
}
TArray<FAssetData> AssetList;
AssetRegistryModule.Get().GetAssets(Filter, AssetList);
for (FAssetData& Asset : AssetList)
{
FinalAssetList.AddUnique(Asset);
}
}
// Run through paths and classes that should be excluded
if (FinalAssetList.Num() > 0 && ExcludedPaths.Num() > 0)
{
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Excluding Assets from specified paths"));
FARFilter Filter;
Filter.bIncludeOnlyOnDiskAssets = true;
Filter.bRecursivePaths = true;
for (const FString& ExcludedPath : ExcludedPaths)
{
Filter.PackagePaths.AddUnique(*ExcludedPath);
}
TArray<FAssetData> AssetList;
AssetRegistryModule.Get().GetAssets(Filter, AssetList);
FinalAssetList.RemoveAll([&AssetList](const FAssetData& Asset) {return AssetList.Contains(Asset); });
}
if (FinalAssetList.Num() > 0 && ExcludedClasses.Num() > 0)
{
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Excluding Assets of specified classes"));
FARFilter Filter;
Filter.bIncludeOnlyOnDiskAssets = true;
Filter.PackagePaths = ClassPackagePaths;
Filter.bRecursivePaths = true;
for (const FString& ExcludedClass : ExcludedClasses)
{
FTopLevelAssetPath ExcludedClassPathName = UClass::TryConvertShortTypeNameToPathName<UStruct>(ExcludedClass, ELogVerbosity::Error, TEXT("UGenerateAssetManifestCommandlet::Main"));
if (ExcludedClassPathName.IsNull())
{
UE_LOG(LogGenerateAssetManifestCommandlet, Error, TEXT("Failed to convert short class name \"%s\" to path name. Please use class path names for ExcludedClasses."), *ExcludedClass);
}
else
{
Filter.ClassPaths.AddUnique(ExcludedClassPathName);
}
}
TArray<FAssetData> AssetList;
AssetRegistryModule.Get().GetAssets(Filter, AssetList);
FinalAssetList.RemoveAll([&AssetList](const FAssetData& Asset) {return AssetList.Contains(Asset); });
}
FString FinalFileList;
if (FinalAssetList.Num() > 0)
{
UE_LOG(LogGenerateAssetManifestCommandlet, Display, TEXT("Converting Package Names to File Paths"));
for (FAssetData& RemovedAsset : FinalAssetList)
{
FString ActualFile;
if (FPackageName::DoesPackageExist(RemovedAsset.PackageName.ToString(), &ActualFile))
{
ActualFile = IFileManager::Get().ConvertToAbsolutePathForExternalAppForRead(*ActualFile);
FinalFileList += FString::Printf(TEXT("%s") LINE_TERMINATOR, *ActualFile);
}
}
if (!FFileHelper::SaveStringToFile(FinalFileList, *ManifestFile))
{
UE_LOG(LogGenerateAssetManifestCommandlet, Error, TEXT("Failed to save output file '%s'"), *ManifestFile);
return 1;
}
}
return 0;
}