Commit Graph

222 Commits

Author SHA1 Message Date
kerim borchaev
a04e402091 Added tag metadata to items in New Asset menu of Context Browser
#rb logan.buchy

[CL 29228979 by kerim borchaev in ue5-main branch]
2023-10-30 06:33:19 -04:00
mateo egey
cee00f7328 Multitude of small changes and fixes to content browser & asset picker.
- Removed unused function

- Added 'FX' asset type category for Niagara purposes that maps to the FX asset category path for default expansion purposes

- Restored functionality for default filter category expansion. This code seemed abandoned. The category expansion could be specified in the asset picker config, but in the end was ignored and the Basic asset path was used instead. This uses a Convert function to go from AssetTypeCategory -> AssetCategoryPath. There is no 1:1 mapping, so it falls back to Basic if necessary. Changing the type in the asset picker config would be cleaner, but isn't straight forward due to FAssetCategoryPath needing to be exposed to all modules that include the content browser module

- Tweaked OnExtendAddFilterMenu delegate. It's now a global delegate, making it unnecessary to handle template shenanigans to access it.
AssetPickerConfig has a new option to provide this OnExtendAddFilterMenu externally. As the 'Common' category still shows up if we expand the FX category (since Niagara System is part of Basic & FX), we can use this to remove unwanted filters
The delegate is called on the dynamic menu section before the widget generation

- Added PinAllFrontendFilters argument. This is useful if you have a small amount of filters available so that you want to display them all by default

Big code cleanup:
- MakeAddFilterMenu is now marked as final to help with API consistency.
- Added new 'CreateAssetFilterBarContext` virtual function. This is now the unified way of configuring your menu.
- The context now contains the FOnFilterAssetType delegate, and the OnExtendAddFilterMenu delegate. This allows subclasses to keep their original functionality, while having a central place to tweak it
- Removed the old content browser context as it's no longer used
- Exposed the menu name. Kept old names consistent. This allows to reuse menus, or create new ones.
- Moved the right click context filter UI of the content browser into the SAssetFilterBar. Now all SAssetFilterBars can do this. Removed the OnGetContextMenu delegate that was only used in one place
- Removed various functions that are no longer needed

#rb rex.hill, aditya.ravichandran

#ushell-cherrypick of 28538117 by Mateo.Egey

[CL 28705843 by mateo egey in ue5-main branch]
2023-10-12 07:03:37 -04:00
jeanfrancois dube
055748782e Added the possibility to copy content browser selected paths to the clipboard (mapped to Ctrl+C).
#rb sebastien.lussier

[CL 27669429 by jeanfrancois dube in ue5-main branch]
2023-09-07 07:51:03 -04:00
julien stjean
2a8b0ed68c Fixed a crash when exiting the editor via the QuitEditor function.
The slate windows get close after the subsystems are deinitilaized so we need to be carefull with those in the content browser widget code. Some binding can still be queried while processing some defered windows event during the closing of the slate application.

#jira UE-189606
#rb JeanLuc.Corenthin

[CL 26615347 by julien stjean in ue5-main branch]
2023-07-26 14:14:51 -04:00
rex hill
6b756a6b46 [ContentBrowser] Add cvar for debugging enumeration issues to shut off breadcrumb content browser data source queries each tick to.
Allows setting breakpoints and not having them hit each tick by breadcrumb.
#rnx
#jira

[CL 26434474 by rex hill in ue5-main branch]
2023-07-18 10:58:23 -04:00
rex hill
858bd384e3 Re-add ability to hide collections that was removed by 23662444
#preflight skip
#rnx

[CL 25461666 by rex hill in ue5-main branch]
2023-05-12 18:52:39 -04:00
Julien StJean
73bf6aa597 Fixed an issue with the content browser not always showing the path filters. The SLATE_ARGUMENT to determine if it should be shown was not initialized.
#jira UE-178338
#preflight 643ee3312a71363e1082fbc2
#rb Rex.Hill

[CL 25093460 by Julien StJean in ue5-main branch]
2023-04-18 16:16:54 -04:00
jamie dale
b95e92ef3d Content Browser UX improvements for cooked content
* Plugins that only contain cooked content (and have no C++ modules) no longer show their "Content" suffix.
* Folders that only contain private cooked content are no longer visible in the asset or path views.

#preflight 642f2e3cb306e98c632f0195
#rb Jason.Stasik, Aditya.RaviChandran

[CL 24994922 by jamie dale in ue5-main branch]
2023-04-11 14:22:33 -04:00
scott nelson
c5c4059f2c Update wording of trying to edit cooked assets to be less scary for new users
#rb Derek.Truong
#preflight skipped

[CL 24851397 by scott nelson in ue5-main branch]
2023-03-30 02:50:12 -04:00
rex hill
2ff6708892 CIS - Fix deprecation warning after merge
[CL 24620671 by rex hill in ue5-main branch]
2023-03-13 16:24:55 -04:00
rex hill
700afabf83 Editor - Fix some favorites being deleted in content browser if plugin not mounted when settings loaded
#preflight skip

[CL 24620618 by rex hill in ue5-main branch]
2023-03-13 16:23:10 -04:00
lauren barnes
17a57fa4fa Fall back to EditorConfig version of content browser settings where it exists, removing some settings from per-instance settings
#jira UE-175898
#preflight 63fe5ff8ac6c61e2b553eea1

[CL 24454235 by lauren barnes in ue5-main branch]
2023-02-28 18:18:28 -05:00
lauren barnes
2aae7e7f18 Browsing to assets where the current settings would cause the asset to be hidden now updates the settings of the active Content Browser to show the asset(s). This is done by directly changing the setting as many systems are listening for Content Browser settings changes to refresh their display to the user.
#jira UE-175679
#rb julien.stjean
#lockdown jeanmichel.dignard
#preflight 63ea6739923476b686e0bc0b

[CL 24194579 by lauren barnes in ue5-main branch]
2023-02-13 18:26:10 -05:00
sebastian nordgren
70676dac04 Selecting a folder in the Content Browser with an empty ContentBrowser.json config file no longer occasionally crashes.
The EditorConfig argument was being passed to SPathView as a raw pointer, but opening a new Content Browser tab or opening the drawer could cause the config array to be resized and invalidate the pointer.

Instead, the content browser instance name is now passed to SPathView and the config is looked up each time.

#rb aditya.ravichandran
#jira UE-175926
#preflight 63e24fb49910415ae2f603f5
#lockdown jeanmichel.dignard

[CL 24053956 by sebastian nordgren in ue5-main branch]
2023-02-07 13:43:08 -05:00
JeanMichel Dignard
38ef5daae8 Fixed truncation warnings in the ContentBrowser modules
#jira UE-166269
#rb yohann.dossantos
#preflight 63e12ffa797b029c0a6507fe

[CL 24032337 by JeanMichel Dignard in ue5-main branch]
2023-02-06 12:05:08 -05:00
julien stjean
55a1b3af29 Introducing the unsupported asset item for the content browser.
These are currently used to display the asset that are hidden by a backend class permission system.
They can also be restricted to some path only if desired.
Note: We will do a UX pass for the unsupported items after this is submitted and later we will also add some support for the unsupported asset to the alias data source.

#preflight 63dc23a7175a9839ac4cf474
#rb Jason.Stasik

[CL 24007061 by julien stjean in ue5-main branch]
2023-02-03 22:39:50 -05:00
sebastian nordgren
b3c6af40ef Content Browser sources panel is now always open by default.
#review @aditya.ravichandran
#preflight 63d27db2e55deff624f0829d

[CL 23867551 by sebastian nordgren in ue5-main branch]
2023-01-26 09:54:36 -05:00
sebastian nordgren
36d8937ee1 Content browser now restores the selected paths after a restart.
Selecting a content browser path now triggers an editor config save.

Added icon to Lock/Unlock Content Browser setting.

#review-23772163 @aditya.ravichandran
#preflight 63c94681b065224750208da9

[CL 23773172 by sebastian nordgren in ue5-main branch]
2023-01-19 09:57:32 -05:00
sebastian nordgren
9ebab4256d Collections are now visible in the Content Browser again.
Removed CollectionsDocked setting, since it wasn't bound to any toggle anywhere.

Removed sources widget switcher which was untoggleable.

#jira UE-173851
#review-23661236 @editor-ux
#preflight 63c00acc4b018bfa800fbebc

[CL 23662444 by sebastian nordgren in ue5-main branch]
2023-01-12 09:40:29 -05:00
sebastian nordgren
de150ad082 Content browser settings moved to editor config system.
There are a few settings here that we use in places where it's ambiguous which content browser instance is triggering the change, and those have not been transferred over. A few settings also appear to now be unused, and those have also not been transferred.

Additionally, set the SetDisplayDeveloperFolder(bool, bool) functions which took an override variable have been deprecated, and the overrides moved to SAssetView variables directly - these were used after syncing content to temporarily override filters and weren't persisted.

Tested across 2 Content Browsers, toggling all settings enabled on one, and all setting disabled on the other, and checking that the settings persist across restarts of the editor.

#jira UE-150674
#review-23434533 @editor-ux
#preflight 63bd773868068a8bd64ea317

[CL 23626453 by sebastian nordgren in ue5-main branch]
2023-01-10 09:46:42 -05:00
aditya ravichandran
d28f187281 Content Browser: Fix a regression where the state of filters was not being saved/loaded
#jira UE-173066
#rb lauren.barnes
#preflight 639c9305776b61ba3b7506d1
#lockdown aurel.cordonnier

[CL 23539588 by aditya ravichandran in ue5-main branch]
2022-12-16 13:21:25 -05:00
sebastian nordgren
5fbf85dd1b Pressing Delete in the Favorites view now removes the favorite instead of deleting the folder.
#review-23372887 @lauren.barnes
#preflight 638a20634c3ce8ae5d1e81dd

[CL 23373547 by sebastian nordgren in ue5-main branch]
2022-12-02 11:07:48 -05:00
jason stasik
82f31afa1b Add cvar to hide ability to add searches as collections
#rb aditya.ravichandran
#preflight 636040c1c6242f88a4b94e82

[CL 22876445 by jason stasik in ue5-main branch]
2022-10-31 21:23:27 -04:00
jared cotton
db9180da10 Re-submission of 'view' method for AssetEditing (aware of merge issues that will arise in 23.00 and ready to resolve. Also ready with fix for issue that will arise when CL hits /Fortnite-Main in GLTFProxyAssetActions.h)
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf

Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.

The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.

[CL 22823595 by jared cotton in ue5-main branch]
2022-10-28 00:33:58 -04:00
bob tellez
3dec1bb8cb [Backout] - CL22782944
[FYI] jared.cotton
Original CL Desc
-----------------------------------------------------------------
Addition of 'view' method to AssetTypeActions

#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf

Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.

The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.

[CL 22803476 by bob tellez in ue5-main branch]
2022-10-26 23:17:50 -04:00