Commit Graph

93 Commits

Author SHA1 Message Date
brooke hubert
b64f2e25fb [Deprecation Cleanup] Remove deprecated code in actor factory class
#rb logan.buchy, ronald.koppers
#jira UE-200474

[CL 29744522 by brooke hubert in ue5-main branch]
2023-11-15 08:49:58 -05:00
anousack kitisa
3ce04fd115 GeometryCache: Fixed uninitialized bounding box in GeometryCacheMeshData that could cause issues for GeometryCacheComponent bounds.
[CL 29492349 by anousack kitisa in ue5-main branch]
2023-11-06 13:02:40 -05:00
zach bethel
fe3ad17905 Fixed parallel GDME issues and re-enabled.
- Hair visualization mode context needs a mutex to initialize. Hair also currently requires deterministic ordering of dynamic meshes to avoid artifacts, so disabling parallel support for now.
 - Fixed race in allocating particle order buffer.
 - Fixed Geometry Collection UpdateFrame to support a command list.

#jira UE-199472, UE-199456, UE-199463

[CL 29329272 by zach bethel in ue5-main branch]
2023-11-01 15:47:31 -04:00
MaximeRobinot
26f5cabe42 PR #10722: GeometryCache fixes
* Fixed geometry cache material mapping when visibility animation is used. Now, the materials won't shift around when a mesh section is hidden.
* Import can now be interrupted.

#jira UE-192005
#rb Anousack.Kitisa

[CL 28204095 by MaximeRobinot in ue5-main branch]
2023-09-25 16:35:07 -04:00
zach bethel
29f735f4a3 Modified scene proxy GetDynamicMeshElements calls to take a local command list instead of relying on the immediate command list and defer uniform expression cache invalidations.
- Calls to FRHICommandListImmediate::Get() replaced with Collector.GetRHICommandList()

#jira UE-194426

[CL 27813729 by zach bethel in ue5-main branch]
2023-09-12 18:32:22 -04:00
stu mckenna
869f97b9b1 - Add ConditionalPostLoad for Niagara material texture bindings / MIC materials
- Without this duplicated a system for validation can crash as we access a subobject which has not been PostLoaded yet

#rb rob.krajcarski

[CL 27694844 by stu mckenna in ue5-main branch]
2023-09-07 19:11:12 -04:00
Anousack Kitisa
8de62d61a1 USD:
* Fixed USD geometry cache streams not being unregistered when the stage is unloaded.
* Fixed geometry cache assets being evicted from the asset cache due to their size varying with the streamer settings.

#jira UE-193306
#rb Daniel.Coelho

[CL 27460465 by Anousack Kitisa in ue5-main branch]
2023-08-29 15:23:28 -04:00
john vanderburg
058843c9e2 [GeomCache] Added some virtual method to the tracks to sample at a specific frame directly (sample index).
[CL 27265435 by john vanderburg in ue5-main branch]
2023-08-22 05:50:43 -04:00
stu mckenna
8742d2b1a3 - Remove mutable access to particle data if using a const emitter instance pointer
#rb rob.krajcarski

[CL 27231844 by stu mckenna in ue5-main branch]
2023-08-20 00:24:05 -04:00
michael galetzka
03609a77e1 Fixed missing non-unity includes
#jira UE-183494
#rb none

[CL 26728961 by michael galetzka in ue5-main branch]
2023-07-31 21:42:13 -04:00
michael galetzka
619db04967 Reset cached scene velocity to prevent motion blur when reusing components
#jira UE-183494, UE-184022
#rb stu.mckenna, jeremy.moore

[CL 26727868 by michael galetzka in ue5-main branch]
2023-07-31 20:30:59 -04:00
bryan sefcik
64f140d78d Added shader.build.cs file.
Updated build.cs files to use new shader module.

#jira
#rb Joe.Kirchoff and guillaume.abadie

[CL 26664107 by bryan sefcik in ue5-main branch]
2023-07-27 22:53:25 -04:00
zach bethel
aa1b0c680f Deprecated non-command list RHI methods.
- RHICreate{Vertex, Index, Structured}Buffer
 - RHICreate{ShaderResource, UnorderedAccess}View
 - RHIUpdateUniformBuffer
 - Various initialization / locking methods for helper buffer types in RHIUtilities.h

The goal is to continue to force resource creation through command lists to avoid surprises with moving things off the render thread.

#rb christopher.waters

[CL 26183242 by zach bethel in ue5-main branch]
2023-06-22 11:08:27 -04:00
zach bethel
793d4d963c Fixed nonunity build break.
[CL 26099347 by zach bethel in ue5-main branch]
2023-06-19 14:54:04 -04:00
zach bethel
a7a9029b20 Deprecated InitRHI() in favor of InitRHI(FRHICommandListBase&).
#rb mihnea.balta, luke.thatcher, christopher.waters

[CL 26097009 by zach bethel in ue5-main branch]
2023-06-19 13:56:56 -04:00
christopher waters
20049327ff Making FRayTracingGeometryInitializer not a memory layout type since nothing needs it like that anymore.
#rb yuriy.odonnell

[CL 26007363 by christopher waters in ue5-main branch]
2023-06-15 05:41:47 -04:00
marc audy
d1f48fc5c8 Fix implicit capture of this using [=] deprecated in C++20
#jira
#rnx

[CL 25989494 by marc audy in ue5-main branch]
2023-06-14 15:07:58 -04:00
zach bethel
a9a5fa39db Deprecated non-command list variant of InitResource and UpdateResource. Patched the engine to pass command lists through. Follow-up CL's will refactor individual locations to thread command lists through the various callstacks, but that was done very judiciously in this CL to reduce risk.
#rb mihnea.balta, christopher.waters

[CL 25953623 by zach bethel in ue5-main branch]
2023-06-13 11:46:40 -04:00
Zhenglin Geng
f210dfde0a GeometryCacheConstantTopologyWriter: fix signed/unsigned mismatch
#jira none
#rb trivial

[CL 25862982 by Zhenglin Geng in ue5-main branch]
2023-06-07 20:03:55 -04:00
Zhenglin Geng
9679b35ffb Add GeometryCacheHelper to save geometrycache in engine
#rb anousack.kitisa, john.vanderburg
#jira none

[CL 25848629 by Zhenglin Geng in ue5-main branch]
2023-06-07 12:40:36 -04:00
stu mckenna
b4f0d2bcb3 - Use initializer list for AttributeBindings as not all have correct reserve sizes
#rb rob.krajcarski
#preflight 6478d0c37a6aeda41b4da81a

[CL 25738233 by stu mckenna in ue5-main branch]
2023-06-01 15:54:04 -04:00
Wojciech Krywult
d1baf24722 AsyncIO: Fixed incorrect handling of the STAT_AsyncFileMemory stat.
I've reviewed all code using async requests and we had multiple places incorrectly handling the stat: some placed failed to decrease the counter, while others would decrease it when they shouldn't. The main cause was the fact that when we create an async request and pass nullptr as the target memory, the request allocates the memory itself and increases the STAT_AsyncFileMemory. However, when we call GetReadResults() on such requests, the responsibility is on the caller to balance the calls and decrease the stat, which is not very obvious and leads to the mentioned bugs. On top of that, when we call GetReadResults() we may not have the knowledge as to whether the returned memory was allocated by the request or not (which may affect whether we should touch the stat at all).

Resolved by adding IAsyncReadRequest::ReleaseMemoryOwnershipImpl member, which may be used by request implementations to do the proper clean up (balance the stat). This way requests take the full responsibility for their changes and users of the requests don't need to know their implementation details.

#preflight none
#rb Patrick.Laflamme
#jira UE-185064

[CL 25664733 by Wojciech Krywult in ue5-main branch]
2023-05-29 12:11:37 -04:00
stu mckenna
5dce276366 - Add emitter mode support for Geometry Cache Array Index
#rb michael.galetzka
#rnx
#preflight 646f87e7d1157dc4a7722498

[CL 25645043 by stu mckenna in ue5-main branch]
2023-05-26 12:15:10 -04:00
stu mckenna
83ace92a70 - Add MIC support to Geometry Cache Renderer
#rb michael.galetzka
#preflight 646e6dae1417daba1e0633d8

[CL 25632022 by stu mckenna in ue5-main branch]
2023-05-25 18:13:44 -04:00
daniel coelho
74cd9be0a8 GeometryCache: Expose streamer settings to Python so that we can test things during streaming from automated tests.
#jira UE-186747
#rb Anousack.Kitisa
#preflight 646f33fc1417daba1e551b5e

[CL 25618385 by daniel coelho in ue5-main branch]
2023-05-25 06:42:49 -04:00