robert manuszewski
703fbc2727
Fixing a crash when reporting long reference chains with 'obj refs' command.
...
#rb none
#ROBOMERGE-VERSION: 349-6578295
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 6543528 via CL 6543620 via CL 6543667
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6578921 by robert manuszewski in Dev-VR branch]
2019-05-20 14:21:06 -04:00
bob tellez
d4a5ddeb20
#UE4 Better FGCObject reporting in obj refs. FGCObject names are now reported in the "obj refs" console command, provided that they pass in FGCObject::GGCObjectReferencer as the referencer when calling AddReferencedObjects. FGCObjects may now also implement GetReferencerPropertyName to describe more details about how it references an object.
...
#ROBOMERGE-VERSION: 349-6578295
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 6542056 via CL 6542588 via CL 6542593
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6578718 by bob tellez in Dev-VR branch]
2019-05-20 14:14:27 -04:00
ben woodhouse
970d2b258f
Fix linker loop deadlock bug (causes loading deadlock in some cases)
...
#rb gil.gribb
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 6417518 via CL 6418865 via CL 6418880 via CL 6418961
2019-05-15 14:18:10 -04:00
josh adams
00528d0aee
- Added debug spikemark and spikemarkcheck to track objects that get destroyed after a mark, which can be used to track objects that go away right after being loaded; can help reduce memory spikes of objects being loaded and GCd right away
...
#rb none
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 6402899 via CL 6403012 via CL 6404642 via CL 6404653
2019-05-15 13:08:26 -04:00
robert manuszewski
f55a326805
Fixing a crash when launching cooked projects with the Event Driven Loader disabled
...
#rb none
#jira UE-73368
#lockdown cristina.riveron
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 6316372 in //UE4/Release-4.22/... via CL 6317373
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6350224 by robert manuszewski in Dev-VR branch]
2019-05-07 18:00:23 -04:00
david harvey
77d8ce7044
[LLM] another pass over EngineMisc. moves about 15MB out in my test replay, mostly moved to LoadMapMisc and StreamingManager.
...
#rb anthony.bills
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: david.harvey
#ROBOMERGE-SOURCE: CL 6173661 via CL 6179493 via CL 6179684
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 6218434 by david harvey in Dev-VR branch]
2019-05-01 18:51:32 -04:00
johan torp
25f11ea9ae
Fix race condition in cook -diffonly
...
The same ubulk file, typically for a texture, was written by two different threads. This caused a fatal SavePackage assert in FAsyncWriteWorker::DoWork(). There was no need to write out these files to disk at all.
Also cleaned up surrounding code a little bit.
#jira ue-72635
#rb robert.manuszewski
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: johan.torp
#ROBOMERGE-SOURCE: CL 5937291 via CL 5937787 via CL 5937827
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5956336 by johan torp in Dev-VR branch]
2019-04-17 17:01:09 -04:00
pj kack
8b34e2ed76
Optimize UPackage::IsFullyLoaded() for cooker.
...
The editor specific feature of querying the file system to identify newly created packages (not having a corresponding file on disk) is really slow.
Early out from this expensive check when the package already has a known file size.
VTune user-mode cpu sampling time results when cooking a big data set (~200 000 packages):
UCookOnTheFlyServer::MaybeMarkPackageAsAlreadyLoaded() down from 10 sec to 0.1 sec, a 100X speedup.
FLinkerLoad::LoadAllObjects down from 400 sec to 280 sec, a 1.4X speedup, i.e. ~4% (120 sec) of the total load time of 2750 sec.
#rb robert.manuszewski
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: pj.kack
#ROBOMERGE-SOURCE: CL 5818305 via CL 5818901 via CL 5818980
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5856467 by pj kack in Dev-VR branch]
2019-04-12 13:52:56 -04:00
bob tellez
9bbdf24fb9
#UE4 Changed the order of the asset load error message to show the referencer first
...
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5755606 via CL 5763296 via CL 5763365
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5776193 by bob tellez in Dev-VR branch]
2019-04-08 13:01:56 -04:00
graeme thornton
ce60c733b0
Edigration of an FLinkerLoad optimization from Dev-Core CL 5709116
...
Second optimization to a heavily hit function that uses an FArchiveFromStructuredArchive adapter. That class needs optimization, so temporarily use a straight FArchive path when text archive support is compiled out
fyi ben.woodhouse, gil.gribb, per.larsson
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5716883 via CL 5716884 via CL 5716885 via CL 5716886 via CL 5717811 via CL 5717889
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5729182 by graeme thornton in Dev-VR branch]
2019-04-04 01:13:38 -04:00
bob tellez
deeafb033b
#UE4 Improve logging when assets fail to load. Failing to get the package linker will now produce fewer redundant log messages and all failure messages will include the asset that failed to load as well as the asset that was requesting the linker where possible.
...
#rb Robert.Manuszewski
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5713888 via CL 5714486 via CL 5714487
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5723933 by bob tellez in Dev-VR branch]
2019-04-03 22:21:45 -04:00
bob tellez
1deb83c532
#UE4 Fix a bug that caused logs about missing assets to not show their referencer
...
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5641069
2019-03-29 17:06:05 -04:00
marc audy
92d4e15440
Fix crash on shutdown depending on order of globals being destroyed
...
#jira
#rnx
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5494625 via CL 5494635 via CL 5494639 via CL 5497857 via CL 5497991
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5516123 by marc audy in Dev-VR branch]
2019-03-22 18:13:07 -04:00
dan oconnor
4d57a48ceb
Avoid resetting bExportLoadFailed when an object is destroyed, allows exports to stay invalidated after a GC call. Also we now invalidate exports for nodes replaced via ReplaceOldNodeWithNew
...
#rb Robert.Manuszewski
#jira UE-70904
#lockdown Cristina.Riveron
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: dan.oconnor
#ROBOMERGE-SOURCE: CL 5497598 in //UE4/Release-4.22/... via CL 5497599
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5516100 by dan oconnor in Dev-VR branch]
2019-03-22 18:12:46 -04:00
robert manuszewski
49e924db5a
Fixing crash when the engine tries to open content saved with a newer engine version
...
#jira UE-71880
#rb none
#lockdown cristina.riveron
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5496341 in //UE4/Release-4.22/... via CL 5496403
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5516098 by robert manuszewski in Dev-VR branch]
2019-03-22 18:12:42 -04:00
marc audy
83d3103481
Rework sparse delegate storage to not use uobject annotation and manage its own map and lock state. This eliminates unnnecessary annotation cache overhead and ensures entire operation on map is completed while the lock is in place rather than copying per-object map out of the annotation and then moving modified inner per-object map back in to the annotation as two separately locked actions.
...
#rnx
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5483896 via CL 5483909 via CL 5483913 via CL 5487278 via CL 5487454
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5510133 by marc audy in Dev-VR branch]
2019-03-22 17:25:12 -04:00
steve robb
fa5082908a
Fix for warnings about engine classes being hot reloaded when they haven't even changed.
...
#jira UE-71581
#rb none
[FYI] jamie.dale
#lockdown cristina.riveron
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5459196 in //UE4/Release-4.22/... via CL 5459199
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5477267 by steve robb in Dev-VR branch]
2019-03-20 13:30:59 -04:00
steve robb
c0ffefcd13
Fix to stop UClass CDOs trying to have their token streams reassembled on hot reload.
...
#rb robert.manuszewski
#jira UE-71566
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 5415461 in //UE4/Release-4.22/... via CL 5415463
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5418411 by steve robb in Dev-VR branch]
2019-03-15 13:01:45 -04:00
bob tellez
93417d94ea
#UE4 Remove redundant call to DetachFromLinkers. It was causing a crash when using EDL
...
[FYI] Robert.Manuszewski
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 5407194 via CL 5407308 via CL 5407320
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5412519 by bob tellez in Dev-VR branch]
2019-03-15 06:36:00 -04:00
robert manuszewski
af8e2aac6b
Restoring accidentally commented out code
...
#rb none
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401325 via CL 5404234 via CL 5404237
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5412326 by robert manuszewski in Dev-VR branch]
2019-03-15 06:24:53 -04:00
robert manuszewski
357c52a836
Fixing a crash when detaching linkers from serialize context
...
#rb none
#jira UE-69177
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5402557
2019-03-15 06:21:38 -04:00
robert manuszewski
eda1e889df
Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
...
#rb none
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5399372 via CL 5400965 via CL 5401943
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5412054 by robert manuszewski in Dev-VR branch]
2019-03-15 06:07:28 -04:00
robert manuszewski
10da75c078
Fixing issues with objects not being serialized before they are being ConditionallyPostLoaded by other objects and LoadContext related crashes
...
#rb none
#jira UE-69177
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 5401696 in //UE4/Release-4.22/... via CL 5401697
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5412053 by robert manuszewski in Dev-VR branch]
2019-03-15 06:07:24 -04:00
Ryan Vance
35eb0041ab
Merging //UE4/Dev-Main to Dev-VR (//UE4/Dev-VR)
...
#rb integration
[CL 5387703 by Ryan Vance in Dev-VR branch]
2019-03-13 15:19:08 -04:00
marc audy
820736a82c
A second attempt at soothing Linux build errors
...
#jira UE-71127
#rnx
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 5335697
2019-03-13 14:44:54 -04:00
