Reasons for the flush:
In Editor realtime rendering changing a material connection (or via undo/redo) changes what is rendered on the RT (specifically in FMeshDecalMeshProcessor::AddMeshBatch() Emmissive connection test)
before the Shader Map has been updated in PostEditChangeProperty() - Viewport render command enqueue has already happenned so we have a data race and we need to flush that before the material change.
#jira UE-70565
#rb mark.satterthwaite
#ROBOMERGE-OWNER: ryan.vance
#ROBOMERGE-AUTHOR: richard.wallis
#ROBOMERGE-SOURCE: CL 5418937 in //UE4/Release-4.22/... via CL 5418940
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 5421544 by richard wallis in Dev-VR branch]
Merge conflict.
jason.bestimt, please merge this change by hand.
More info at https://robomerge.epicgames.net#DEVVR
--------------------------------------
Copying //UE4/Release-Staging-4.21 to //UE4/Dev-Main (Source: //UE4/Release-4.21 [at] 4447256)
============================
MAJOR FEATURES & CHANGES
============================
Change 4447256 by Joe.Graf
Added a video settings field to the debug menu so you can see your choice
#jira: UE-65026, UE-65017
Change 4446451 by Matt.Kuhlenschmidt
Fix inline edit conditions not supporting undo
PR #4854: UE-61432: Add FScopedTransaction to SetEditConditionState (Contributed by projectgheist)
#jira UE-61432
Change 4446389 by Mieszko.Zielinski
Fixed navmesh tiles AABB being calculated wrong for large agents #UE4
#jira UE-65038
Change 4446171 by Matt.Kuhlenschmidt
Fix crash resetting cascade distributions to default
#jira UE-64458
Change 4446143 by Uriel.Doyon
Re-worked fix from CL 4442729 to handle !SUPPORTS_INDEPENDENT_SAMPLERS
#jira UE-64695
Change 4446071 by Jeff.Fisher
Duplicating for 4.21 Change: 4446057 UE-64942 Material Switching in MRMesh
-Fixed run time material switching on MRMesh
#jira UE-64942
Files:
//UE4/Dev-VR/Engine/Source/Runtime/MRMesh/Private/MRMeshComponent.cpp#24
//UE4/Dev-VR/Engine/Source/Runtime/MRMesh/Public/MRMeshComponent.h#16
Change 4445939 by Joe.Conley
#jira UE-54503 - Transparency for textures applied to the spectator screen for VR
Added a flag bUseAlpha that is checked in FDefaultSpectatorScreenController::RenderSpectatorModeMirrorAndTexture(), if (SpectatorScreenModeTexturePlusEyeLayout_RenderThread.bDrawEyeFirst). It can be set with the SetSpectatorScreenModeTexturePlusEyeLayout Blueprint node.
Change 4445917 by Matt.Kuhlenschmidt
Guarad against crash when destroying asset view items
#jira UE-61108
Change 4445911 by Matt.Kuhlenschmidt
Guard against null objects in asset editors
#jira UE-64499
Change 4445574 by Wyeth.Johnson
Kill volume cleanup, helper function for cone, edge case on pendulum
#jira none
Change 4445472 by Matt.Collins
UE-64680
The new depth bounds optimization in PostAO doesn't work with MSAA. The AO target and depth buffer are different sample counts. Forcing this feature off for now.
In the future if we want to turn it back on we will either have to resolve the depth buffer or increase the AO target sample count.
#jira UE-64680
Change 4444917 by Bogdan.Vasilache
UE-63963 - Fix FSystemTextures.InitializeTextures initialization ordering
#jira UE-63963
Change 4444779 by andrew.porter
QAGane: Updating focus so we can select UMG test button in TM-PlaybackControls
#jira UE-29618
Change 4444678 by Richard.Wallis
Clone of Dev-Rendering CL 4444343:
Fix for eyedropper in the Color Picker window not grabbing any color values on Mac. Bug also says Linux - unable to verify if its the same issue so kept change to Mac specific code.
#jira UE-53789
Change 4444677 by Lauren.Ridge
Context menu opening cancels a rename
#jira UE-64525
Change 4444321 by Michael.Dupuis
#jira none: uncomment the lazy obj ptr warning as the integration is completed
Change 4444288 by Simon.Tourangeau
BP_SunPosition now has a soft ref to BP_SkySphere to prevent cross level referencing
#jira UE-64607
Change 4444287 by JeanMichel.Dignard
Copied 4442004 Daniel.Coelho
Fix for being unable to trigger on variants from UMG blueprints
#jira UE-64948
Change 4444105 by Mitchell.Wilson
Saving assets to resolve UMeshDescription warnings
#jira UE-64022
Change 4444080 by Ben.Marsh
Fix path to Win64 DLLs when building DDC on Linux.
#jira
Change 4444036 by Patrick.Boutot
Fix crash when there are too many pending task in ImageWriteQueue.
#jira UE-64991
Change 4443920 by Ben.Marsh
Fix runtime dependencies not being enumerated for modules that aren't linked into a binary.
#jira UE-65024
Change 4443889 by Ben.Marsh
Copy Windows DDCUtils DLLs when building DDC for Linux on the Win64 host platform.
#jira UE-64975
Change 4443882 by Ben.Marsh
Fix CIS compile error in UE4Game HTML5.
#jira
Change 4443531 by Nick.Shin
#jira UE-65015 HTML5: Project Crashes During Launching Engine due to "Texture format 'R8G8B8A8_UINT' not supported"
this solution was based on: UE-48208
Change 4443358 by Joe.Graf
Changed the world mapping state conversion in ARKit to return NotAvailable, Mapping, Mapped
#jira: UE-65023
Change 4443217 by Dan.Oconnor
Fixed crash after hitting stop when in-stack-debugging
Clear GPlayInEditorID when stopping PIE at a blueprint exception/breakpoint
#jira UE-64895, UE-65005, UE-65008
Change 4443200 by Max.Chen
Sequencer: Now accouting for frame rate when copying key tangents when converting from matinee to level sequence.
#jira UE-65020
Change 4443062 by Dan.Oconnor
Fixed crash when undoing after deleting a function graph that has a math expression node
#jira UE-62134
Change 4442903 by Lauren.Ridge
Allowing material graph nodes to have duplicate names in all cases except creating a new parameter from a constant
#jira UE-64421
Change 4442878 by Joe.Graf
Disabled the clion ignore file generation on Windows since it isn't supported correctly there
#jira: UE-64871
Change 4442840 by Max.Chen
Control Rig: Fix crash tearing down sequencer object spawner
#jira UE-65013
Change 4442810 by Ethan.Geller
Fix build for SoundVisualizations plugin: add const qualifiers for WaveInfo. #jira none #rb none #fyi aaron.mcleran
Change 4442769 by Brandon.Schaefer
Linux: Use the size of our In Rect which is the size of our buffer rather then the size of the Texture which is not always the same size as the buffer
#jira UE-64785
[at]Rolando.Caloca, [at]Arciel.Rekman
Change 4442758 by Dan.Oconnor
"Assign [Delegate Name]" blueprint context menu entries now properly create a custom event node again
#jira UE-65000
Change 4442729 by Uriel.Doyon
Changed GetForwardDynamicShadowFactors implementation to use Texture2DSampleLevel instead of Load.
This is because we sometime bind the GWhiteDummy when the light attenuation buffer is not required, which is a 1x1 texture.
#jira UE-64695
Change 4442724 by Max.Chen
Sequencer: Added back in ScrubHandleUp/Down for the VisualLoggerTimeSliderController to fix missing brush warning
#jira UE-64994
Change 4442519 by Marc.Audy
Avoid broadcasting events that could result in invalidating the array we're iterating.
#jira UE-64959
Change 4442460 by JeanMichel.Dignard
Fixed crash with VRED importer
- DataTable wasn't counting its changes properly resulting in a failed check.
#jira UE-64982
Change 4442216 by Ethan.Geller
Unshelved from pending changelist '4438353':
Ensure const correctness in USoundWave cook processing.
Change 4442191 by Mitchell.Wilson
Updating min ios version to resolve warnings.
#jira UE-64815
Change 4442124 by Arciel.Rekman
Another fix for lock up on starting without audio devices (UE-64506).
#jira UE-64506
Change 4442006 by Ben.Marsh
Fix debug info being included for Lumin binaries on Mac.
#jira UE-65002
Change 4441939 by Ben.Marsh
Fix inability to package Mac targets from Windows.
#jira UE-64148
Change 4441374 by tim.gautier
QAGame: Resaved Niagara assets.
Rebuilt lighting / resaved TM-ShaderModels
#jira UE-29618
Change 4441369 by Rolando.Caloca
UE4.21 - hlslcc - Fix UAV getting removed
#jira
Change 4441347 by Michael.Dupuis
#jira UE-63631: LOD Distribution settings, must be > 1.01 as otherwise 1/1 will not give correct result.
Change 4441132 by Dan.Oconnor
Remove unused dtor
#jira None
Change 4441108 by Dan.Oconnor
Fix leaking entries for PLACEHOLDER classes in the new ClassToPlaceholderMap
#jira UE-64971
Change 4441096 by tim.gautier
Adding the VRMode_Ball asset for VRMode testing.
#jira UE-29618
Change 4441093 by Ryan.Gerleve
Fix the writer's size issue in the auth handler when requesting resends. This fixes packet over/underflows. Also make it so that dropall drops all of auth's packets as well.
#Jira UE-63796, UE-64156
#AUTOMERGE using branch //UE4/Dev-Networking_to_//UE4/Release-4.21 of change#4374419 by Jake.Leonard on 2018/09/18 15:41:48.
Change 4441065 by Ryan.Gerleve
Fix using SetIp(uint) on an IPv6 only platform so that both cases are handled properly. Should contain the same flow as the IPv6 framework.
#Jira UE-64129
#AUTOMERGE using branch //UE4/Dev-Networking_to_//UE4/Release-4.21 of change#4374299 by Jake.Leonard on 2018/09/18 15:23:37.
Change 4441052 by Ben.Zeigler
#jira UE-64446 Fix crash on cooked devices when using GameplayCues but not explicitly setting a manager
It is unsafe to reference dynamic objects from a CDO so spawn an instance of the default class
Change 4441042 by Ryan.Gerleve
Remove the bForceUDP from the new CreateSocket signature. This is an argument that came in from UE3 and is not supported. It should not continue to exist anymore.
#Jira: UE-63879
#AUTOMERGE using branch //UE4/Dev-Networking_to_//UE4/Release-4.21 of change#4356623 by Jake.Leonard on 2018/09/10 20:35:09.
Change 4441005 by Ben.Zeigler
#jira UE-64446 Call InitGlobalData from ActionRPG sample and set up path for cue notifies. All projects using abilities should do this
Change 4440944 by Ryan.Gerleve
Because addrconfig is not supported on HTML5. This is not documented anywhere, so any query with the flag will just be removed from any queries.
#Jira UE-63791
#AUTOMERGE using branch //UE4/Dev-Networking_to_//UE4/Release-4.21 of change#4356538 by Jake.Leonard on 2018/09/10 19:35:29.
Change 4440912 by Ryan.Gerleve
Skip lobbies we are already a part of when generating matchmaking results. This allows us to not try to fetch data on ourselves.
#Jira UE-63543
#AUTOMERGE using branch //UE4/Dev-Networking_to_//UE4/Release-4.21 of change#4356532 by Jake.Leonard on 2018/09/10 19:34:39.
Change 4440861 by Ben.Zeigler
#jira UE-61890 Fix XGE shader compilation on newer incredibuilds by checking registry for path
Change 4440850 by Michael.Dupuis
#jira UE-62426: Reset InstanceCountToRender if the static mesh is valid or we have no instances
Change 4440514 by Ben.Marsh
Add additional info to comment around optimization being disabled due to codegen bug.
#jira
Change 4440501 by Ben.Zeigler
#jira UE-64971 Fix resolving export tracker to clean itself up after resolving. This fixes the immediate crash, but there may be another way it can end up crashing so this needs further investigation as the structure is unsafe
Change 4440479 by Rex.Hill
Fix debug hud not rendering when swapping between PIE/SIE modes
#jira UE-64704
Change 4440447 by Joe.Graf
Rename/move AR samples
#jira: UE-64944
Change 4440338 by Joe.Graf
Cleaned up leftover files from the bad 4.20->Dev-VR merge
#jira: UE-64957
Change 4440318 by Joe.Graf
Fixed the bad asset merge that happened from 4.20 back to Dev-VR
#jira: UE-64957
Change 4440237 by Ben.Zeigler
#jira UE-64960 Disable validating data dialog when saving, and ony show if > 0.1 seconds
Change 4440157 by Mieszko.Zielinski
Fixed a bug in how UNavModifierComponent handles FKConvexElems #UE4
#jira UE-60987
Change 4440017 by Mitchell.Wilson
Saving SunlightColorLUT in KiteDemo to resolve warnings.
#jira UE-64744
Change 4439856 by Jurre.deBaare
Crash when trying to "Update Mesh Section" on any procedural mesh just after "Clear Mesh Section" and "Create Mesh Section" for different vertices and triangles.
#fix Ensure that we recreate the scene proxy whener a mesh section is updated with a larger amount of vertices than original, this will reinit the vertex buffers to the correct sizes
#jira UE-60607
Change 4439831 by Ben.Marsh
Fix ClangEditor CIS warning.
Change MSVC_PRAGMA to not be defined when compiling using Clang on Windows. Also add a link to bad codegen report on Microsoft's developer forum for an instance of optimization being disabled.
#jira
Change 4439828 by mason.seay
Added variable to blueprint
#jira UE-29618
Change 4439763 by Jurre.deBaare
#jira UE-62048
PR #4892: HLOD System: Fix crash when static mesh has no valid material (Contributed by user37337)
#fix slightly modifier fix
Change 4439731 by Joe.Graf
Rename/move AR samples
#jira: UE-64944
Change 4439715 by Cosmin.Sulea
UE-64937 - IphonePackager cannot verify UDID on new devices (XS or newer)
#jira UE-64937
Change 4439697 by Wyeth.Johnson
Metadata errors and fixes
#jira none
Change 4439658 by Michael.Dupuis
#jira UE-63831: Added some guard to prevent the crash
Change 4439605 by Michael.Dupuis
#jira UE-53944: Added some asserto help track what could be happening in this case
Change 4439516 by Ben.Marsh
UBT: Set the permissions on directories containing scripts to be executed as part of remote builds.
#jira UE-64860
Change 4439395 by Michael.Dupuis
#jira UE-63637: When doing migration from 4.18, if the data was in a BP, use a Reset instead of a Reserve, as otherwise we will end up with twice the amounf of instances.
Change 4439197 by Michael.Dupuis
#jira UE-63242
#jira UE-63123:
Integrate from Dev-Editor branch
Change 4439162 by Mieszko.Zielinski
Made sure NavigationSystemConfig respects GEngine->NavigationSystemClassName #UE4
#jira UE-62991
Change 4439106 by Cosmin.Sulea
UE-64603 - Android Devices do not show up in device list for Device Output Log
#jira UE-64603
Change 4438283 by Ben.Zeigler
#jira UE-63825 Integrate pull request:
PR #5073: Implement LoadGameFromMemory function. (Contributed by KelbyG)
Change 4438242 by Ben.Zeigler
Test case for #jira UE-63705. To verify, open WeakReferencedPrimaryAsset and note that the UntrackedMeshPtr is set to AT_StaticMesh.
Then, right click and show references, that mesh should NOT show up, as it is marked as Untracked via metadata
Change 4438238 by Ben.Zeigler
#jira UE-63843 Temporary fix for Visual Studio 2017 compile bug causing crashes in Audio Mixer code
Change 4438237 by Ben.Zeigler
#jira UE-64770 Fix bug where AssetManager could fail to call delegates in sync load mode
Change 4438236 by Ben.Zeigler
#jira UE-64466 Fix issues with debug builds with ENABLE_NAN_DIAGNOSTIC and TransformNonVectorized, it's not safe to use the FVector constructor as it will always ensure. Also unified checks with the vectorized version to be consistent
Change 4438234 by Ben.Zeigler
#jira UE-63705 Add full support for Untracked soft object references, enable by adding that tag to the metadata for a property or using FSoftObjectPathSerializationScope with NeverCollect
If set the references will not be automatically cooked, reported to the asset registry, or cause warnings when deleting a referenced actor
They are meant to be used for cases where they are just used as a lazy cache, such as things converted from FLazyObjectPtr
The reference from Foliage to it's base actor is now an Untracked SoftObjectPtr instead of a LazyPtr
Change 4437969 by Michael.Lentine
Fix gpu skin cache with multiple cloth sections.
#jira ue-62951
Change 4437907 by Joe.Graf
Rename/move AR samples
#jira: UE-64944
Change 4437901 by Mikey.Boyd
Resaved QA-Promotion and TM-ShaderModels to clear up warnings for Linear Color Curves in UE-64949.
#jira UE-29618
Change 4437877 by Dan.Oconnor
Guard against double-queuing in Macro BP gather phase
#jira None
Change 4437615 by Sorin.Gradinaru
UE-64624 App fails to open when packaged for Distribution - Android
#jira UE-64624
#Android
#4.21
As Chris.Babcock mentioned, this is caused by an app pause event triggered when the obb downloader starts and puts the activity in background. Adding a flag to ignore the first app pause in this situation.
Change 4437541 by Andrew.Porter
QAGame: Updating location of an animation so it can be visiblty in the sequence
#jira UE-29618
Change 4437078 by Mitchell.Wilson
Updating lerp tooltip based on updates by Sam Deiter.
#jira UEDOC-8219
Change 4436943 by Bogdan.Vasilache
UE-61698 - Android + Mouse: Hover events and Get Mouse Position on Viewport not working
#jira UE-61698
Change 4436915 by Dan.Oconnor
Remove debugging hook accidentally added in 4235135
#jira None
Change 4436204 by Joe.Graf
Switched the AREnvProbe sample to Metal 2.1 to fix the z-fighting that happens in 2.0 and below
#jira: UE-64932
Change 4435856 by Arciel.Rekman
Fix CIS (UE-64925).
#jira UE-64925
Change 4435811 by Mark.Satterthwaite
Sort out the way we report R11G11B10 support for Metal so that it should work correctly on iOS & tvOS.
#jira UE-64905
Change 4435783 by Brandon.Schaefer
libvpx: Rebuild on centos7
#jira UE-64887
Change 4435710 by Thomas.Sarkanen
Fixed crash drag-dropping a variable onto a state machine
#jira UE-64539 - [CrashReport] UE4Editor-CoreUObject.dylib!CastLogError()
Change 4435694 by Andrew.Grant
Removed some stale Orion tests
#jira UE-64857
Change 4435662 by Ben.Marsh
Rework the way that custom icons are used on Windows.
* For code projects, the custom icon is embedded into the resource when compiled from UBT. This ensures the custom icon is set even before packaging, and removes the need for a deployment step.
* For content projects, the custom icon is set after packaging using the previous method.
#jira UE-64527
Change 4435599 by Michael.Lentine
Avoid crash with null materials
#jira ue-64819
Change 4435596 by Michael.Lentine
Account for the case where skeletal mesh doesn't exsit in the component body setup.
#jira ue-63104
Change 4435563 by Brandon.Schaefer
SDL2: Fix pointer barriers on resize/move and multimonitor
Part of this change is from PR 5041 (thanks yaakuro)
#jira UE-60461, UE-63372
Change 4435557 by Michael.Lentine
Allow for non uniform scaling in some of the capsule functions.
#jira ue-59651
Change 4435518 by Mitchell.Wilson
Saving two assets to resolve empty engine version warnings in RemoteSessionApp
#jira UE-64747
Change 4435416 by Robert.Manuszewski
Fixing a Cook On The Fly server crash when an asset that has been requested by the client is missing from the server
#jira UE-64616
Change 4434780 by Uriel.Doyon
Fixed Niagara proxy rendering in ES2 while the shaders are not available.
#jira UE-64666
Change 4434758 by Joe.Graf
Fixed the use of deprecated NSKeyedArchiver and NSKeyedUnarchiver methods
#jira: UE-64913
Change 4434757 by Joe.Graf
Removed invalid plugins that were specified for the AR samples
#jira: UE-64914
Change 4434497 by Joe.Graf
Fixed incomplete merge of ARSharedWorld sample
#jira: UE-64673
Change 4434281 by Joe.Conley
#jira UE-63793 - ARKit Crash with Session Type: Image
Removing error logging since it's also getting logged higher up in the callstack.
Change 4434250 by Joe.Conley
#jira UE-63793 - ARKit Crash with Session Type: Image
Instead of an assert (and thus crash) if Session Configuration is null (which happens if device/os doesn't support ARKit 2.0), just print out an error to the log and keep running.
Change 4434173 by Aaron.McLeran
Fix for audio device shutdown
-- Actually, need to make sure the flush code doesn't execute on platforms without threads. This will still fail on HTML5
#jira UE-64619
Change 4434112 by Aaron.McLeran
Bug fix pausability
- Pausing sound while stopping can cause a crash when updating the sound
#jira none
Change 4433986 by Michael.Lentine
Avoid dereferencing null.
#jira ue-63593
Change 4433954 by Michael.Lentine
Use correct enable flag.
#jira ue-64801
Change 4433867 by Uriel.Doyon
Fixed integration issue from Niagara with "Collision Query" module
#jira UE-64906
Change 4433779 by Dan.Oconnor
Mirror 4379405 from Dev-Framework
Add flags to track bMarkedObjectsPendingKill and bCleanedUpWorld to ensure that sublevels are cleaned up properly
#jira UE-64227
Change 4433771 by Dan.Oconnor
Mirror 4365800 from Dev-Framework
Avoid marking a blueprint as modified when the compiler renames a graph
#jira UE-63942
Change 4433763 by Dan.Oconnor
Mirror 4363197 from Dev-Framework
Perform a placeholder resolve pass immediately after the CDO has been serialized
#jira UE-62928
Change 4433716 by Chris.Bunner
#author Bogdan.Vasilache
Comitting shelf 4433043 for UE-64237.
#jira UE-64237
Change 4433609 by Uriel.Doyon
Fixed how UNiagaraDataInterfaceCurlNoise release its render resource by adding a release command in BeginDestroy.
#jira UE-64898
Change 4433524 by zak.parrish
Final functionality for AR SaveLoad now in place. Just needs cleanup/commenting and About screen
#JIRA UE-64681
Change 4433512 by Christina.TempelaarL
Mirror 4373989 from Dev-Editor.
Cascade: Copy particle emitter properties when invoking Duplicate Emitter or Export Emitter in the Cascade editor.
#jira UE-63856
Change 4433328 by Chris.Babcock
Fix ConfigRules.jar parsing for Linux line endings
#jira UE-64892
#ue4
#android
Change 4433279 by Zachary.Wilson
Switching DoF methods for PostProcess volumes in QA_PostProcessing and TM_Showflags_LightingFeatures.
#jira UE-64659
Change 4433092 by Dan.Oconnor
Fix missing include
#jira None
Change 4433046 by Michael.Lentine
Renamed command to relfect actual behavior.
#jira ue-55368
Change 4433024 by Ben.Marsh
PR #5154: Prevent crunch_x64.exe from showing in Git commit changes (Contributed by projectgheist)
#jira
Change 4432990 by Wyeth.Johnson
Fixing issues related to particle mass and gravity
#jira none
Change 4432979 by Uriel.Doyon
Fixed DOF when enabling Pre-Exposure
Added units to the intensity property of point, spot, rect, directional and sky lights.
Refactored the VisualizeHDR so that it shows the HDR view is a PIP on top of the main render.
Fixed PixelInspector results being affected by pre-exposure.
Added a pre-exposure output value to the PixelInspector.
Moved ExposureCompensation to the Exposure tab in post-process settings.
Changed max slider intensity for directional light to be in 120 000 lux
Changed max slider intensity for sky light to be in 50 000 cd/m2
Non bUseInverseSquaredFalloff point lights now have their units forced to ELightUnits::Unitless
Moved light units to advanced display, now that the unit is embeded in the Intensity property
Added Candela, Lux and CandelaPerMeterSquared units to the engine units
Fixed meta data properties to support the "Units" keyword.
#jira UE-64881
Change 4432953 by Chris.Gagnon
CL 4356067 copied to Release-4.21
#jira UE-63861
Change 4432934 by Chris.Gagnon
CL 4399650 copied to Release-4.21
#jira UE-64070
Change 4432913 by Dan.Oconnor
Mirror 4363175 from Dev-Framework
Reuse subobjects during archetype reinstancing path
#jira UE-59135
Change 4432901 by Michael.Lentine
Adding missing counter.
#jira ue-59969
Change 4432895 by Dan.Oconnor
Mirror 4344890 from Dev-Framework
Make FObjectFinder visibile to reference collectors and properly replace subobjects on the CDO. This fixes instability after reloading the FirstPersonCharacter blueprint
#jira UE-54419, UE-63061
Change 4432805 by Uriel.Doyon
Fixed error when compiling some Niagara GPU particles
#jira UE-64885
Change 4432789 by Michael.Lentine
Fix comments.
#jira 58064
Change 4432766 by Ben.Marsh
Fix issues with mismatched solution/project configurations.
* Every C++ project now has an "invalid" configuration. Trying to build any solution configuration which does not apply to the project will now build that, which prints an error rather than building a completely different configuration.
* Available configurations are now parsed from C# files, so the "Release" configuration will now be used if "Development" is not available, and platforms are supported correctly.
* Programs are now built in game and editor configurations.
#jira UE-59288
Change 4432649 by Michael.Lentine
Resize Temp instead of Out.
#jira ue-62919
Change 4432540 by Chris.Bunner
[Duplicating 4432262] - HLOD visibility state is now cleared when not in use.
#jira UE-64432
Change 4431926 by Chad.Garyet
Integrating changes from dev-build over to release-4.21
- Add win64 host support to DDC Group Linux
- Change project params split to remove empty entries
- Change BuildDerivedDataCache to skip building a feature pack if there are no project specific platforms for it out of the available targetplatforms
#jira UE-62311
Change 4431602 by Simon.Therriault
Merging MediaBundle fix
#jira UE-64853
Change 4431481 by Brandon.Schaefer
Linux: Break grabs and bring down pointer barreirs when we have crashed
#jira UE-63981
[at]Arciel.Rekman
Change 4431456 by Jules.Blok
Merging CL 4428447 from Dev-VR - Update the WMR plugin for Dev-Rendering changes.
#jira UE-64507
Change 4431310 by Robert.Manuszewski
Fixed a crash when setting the initial size of the disregard for Garbage Collection pool to a value greater than 66560.
#jira UE-64844
Change 4431307 by Sorin.Gradinaru
UE-64749 App crashes on device when a Widget Blueprint in use contains a Web Browser widget
#jira UE-64749
#Android
#iOS
#4.21
Moving SharedThis(this) out of the WB Window's constructor
Change 4431161 by Robert.Manuszewski
Fixing CIS
#jira none
Change 4431153 by Sorin.Gradinaru
UE-63263 Startup movies are not playing on tvOS
#jira UE-63263
#4.21
#tvOS
Startup movies need AppleMoviePlayer.uplugin, which was never enabled for tvOS.
Same behavior as an iPhone/iPad, slightly stuttering at first run, plays fine afterwards
Change 4430958 by Matt.Collins
Returns the default context from GetCurrentContext if none is set. Fixes crash in UE-64369. This is probably not 100% correct - we should fix all the cases where GetCurrentContext is called and a context is not set.
#jira UE-64369
Change 4430862 by Matt.Collins
Turning GPU Command Buffer timing back on. Enables correct profiling.
#jira UE-64841
Change 4430813 by Marcin.Undak
Linux: fixed editor launch with no audio device
#jira UE-64506
Change 4430783 by Ben.Marsh
Include Mac build files on Windows (eg. shell scripts, mono) to support remote compilation.
#jira UE-64684
Change 4430761 by Ben.Marsh
Fix issues with running DsymExporter remotely from a PC, and reorder engine filters to reduce the amount of junk which has to be re-transferred every time.
#jira UE-63883
Change 4430445 by Chris.Gagnon
Copy of CL 4416373
Extend GCompilingBlueprint lifetime to include BroadcastBlueprintReinstanced when compiling synchronously
#jira None
Change 4430103 by Ben.Marsh
Make sure Newtonsoft is included in the installed engine build. (Also ignore *.build.cs that aren't enumerated from the targets we build; they won't be usable)
#jira UE-64777
Change 4430050 by Ben.Marsh
PR #5151: Fix BuildPlugin automation command to include Shaders folder (Contributed by pluranium)
#jira UE-64781
Change 4430037 by Ben.Marsh
UBT: Fix generating and checking for UHT manifest in the wrong location. If a target does not have a script plugin, the manifest should not be stored in the project binaries directory.
#jira
Change 4430035 by Alexis.Matte
Port a fix from cl: 4366690
Fix the material ID when creating generating reduce LODs from a mesh where the materials was re-order to the FBX order.
#jira UE-64028
Change 4429730 by Ryan.Vance
#jira UEVR-1322
Instead of tearing down and spinning up the render thread / rhi thread pipeline on pause, simply disable and enable rendering.
This leaves the rendering infrastructure intact, but with no work to do.
Change 4429709 by Ryan.Vance
#jira UE-64289
Distortion correct mesh generation needs to happen on the render thread.
Change 4429690 by Ryan.Vance
#jira UE-63538
From 4.20.3 hotfix: 4333358
Test render target texture size if available to ensure we don't do an extra upscale when not needed.
The render target size is not updated when the backing render target texture is reallocated.
Change 4429671 by Ryan.Vance
#jira UE-63333
Lumin needs task threads to avoid saturating a single core. Reverting to previous task thread behavior for lumin.
Change 4429489 by Mitchell.Wilson
Saving curve assets to resolve warnings.
#jira UE-64744
Change 4429160 by Wyeth.Johnson
First pass at integrating mass as a first class citizen. This includes solver changes, a new gravity force, and updates to a number of other force modules and templates
#jira none
Change 4429064 by Mitchell.Wilson
Updating default iOS version to 10 in samples and templates
#jira UE-64815
Change 4428944 by Michael.Trepka
Fixed issues with cursor locking on window activation on Mac
#jira UE-13768
Change 4428879 by Ben.Marsh
Fix error generating dsyms on Mac through the remote toolchain.
#jira UE-63883
Change 4428729 by Ben.Marsh
Fix warning about missing expat libs when generating projects from installed build on Mac.
#jira UE-64740
Change 4428710 by Dan.Oconnor
When recompiling a blueprint macro library we now do a full compile of all dependent blueprints
#jira UE-63284
Change 4428331 by frankie.dipietro
Update TM-FocusPriority to utilize a looping Music file
#jira UE-29618
Change 4428295 by Rex.Hill
Fixed debug hud not drawing during simulate in editor
#jira UE-64704
Change 4428255 by Zachary.Wilson
Removing Bokeh and Gaussian DoF tests that were displaying a warning
#jira UE-64659
Change 4428236 by Andrew.Rodham
Sequencer: Fixed edge case where equvalent range bounds were not considered equal
#jira UE-64742
Change 4428210 by zak.parrish
#JIRA UE-64681
Getting proper save reporting in place on AR Save Load
Change 4428146 by Ben.Marsh
Fix CIS error.
#jira
Change 4428046 by Chris.Babcock
Fix bad merge
#jira UE-64784
#ue4
#android
Change 4427865 by Ben.Marsh
Add missing include causing CIS error.
#jira
Change 4427846 by Ben.Marsh
When we detect a hang and send an ensure crash report, include the callstack of the thread that hung.
#jira UE-63982
Change 4427716 by Peter.Sauerbrei
deprecate IOS 9
#jira UE-64018
Change 4427575 by Cody.Albert
Fixed ShooterGame best score logic
#jira UE-64514
Change 4427537 by Frank.Fella
Niagara - Disable the houdini plugin in engine test since we're not actively testing it and it's causing lots of cooking problems.
#jira UE-64736
Change 4427273 by Stefan.Boberg
PR #5123: Small typo in Engine.h (Contributed by Vatyx)
#jira UE-64496
Change 4427126 by Simon.Tovey
Merging from Dev-Niagara 4427076
Fix for static analysis warnings.
#jira UE-64717
Change 4427014 by Simon.Therriault
Fix for MediaFrameworkUtilities plugin
#jira UE-64774
Change 4426983 by Ben.Marsh
Remove natvis file from UE4 project.
#jira
Change 4426920 by Sorin.Gradinaru
Unshelved from pending changelist '4398174':
UE-54804 Graphical stuttering for weapon model on Lenovo S939 in First Person Template Project
#jira UE-54804
#Android
#4.21
The bug was generated by CL3840215 - the fix for UE-53592: Assertion right after rendering scene on Lenovo S939. I've retested UE-53592 on my side and it's OK.
Also, when building a sample (eg. First Person) on //Dev-Main, the game crashed at start with:
D/UE4 (22619): Assertion failed: glProgramParameteri [File:C:/Work/UE4_Main/Engine/Source/Runtime/OpenGLDrv/Private\Android/AndroidOpenGL.h] [Line: 479]
Change 4426571 by Ben.Marsh
Fix UAT compile error.
#jira
Change 4426569 by Ben.Marsh
UnrealVS: Fix single-file compile not working for foreign projects where the engine folder contains a space.
#jira UE-64752
Change 4426529 by Ben.Marsh
Various fixes/improvements to program plugins.
* Runtime plugins are no longer loaded for every program (as was the case in 4.20)
* If a module is whitelisted for a specific program, it will be enabled regardless of whether the Type is "Program" or not.
* The bCanBeUsedWithUnrealHeaderTool flag in the plugin descriptor is now translated into support for the "UnrealHeaderTool" program on load.
* Restored support for the RuntimeAndProgram module type.
* Plugins are now enabled in UHT by passing the project on the command line, rather than passing explicit plugins to enable.
#jira UE-64247, UE-64595
Change 4426481 by Jeff.Fisher
UE-64597 //UE4/Release-4.21 - Build DDC Win64 - BP_DebugMenu has been saved with empty engine version
-resaved
#jira UE-64597
Change 4426400 by Ben.Marsh
Fix extra blank line at the end of ManagedProcess output.
#jira UE-64780
Change 4426398 by Arciel.Rekman
Linux: fix ARM server build (UE-64775).
#jira UE-64775
Change 4426126 by Dan.Oconnor
Harden EdGraphPin serialization
#jira UE-64500
Change 4426071 by Dan.Oconnor
Added logging to Blueprint merge operation
#jira UE-58891
Change 4426061 by Phillip.Kavan
Fix for an EDL runtime assertion on load when constructing the CDO for a nativized Blueprint class that contains an instanced object reference of another nativized Blueprint class type that references an instance of a non-nativized Blueprint class as a nested, class-owned subobject.
- Mirrored from //UE4/Dev-Framework (4413311).
#jira UE-62514
Change 4426031 by Phillip.Kavan
Fix potential data loss in inherited SCS component default value overrides at runtime in a cooked build for an instance of a non-nativized child Blueprint class that inherits from a nativized parent Blueprint class.
- Mirrored from //UE4/Dev-Framework (4365827).
#jira UE-63757
Change 4425975 by Phillip.Kavan
Fix potential CDO validation failures at cook time during the C++ code generation pass when Blueprint nativization is enabled.
- Mirrored from 4371073.
#jira UE-63647
Change 4425952 by Chris.Babcock
Add notification channel for Android 26 compatibility
#jira UE-62741
#ue4
#android
Change 4425916 by Dan.Oconnor
Added logging to package reloading
#jira UE-63834
Change 4425857 by Rolando.Caloca
UE4.21 - FIx crash on html5
#jira UE-64690
Change 4425808 by Jeff.Fisher
Merging using Dev-VR_to_Release-4.21 Change: 4425273 UEVR-1333 MRMesh normals problems
-Normals should not be world scaled.
#jira UEVR-1333
Files:
//UE4/Dev-VR/Engine/Plugins/Lumin/MagicLeap/Source/MagicLeap/Private/MeshTrackerComponent.cpp#13
Change 4425722 by Rolando.Caloca
UE4.21 - Android compile fix
#jira
Change 4425408 by Phillip.Kavan
Fix UBT warnings when building/packaging with Blueprint nativization enabled.
- Mirrored from //UE4/Dev-Framework (4352144).
#jira UE-62946, UE-63311
Change 4425238 by frankie.dipietro
Update TM-FocusPriority so that tests may utilize 8 audio channels
#jira UE-29618
Change 4425232 by Jamie.Dale
Fixed crash when re-pointing an object referenced in Python
#jira UE-64363
Change 4425194 by Phillip.Kavan
Support a proper fallback to construct any native 'noexport' struct-typed literal term in a nativized Blueprint class.
- Mirrored from //UE4/Dev-Framework (4347635).
#jira UE-63364
Change 4424786 by Brian.Zaugg
Add support for new iOS UserNotifications framework, enabled if min iOS version is set >= 10.
#jira UE-51041, UE-59178
Change 4424584 by Ben.Marsh
Include the Visual Studio .natvis file as a solution item, to fix problems with VS2017 15.8.5 not finding it in a makefile project.
#jira UE-64733
Change 4424410 by Max.Chen
Sequencer: Fix deprecation
#jira UE-48190
Change 4424364 by Frank.Fella
Niagara - Fix static analysis for SItemSelector.h - Preflight passed.
#jira UE-64719
Change 4424291 by Shaun.Kime
Volume texture work should not be pulled over from Dev-Niagara yet
#jira UE-64756
Change 4424021 by Jason.Bestimt
Merging CL 4401151 from Dev-VR - Adding destructor to SoundPresets
#JIRA:none
Change 4423955 by Brandon.Schaefer
Linux: Add a timer when we lose focus to check if we have lost application focus
#jira UE-63931
Change 4422974 by Robert.Manuszewski
Fixing CIS
#jira UE-64741
Change 4422709 by Jason.Bestimt
Merging CL# 4419752 from Dev-VR - Fixes to prevent audio from crashing on exit
#JIRA: none
Change 4422691 by Jamie.Dale
Fixing localization warnings
Added support for gathering from the newly added UI_COMMAND_EXT macro
#jira
Change 4422394 by Sorin.Gradinaru
UE-64066 TM-Gameplay Load Game does not work on TVOS
#jira UE-64066 TM-Gameplay Load Game does not work on TVOS
#tvOS
#4.21
Blocker: GRHIHDRDisplayOutputFormat must have a default value for tvOS (PF_B8G8R8A8, just like mac or ios for non-hdr). The issue appeared at CL4092793 [at] //UE4/Dev-Rendering, 5/24/2018
Change 4422285 by Jamie.Dale
Fixing localization warnings
#jira
Change 4421911 by Chris.Babcock
Fix issues with LLDB data formatters with 2 byte characters
#jira UE-64737
#ue4
Change 4421833 by Wyeth.Johnson
#jira 64735
Sample Skel Mesh refactor to fix it not initializing, still bugged for vertex colors
Change 4421316 by Jamie.Dale
Fixing localization warnings
#jira
Change 4421223 by Ben.Marsh
Add an experimental setting to enable support for long paths in the content browser.
#jira
Change 4421197 by Jamie.Dale
Fixing localization warnings
#jira
Change 4421191 by Jamie.Dale
Fixing localization warnings
#jira
Change 4421179 by Rolando.Caloca
UE4.21 - Vulkan - Add missing viewport resize function
- Separate num buffers per usage
#jira
Change 4420955 by Michael.Trepka
Ignore tooltips and cursor decorator windows when determining the window under cursor on Mac
#jira UE-64645
Change 4420323 by Robert.Manuszewski
Reimplementing CL #4402016 from Dev-Core:
Fixed cooked materials not working in the editor
#jira UE-64389
Change 4420227 by Rex.Hill
Fix USD Linux compiler warning
#jira UE-63658
Change 4420198 by Ben.Marsh
UBT: Detect changes to source directories and invalidate the makefile if they are newer. Forces the makefile to be rebuilt when files are added or removed.
#jira UE-42601
Change 4420194 by Mitchell.Wilson
Saving color curve assets to resolve warnings.
#jira UE-64724
Change 4419740 by Jamie.Dale
Don't force LocRes files to always use Unicode strings
The automatic Unicode detection works just fine for them, and changing this can produce considerably smaller (up-to 50% smaller!) LocRes files
#jira
Change 4419728 by Mikey.Boyd
Updating TM-MaterialAttributes map and MaterialAttributes_Widget for cleaner testing of UEQATC-3497. Set the level to the default GameMode, updated the level blueprint, and disabled interaction with the widget bp.
#jira UE-29618
Change 4419646 by Ben.Marsh
UBT: Determine the correct user directory when remote compiling on Mac, rather than inferring it from the user name. The user name can be changed after an account is created.
#jira UE-64071
Change 4419529 by Jules.Blok
Merging CL 4323685 from Dev-VR - Fix GLES occlusion queries when HDR is disabled.
Add occlusion query support for Multi-View.
Add ShowFlag to visualize occlusion query bounding meshes.
#jira UE-62347
Change 4419528 by Jules.Blok
Merging CL 4323400 from Dev-VR - Remove StereoPair in favor of visibility map merging introduced in CL 4036044
#jira UE-62738
Change 4419525 by Stefan.Boberg
Reduce CPU usage for Cook-on-the-fly server by not busy-waiting for assets to cook.
Added an event which is signaled when a network request has been received. The main COTF loop blocks on this event when the cook request queue is empty. This reduces CPU usage while keeping the request latency low.
#jira UE-51348
graeme.thornton, martin.ridgers
Change 4419034 by Ben.Marsh
Allow plugins specified on the command line to override engine plugins.
#jira UE-64685
Change 4419015 by Frank.Fella
Niagara - Fix linux compile error from CL 4418815.
#jira UE-63379
Change 4418931 by Frank.Fella
Niagara - Fix Win32 compile issue caused by cl 4418639
#jira UE-61823
Change 4418887 by Frank.Fella
Merging from Dev-Niagara all plugin content updates.
#jira UE-64711
Change 4418883 by Uriel.Doyon
Fixed GPU emitters not being ticked correctly on the renderthread.
#jira UE-64710
Change 4418817 by Chris.Babcock
Fix for x86 and x86_64 Android architectures with NDK14b
#jira UE-64708
#ue4
#android
Change 4418815 by Frank.Fella
Merging from Dev-Niagara 4399353 for nicholas.goldstein
Improve discoverability of and navigability to parent Emitters in Systems
#jira UE-63379
Change 4418709 by Frank.Fella
Merging from Dev-Niagara 4397394 for nicholas.goldstein
Add missing entries and param creation subcategory to Set Variables module.
#jira UE-63373
Change 4418639 by Frank.Fella
Merging from Dev-Niagara 4360525, 4360676, 4364096 for Simon.Tovey
Some compile time optimizations
- Moved large map of hlsl keyword replacements from C++ to ini file to improve compile times.
- Now not using templates to handle input parameters to data interface. Now taking a bit from the bytecode offset to denote constant vs register.
- As well as improving compile times, this also makes DIs far easier to write and maintain so I've rolled out to all DIs. Has no affect on perf.
- Moved some things into the VectorVM namesspace.
#jira UE-61823
Change 4418333 by Mark.Satterthwaite
Fix incorrect usage of a CFDictionary passed into IOServiceGetMatchingServices which releases it for us. #rb none #jira UE-62569
Change 4418323 by zak.parrish
Checking in files for SaveLoad - almost done. Need to update save status and do the helpAbout screen
#JIRA UE-64681
Change 4418307 by Frank.Fella
Merging from Dev-Niagara 4357655 for nicholas.goldstein
Fix various capitalization inconsistencies in niagara stack menus
#jira UE-63371
#jira UE-63446
Change 4418242 by Frank.Fella
Merging from Dev-Niagara 4356331 for nicholas.goldstein
Add Spacer between Event Handler header row and added Event Handler properties
#jira UE-63390
Change 4418222 by Dan.Oconnor
Close blueprint editor when replacing a blueprint, avoiding crash when using the merge tool to reload a blueprint
#jira UE-64435
Change 4418217 by Frank.Fella
Merging from Dev-Niagara 4356318 for nicholas.goldstein
Adjust DisplayName generation of linked inputs in Niagara Stack input options to show the entire namespace and to not pass through FName::NameToDisplayString
#jira UE-63387
#jira UE-60349
Change 4418163 by Frank.Fella
Merging from Dev-Niagara 4346597, 4346602, 4346709, 4353333, 4353344, 4353346, 4353355, 4355466, 4355948, 4356192
Niagara - New emitter and new system dialogs
#jira UE-63765
Change 4418114 by Mark.Satterthwaite
Assert that Metal heaps and sub-allocated buffers are actually created properly to catch OoM errors. #rb none #jira UE-62235
Change 4417947 by Ben.Marsh
Compile DebugGame version of the launch module for installed builds.
#jira UE-64604
Change 4417554 by Joe.Conley
Merging using Dev-VR_to_Release-4.21
#jira UE-63210 - "Stereo layers persist in HMD after VR Preview"
#jira UE-54565 - "Packaged game/Editor with Stereo Layers crashes when exiting game through steam VR overlay"
Remove check(VROverlay) in FSteamVRHMD::GetStereoLayers() and just return nullptr if it is null.
Revert previous fix for UE-54565 that caused UE-63210
Change 4417553 by Joe.Conley
Merging using Dev-VR_to_Release-4.21
#jira UE-64054 MRC - Mixed Reality Calibration app does not let users toggle between attachment devices.
Enumerate Motion Sources was getting called before the Motion Controller modular features were being added.
Added a delay before calling Enumerate Motion Sources.
Change 4417552 by Joe.Conley
Merging to Release-4.21 (//UE4/Release-4.21)
#jira UE-63579 Assert when having too many VR devices
Increase max controllers to support more.
Change 4417533 by Ben.Marsh
Fix IPhonePackager not being included in installed builds created on a Mac.
#jira UE-58493
Change 4417495 by Joe.Conley
Back out changelist 4417484
Integrate automatically submitted this before I could convert it to an edit, back out.
#jira UE-63579 Assert when having too many VR devices
Change 4417484 by Joe.Conley
Merging using Dev-VR_to_Release-4.21
#jira UE-63579 Assert when having too many VR devices
Increase max controllers to support more.
Change 4417438 by Ben.Marsh
Prevent unzipped frameworks from being removed every time a remote IOS compile is started, preventing iterative builds.
#jira
Change 4417422 by Ben.Marsh
PR #4937: UE-62508: Add option to project launcher to include prerequisites com. (Contributed by projectgheist)
#jira UE-62508
Change 4417362 by Ben.Marsh
Fix compile warning when converting a blueprint project to native.
#jira UE-63802
Change 4417357 by Jerome.Delattre
Copying from Dev-Enterprise CL 4364256
Fix typo in FGenericPlatformMemory::DumpStats to properly report the free virtual memory.
#author Martin.Sevigny
#jira
Change 4417350 by Jerome.Delattre
Copying from Dev-Enterprise CL 4364260
SceneCapture: Don't CaptureOnMovement if CaptureEveryFrame is enabled. This prevent the capture from happening twice in 1 frame.
#author Martin.Sevigny
#jira UE-64686
Change 4417333 by Uriel.Doyon
Reduced the amount of interpolants in FVertexFactoryInterpolantsVSToPS by the Niagara when using DynamicParameters.
Now only the param required are used where as before the count was defined by the max index.
#jira UE-63712
Change 4417318 by Dan.Oconnor
Improve error messaging when a class creates its CDO while the class layout is being created
#jira UE-64534
Change 4417276 by Frank.Fella
Merging 4340773 from Dev-Niagara for nicholas.goldstein
Add UProperty Specifiers to PropertyMetaData to fix displayed name and tooltip
#jira UE-63233
Change 4417226 by Frank.Fella
Merging 4340719 from Dev-Niagara for nicholas.goldstein
Disable Widget focus of expander arrows and pulldown arrows in Niagara Stack to prevent unexpected tab selection
#jira UE-63380
Change 4417196 by Patrick.Boutot
Create a 10bit media texture for CharBGR10A2 media format.
#jira UE-64682
Change 4417193 by Patrick.Boutot
Keep a reference to the current MediaProfile's proxy to prevent GC
Move MediaProfileSettings to default config.
#jira UE-64475
Change 4417192 by Patrick.Boutot
Deprecate ABGR16 and Float RGB from EDefaultBackBufferPixelFormat. They are not supported by D3DX SwapChain. The jira has more info on which formats are supported.
#jira UE-63090
Change 4416191 by zak.parrish
Resaving Debug menu for TP_ARBP template
#JIRA UE-64678
Change 4416030 by Marc.Audy
Remove broken test (as best it can be told it could never have worked)
#jira UE-64547
Change 4415784 by Marc.Audy
PR #5133: UE-64479 Fix the icon display for the Timeline node replication status (Contributed by mamoniem)
PR #5132: UE-64479: Replicated icon shows up for timelines in BP (Contributed by projectgheist)
#jira UE-64479
#jira UE-64596
#jira UE-64606
Change 4415763 by Steve.Robb
Fixes for improperly initialized USTRUCT() members.
#jira UE-64551
#jira UE-64546
Change 4415723 by Rolando.Caloca
UE4.21 - Remove Linux hack for Vulkan
#jira
Change 4415679 by Rolando.Caloca
UE4.21 - Copy fix from 4415584 and 4401641
- Added support for -vulkanpresentmode=N where N is a VkPresentModeKHR
- This prevents the CPU from getting more than one frame ahead of the GPU. In addition to making the Vulkan RHI more consistent with the DX RHIs and reducing game input latency, this also fixes the issue where memory for volatile uniform buffers could be overwritten by the CPU before the GPU was done with it. This could happen when running in immediate present mode with frame pacing and smoothing disabled, as the CPU could get several frames ahead of the GPU.
#jira
Change 4415654 by Jamie.Dale
Fixed the editor failing to load the native game localization data during init
#jira UE-64097
Change 4415635 by Jamie.Dale
Fixed null pointer access in setting helpers
#jira
Change 4415630 by Jamie.Dale
Ensure we GC at various points that could have left lingering references to items being content hot-reloaded
#jira
Change 4415624 by Jamie.Dale
Ensure that the transient instance created by the material editor is marked pending-kill once the material editor is closed
This fixes an issue where a lingering material editor instance would re-apply old material constant values after a content hot-reload, as the content hot-reload would call PostEditChange on the lingering instance.
#jira
Change 4415620 by Jamie.Dale
Fixed type validation of objects within containers
#jira UE-64151
Change 4415613 by Jamie.Dale
Fixed crash when deleting a package without an SSC state
#jira
Change 4415592 by Marcin.Undak
UAT: Aways create directory before saving encryption parameters
#jira none
Change 4415590 by Jamie.Dale
Merging CL# 4357533, CL# 4366557 and CL# 4374101
#jira
Change 4415577 by Marcin.Undak
Linux: fixed WebM crash
#jira UE-64157
Change 4415340 by frankie.dipietro
Empty M_VolumeSampler for testing
#jira UE-29618
Change 4415334 by frankie.dipietro
Adjust M_VolumeSample test material to use Emissive
#jira UE-29618
Change 4415085 by Ben.Marsh
Restore const signature for FApplePlatformCrashContext::ReportCrash() for compatibility with callbacks.
#jira
Change 4415032 by Ben.Marsh
Fix Mac compile error due to calling non-const function.
#jira
Change 4415005 by frankie.dipietro
Add M_VolumeSample to QAGame to aid Volume Texture testing
#jira UE-29618
Change 4414930 by Ben.Marsh
Include portable callstacks in ensures.
#jira UE-64574
Change 4414631 by Graeme.Thornton
Fix for crash when running automation tests
#jira UE-64652
Change 4414055 by Dan.Oconnor
Remove use of FAssetData to avoid side effects that can result in CDO creation
#jira UE-64534
Change 4413933 by Jeff.Fisher
Merging using Dev-VR_to_Release-4.21
4374589 UE-57680 [CrashReport] UE4Editor_SteamVR!FSteamVRModel::GetRawMeshData() [steamvrassetmanager.cpp:307]
-Added some more logging to try to figure out why this is crashing. Logs the resourceID of the steamVRMesh which might tell us if this is happening with some specific hardware. Also logs index and vertex counts and pointers to see if the data is somewhat malformed or just completely invalid.
4380355 UE-57680 [CrashReport] UE4Editor_SteamVR!FSteamVRModel::GetRawMeshData() [steamvrassetmanager.cpp:307]
-Two more log lines for steamvr shutdown. Maybe we are trying to get the models after shutdown and get bad data?
#jira UE-57680
Change 4413599 by Mitchell.Wilson
Saving SunlightColorLUT to resolve warning.
#jira UE-64648
Change 4413343 by Ben.Marsh
Add Rsync filters to installed build on Windows.
#jira UE-64623
Change 4413276 by Ben.Marsh
Remove logic that prevents UHT compiling on Mac during a remote build.
#jira UE-64493
Change 4413205 by Ben.Marsh
Fix missing dependencies from installed build on Mac and Linux.
#jira UE-64629
Change 4413154 by Jason.Bestimt
Merging CL 4379292 from Dev-VR - Fixes for mobile static draw list using incorrect material render proxy
#JIRA: UEVR-1321
Change 4413148 by Jason.Bestimt
Merging CL 4373138 from Dev-VR - Fix for media texture crash on Lumin
#JIRA: UEVR-1319
Change 4413142 by Jason.Bestimt
Merging CL 4347297 from Dev-VR - Swapping double to single quote to fix Mac Editor packaging for Lumin
#JIRA: UE-63556
Change 4412619 by Jason.Bestimt
Merging CL 4331753 from Dev-VR - Allowing output log to capture warning and error verbosity from commandline output it receives (like launch on Lumin)
#JIRA: UE-62981
Change 4412526 by Jason.Bestimt
Merging CL 4311018 from Dev-VR - Preventing multiple lumin frame timing hints while the graphics context isn't valid
#JIRA: UE-62031
Change 4412517 by Jason.Bestimt
Merging CL 4304939 from Dev-VR - Commenting out Eye Tracker init log until the feature is complete.
#JIRA: UE-61413
Change 4412515 by Jason.Bestimt
Merging CL 4304711 from Dev-VR - Downgrading sandbox jail warning to log, as it is expected output
#JIRA: UE-62992
Change 4412508 by Jason.Bestimt
Merging CL 4303846 from Dev-VR - Fix for fully qualified name in header
#JIRA: UE-62068
Change 4412496 by Jason.Bestimt
Merging CL 4303647 from Dev-VR - Fixing synth style warnings in Lumin Sample
#JIRA: UE-62068
Change 4412491 by Jason.Bestimt
Integrating CL 4303618 from Dev-VR to remove Lumin Emulator plugins
Change 4412425 by Mitchell.Wilson
Updating GetLinearColor nodes in BP_Sky_Sphere to GetClampedLinearColor nodes. Saving curves due to the change to resolve warnings.
#jira UE-64228
Change 4412349 by Lauren.Ridge
Adding custom version to linear color curve assets
#jira UE-64228
Change 4412302 by Ben.Marsh
Include the full filename of the config file if we can't save a backup. Attempt to track down UE-64554.
#jira UE-64554
Change 4412161 by frankie.dipietro
Adding bUsedWithStaticLighting flag to M_Roughness_0 to fix RectLight test
#jira UE-29618
Change 4411692 by tim.gautier
Minor adjustment to M_Tree_FallTreeMerged_01 - added a StaticSwitchParam
#jira UE-29618
Change 4411522 by Lauren.Ridge
PostLoad check and additional GetClampedColorValue BP function for linear color curves
#jira UE-64228
Change 4411494 by Francis.Hurteau
Copied 4359025 Francis.Hurteau
Test if have a valid continuation before running it when setting continuation on a ready future
#jira UE-64567
Change 4411151 by Jeff.Fisher
Merging using Dev-VR_to_Release-4.21
4345353 UE-62255 Google 6DOF Motion Controller Support
-Added support for 6DOF controller tracking on daydream.
-Project Settings->Android->Advanced APK Packaging->Configure GoogleVR to support specific hardware configurations-> Set to Daydream(6.6 DoF) to enable support for two 6dof controllers. A single 3dof controller is also supported by this configuration, as is a single 6dof controller.
-Currently the 3dof controller is detected only by noticing that the positions returned for all controllers are exactly 0,0,0 per Google reccomendation. A future API should make it explicit when a controller is 3dof or 6dof.
-Currently we arbitrarily make the controller at index 0 the right and the one at 1 the left. A future api should let us query for controller handedness.
4346387 Fixing build break in GoogleVRControllerFunctionLibrary.h
4349142 Fixing GoogleVRController build warning
4349742 Fixing AndroidRuntimeSettings build errors.
4350977 Fix for static analysis warning
4351170 Build fix for bad assert
#jira UE-62255
Change 4410947 by Lina.Halper
#DUPEMERGE
Fixes many reference pose issues, where they want to add node, and how it updates, and how they could move
- mainly execution can be disabled by button, and we will mark to compile when it needs recompile due to hierarchy change
- added quick warning to log when hierarchy is missing
- still lots of things need more iteration
- fixed assets
#jira: UE-63136
Change 4410550 by Lauren.Ridge
Fix for ListView not propagating selection change events
#jira UE-64118
Change 4410527 by Lauren.Ridge
Adding condition to guard against crash when pasting comments
#jira UE-63214
Change 4410512 by Marcin.Undak
UAT: Create manifest directory, before writing to it
#jira none
Change 4410511 by Lauren.Ridge
Fix for crash on spamming trigger presses in VR mode
#jira UE-63608
Change 4410489 by Lauren.Ridge
Fix for disappearing UI handle in VR mode
#jira UE-63622
Change 4410364 by Ben.Marsh
PR #5138: Fix bForceBuildShaderFormats not being read correctly in TargetRules (Contributed by rlabrecque)
#jira UE-64611
Change 4410086 by Ben.Marsh
UAT: Show timing/agent info in UAT the same way as in UBT, to make it easier to track down badly configured agents.
(Originallly CL 4343393 in Dev-Build)
#jira
Change 4410018 by Lina.Halper
#DUPE MERGe
Merging using Dev-Anim<->Release4.21
fix motion blur issue on poseable mesh component
#jira: UE-62296
Change 4409981 by Simon.Tourangeau
SunPosition plugin
#jira UE-64075
Change 4409913 by Michael.Kirzinger
Fix FUniqueNetIdRepl serialization for out of engine OSSs. Use FNetBitReader/Writer in the serialization test so it properly tests network replication
#jira UE-63326
[at]josh.markiewicz
Change 4409838 by Simon.Tourangeau
Integrate misc nDisplay fixes from Dev-Enterprise
- nDisplayLauncher: Removed useless no-val command line arguments
- Fixed Editor crash when translation direction is set in BP_DemoWand_Blueprint
- Use quotation marks for paths
- A lot of nDisplay warings "wand not found"
- nDisplayLauncher passes custom arguments at beginning
- Update blueprints (resubmit + comments)
- Single view for monoscipic devices
- Move swap eye attribute to [cluster_node]
- Removed viewport flip feature
- Disable input on slave nodes
- Fix for GL3/4 monoscopic device. Missed changes for 'Viewport positioning fix'.
- Removed custom swap_int
- Fixed demo blueprints
- Fixed crash in DC components when the DC is not initialized
- Fixed visibility of some inherited members
- Fixed Editor crash on second PIE session start
- Fix for viewport positioning
- BP API docs (comments)
- Turn off some screen effects in the nDisplay template project
#jira UE-64170
Change 4409812 by Simon.Tourangeau
USD SDK updated to v18.09
Merged from Dev-Enterprise
#author Rex.Hill
#jira UE-64140
Change 4409754 by Graeme.Thornton
Copy of CL 4385549 from Dev-Core
Try and detect a serialize function inside arbitrary preprocessor blocks and throw an error
Make a couple of other "can't have things inside preprocessor blocks" messages consistent with this one
#jira none
Change 4409671 by Jeff.Fisher
Merging using Dev-VR_to_Release-4.21
4392743 UE-63646 MagicLeap 4.21 redirects need updating
-Made redirectors more specific, found a way to do the updates without the MatchSubstring package update flag, to avoid a warning about how it is very slow.
#jira UE-63647
Change 4409395 by Ben.Marsh
Fix Python.build.cs adding locally generated *.pyc files as runtime dependencies. Since these files are not tracked as build products, they will not exist on other build machines, causing warnings when building DDC.
#jira
Change 4408881 by Max.Chen
Sequencer: Added missing ini change for 4395032
#jira UE-64258
Change 4408670 by Max.Chen
Sequencer: Step to next/prev key no longer uses ExclusiveEndFrame - 1. This fixes cases where you want to step to the last key of a section and add another animation clip that doesn't overlap.
#jira none
Change 4408662 by Max.Chen
Sequencer: Removed derived blueprint type for level sequence director blueprints
#jira UE-64258
Change 4408661 by Max.Chen
Sequencer: When evaluating a range of a sequence, all overlapping segments of that range are now guaranteed to be up-to-date and compiled.
This is a newer version of 4280319 which was backed out in 4317353, with the TRange::Overlaps issues addressed.
#jira UE-63336
#jira UE-62873
Change 4408660 by Max.Chen
Sequencer: Fix crash when converting matinee assets to sequences due to changes in events. Event keys will now have blueprint event endpoints created in the level sequence blueprint when converting.
#jira none
Change 4408354 by Marc.Audy
Fix additional cases where GetBlueprint could get called without a valid blueprint, thus checking
#jira UE-62444
Change 4408286 by Joe.Conley
#jira UE-64552 [CrashReport] UE4Editor_MagicLeap!UImageTrackerComponent::TickComponent() [imagetrackercomponent.cpp:391]
MagicLeap ImageTrackerComponent: Adding check for PLATFORM_LUMIN to prevent PIE crash running code that was designed to only run on device.
This had been fixed previously but somehow the fix got lost merging between streams.
Change 4408252 by Brandon.Schaefer
Doubles in the form of 1e+9999 can be larger then 30 chars, set aside more room
#jira UE-64582
Change 4408076 by Mike.Erwin
UAT: fix Iterative Deploy leaving behind old files on Android
(copy 4369737 from Dev-Build)
For iterative deploy on Android, files & directories not in staging will be zapped from the device.
The following directories are spared, to maintain config & logs on device:
Engine/Saved
Engine/Config
ProjectName/Saved
ProjectName/Config
Tested with Samsung Galaxy S6+ (Android 6.0) and Google Pixel 2 (Android 9.0)
#android
#jira UE-61686
Change 4408070 by Mike.Erwin
UAT: iterative deploy no longer prevents cleaning of staging directory
(copy 4369732 from Dev-Build)
Partial fix for
#jira UE-58838 UE-61686 UE-62879
Might need additional work to reduce file copies from Build to Stage.
Change 4407741 by Ben.Marsh
UBT: Avoid trying to figure out which mobile provision to use for a project when we already know the path to the provision we want. Also fix certificate not being updated if mobile provision changes.
#jira
Change 4407632 by Jamie.Dale
Removed pyc files from Python SDK
#jira UE-64531
Change 4407622 by Jamie.Dale
Updated Python SDK copy script to exclude pyc files
#jira UE-64531
Change 4407431 by Anousack.Kitisa
Copied 4392037 Anousack.Kitisa
Modified API for UV map generation.
#jira UE-63814
Change 4407427 by Ben.Marsh
Suppress warning for missing DebugNonUFS files when staging installed build.
#jira UE-64579
Change 4407401 by Anousack.Kitisa
Copied 4383601 Anousack.Kitisa
[StaticMeshEditor]:
* Fixed material assignment issue when re-importing Datasmith static mesh after deleting a section from the mesh.
* Fixed material issue when deleting a section from a mesh and undoing and chaging material on the mesh.
#jira UE-62480
Change 4407274 by Joe.Graf
Over merge reverted
#jira: fix
Change 4407268 by Anousack.Kitisa
Copied 4369800 Anousack.Kitisa
Import/export FBX metadata on SkeletalMesh and Skeleton assets.
#jira UEENT-1881
Change 4407220 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - AR samples updated
#jira: UE-64673
Change 4407213 by Rolando.Caloca
UE4.21 - Copy 4403346
DR - Fix post opaque extension running before lights
#jira
Change 4407208 by Anousack.Kitisa
Copied 4369604 JeanLuc.Corenthin
- Fixed indexing issue with FOverlappingCorners object created using a FmeshDescription object:
- Changed logic in building of FOverlappingCorners to be based on index of wedge, number of wedges equal 3 times the number of triangles like in FRawMesh, instead of index of vertex instances.
- Updated BuildVertexBuffer to take this new logic in account.
- Fixed crash in FMeshDescriptionOperations::CreateMikktTangents:
- MikkTSpace sdk does not handle properly faces with 0 vertices which occur with mesh description with invalid polygons.
#jira UE-62478, UE-63758
Change 4407188 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Fixed missing include when not using unity builds
#jira: UE-64673
Change 4407179 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added a way to see the ARKit CPU consumption across all of its threads
#jira: UE-64673
Change 4407178 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Bug fix for landscape image detection being at the wrong distance
#jira: UE-64673
Change 4407174 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Improved debug rendering of AR tracked images
#jira: UE-64673
Change 4407165 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added post edit change to force correct aspect ratios when editing physical size for detected images
#jira: UE-64673
Change 4407162 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Reverted premature merge
#jira: merge
Change 4407156 by Joe.Graf
Merging using Dev-VR_to_Release-4.21
#jira: merge
Change 4407146 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Point cloud rendering additions
#jira: UE-64673
Change 4407134 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added some config properties to box component for debug rendering
#jira: UE-64673
Change 4407128 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added missing #ifdef
#jira: UE-64673
Change 4407127 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - AR point cloud debug rendering support added
#jira: UE-64673
Change 4407119 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARVideoSettings sample
#jira: UE-64673
Change 4407113 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added a device orientation query in addition to the event that is present
#jira: UE-64673
Change 4407109 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Fixed a missing nullptr check that was causing AR apps to crash
#jira: UE-64673
Change 4407105 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added support for rotating an image while generating a jpeg for ARSharedWorld sample
#jira: UE-64673
Change 4407101 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added a set of properties to override thread priorities when using ARKit and UE4 is causing ARKit to starve
#jira: UE-64673
Change 4407098 by Joe.Graf
Merging using Dev-VR_to_Release-4.21
#jira: merge
Change 4407093 by Francis.Hurteau
Copied 4372687 Francis.Hurteau
Fix potential assert when changing ProtocolVersion based on ping messages
#jira UE-64035
Change 4407088 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Added scaling to jpeg creation for ARSharedWorld sample
#jira: UE-64673
Change 4407082 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407078 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Fix for null session config being passed to AR system
#jira: UE-64673
Change 4407074 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407064 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407061 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407052 by JeanLuc.Corenthin
Copy CL #4392021
- Fixed crash when importing model thru VRED importer
- Includes changes to StaticMeshBuilder.cpp made in CL #4369604
#jira UE-64152
Change 4407051 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407045 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Code suupport for streaming ar shared worlds
#jira: UE-64673
Change 4407039 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - ARSharedWorld sample
#jira: UE-64673
Change 4407032 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Improved AR template
#jira: UE-64673
Change 4407030 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Better BP exposure of GetMappingStatus for AR
#jira: UE-64673
Change 4407017 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Better double free fix for ar env probes
#jira: UE-64673
Change 4407012 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Double free fix for env probes
#jira: UE-64673
Change 4407007 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - AREnvProbe sample
#jira: UE-64673
Change 4407006 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - AREnvProbe sample
#jira: UE-64673
Change 4407003 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - AREnvProbe sample
#jira: UE-64673
Change 4406999 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Render doc fix for non-editor builds
#jira: merge
Change 4406994 by Anousack.Kitisa
Copied 4362955 JeanMichel.Dignard
Static Mesh Library : SetLodFromStaticMesh
- Assign materials to new LOD sections based on source mesh LOD.
- Copy LOD build settings from source.
#jira UE-63659, UE-64016
Change 4406992 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Fix for CLion IDE usage
#jira: merge
Change 4406987 by Joe.Graf
Merging using Dev-VR_to_Release-4.21 - Fix for missing property decoration for video modes
#jira: UE-64673
Change 4406944 by Max.Chen
Sequencer: Stop all sounds on tear down
#jira UE-63501
Change 4406942 by Mark.Satterthwaite
Duplicate CL #4398322: Rebuild mtlpp using Xcode 10 so Metal 2.1 works on iOS.
#jira N/A
Change 4406880 by Anousack.Kitisa
Copied 4356072 Anousack.Kitisa
[StaticMeshEditor]:
* Moved the UV channel removal functionality from the LOD details panel to the UV drop-down menu.
#jira UEENT-1827
Change 4406826 by Francis.Hurteau
Copied 4366928 Jeremie.Roy
Fix crashes related to the UndoHistory.
Add missing UndoBufferChangedDelegate broadcasts in EditorTransaction
#jira UE-64096
Change 4406820 by Anousack.Kitisa
Copied 4350474 Johan.Duparc
Fix UEditorAssetLibrary::DoesAssetExist to handle sub object name
#jira UE-62333
Change 4406783 by Anousack.Kitisa
Copied 4348861 Anousack.Kitisa
[StaticMeshEditor]:
* Fixed vertices being merged even though they don't share mergeable attributes.
#jira UE-62980
Change 4406752 by Anousack.Kitisa
Copied 4348838 Anousack.Kitisa
Fixed ConvertAnyPathToObjectPath returning wrong path for objects that are named differently than their package.
#jira UE-62333
Change 4406721 by Brandon.Schaefer
Linux: Set FORCE_ANSI_ALLOCATOR when using -EnableTSan to avoid multiple definitions
#jira UE-62804
Change 4406461 by Francis.Hurteau
Copied 4382276 Francis.Hurteau
Fix syncing streaming level visibility state with undo/redo
#jira UE-64315
Change 4406459 by Ben.Marsh
Fix temporary files containing dependency lists being created in Engine directory. Move them under Engine/Intermediate instead.
#jira
Change 4406451 by Brandon.Schaefer
Linux: Dont try to make current if our current window was the SplashScreen window we just destroyed
#jira UE-64211
Change 4406440 by Chris.Babcock
Remove AKEYCODE_BACK from valid gamepad keycodes to allow it when controllers are disabled
#jira UE-64350
#ue4
#android
Change 4406382 by Anousack.Kitisa
Copied 4393087 Patrick.Boutot
Add a shader source directory for the OpenCVLensDistortion plugin.
#jira UE-64568
Change 4406345 by Joe.Graf
Merge Xcode project generation fix to defaul to Legacy build mode using Dev-VR->Release-4.21
#jira: merge
Change 4405792 by JeanMichel.Dignard
Copied 4393315 JeanMichel.Dignard
Better telemetry for plugin warden
- Added more event attributes to track potential issues.
#jira UE-64280
Change 4405776 by JeanMichel.Dignard
Copied 4392578 JeanMichel.Dignard
Fixed actors not saving properly on a reimport when moved to a sublevel.
The issue is that they were being parented to actors from another level which isn't supported.
Also, the scene component template should refer to the parent component through a TSoftObjectPtr in case it's in another package.
#jira UE-62070
Change 4405738 by Mark.Satterthwaite
Duplicate CL #4396224: Remove another broken bit of legacy Metal code.
#jira UE-64128
Change 4405733 by Mark.Satterthwaite
Duplicate CL #4399472: Handle all Metal formats in ShaderPlatformToPlatformName - I have not made this handle all formats or platforms so this function is *wrong* for a number of others and should *assert* on failure to identify a platform. This fixes incorrect shader compilation for Forward rendering on iOS.
#jira UE-64355
Change 4405630 by JeanMichel.Dignard
Copied 43737703 Johan.Duparc
Prevent crash for old datasmith assets
Clear transactional flag in user asset data that could cause a crash for Blueprint assets.
#jira UE-63349
Change 4405481 by Sorin.Gradinaru
UE-61699 Kindle Fire 5th Gen crashes rotating Remote Session
#jira UE-61699
#Android
#4.21
From //UE4/Dev-Mobile CL4360704
Disabling threaded rendering for Kindle Fire HD 7 5th gen in DefaultDeviceProfiles.ini
Change 4405276 by Frankie.DiPietro
Adding test content for Volume Textures, Iris Normals, and Subsurface Boundary Bleed Color coverage
#jira UE-29618
Change 4405138 by JeanMichel.Dignard
Copied 4350470 Johan.Duparc
Fix crash on property edition for blueprint actors with templated asset user data
#jira UE-63349
Change 4404967 by Mikey.Boyd
Making content change to M_Translucent_PanNrm for UEQATC-244. Added a Texture Sample node to be used to test Platform Stats.
#jira UE-29618
Change 4404909 by Robert.Manuszewski
When enabling cooked assets in the editor, the engine will now use FArchiveAsync2 in the editor to be able to open them.
(re-implemented CL #4400327 from Dev-Core)
#jira UE-64389
Change 4404901 by Robert.Manuszewski
Fixed a hang when entering PIE when Background Streaming is disabled
#jira UE-63320
Change 4404816 by Ben.Marsh
Fix "Non-void function should return a value" warning in CIS.
#jira
Change 4404621 by Stefan.Boberg
Re-enabled LLM on Editor builds since the performance issue has been addressed
#jira UE-60020
Change 4404491 by Max.Chen
Sequencer: Use cached object bindings when drawing motion trails.
FindObjectId can be slow because it clears the cached bindings. Added FindCachedObjectId which retrieves the binding without clearing the cache.
#jira UE-63347
Change 4404490 by Max.Chen
Sequencer: Fix key reduction not working on imported fbx channel.
Implement channel Optimize() so that it follows the curve editor's SimplifySelection by evaluating whether a key is needed (rather than removing the key and checking whether the value has changed).
The main fix is that the tangents need to be calculated as non-normalized (ie. with the DisplayRate)
#jira UE-62353
Change 4404488 by Max.Chen
Sequencer: Changed HandleSingleNode fallback check for collapsed parents.
#jira UE-64394
Change 4404486 by Max.Chen
Sequencer: Remove restriction on hidden mobility. It's too wide to restrict transform tracks.
#jira UE-63415
Change 4404472 by Max.Chen
Sequencer: Restore drawing paths for selected nodes and channels
#jira UE-64204
Change 4404468 by Max.Chen
Sequencer: Check for property type in evaluation. This fixes an issue where the property type is changed after the track has been created.
#jira UE-64278
Change 4404439 by Keli.Hlodversson
Merging critical SteamVR fixes from Dev-VR
#jira UE-63198
#jira UE-64098
#jira UEVR-1250
Change 4403717 by Marc.Audy
Inline templated version of GetGameInstance
#jira UE-62591
Change 4403702 by Marc.Audy
PR #4944: Added template cast versions of multiple methods. (Contributed by francoap)
#jira UE-62591
Change 4403699 by Marc.Audy
Make reregistering an object in the significance manager an ensure not a check
#jira
Change 4403697 by Marc.Audy
PR #5074: Fixed minor bugs in GameUserSettings. (Contributed by phoenxin)
#jira UE-63893
Change 4403695 by Marc.Audy
Fix crash pasting timeline with external curve that has been force deleted
#jira UE-64504
Change 4403693 by Marc.Audy
PR #5077: Prevent TimelineComponent Update delegate from being executed 3 times when looping (Contributed by nedwardsnae)
#jira UE-63927
Change 4403691 by Marc.Audy
PR #5076: Correct icon when dragging an event dispatcher variable (Contributed by projectgheist)
#jira UE-63895
Change 4403689 by Marc.Audy
PR #5075: Mouse decorator when dragging a category from My Blueprint panel (Contributed by projectgheist)
#jira UE-63894
Change 4403686 by Marc.Audy
PR #5096: UE-64019: Use compare function for tooltip FText instead of != operator (Contributed by projectgheist)
#jira UE-64109
#jira UE-64019
Change 4403662 by Marc.Audy
Ensure that objects created via duplication in PIE are correctly constructed
#jira UE-63505
Change 4403462 by tim.gautier
Cleaned up M_Tree_FallTreeMerged_01, added comment blocks for UEQATC-212
#jira UE-29618
Change 4403308 by Michael.Trepka
Update mouse position on NSDraggingUpdate event on Mac
#jira UE-60800
Change 4403290 by Michael.Trepka
Fixed issues with window position and size when toggling between fullscreen and windowed modes
#jira UE-63212
Change 4403270 by Michael.Trepka
Fixed a problem with mouse click/drag events being received by incorrect window/widget in certain conditions while dragging windows on Mac
#jira UE-57506
Change 4403216 by Ben.Marsh
Fix null reference exception when resolving paths.
#jira
Change 4403213 by Ben.Marsh
Revert change to use FileReference for executable to use in the <Spawn> task, to ensure we can use programs in the PATH.
#jira
Change 4403209 by Ben.Marsh
Prevent null dereference when tagging a set of files.
#jira
Change 4403200 by Ben.Marsh
BuildGraph: Add support for automatic parsing of collection types in BuildGraph parameters.
#jira
Change 4403188 by Mikey.Boyd
Adding content for Data Table test coverage.
#jira UE-29618
Change 4403163 by Ben.Marsh
Sanitize the contents of all the receipts in the installed engine build, to make sure they don't reference any files we don't distribute.
#jira UE-56424
Change 4403151 by Ben.Marsh
UBT: Don't assume that console encoding is UTF-8 when using ParallelExecutor.
#jira UE-64248
Change 4403136 by Ben.Marsh
Fix IWYU issues with SQLite support.
#jira UE-64523
Change 4403116 by Ben.Marsh
UBT: Fix project files being generated for VS2017 if the user only has AutoSDKs, and does not have the IDE installed.
#jira UE-62726
Change 4403074 by Ben.Marsh
UBT: Fix a couple of edge cases when parsing output from child processes.
* If a single line was larger than 32kb, the process would be treated as having terminated.
* If the last output line did not have a trailing newline, the line would be dropped.
#jira UE-64234
Change 4403066 by Ben.Marsh
Fix project browser reopening when creating a new project, if other command line arguments are present. Missing a space between the project file and previous argument list.
#jira UE-63724
#lockdown Nick.Penwarden
#rb none
#ROBOMERGE-OWNER: jason.bestimt
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 4447546 in //UE4/Main/...
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 4452228 by jason bestimt in Dev-VR branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3813004 by Matt.Kuhlenschmidt
Fix dpi scale being wrong when there is a mix of high dpi and low dpi monitors and the editor opens the window on the low dpi monitor
Change 3946515 by Michael.Trepka
Reverted CL 3813004. We need to save editor's root window size and position in DPI-independent units, as that's what the loading code expects.
Change 4052825 by Brandon.Schaefer
Add back -funwind-tables for arm
This was removed an only tested on x86 which worked just fine. Arm reqiures this for backtrace
#jira none
Change 4055318 by Brandon.Schaefer
Remove extra mallocs when crash handling
Still need to look into gmalloc calls, such as using FStrings during Ensure/Crash handling
[at]Arciel.Rekman
#jira UE-58538
Change 4055623 by Brandon.Schaefer
Replace std::endl with "\n"
As std::endl is "\n" << std::flush. On windows dump_syms was taking 33 seconds to fflush with std::endl on a 1.2GB file. No longer with "\n".
[at]Josh.Engebretson
Change 4057102 by Jamie.Dale
Added missing API export
Change 4057384 by Rex.Hill
Fix ReversePolygonFacing crash
Change 4067426 by Matt.Kuhlenschmidt
PR #4667: Source control history: remove empty spacing in the right of the detail panel (Contributed by SRombauts)
Change 4067587 by Matt.Kuhlenschmidt
PR #4311: PlacementModeTools shapes searchable and thumbnail (Contributed by projectgheist)
Change 4068480 by Cody.Albert
Fix display name for Display UI Extension Points
Change 4070876 by Brandon.Schaefer
Avoid printing when in a signal handler. Put that off until the end
#jira UE-36663
[at]Arciel.Rekman, [at]Anthony.Bills
Change 4071980 by Brandon.Schaefer
Cache files that are invalid or the wrong case sensitivity
#jira UE-58250
[at]Arciel.Rekman
Change 4079967 by Matt.Kuhlenschmidt
Added scale parameter to Canvas::DrawText
#jira UE-59023
Change 4080228 by Alexis.Matte
Fix the PerPlatformPropertiesWidget to be readable when there is many platform
#jira UE-57556
Change 4081171 by Matt.Kuhlenschmidt
PR #4272: Fix typo. (Contributed by Damianno19)
Change 4081601 by Matt.Kuhlenschmidt
GitHub 4077 : Hide SDetailView Filterbox when no actor selected
Change 4090114 by Matt.Kuhlenschmidt
Fixed touch events simulated through mouse not respecting high dpi
#jira UE-59477
Change 4091999 by Matt.Kuhlenschmidt
Fixed insert/delete/duplicate children calling PostEditChange on the existing child node not the array
Change 4093187 by Arciel.Rekman
Do not save window position if running with -nullrhi (UE-52498).
- This also fixes a crash on exiting automation tests.
#jira UE-52498
Change 4096404 by Richard.TalbotWatkin
Resaved test assets to update to latest UStaticMesh serialization format.
Change 4096445 by Richard.TalbotWatkin
New serialization layout for UMeshDescription.
- Only the bare minimum is serialized: any internal values which can be inferred from others in the Mesh Description are omitted.
- Triangles are no longer serialized: a triangulation step is performed per polygon when serialized.
- Attribute arrays of simple types are now serialized with BulkSerialize for speed; only FName requires element-by-element serialization.
Change 4112843 by Brandon.Schaefer
Rebuilt replacing std::endl with '\n' avoiding a std::flush *pre* write
Was taking 30 seconds to std::flush on a 1.2 GB file
#jira none
Change 4113422 by Brandon.Schaefer
If we are using the native bundled toolchain set LC_ALL=C to avoid locale issues
#jira UE-59416
Change 4113849 by Cody.Albert
Fix support for toolbar extensions in the UMG editor
Change 4118758 by Richard.TalbotWatkin
- Refactor to put UStaticMesh Mesh Descriptions in a separate object which is not loaded by default, but which can be requested when needed. This needs to be kept in sync with the number of SourceModel LODs.
- Various refactors to import/building.
- Changed UMeshDescription to FMeshDescription, and made its preferred semantics pass-by-reference rather than by pointer.
- Deprecated UMeshDescription.
Change 4119883 by Rex.Hill
Cleanup blueprint callable categories
Landscape Editor -> Landscape|Editor
Landscape Runtime -> Landscape|Runtime
Cloth -> Clothing Simulation
Cinematics -> Cinematic
Utility -> Utilities
Change 4119898 by Rex.Hill
Cleanup blueprint callable categories
x|Magic Leap -> Magic Leap|x
Apple ARKit * -> Apple ARKit|*
Change 4119972 by Brandon.Schaefer
Dont add colors if we are not outputing to a terminal
#jira UE-58173
Change 4119994 by Brandon.Schaefer
Only check once if we are outputing to a terminal
#jira UE-58173
Change 4122654 by Alexis.Matte
Fix re import assignment of sections
#jira UE-59611
Change 4123536 by Alexis.Matte
Add to the fbx importer the possibility to use different sample rate when importing an animation.
#jira UE-59444
Change 4124702 by Brandon.Schaefer
Fix duplicated struct/class from slightly different submit into main coming back into dev-editor
#jira UE-60163
Change 4133449 by Mike.Erwin
glTF importer work
Foundations of work for Skeletal Mesh import; right now we just support Static Mesh.
- node hierarchy
- joint IDs & skinning weights
- matrix & quaternion values
#jira none
Change 4133749 by Matt.Kuhlenschmidt
PR #4771: Fix access violation for ImportAsset commandlet fbx reimport. (Contributed by UristMcRainmaker)
Change 4133758 by Matt.Kuhlenschmidt
PR #4675: Properly set TextScale for OnScreenDebugMessages (Contributed by projectgheist)
Change 4134543 by Alexis.Matte
Update the staticmesh LOD model max deviation when generating a LOD
#jira UE-60353
Change 4134559 by Alexis.Matte
Deprecate FRawMesh, replace by MeshDescription - Editor scripting utilities
#jira UE-60666
Change 4134560 by Alexis.Matte
Deprecate FRawMesh, replace by MeshDescription - SpeedTreeImporter
#jira UE-60667
Change 4135335 by Alexis.Matte
Deprecate FRawMesh - GLTF importer
#jira UE-60670
Change 4135857 by Alexis.Matte
Fix CIS build warning
#jira none
Change 4137249 by Matt.Kuhlenschmidt
Fix tiny fonts from appearing in slow task dialogs
Change 4137280 by Matt.Kuhlenschmidt
Fix specifying relative paths for the auto-import commandlet not working
Change 4137283 by Matt.Kuhlenschmidt
PR #4305: Light map index was unintialized (Contributed by DSDambuster)
Change 4137290 by Matt.Kuhlenschmidt
PR #4382: Prevent error log due to non-existing plugin directory (Contributed by projectgheist)
Change 4147032 by Alexis.Matte
Deprecate FRawMesh, replace by MeshDescription - ABC Importer
#jira UE-60702
Change 4147978 by Matt.Kuhlenschmidt
Fix one of the CIS fails
Change 4154874 by Matt.Kuhlenschmidt
Fix hidden asset properties in struct details panels.
We consider all object properties with "allowedclasses" metadata to be asset properties since they only show an asset picker.
Change 4167303 by Matt.Kuhlenschmidt
Work around for sync to content browser from details panels not working for interface properties
Change 4167388 by Matt.Kuhlenschmidt
Make sure when converting relative path filenames in automated import that we convert them relative to the project directory.
Change 4171891 by Matt.Kuhlenschmidt
Fix preview mesh actor becoming stuck to the cursor when the editor or viewport loses focus
#jira UE-61246
Change 4175503 by Cody.Albert
Updated variable details panels to not display unusable metadata options for UMG widget references
#jira UE-55078
Change 4175736 by Cody.Albert
PR #4663: UE-20103: Slate widgets retain their category name v2 (Contributed by projectgheist)
Change 4178937 by Rex.Hill
Fix crash opening level after removing as sublevel
jira: UE-61305
Change 4181097 by Matt.Kuhlenschmidt
Fix Linux/Mac CIS
Change 4184333 by Alexis.Matte
Fix the material ID assignation when re-importing static mesh
#jira none
Change 4199682 by Arciel.Rekman
Linux: enable XGE during cross-builds to see whether the build issues persist.
- Licensees are asking for this and XGE folks are eager to help investigating the crashes, if any.
Change 4200944 by Cody.Albert
Updated VR Mode button to become inactive during SIE (instead of disappearing altogether)
#jira UE-50220
Change 4204817 by Alexis.Matte
Enable or disable the morph target weight slider depending of the project settings.
#jira UE-61671
Change 4204821 by Alexis.Matte
Optimize import time for morph targets
#jira UE-61670
Change 4207394 by Cody.Albert
PR #3299: UMG Slider Additions (Contributed by Dzuelu)
Change 4208299 by Brandon.Schaefer
Fix warning/error with logical operators
#jira none
Change 4210660 by Cody.Albert
PR #3458: UE-43728: Always show scrollbar when necessary (Contributed by projectgheist)
#jira UE-43727, UE-43278
Change 4215684 by Brandon.Schaefer
Linux: Implement minimized function for LinuxWindow
#jira UE-56023
Change 4217350 by Brandon.Schaefer
Linux: Clean up IsMaximized
#jira none
Change 4217489 by Brandon.Schaefer
Linux: Make popup menus BORDERLESS. Slate will give the menu events
This appears to fix a lot of our grabs causing compiz to do something issue.
#jira UE-59237, UE-54085, UE-51407, UE-50018, UE-53915
Change 4225018 by Cody.Albert
UMG Hierarchy now remembers expansion state when being destroyed and recreated (due to closing widget or switching to Graph view)
#jira UE-61836
Change 4225088 by Cody.Albert
Added hover style for color picker slider
Change 4226081 by Richard.TalbotWatkin
New attribute array API.
Fixed some flaws in the original API, deprecated various methods, and introduced some new features.
- Now attribute arrays are accessed via TAttributesRef or TAttributesView (and corresponding const versions). These value types hold references to attribute arrays, and individual elements can be accessed by their element ID and attribute index. Using a value type is safer than the previous method which required assignment to a const-ref (and not doing so would take a temporary copy of the attribute array).
- The attribute set has been totally flattened, so all attributes of different types are added to the same container. This greatly improves compile times, prevents attributes from being created with the same name but different types, and permits the view feature.
- The class hierarchy has changed to have generic base classes where possible with no particular ElementID type. This reduces the code footprint by no longer generating nearly identical copies of templated methods.
- A TAttributesView allows the user to access an attribute array by the type of their choosing, regardless of its actual type. For example, the Normal attribute may be registered with type FPackedVector, but accessed as if it was an FVector. This allows us to move away from very strong typing, and instead transparently store attributes of a more efficient size, while the user is not affected.
- A transient attribute flag has been added, to denote that a particular attribute should not be saved.
Change 4226083 by Richard.TalbotWatkin
Reinstated original mesh editor materials.
Change 4226102 by Richard.TalbotWatkin
Fixed some deprecation warnings, and a mistake in MeshAttributeArray.h.
Change 4226118 by Richard.TalbotWatkin
Fix build errors:
- Added missing file
- Corrected the last fix.
Change 4226121 by Richard.TalbotWatkin
Bumped static mesh mesh data GUID.
Change 4226231 by Richard.TalbotWatkin
Removed some test code which got checked in by mistake.
Change 4226232 by Richard.TalbotWatkin
Fixed typo which caused build errors.
Change 4226234 by Richard.TalbotWatkin
Fixed a typo in MeshDescriptionTests.
Change 4226237 by Richard.TalbotWatkin
Removed over-cautious deprecation warnings. Once GetAttributes() is changed to GetAttributesRef(), element access will still work with array syntax.
Change 4226625 by Richard.TalbotWatkin
Added missing asset.
Change 4227365 by Matt.Kuhlenschmidt
Fix brush actors not showing the correct icon in scene outliner.
- Actors can now supply their own icon if needed
#jira UE-61948
Change 4229632 by Alexis.Matte
Make the namespace an import option
#jira UE-62099
#jira UE-62067
Change 4229637 by Alexis.Matte
Fix fbx importer staticmesh the light map index, the index was check before the build.
#jira UE-62064
Change 4232793 by Chris.Gagnon
Added include to fix non unity builds.
#jira UE-62138
Change 4234206 by Brandon.Schaefer
Linux: Allow windows that want to be resizable to be resizeable
Github PR #3578 thanks hhyyrylainen
#jira UE-45847
Change 4234322 by Brandon.Schaefer
Continue after starting UnrealVersionSelector to avoid blocking a chain command
#jira UE-61530
Change 4234446 by Chris.Gagnon
Properly handled FPackageName::TryConvertFilenameToLongPackageName() failing in Cache Thumbnail.
#jira UE-61990
Change 4235057 by Brandon.Schaefer
Linux: Write to stderr when we fail to find expected to find sym file
#jira none
Change 4235121 by Brandon.Schaefer
Linux: Mark the static bool as soon as we enter the scope
#jira none
Change 4235399 by Brandon.Schaefer
Linux: Check we are not x86 otherwise add unwind tables
Copying the change that went over into 4.20.1 here
#jira none
Change 4240539 by Jamie.Dale
Made DataTableUtils::GetX functions take a const data pointer
Change 4240646 by Chris.Gagnon
Fix for delayed destruction of UWidgets when they are manually removed from a panel as part of tear down.
Inspired by the pull request, however I put in a more generic fix.
PR #4904: Fix late release of Slate resources managed by UMG slot widgets (Contributed by cmp-)
Change 4242975 by Yuriy.ODonnell
Moved duplicated code from MeshUtilities and MeshDescriptionOperations (FLayoutUV, FAllocator2D, FOverlappingCorners, etc.) into a new single module MeshUtilitiesCommon.
Add a generic opaque mesh view interface FLayoutUV::IMeshView to abstract mesh data access and allow FLayoutUV to be used with any mesh type in any module.
Replaced few instances of using an old version of overlapping corners data structure (multi-map) with new specialized FOverlappingCorners container.
Change 4243112 by Yuriy.ODonnell
Use new attribute array API for accessing FMeshDescription data.
Change 4243131 by Brandon.Schaefer
Cast our new resize w/h to int before checking if we are already that size
#jira UE-52291
Change 4243172 by Brandon.Schaefer
Ceil not trunk for this compare
#jira none
Change 4243271 by Brandon.Schaefer
Change address to be more portable
MS compiler does not place a '0x' on %p formating. Linux/Mac append a '0x' to the address
#jira UE-62325
Change 4243276 by Richard.TalbotWatkin
Fixed deprecated MeshDescription calls (merged with Yuriy's changes).
Change 4244067 by Lauren.Ridge
Preventing crash on floating text if asset container does not exist. VR Editor floating text is now not placeable or blueprintable.
#jira UE-62139
Change 4244547 by Lauren.Ridge
Changes to more accurately represent android behavior in PIE and UMG
#jira UE-62301
Change 4244830 by Alexis.Matte
Fix animation Range import, prevent changing the option when validating the anim range.
#jira UE-62055
Change 4250565 by Yuriy.ODonnell
Removed GeometryCache dependency on MeshUtilitiesCommon in non-editor configs.
Change 4254733 by Matt.Kuhlenschmidt
Slate Fast Path - Changed FSlateWindowElementList GetWindow to be thread safe. For fast path, this is accessed on multiple threads so it needs to be safe
GetWindow is deprecated and GetPaintWindow should be used instead
Edigrate from source CL 4254611
Change 4257092 by Chris.Gagnon
Improved UMG rename validation to respect the errors from the blueprint validator.
This fixes at least the case where it miss reported the issue when the name was greater than the length limit in blueprints.
#jira UE-62417
Change 4257124 by Chris.Gagnon
PR #4924: UE-62113 Fix Other filters toggling all assets to show up (Contributed by mamoniem)
#jira UE-62457
Change 4258696 by Chris.Gagnon
Removed Tab Spawner for Color Curve Editor is your not editing the color curve.
#jira none
Change 4258937 by Chris.Gagnon
Simplifed the code in the case of a null CurveOwner.
#jira UE-62443
Change 4259162 by Richard.TalbotWatkin
Fixed crash when entering mesh editor mode after having loaded a new level.
Change 4259909 by Chris.Gagnon
Added better check output to try and learn more about a crash in the wild.
Added some better const saftey while in there.
#jira UE-60696
Change 4259995 by Chris.Gagnon
Fix for possible crash if the mesh has invalid materials.
Also fixed the fact the FindMaterialIndicesUsingTexture() didn't work as advertised at all.
Seems like you'd attemp to paint all materials even when trying to only paint the ones using a particular texture.
#jira UE-62488
Change 4261012 by Michael.Dupuis
#jira UE-48899: Make sure the RootComponent is valid before trying to use it.
Change 4261361 by Michael.Dupuis
#jira UE-48899: Fixed the warning about scale
Change 4261926 by Michael.Dupuis
#jira UE-48899: Only check the root component validity as it's possible that the component is not registered when this get called.
Change 4262163 by Richard.TalbotWatkin
Fixed uninitialized member.
#jira UE-62493
#jira UE-62506
Change 4262549 by Brandon.Schaefer
Linux: Update the Slate application what the window size will most likely be
As X11 takes a frame to send an Event that a window has had its size changed. This causes things such as the slate renderer to think the window size is different then it actually it. This causes streching of tooltips
#jira UE-62555
Change 4262581 by Brandon.Schaefer
Linux: Use Show so we preserve our bIsVisible bool and avoid sending SDL_ShowWindow twice (ie. if its already shown)
#jira none
Change 4262906 by Chris.Gagnon
PR #4915: [UMG] Bind UWidgetAnimation from C++ to blueprint created animation (Contributed by TheCodez)
Change 4262965 by Chris.Gagnon
PR #4932: Fix to generate cleaner C++ files when using "New C++ Class" (Contributed by TheCodez)
Change 4263177 by Chris.Gagnon
PR #4935: Prevent crash when clicking use selected game mode multiple times (Contributed by projectgheist)
Change 4264723 by Christina.TempelaarL
Fixed SceneCaptureComponent so ShowOnlyActors property is writeable in blueprints.
#jira UE-62547
Change 4266029 by Michael.Dupuis
#jira none: Guarded against the scene being null
Change 4266356 by Richard.TalbotWatkin
Changed FMeshDescription to a struct from a class.
Added log errors when loading UMeshDescription objects (now deprecated), in preparation to resave any which remain.
Once all serialized UMeshDescriptions are wiped out (they only exist internally), FMeshDescription will become a USTRUCT.
Change 4266621 by Matt.Kuhlenschmidt
Fix UE4 icon to be the correct one
Change 4266635 by Chris.Gagnon
Added Message Log output for invalid software cursor as opposed to ensure/log.
#jira UE-62554
Change 4268136 by Matt.Kuhlenschmidt
Fix outline colors not updating when changing on the fly
#jira UE-42116
Change 4269184 by Chris.Gagnon
Fix for possible nullptr dereference.
#jira none
Change 4269902 by Brandon.Schaefer
Slate dialog modal window was not settings its parent window
#jira UE-62608
Change 4272083 by Chris.Gagnon
Fix for case where the the property noded arn't rebuilt in time and custom property ui can be using stale data.
#jira UE-62499
Change 4272869 by Michael.Trepka
Make sure ShooterGame sets correct input modes/mouse capture in menus and in game to avoid problems with keyboard not working in menus after alt-tab
#jira UE-61017
Change 4275155 by Michael.Dupuis
#jira UE-62526: Update lightmap/shadow UV mapping after lighting build on HISMC. ISM will get also updated due to the Edit() that will reapply the values on CreateSceneProxy
Change 4275298 by Lauren.Ridge
Fixed string parsing when looking at parent cvar values
#jira UE-62301
Change 4275391 by Lauren.Ridge
Fix for resolutions increasing when swapping landscape/portrait
Change 4275606 by Lauren.Ridge
Moving all asset container access to PostActorCreated to avoid VR editor assets in cooks
#jira UE-57797
Change 4275807 by Lauren.Ridge
Duplicating color themes now dupllicates the color labels as well
#jira UE-60697
Change 4275989 by Lauren.Ridge
When selecting a node while the details panel is behind a different panel in the same dock tab, the details panel is brought forward
#jira UETOOL-1325
Change 4276146 by Lauren.Ridge
Fix for new texture sample nodes not taking the selected texture from the content browser as the starting value.
#jira UETOOL-1322
Change 4276412 by Lauren.Ridge
Assets that can be dragged into the material graph now indicate that with a checkmark
#jira UE-56024
Change 4279549 by Lauren.Ridge
Fixed recursion of calls through SetDesignerFlags to avoid double-recursion with many nested panels
#jira none
Change 4279894 by Lauren.Ridge
Adding check for RootWidget existing
Change 4279969 by Michael.Trepka
Updated FDesktopPlatformMac::FileDialogShared() to handle a case where no extensions were specified in FileTypes string
#jira UE-62421
Change 4280317 by Lauren.Ridge
Adding if WITH_EDITOR
Change 4280716 by Chris.Gagnon
PR #4979: UE-62795: Deprecate bAutoWrapText in TextBlock (Contributed by projectgheist)
Slightly modified, the base syncronize sets the autowrap value.
Change 4280847 by Lauren.Ridge
Single property setting changes will now also call OnModified delegate for their section
#jira UE-58276
Change 4280850 by Chris.Gagnon
Added early out and log if focus is attempted to be set when the window is suppost to be be disabled due to a modal window being up.
#jira UE-62742
Change 4280931 by Brandon.Schaefer
Linux: Use MallocCrash when hitting out of memory issues in BinnedAllocFromOS
#jira FORT-108267
Change 4281460 by Lauren.Ridge
Clearing focus on a variable once it is committed. Fixes assert on undo
#jira UE-61872
Change 4283706 by tim.gautier
QAGame: Adding HISM test map / assets
Change 4283980 by Michael.Trepka
Unshelved from pending changelist '4238012':
Xcode project generator improvements
- Per-project precompiled header that wraps UnrealEd.h with #ifdef __cplusplus to allow Xcode to compile the pch in ObjC mode. Later we could replace UnrealEd.h with some other header file for non-editor targets
- Moved commands that disable compile warnings from MacToolChain's GetCompileArguments_Global to ApplePlatformCompilerPreSetup.h. Thanks to this we can have all the Xcode recommended warnings enabled in the project, but still allow Clang to index our code without reporting warnings
- Few more minor changes to fix Xcode's project validation and indexing warnings
Also, unify compile warning flags across all Apple platforms.
#jira UE-47965, UE-44327
Change 4284062 by Michael.Trepka
Copy of CL 4222794 from 4.20
Fixed a crash at exit in Mac editor caused by an attempt to use MetalProfiler after deleting it
#jira none
Change 4284266 by Brandon.Schaefer
Linux: Fix deadlock in a file cache which could be locked in a crash handler
#jira UE-62808
Change 4284469 by Lauren.Ridge
Fix for material parameter node crashing
Change 4284541 by Lauren.Ridge
Blueprints inheriting from UWidget will now show up in the palette view even if they are not loaded.
#jira UE-59164
Change 4284542 by Michael.Trepka
Copy of CL 4222797
Fixed a problem with FMacPlatformMisc::NormalizePath allocating an autorelease pool during crash handling, which resulted in the OS killing the process before we spawn CrashReportClient. Now this function is identical to Linux version.
#jira UE-61779
Change 4285288 by Cody.Albert
Fixed crash when changing "Show Coalesced" setting in profiler
Change 4285483 by Chris.Gagnon
PR #4936: Duplicate widget functionality for UMG editor (Contributed by projectgheist)
Fixed up some variable names.
#jira UE-62528
Change 4287219 by Brandon.Schaefer
dump_syms: Replace inline file/line with their callsite over the inline location
Fix <name omitted> appearing as the names for the function
Disable CFI generation for Windows (Linux theres a command line). Speeds up symbol generation
#jira FORT-670
Change 4287247 by Brandon.Schaefer
BreakpadSymbolEncoder: If the file doesnt have a newline at EOF handle that as a seperate case
#jira none
Change 4287259 by Brandon.Schaefer
dump_syms: Build on centos7
#jira none
Change 4287269 by Brandon.Schaefer
Linux: Disable generating CFI info when running dump_syms
#jira none
Change 4287326 by Brandon.Schaefer
dump_syms: Update to disabling the CFI generation version
#jira none
Change 4287902 by Brandon.Schaefer
TestPAL: Add cases for testing inline callstacks
#jira UEENGQA-21414
Change 4288365 by Lauren.Ridge
PR #4422: Set default material parameter name (Contributed by projectgheist)
Change 4292002 by Brandon.Schaefer
Linux: If our default settings are empty help fill in the proper name
#jira UE-62910
Change 4292496 by Lauren.Ridge
Now all renamable nodes do name verification also
Change 4292532 by Lauren.Ridge
PR #4989: Add icons to folder context menu favorites (Contributed by projectgheist)
Change 4293043 by tim.gautier
QAGame: Added a panner to ML_Albedo
Change 4295326 by Richard.TalbotWatkin
- Updated MeshDescription attribute calls to fix deprecation warnings.
- Removed TMeshAttributeArraySet::AddArray because the functionality was already available as part of SetNumIndices.
- Renamed TMeshAttributeArraySet::InsertArray, RemoveArray to InsertIndex, RemoveIndex for naming convention consistency (these methods deal with attribute indices, not with arrays). Added support for them in other attribute classes, and made them virtual so they can be called as part of an AttributesView.
- Removed redundant code in FUSDStaticMeshImportState::AddPolygons, when determining the number of UVs in the mesh description.
Change 4295795 by Richard.TalbotWatkin
Corrected MAX_MESH_TEXTURE_COORDS_MD references.
Change 4297308 by Cody.Albert
Fixed bug with InputPreProcessorsHelper::Add not correctly adding input processors
Change 4297799 by Brandon.Schaefer
Linux: Dont assume DISPlAY=:0
#jira UE-63050
Change 4298150 by Brandon.Schaefer
dump_syms: This is rebuilding dump_sym changes from CL 4287219 for Mac
Replace inline file/line with their callsite over the inline location
Fix <name omitted> appearing as the names for the function
Disable CFI generation for Windows (Linux theres a command line). Speeds up symbol generation
Source code changes for dump_syms was changed at CL 4287219
#jira none
Change 4298369 by Brandon.Schaefer
dump_syms: Rebuild for Linux/Windows to fix a possible crash when missing debug_ranges in the debug section
Source changed in CL 4298150
#jira none
Change 4301952 by Lauren.Ridge
Fixing input labels on material function inputs
#jira UE-63077
Change 4302388 by Brandon.Schaefer
Linux: If we have a 0 LineNumber lets try to use to the previous Record.
Still an issue with non-virtual thunks reporting line number zero but it seems even windows skips these frames. GDB reports a different callsite that doesnt seem super related (possibly?) Nothing to do with thunking though.
#jira UE-62930
Change 4304835 by Alexis.Matte
Add imported framerate info to anime sequence
#jira UE-51302
Change 4307480 by Brandon.Schaefer
SDL2: Update to newer version hg-12121:4358e537000a
Fixed github PR #4844 as well (thanks tomix1024)
#jira UE-62783 UE-61369
Change 4307481 by Brandon.Schaefer
SDL2: Rebuild with the newer version hg-12121:4358e537000a
Fixed github PR #4844 as well (thanks tomix1024)
#jira UE-62783 UE-61369
Change 4308264 by Brandon.Schaefer
Linux: Make both DLLIMPORT the same value
#jira UE-61174
Change 4308640 by Matt.Kuhlenschmidt
Added a "report bug" menu entry to the help menu
#jira UE-63182
Change 4309508 by Brandon.Schaefer
nvTextureTools: Rebuild on Linux using our libc++ and not libstdc++
Move to the proper runtime depend location
#jira UE-54892 UE-61705
Change 4309554 by Brandon.Schaefer
SDL2: Add last missing folder
#jira none
Change 4309955 by Chris.Gagnon
PR #5017: UE-63105: Modify SGraphActionMenu::OnKeyDown to use a different branc. (Contributed by projectgheist)
Change 4311008 by Brandon.Schaefer
nvTextureTools: Actually remove libstdc++ from Linux build
#jira UE-54892
Change 4312195 by Alexis.Matte
- Fix the set range feature to always use the file sample rate so the range match what the user see in the DCC
- Also add some fbx file information to the import dialog
#jira UE-62504
Change 4315347 by Brandon.Schaefer
Linux: Disable XGE builds as it appears to be lower casing folders when the build platform is Windows
#jira UE-63296
Change 4318704 by Lauren.Ridge
Fix for crash on opening map built data
#jira UE-63301
Change 4319999 by Lauren.Ridge
Fix for crash in vr mode
#jira UE-63376
Change 4320144 by Chris.Gagnon
Fix for smoke content that set the hovered size different to the normal size on the UMG slider handle.
#jira UE-63367
Change 4327887 by Michael.Trepka
Disable nonportable-include-path warning in iOS toolchain to allow incorrect case in paths to headers passed using -include
#jira UE-63408
Change 4217622 by Brandon.Schaefer
Linux: Pass a command line argument to crash reporter to show or skip a user agreement popup
#jira none
Change 4312048 by Brandon.Schaefer
Linux: Dont disable ICU by default on Servers
#jira UE-59113
Change 4320173 by Chris.Gagnon
Fix for startup movie streamer on xbox not finishing.
#ROBOMERGE-OWNER: jason.bestimt
#ROBOMERGE-SOURCE: CL 4329255 in //UE4/Main/...
#ROBOMERGE-BOT: DEVVR (Main -> Dev-VR)
[CL 4329265 by chris gagnon in Dev-VR branch]
============================
MAJOR FEATURES & CHANGES
============================
Change 4112782 by Mitchell.Wilson
Resaving some cloth assets and fixing material compile warnings.
#jira UE-59946
Change 4112762 by Max.Chen
Sequence Recorder: Fix case where first recording is null but there are other valid recordings.
StopRecording wasn't getting called because the EndPIE delegate wasn't bound since ActorWorld was incorrectly set.
#jira UE-58688
Change 4112738 by Michael.Dupuis
#jira none:
Fixed Editor instance count, to only include placed instances.
Calling GenerateProceduralContent will no longer automatically remove the current content, as we might want to get the generation for something else than replacing existing data.
When deleting procedural foliage, we can now specify if we want to rebuild the tree.
Change 4112696 by Matt.Kuhlenschmidt
Prevent GC of material editor active preview expression
#jira UE-49777
Change 4112611 by Michael.Dupuis
Fixed Instance count when Alt+Dragging instance
#jira UE-59544: After the operation, reselect the instances, as the selection info into the buffer was lost
Change 4112536 by Thomas.Sarkanen
Fixed static analysis warning caused by CL 4109096
#jira none
Change 4112139 by Phillip.Kavan
Fix invalid child actor template cast in nativized code when the child actor class type is a converted Blueprint class asset.
- Mirrored from //UE4/Dev-Framework (4111638).
#jira UE-53747
Change 4112138 by Phillip.Kavan
Fix UHT warning about duplicating UFUNCTION() meta on nativized child Blueprint classes that override at least one BPIE method from the parent class.
- Mirrored from //UE4/Dev-Framework (4111613).
#jira UE-59182
Change 4111630 by Matt.Collins
#jira UE-59934
Rolling back the previous integration of CL 4080446
Change 4111526 by Mike.Beach
Guarding against bad settings pointers internal to Oculus.
#jira UE-59778
Change 4111525 by Daniel.Wright
UStaticMeshComponent::PostEditUndo now initializes its UStaticMesh's rendering resources. This is necessary for cases where the UStaticMesh is in the same transaction (PostEditUndo will be called AFTER the component). However, when calling UStaticMesh::InitResources we must use a FStaticMeshComponentRecreateRenderStateContext to safely handle any components using the UStaticMesh which are not in the transaction.
#jira UE-59333
Change 4111518 by Mike.Beach
Making sure to load the third party dll, and initing Oculus when we querry for Vulkan extensions. Otherwise we end up calling into the OVR plugin before the dll is loaded.
#jira UE-53643
Change 4111482 by Matt.Kuhlenschmidt
Fix blend sample context menu appering offset on high dpi monitors
#jira UE-59925
Change 4111362 by Ben.Marsh
Fix warnings building samples due to missing paths.
#jira
Change 4111299 by James.McNatton
Changed category of Virtual Camera plugin to Virtual Production #RNX #Jira UE-59404
Change 4111153 by Max.Chen
Sequencer: Fix dereferencing null pointer - CameraNode
#jira UE-59347
Change 4111143 by Matt.Collins
#jira UE-59934
CL 4107446 from Dev-Rendering.
Always force a commandbuffer submission during EndFrame.
Change 4111106 by Matt.Collins
#jira UERNDR-406
Bringing CL 4104051 from Dev-Rendering (//UE4/Dev-Rendering) to Release-4.20 (//UE4/Release-4.20)
---
Some fixes for semaphore handling.
Moved the completion handler to EndFrame (out of FlushFreeList())
FlushFreeList() attached a handler to the command buffer that signaled the semaphore. This can be called through RHIFlushResources which will cause a mismatched signal()
Added BeginFrame/EndFrame to the loop in AddModalWindows so the renderer gets the expected frame delimiters. Removed call to EndFrame from EndDrawingViewport.
---
Change 4111099 by Ben.Zeigler
#jira UE-59199 Add enum redirector for CVD_NormalVision, some values map to normal as they were removed
This is needed because that enum value would have been written into the EditorPerProjectSettings for anyone that modified editor style, and then cause mysterious cook warnings
Change 4111039 by Ben.Zeigler
#jira UE-59046 Fix it so trying to convert a soft path to hard object ref will throw error during async loading instead of silently failing
Change 4111013 by Steve.Robb
Fix for adding a new module to a project.
#jira UE-59770
Change 4110907 by Marc.Audy
Add required redirectorfor moving classes from TimeManagement to CoreUObject
#jira
Change 4110897 by Ben.Zeigler
#jira UE-57739 Don't crash if dropping a pin on a node causes the source pin to become invalid, just fail to connect instead
Change 4110868 by Ben.Zeigler
#jira UE-59920 Fix several issues where half-connected reroute nodes could break AutoCreateRefTerm and other node expansions if they happened to be late in the nodes array, by always expanding knot nodes first
Change 4110704 by Ben.Zeigler
#jira UE-56365 Fix k2 node tooltip code to not crash if the node is out of date due to slate updates being a tick behind
Change 4110686 by Andrew.Grant
Resaved to fix empty engine version warning
#jira UE-59695
Change 4110466 by Ben.Zeigler
#jira UE-59908 Change loading screen logo back to one with text baked in and clean up comments
Delete unused logo images
Change 4110418 by Ben.Zeigler
#jira UE-58025
Fix non editor builds
Change 4110258 by Max.Chen
Sequencer: Fix some erroneous cases in import fbx. In particular, this fixes an issue where importing an fbx onto one node would behave differently if there are multiple nodes in the fbx since it was ambiguous as to which fbx node to map onto the single node in sequencer.
- Changed import operation to be more explicit - when invoking through the general import fbx menu, all object bindings are mapped onto. When invoking through the context menu, only the selected object bindings are mapped onto.
- Added a user toggle to match by name only. The default is true.
- When importing onto a selected node, disable the creation of cameras.
- Don't set range bounds on imported keys since external packages, ie. maya, most likely only have 1 equivalent infinite section range.
- Remove any existing sections/keys when importing onto existing tracks.
#jira UE-59347
Change 4109923 by Michael.Dupuis
#jira UE-59904: Build tree post Serialize otherwise sometime foliage will be missing
Change 4109916 by mason.seay
Updated level blueprint so it Resets Ignore Look Input, which will prevent look input from being ignored if user triggers Ignore multiple times
#jira UE-29618
Change 4109849 by Michael.Dupuis
#jira none: Removed PRAGMA_ENABLE_OPTIMISATION
Change 4109835 by Lukasz.Furman
added OnTaskFinished call when behavior tree's subtree is deactivated
#jira UE-48353
Change 4109829 by Ben.Zeigler
#jira UE-59909 Add logic so the player cannot be hurt during ShieldNS anim notify by adding and removing a damage immune gameplay effect
Change 4109820 by Michael.Dupuis
#jira UE-59533: Update the LOD Distribution settings to fix the landscape popping
Change 4109813 by Michael.Dupuis
#jira UE-59533: Increase the max LOD0 distribution factor so on map with very small component, the value can be increase more than before.
Change 4109780 by Alexis.Matte
Add the tps file for the levenshtein distance algorithm
#jira none
Change 4109567 by Ben.Marsh
Fix incorrect console colors after a warning or error on Mac. Cannot assume that the default foreground color is gray.
#jira UE-55093
Change 4109542 by mason.seay
Updated timeline on BP
#jira UE-29618
Change 4109474 by Marc.Audy
Fix shadow variable warning
#jira UE-59895
Change 4109420 by Michael.Dupuis
#jira UE-58672 : Since it's possible the GetInstanceBasePtr() would not find the base id we hit, do not assume it must always be valid, and simply skip it instead of crashing.
Change 4109397 by Ben.Marsh
Speculative fix for exception reading UBT makefiles on Mono. Doesn't seem to be able to deserialize dictionaries with custom comparison functions correctly.
#jira UE-59222
Change 4109395 by Lauren.Ridge
Removing legacy uses of GetEditorIcon from UMG
#jira UE-59038
Change 4109390 by Zachary.Wilson
Adding alternative ground truth images for AMD on the planar reflection tests. ST_PR00, 03, 04, 05
#jira UE-59409
Change 4109373 by Michael.Dupuis
#jira UE-58664
Restrict the Paint/Unpaint Density to 1.0
Restrict the Foliage Density type to 10000
Restrict the Grass Density type to 1000
Fixed a NAN that could be generated when adding instances
These settings would still allow to paint ~2 millions instances with the biggest brush and max density per click.
Change 4109348 by Lauren.Ridge
Removing engine content that used a material attribute layers node inside a material function
#jira UE-55739
Change 4109296 by Lauren.Ridge
Fix for crash on adding OnClicked event to button in Widget BP
#jira UE-59846
Change 4109193 by Matt.Kuhlenschmidt
Fixed crash when construction scripts are rerun during the details panel calling posteditchange
#jira UE-59649
Change 4109096 by Thomas.Sarkanen
Fixed crash when running in standalone editor build using sub-instances that copy properties
Revamped change as the last one failed Fast Path automated tests. This change limits the property re-find only to cases where we are using sub-instances.
DestProperty serialization was always a bad idea, this is another artifact of the problem where the property persists but the class it belongs to gets trashed. Re-mapping the property by name to the correct outer fixes this for a minor startup cost.
#jira UE-59510 - Crash in Standalone When Sub Anim Instance Uses Exposed Variable
Change 4109078 by Ben.Marsh
Fix warnings building PlatformerGame due to incorrect include path.
#jira
Change 4109066 by Matt.Kuhlenschmidt
Prevent alt-f4 during slow tasks as it causes entry into the shutdown sequence at abnormal times
#jira UE-59866
Change 4109020 by Ben.Marsh
Fix client targets showing up in packaging menu for installed builds (which don't ship with client binaries).
(This implementation is a little suspect in general - there is no requirement that client targets are called "*Client.Target.cs", though that is typically the case.)
#jira UE-59641
Change 4108991 by Martin.Wilson
Fix crash when trying to extract transform from raw track with no track data.
#jira UE-58025
Change 4108987 by Martin.Wilson
Make sure rotations are normalized before creating blended transform
#jira UE-53971
Change 4108932 by Thomas.Sarkanen
Back out changelist 4108877
This was causing a 100% crash in an automated test
#jira none
Change 4108930 by Danny.Bouimad
Fixing testcase content #Jira UEQATC-405
Change 4108883 by Danny.Bouimad
Fixing Automated LodCurveLinkingTest1 #Jira UE-59763
Change 4108877 by Thomas.Sarkanen
Fixed crash when running in standalone editor build using sub-instances that copy properties
DestProperty serialization was always a bad idea, this is another artifact of the problem where the property persists but the class it belongs to gets trashed. Re-mapping the property by name to the correct outer fixes this for a minor startup cost.
#jira UE-59510 - Crash in Standalone When Sub Anim Instance Uses Exposed Variable
Change 4108874 by Thomas.Sarkanen
Fixed incorrect preview mesh being applied after retargeting
On first setup, the preview mesh was obtained using a legacy path that didnt use the skeleton fallback
#jira UE-59636 - When Retargeting Animation, Mesh Set as Preview that Shares Skeleton Isn't Kept
Change 4108834 by Thomas.Sarkanen
Pressing enter when selecting an object from a Blueprint node now works
#jira UE-58017 - Enter key does not set chosen asset on some blueprint nodes
Change 4108833 by Thomas.Sarkanen
Fixed crash caused by retargeting a skeleton when some of its animations are still open
Firstly we now auto-close all assets that use a skeleton when retergetting instead of popping up a dialog to suggest the user does it.
Secondly as a safety measure we dont re-use an animation editor if the persona toolkit's skeleton doesnt match.
#jira UE-58681 - [CrashReport] UE4Editor_Persona!FPersonaToolkit::SetAnimationAsset() [personatoolkit.cpp:211]
Change 4108808 by Dmitriy.Dyomin
Fixed: ARPG crashes on Vulkan PC and Android
#jira UE-59781
Change 4108719 by Max.Chen
Sequencer: Fix CIS
#jira UESEQ-355
Change 4108675 by Max.Chen
Sequencer: Added audio support to FCP XML import/export
#jira UESEQ-355
Change 4108674 by Max.Chen
Sequencer: Upon export, log warnings when filename format is not '{shot}'
#jira UESEQ-358
Change 4108673 by Max.Chen
Sequencer: Added 'Write FCPXML' option to Render Movie Settings dialog.
Changed track menu FCPXML export to get default resolution and frame rate from MovieSceneCaptureSettings.
#jira UESEQ-358
Change 4108418 by Mark.Satterthwaite
Fix Shipping iOS builds.
#jira UE-59883
Change 4108118 by Alexis.Matte
Make sure GIsImportingT3D is false when the scene importer open the blueprint editor. This flag force a load of UObject when we do FindObject, which in this case was forcing a load of all blueprints assets.
#jira UE-59854
#jira UE-57861
Change 4108059 by Ben.Marsh
Merge latest UGS fixes (up to 1.140) to 4.20 branch.
#jira
Change 4107719 by Mark.Satterthwaite
Duplicate 4107661:
Refactor the MetalRHI debugging tools to move away from reimplementing the Objective-C protocols to adding separate debugging classes. This makes it easier to build on/for future OSes without having to interpose new functionality we don't yet use.
#jira UE-59883
Change 4107443 by Lauren.Ridge
Fix for crash on connecting curve param node with no texture set
#jira UE-59880
Change 4107248 by Dan.Oconnor
Explicitly close floating Blueprint Debugger controls when the master tab is closed
#jira UE-59835
Change 4107137 by Jason.Bestimt
Removing ML Analytics Plugin to fix regressions
#JIRA: UE-59874, UE-59873
Change 4107125 by paulo.souza
#jira UE-59806 - ARPG - Goblin death not running all destroy logic
Change 4107113 by Phillip.Kavan
Allow the NativizedAssets plugin source to include monolithic engine header files without a compiler warning.
- Mirrored from //UE4/Dev-Framework (4081432).
#jira UE-59125
Change 4106736 by Jamie.Dale
Fixed content browser filter failing to match certain names if asset paths were omitted from the search
#jira UE-59849
Change 4106581 by Martin.Wilson
Fix issue with double ticking a reused animation instance on set skeletal mesh because of parallel evaluation.
#jira UE-54851
Change 4106475 by Jason.Bestimt
Fix for Lumin Linux dependency in a better way
#JIRA: CIS
Change 4106201 by Michael.Trepka
Don't allow invalid cursor clip rects when locking the cursor on Mac
#jira UE-59842
Change 4106188 by Jason.Bestimt
Wrapping Lumin call with PLATFORM_LUMIN
#JIRA: CIS
Change 4106179 by Michael.Dupuis
#jira UE-53944: Integrated guard from user to prevent crash if bad data is found in the view
#4714
Change 4106176 by Martin.Wilson
Fix for crash introduced in 4105998
#jira UE-56395
Change 4106103 by Ben.Marsh
UBT: Fix intellisense search paths not being set correctly for modules which are not built by default.
#jira
Change 4106081 by Marc.Audy
Fix shadow variable
#jira UE-59848
Change 4106078 by Jason.Bestimt
Fix for Linux trying to build MagicLeapAnalytics by swapping from Blacklist to Whitelist
#JIRA: none
Change 4106015 by Martin.Wilson
Make sure that animations that have transform curves are up to date on loading.
#4320
#jira UE-53392
Change 4106005 by Anthony.Bills
[Linux] Add support for terminfo2 to fix mono issue 6752, and rebuild .net 4.5's mscorlib.dll
#jira UE-59382
Change 4105998 by Martin.Wilson
Fix crash when re registering a skeletal mesh component with a post process instance that references invalid virtual bones
#Jira UE-56395
Change 4105962 by Jeff.Fisher
Duplicating for 4.20:
Change: 4097595 and 4104555
UE-59359 Mr Mesh Crash at startup
-Vulkan does not work correctly unless we fill in all of the vertex buffers. MRMesh now requires that via assert and MeshTrackerComponent fills in placeholder data as necessary.
-Also fixed the vr.MagicLeap.FakeMeshTrackerData cvar, it was missing the 'MagicLeap'.
#jira UE-59359
Change 4105952 by Ben.Marsh
Add an "IsTerminating" event to the record of active sessions. Should allow detecting whether RequestExit() was called before an abnormal shutdown was triggered.
#jira
Change 4105946 by Ben.Marsh
Disable debug info for IOS and TVOS in installed builds.
#jira UE-59816
Change 4105939 by Michael.Dupuis
#jira UE-59256: Properly take into account the scale of the instances when determining LOD transition
Added the possibility to see the Cluster tree bounds in the Show->Advanced Menu
Change 4105915 by Jamie.Dale
Implemented negative indexing for Python wrapped arrays
#jira UE-59841
Change 4105896 by Richard.Wallis
Another macOS TIS non-MainThread spam warning fix.
#jira UE-54623
Change 4105813 by Michael.Dupuis
#jira none: Prevent a possible crash if using world offset with a landscape without sub sections
Change 4105764 by Ben.Marsh
Add a check that a 2015 compiler exists under VS2015 toolchain directories - it may not have been installed.
#jira
Change 4105747 by Ben.Marsh
Fix detection of VS2017 toolchains that only have a 32-bit compiler for x64 (eg. VS2017 Express Desktop)
#jira UE-59838
Change 4105642 by Jason.Bestimt
Disabling Lumin Platform Editor modules on linux
#JIRA: UE-59543
Change 4105553 by Matt.Kuhlenschmidt
PR #4633: Fixed DPI awareness of two functions (Contributed by Temaran)
#jira UE-57283
Change 4105486 by Michael.Dupuis
#jira UE-58074: Include the HeightmapScaleBias in the DDC hash as component can share the same heightmap with different HeightmapScaleBias
Change 4105474 by Michael.Dupuis
#jira UE-57957: Fixed neightbord component extend used when component was not visible (so not custom data and generating neighbord)
#jira UE-58995:
Change 4105427 by Sorin.Gradinaru
UE-59698 Cannot load youtube URLs on Android
#jira UE-59698
#Android
#4.20
The native WebView cannot load HTML5 movies if the control's layout doesn't have the FILL_PARENT param
Change 4105308 by Mieszko.Zielinski
Merge of 4077826 over from Dev-Framework #UE4
#jira UE-59186
Change 4105050 by Ben.Marsh
Disable debug info for all target platforms in installed engine builds, to fix bloated install size. IOS and TVOS still have it enabled for now, due to errors when packaging.
#jira UE-59816
Change 4104584 by Mike.Beach
Mirroring CL 4103694 from Dev-VR
Making it so the HMD post-process pass properly fills out its RenderTargetDesc (so it doesn't rely on being the final output to have it set).
#jira UE-56511
Change 4104538 by Alexis.Matte
Fix crash when reloading a skeletal mesh actor with some vertex painting
#jira UE-57891
Change 4104534 by Mike.Beach
Mirroring CL 4090670/4094620 from Dev-VR
MR Calibration - Fixing an issue where the alignment models would disappear.
MR Calibration - Saving garbage mattes when exiting using escape.
#jira UEVR-24
Change 4104381 by Alexis.Matte
Fix a render thread crash when reimporting skeletal mesh
#jira UE-51935
Change 4104365 by Mike.Beach
Mirroring CL 4064903 from Dev-VR
Removing duplicate redirects, and resaving MRCalibration content so packaging works without failing on old package references.
#jira UE-58914
Change 4104341 by Alexis.Matte
Support non uniform scale scene transform for fbx skeletal mesh exporter
#jira UE-57733
Change 4104328 by Alexis.Matte
Fix a crash when re-importing an animation and we have to choose a skeleton for the anim sequence
#jira UE-58027
Change 4104318 by Phillip.Kavan
Monolithic engine header file exclusion from nativized Blueprint assets is now tied to a project setting.
- Mirrored from //UE4/Dev-Framework (4082035).
#jira UE-59125
Change 4104305 by Mike.Beach
Mirroring CL 4098493 from Dev-VR
Not forcing stereo scene capture target to resize (only intended for the main stereo scene buffer, as the depth buffer needs to match the color buffer on some platforms).
#jira UE-58953
Change 4104274 by Mike.Beach
Mirroring CL 4088048 from Dev-VR
Use the standardized tracking-to-world transform for world layer positioning on Oculus - handles both explicit and implicit HMD positioning.
#jira UE-59275
Change 4104259 by Mike.Beach
Mirroring CL 4084827/4085071 from Dev-VR
MRC - Adding CVar for overriding the tracking latency (makes development easier in the calibration process).
#jira UEVR-847
Change 4104246 by Mike.Beach
Mirroring CL 4084289 from Dev-VR
MR - Setting up the calibration save data so that we version it in the future (know that a lens param change is inbound after 4.20).
#jira UE-58187
Change 4104240 by Mike.Beach
Mirroring CL 4083160 from Dev-VR
Making it so the HMD post-process pass properly fills out its RenderTargetDesc (so it doesn't rely on being the final output to have it set).
#jira UE-56511
Change 4104233 by Mike.Beach
Mirroring CL 4081823 from Dev-VR
Loading Oculus controller models in the editor so that they get included in the cooking process (so that the MotionController components that indirectly uses these at runtime don't get dropped).
#jira UE-58190
Change 4104196 by Alexis.Matte
Unshelved from pending changelist '4075677':
Fix fbx scene re-import crash when the user re-import more then one time with some override material.
#jira UE-57937
Change 4104191 by Mike.Beach
Mirroring CL 4080389 from Dev-VR
Speculative fix/guard against live crash - trying to catch malformed model data. Logging helpful information to give us insight in the future.
#jira UE-57680
Change 4104177 by Mike.Beach
Mirroring CL 4080119 from Dev-VR
CIS fix - circumventing vs2015 errors/warnings
#jira UE-59326, UE-59324
Change 4104170 by Mike.Beach
Mirroring CL 4078631 from Dev-VR
Fixing MR Calibration so it scales the alignment model according the the capture's FOV (so they appear the same size across capture devices - leading to a homogenous experience).
Also moved the FOV override config setting to be a console command/setting (mrc.FovOverride) to help in testing this.
#jira UE-55499
Change 4104167 by Jostin.Bilyeu
Checking in needed changes to level TM-DualLobeSpec in order to correctly verify intended functionality of feature
#jira UE-29618
Change 4104158 by Peter.Sumanaseni
#jira
Change 4104057 by Wes.Hunt
Remove sending of UniqueAdvertisingId from AnalyticsET SessionStart events.
#jira UE-59790
SOURCE CL 4101872 in //UE4/Main/...
Change 4104031 by Dan.Oconnor
Update assert to handle subobjects nested in components
#jira UE-56422
Change 4103946 by Dan.Oconnor
No need to load AnimationBlueprintEditor so early
#jira UE-59669
Change 4103859 by Brandon.Schaefer
Vulkan on Linux does not allow debugging with markers
This is required for debugging wtih Render Doc or anything that uses VK debug markers
#jira none
Change 4103677 by Sorin.Gradinaru
UE-59052 Can't use touch to interact with Web Browser on iPhoneX
#jira UE-59052
#iOS
#4.20
from CL4077699 on Dev-Mobile
Fixed crash on some iOS 11 devices (addSubview before setting WebView's params)
Fixed unresponsive WebView on iPhone X (resize the parent with the same size as the child, the touch won't work if the parent is smaller)
Change 4103637 by Sorin.Gradinaru
UE-39451 Web browser widget causes app to crash when packaging for Distribution on Android
#UE-39451
#Android
#4.30
from CL 4067204 on Dev-Mobile
Adding a proguard exception for the WebViewControl.FrameUpdateInfo
Change 4103619 by Marc.Audy
Allow the default physics volume to be spawned during construction script execution if it needs to be lazily created
#jira UE-58875
Change 4103590 by mason.seay
Added Show Mouse Cursor
#jira UE-29618
Change 4103469 by paulo.souza
#jira UE-59807 - War Hammer weapon was missing Ability setting resulting in it not working correctly.
Change 4103459 by mason.seay
Updated maps so users can toggle UI-only input
#jira UE-29618
Change 4103423 by paulo.souza
#jira UE-59808 - Projectile abilities collision blocking on the camera trace
Change 4103280 by Jason.Bestimt
Fixing copyright in Lumin Plugins
#JIRA: 59192
Change 4103238 by JeanMichel.Dignard
Copied cl 4077328 from dev-enterprise
Fixed SoftObjectPtr/Paths becoming invalid when saving a new world since it's being moved from /Temp/Untitled to its own package.
#jira UEENT-1423
Change 4103138 by Richard.Wallis
Emergency Fix for bug I introduced in macOS UnrealFrontend crashing on open. FSlateMacMenu::PostInitStartup() gets called much much earler in the front end tool than in the editor. Unfortunatly the style set referenced is invalid as this call happens much earlier in the startup than with the game or the editor
1) Changed GetStyleSetName() - this is not imortant for us so it won't crash there again.
2) Added a check to see if the menu hasn't been setup correctly - if not initialize - this allows localization and and correct keyboard short cuts in non editor / game builds.
3) Keep Editor and Game menu startup behaviour the same as before.
#jira UE-59704
Change 4102958 by mason.seay
Test map update
#jira UE-29618
Change 4102847 by Marc.Audy
Try and find the full path name for default value of class parameters
#jira UE-59746
Change 4102449 by Ben.Marsh
PR #4700: This patch fixes a build failure that occurs on the very first build after adding new files with reflected types. (Contributed by junkimu)
#jira UE-58275
Change 4102431 by Ben.Marsh
UBT: Fix issue where overlapping circularly header dependencies would not be parsed correctly, preventing files not being rebuilt on header changes (noted where Clang detected an out of date PCH).
#jira UE-54979
Change 4102328 by Guillaume.Abadie
Cherry-pick 4102327: Fixes a bug in FTAAPassParameters::TopLeftCornerViewRects() that was mistakenly increasing input and output view sizes, causing DOF buffers misalignement for split screen & VR.
#jira none
Change 4102318 by Emil.Persson
Fix for dark metal (missing reflections) in Blueprint Editor. Duplicate of changelist 4099649.
#jira UE-59217
Change 4102310 by Dmitriy.Dyomin
Fixed: UMG element clipping does not work on Android with Mali GPUs
#jira UE-56058
Change 4101920 by Ben.Marsh
Don't bother tagging the BuildConfiguration schema on Linux and Mac; we only include it in the distribution for Visual Studio anyway.
#jira
Change 4101538 by Mark.Satterthwaite
Duplicate 4073368
Linear allocator for <2MB Managed buffers allocated in 4MB chunks - hopefully this reduces the total number of buffers and thus reduces the churn in the driver further. These should all be Volatile buffers meaning that we should eventually get semi-decent reuse of these buffers. Fixes some buffer alignment and sizing gotcha's along the way.
#jira NA
Change 4101500 by Mark.Satterthwaite
Duplicate 4098091
On Mac we can avoid continually reallocating the depth-fallback texture as we only need the largest size to hang around and we can use DontCare for Load & Store. On iOS due to driver bugs we need to match the size and either Clear or Load - but I think Clear should be faster. Should make FortGPUTestBed faster on the CPU.
#jira NA
Change 4101453 by Mark.Satterthwaite
Duplicate 4078874 & 4079396
Make LPV visualisation work on macOS to aid debugging.
#jira UE-58937
Export the constant-buffer bindings that are actually used by Metal shaders to prevent overwriting SRVs & UAVs with unused uniform-buffer data.
#jira UE-58937
Change 4101448 by Max.Chen
Sequencer: Fix uninitialized default completion mode
#jira UE-58335
Change 4101417 by Sam.Deiter
#JIRA #RB UEDOC-7656 - Fixed an issue with ARPG not building the loading screen CPP file.
Change 4101412 by Mark.Satterthwaite
Duplicate 4075868
Metal Vega drivers in 10.13.5 fix blitting with non-zero offsets and we should be using the same buffer blitting path on 2013 Mac Pro's now that we aren't paying an exorbitant cost for doing so.
#jira N/A
Change 4101393 by Mark.Satterthwaite
Fixed a mistake I let slip through in 3934147 that will potentially cause slight miscompilation of SP_METAL.
#jira N/A
Change 4101390 by Marc.Audy
Placed Editor Utility Base once again ticks in the editor as intended
#jira UE-59743
Change 4101367 by Brandon.Schaefer
Avoid printing when in a signal handler.
Put that off until the end
#jira UE-36663
Change 4101362 by Mark.Satterthwaite
Duplicate 4091485
PR - Fixed potential memory leak.
#4751
#jira UE-59490
Change 4101349 by Brandon.Schaefer
VHACD Needs to be recompiled
#jira UE-59506
Change 4101335 by Brandon.Schaefer
Cache files that are invalid or the wrong case sensitivity
#jira UE-58250
Change 4101325 by Dan.Oconnor
SA fix, remove unneeded null check
#jira UE-46834
Change 4101278 by Brandon.Schaefer
Set our location to Linux/Mac GenerateProject.sh if we are not running from that location
#jira UE-59127, UE-57928
Change 4101219 by Brandon.Schaefer
If RunUAT gets a signal while running mono bring mono down as well
#jira UE-56041
Change 4101169 by Dan.Oconnor
Mirror 4094297 from Dev-Framework
Mark blueprint created properties as RF_LoadCompleted to prevent the linker from finding them and overwriting them
#jira UE-59642
Change 4101157 by Sam.Deiter
#jira UEDOC-7655 Updating these images to reflect the name of the project and look like the other loading screens.
Change 4101132 by Jamie.Dale
Fixed some places that were running asset registry queries inside a loop and causing performance issues
#jira UE-59766
Change 4101125 by Jamie.Dale
Added IAssetRegistry::GetAssetsByTags to optimize tag look-up when you can have several potential values
#jira UE-59766
Change 4101102 by Dan.Oconnor
Mirror 4090824 from Dev-Framework
Add abillity to insert pins before or after a target pin for Sequence nodes via the context menu
#jira UE-59530
Change 4101017 by Brandon.Schaefer
Add a pop up message box for Linux to check if we want to or not submit crash report data
#jira UE-59617
Change 4100961 by Michael.Trepka
Updated Mac VHACD libs
#jira UE-59506
Change 4100703 by Dan.Oconnor
Mirror 4090523 from Dev-Framework
Allow user to close Blueprint Debugger while at a breakpoint, origin of this behavior was 1148085 and the original issue no longer seems to happen. Also fix mismatch between tab name and context menu entry
#jira UE-59526
Change 4100697 by Dan.Oconnor
Merge 4083850 from Dev-Framework
Prevent GameplayAbilitiesEditor from creating FBluerpintActionDatabase when not neccessary, improve performance of FBlueprintActionDatabase::RegisterAllNodeAction
#jira UE-59036
Change 4100687 by Dan.Oconnor
Mirror 4086666 from Dev-Framework
Fix regression due to 'Step Over' fixes - we could pause VM execution when trying to end a Play-in-Editor or Simulated-in-Editor session
#jira UE-58916
Change 4100658 by Jostin.Bilyeu
Checking in new level TM-DuelLobeSpec and corresponding assets needed to verify Duel Lobe Specularity
#jira UE-29618
Change 4100600 by Max.Chen
Sequencer: Fix uninitialized default completion mode
#jira UE-58335
Change 4100576 by Dan.Oconnor
Mirror 4081417 from Dev-Framework
Enum literals are now more similar to byte literals, which makes them safer to pass by reference
#jira UE-58473
Change 4100559 by Dan.Oconnor
Mirror 4081153 from Dev-Framework
Watch Point Viewer should not be a nomad tab, is owned by the Blueprint Debugger tab manager
#jira UE-59313
Change 4100540 by Dan.Oconnor
Mirror 4078822 from Dev-Framework
Continue trying to finish reinstancing when instances of the old class are being async loaded
#jira UE-58123
Change 4100527 by Dan.Oconnor
Mirror 4092349 from Dev-Framework
Speculative fix for shutdown crash, avoid use of LoadModule in DataValidator ShutdownModule and delete delegates registered in another module when BlueprintGraph shuts down
#jira UE-57763
Change 4100478 by Mike.Zyracki
weighted, non-weighted fix typo fix for issue found by AndrewP
#jira UE-58573
Change 4100445 by Mike.Zyracki
Fix for build warning, order of initialization.
#jira UE-58712
#trivial
Change 4100438 by Dan.Oconnor
Mirror 4083455 from Dev-Framework
Reduce use of template nodes - a template node was causing an ensure when asset reload code attempted to fix it up
#jira UE-46834
Change 4100374 by Mike.Zyracki
Fix for bad Camera Rotation Imported From Maya
Main issue was that we don't support RotationOrders that aren't XYZ.
We had some code to zero out other part's of the FBX transform pipeline but it wasn't setting the Rotation Order correctly and was also based upon old documentation.
Currently recommendation is to always just zero everything out.
Finally had to use ResetPivotSetAndConvertAnimation since there appears to be a bug with ConvertPivotAnimationRecursive into the correct space.
#jira UE-59116
Change 4100310 by Jamie.Dale
Fixed ExecutePythonScript failing when passing file arguments
#jira none
Change 4100305 by Mike.Zyracki
Fix for performance issues with motion trails.
Found that the main issue was the GetRefTM call. Refactored the code so that we only call that once per tick, instead of up to 4 times per tick. Also we cache the calculation of the key positions, so we don't need to calculate them again when calculating keys. Finally the GetRefTM call was recursive which was a decent hint, so we cache out it's parent's first and just get the transform's linearly.
Also we don't select parents or children to show their trails also, this seemed buggy and possibly very very slow.
#jira UE-58712
Change 4100290 by Ben.Marsh
Prevent schema being added as a build product twice.
#jira UE-59757
Change 4100259 by Jeff.Fisher
Duplicating in Release-4.20:
Change: 4087159
UE-58249 Late update has FP precision issues on PSVR
-In lateupdate the TranslatedViewMatrix and its inverse were being calculated from the ViewMatrix, by subtracting the PreViewTranslation. This doesn't work because the translation numerical innacuracy is already in the ViewMatrix.
-I also rearanged the UpdateViewMatrix code some to make it look more like the FViewMatrix constructor code that sets this up, just to make it easier to spot the difference.
#review-4087096
#jira UE-58249
Files:
//UE4/Dev-VR/Engine/Source/Runtime/Engine/Private/SceneView.cpp#71
Change 4100170 by Brandon.Schaefer
Need dump_syms and BreakpadSymbolEncoder in installed builds
#jira UE-59500
Change 4100070 by Richard.Wallis
Speculative fix for crash in macOS AppKit NSPersistentUIManager. Disable NSWindow application resume feature per window - we are not using it anyway. OS system may still be called but hopefully this reduces the amount of work it is doing. There still seems to be some generic data getting written however.
There is also an undocumented *NSDisablePersistence* plist key. Using this plist key completely stops any data getting written by the OS window resume feature. This CL does NOT use this because it's undocumented but maybe an option for the future.
#jira UE-52294
Change 4099999 by James.McNatton
Removed the disconnect button in the VirtualCamera plugin and cleaned up redirectors in VCam Widgets folder #jira UE-58032 #rb none
Change 4099996 by Ben.Marsh
Build: Merge changes to support AutoSDKs on Mac.
#jira UE-59574
Change 4099991 by Jamie.Dale
Updated wrapped enums to be more consistent with native Python enums
- Wrapped enums now generate values that are instances of the enum type itself, containing a name and value field (like native Python enums).
- Wrapped enums are now strongly typed and do not allow implicit conversion from numbers (explicit casting is available, but throws if the value is unknown).
- Wrapped enum entries may be compared against numbers (even numbers that don't have valid values) via the == and != operators (like IntEnum in Python).
- Wrapped enums may now be iterated (like native Python enums).
- Wrapped enums now return a length based on their number of entries (like native Python enums).
- ScriptName meta-data can now be used with enum entries.
#jira none
Change 4099973 by Mitchell.Wilson
Removing some more content that got duplicated into the main project from the virtualcamera plugin content.
#jira UE-59744
Change 4099913 by Jamie.Dale
Fixed some places that were calling LoadModuleChecked during shutdown
#jira UE-59482
Change 4099905 by Jamie.Dale
Fixed InitializeAvailableCultures missing some languages
#jira UE-59349
Change 4099879 by Jamie.Dale
Fixed a crash when a Blueprint with variable watches was destroyed
#jira UE-59117
Change 4099874 by Mitchell.Wilson
Removing some unused files from the Content directory. Updating defaultengine.ini with remote session channel info.
#jira UE-59745 UE-59744
Change 4099860 by Benn.Gallagher
Fixed clothing data binding state becomming mismatched after a reimport over multiple LODs, moved the unbind and rebind steps out of the inner import loop to be handled before and after the total reimport.
#jira UE-57337
Change 4099819 by Richard.Wallis
Fix for Timed Notifies scrub incorrectly on timeline on Mac. This is also an issue if running in Hi DPI on windows.
#jira UE-55678
Change 4099808 by Jamie.Dale
Fixed crash when content hot-reloading the build data for the currently loaded world
#jira UE-59163
Change 4099773 by Jamie.Dale
Fixed crash after attempting to load a package that is too new
#jira UE-58121
Change 4099759 by Jamie.Dale
Fixed material editor crash if reloading a texture used by the material
#jira UE-57762
Change 4099744 by Jamie.Dale
Fixed placeholder string table entries being considered identical as their entry may appear in the future
#jira UE-58987
Change 4099735 by Jurre.deBaare
Crash importing specific Alembic file
#fix Additional fix to triangulation vs indexing of vertex attributes, this fixes the crash but also normal issues seen before
#misc default constructor for FTrackRenderData which could cause jittering/invisible geometry
#jira UE-59095
Change 4099612 by Michael.Trepka
Reverted change that delays crash reporting initialization for CEF on Mac
#jira UE-57378
Change 4099564 by Guillaume.Abadie
Cherry-pick 4075014: Works arround HLSLCC's issue with InterlockedOr in DOF's reduce pass.
#jira none
Change 4099557 by Guillaume.Abadie
Cherry-pick 4074767: Fixes DOF's scattered bokeh changing of intensity dynamic resolution + TAAU.
#jira none
Change 4099549 by Guillaume.Abadie
Cherry-pick 4073050: Whitelists vulkan for DOF's R11G11B10 optimisation and increase to 4 gathering on consoles.
#jira none
Change 4099544 by Guillaume.Abadie
Cherry-pick 4073044: PR #4681: UE-58051: Scene Capture 2D: additive mode not working in 4.19 (Contributed by lion03)
#jira UE-58051
Change 4099540 by Richard.Wallis
Fix for PIE HighDPI touch location.
#jira UE-59015
Change 4099516 by Richard.Wallis
speculative fix for FSlateMacMenu::UpdateMenu() crashes. I've not been able to reproduce this. All the crash call stacks seem to be at shutdown, maybe with the save changes dialogue that would appear after modifications then a CMD+Q. I can get similar behaviour by adjusting when the FMacMenu adds and removes itself to the GCachedMenuState map. This fix changes the access pattern to the map from operator[] (which uses a FindChecked underneath and is the cause of this crash/assert) to a FindRef then checking for a valid node.
Since these crashes are at shutdown I think this is ok to do and I've tested with this fix in place, randomly not adding those items to GCachedMenuState object during editor operation and it now survives this and recovers if you then reenable the adding of the items.
My best guess as to the cause is that the defered update event on shutdown is happenning way after the FMacMenu dealloc has been called and so the GCachedMenuState is empty by then.
#jira UE-57012
Change 4099511 by Max.Chen
Fix CIS
#jira UE-59739
Change 4099486 by Richard.Wallis
Speculative fix for crash in FMacWindow::ApplySizeAndModeChanges(). I had seen a crash in here while working on UE-46999 (fix for that submitted in CL 4016062) due to the window handle becoming nil mid way through the ApplySizeAndModeChanges() function then a deref'd. This CL adds extra null pointer protection to make sure we check the validity of the WindowHandle after calls to UpdateFullScreenState().
#jira UE-55071
Change 4099392 by Andrew.Rodham
Sequencer: Fixed RootToSequence transform not being used when compiling segments with "Evaluate Sub Sequences in Isolation" enabled
#jira UE-59138
Change 4099386 by Ben.Marsh
Include the BuildConfiguration.Schema.xsd file in the installed engine build, and don't write it out when running in an installed build.
#jira UE-58692
Change 4099382 by Benn.Gallagher
Fixed crash when switching clothing meshes when clothing LOD0 is unbound on a clothing data object.
#jira UE-55780
Change 4099363 by Jason.Bestimt
Fix for HMD errors
#jira UEVR-1191
Change 4099307 by Richard.Wallis
Clone of CL 4077664: Fix for Mac crash from crash report: [CrashReport] UE4Editor-Renderer.dylib!void FForwardLightingParameters::Set<FRHICommandList, FRHIPixelShader*>(). Reflection uniform buffer is NULL when shader parameter is bound - fails checkSlow(!Parameter.IsBound() || UniformBufferRHI); in SetUniformBufferParameter().
#jira UE-51698
Change 4099289 by Richard.Wallis
Clone of CL 4059587: Fix for Sequencer window opening behind Main Window. FLevelSequenceEditorToolkit::Initialize() Closes and reopens the world outliner after adding the Sequencer window. On Mac this makes the world outliner / main window move back in front of the sequencer window. This change swaps around those operations. Reopen the world outliner then add the sequencer window. Outliner info still changes it's visible data as before.
Tested with World Outliner docked and undocked.
#jira UE-55280
Change 4099279 by Richard.Wallis
Fix for crash in Mac editor copying unusual characters in the output log.
Current operation is unsafe. String Length, number of bytes and code units are not always interchangeable in this way - use FString as that is the target type and does the right thing.
#jira UE-57774
Change 4099256 by Richard.Wallis
Fix for menu options not updating immediatly after creating or removing collision on Mac. We set the bChachedMacMenuStateNeedsUpdate when a menu is opening, key up and mouse up. However these can be missed on a mouse menu selection (mouse up doesn't cover this case). This change makes sure that the menu cache updates after a menu item execute operation has been called.
#jira UE-57049
Change 4098972 by Max.Chen
Sequencer: Modify the section when toggling the bounded range. This fixes an issue where the evaluation would be incorrect because the template wouldn't regenerate when toggling the section bounds.
#jira UE-59726
Change 4098967 by Mike.Zyracki
Turn off turning off optimization for geometry sequencer tracks.
#trivial
#jira UESEQ-372
Change 4098942 by Max.Chen
Fix CIS
#jira UESEQ-372
Change 4098906 by Max.Chen
Fix CIS
#jira UESEQ-372
Change 4098881 by Max.Chen
Fix CIS
#jira UESEQ-372
Change 4098667 by Marcus.Wassmer
Duplicate 4098665. Fix d3ddebug error on launch
#jira UE-59693
Change 4098542 by Mike.Zyracki
Geometry Cache Sequencer Support for 4.20
#jira UESEQ-372
Change 4098373 by Jason.Bestimt
Misc Vulkan/Lumin fixes from Dev-VR
CL 4071730, 4077567, 4077947, 4078460, 4078467, 4081212, 4081315, 4081648, 4083015
#JIRA: UE-59722
Change 4098334 by Ethan.Geller
[Release 4.20] #jira UE-54812 fix up include path.
Change 4098286 by Matt.Kuhlenschmidt
Fix slate resources being destroyed when a dynamic image brush is destoyed even if the resource is shared.
#jira UE-55792
Change 4098284 by Brandon.Schaefer
Missing header in Monolithic builds
Fixed indent issues, was using spaces vs tabs
#jira UE-59705
Change 4098247 by Michael.Trepka
Fixed a crash in FMacApplication::ProcessMouseUpEvent()
#jira UE-57859
Change 4098219 by Matt.Hoffman
Linux CIS Fixes for TOptional
#trivial
#jira None
Change 4098209 by Matt.Kuhlenschmidt
Disable "restart detection" reimport test until we can reproduce the issue. Its not detecting a legit issue
#jira UE-59710
Change 4098132 by Ben.Marsh
Add "Nuget Package Manager" to the list of required components for compiling the engine.
#jira UE-59376
Change 4098110 by Ben.Marsh
Fix missing DLL errors when compiling for Win32 with the VC++ 14.14 toolchain.
#jira UE-59150
Change 4098088 by Matt.Kuhlenschmidt
Fix ensure starting tutorials in any editor project
#jira UE-59714
Change 4098011 by Ben.Marsh
Fix editor targets not being rebuilt when packaging from an installed engine build.
#jira UE-58652
Change 4098006 by Matt.Hoffman
Deleting keys, undoing the deletion, selecting them and then redoing the deletion no longer causes a crash in Sequencer/UMG's Curve Editors. KeyHandleLookupTables were not being serialized so when Undo/Redo transactions happened their map of the key handles would not be restored. This caused a mis-match in the data (the map contained more entries than actual data) so the map would falsely report a valid index when there was not one. Graph Editor selections are not sync'd with the Undo/Redo system currently so redoing a deletion after selecting keys would leave you in a state where you tried to request now out of bounds keys on the next Tick to update the UI.
#jira UE-58270
Change 4097995 by Ryan.Vance
#jira UEVR-1190
Disable rhi thread when running with vulkan on oculus android platforms.
Change 4097981 by Ben.Marsh
Ignore private include paths for any precompiled modules. Prevents warnings when they are stripped out from an installed engine build.
#jira
Change 4097963 by Ben.Marsh
Write the exception callstack to the UBT log when thrown reading a makefile.
#jira UE-59222
Change 4097940 by Ben.Marsh
Prevent source folder being added as a private include path if it does not exist.
#jira UE-59145
Change 4097927 by Ethan.Geller
[Release-4.20] #jira UE-54812 Bring fixes over for Set Mic Threshold issue in binary builds. #rb aaron.mcleran
Change 4097905 by Krzysztof.Narkowicz
Added dual specular for subsurface profile shading model. It is controlled by parameters inside subsurface profile.
#jira UE-59709
Change 4097898 by Ryan.Vance
#jira UEVR-1191
Ensure we prefer VK_PRESENT_MODE_MAILBOX_KHR or VK_PRESENT_MODE_IMMEDIATE_KHR over VK_PRESENT_MODE_FIFO_KHR when creating a swap chain when running inVRr. VSync will interfere with compositor cadence.
Change 4097855 by Ben.Marsh
Move checks for unique field names behind an additional define, to avoid performance hit when compiling blueprints.
#jira UE-58593
Change 4097850 by Ben.Marsh
Fix UE4Game compile errors.
#jira UE-58593
Change 4097849 by Marcin.Undak
Vulkan: fix missing debug markers (TCHAR_TO_ANSI lifetime issues)
- Fixed by BrandonS.
#jira UE-59484
(merged from Dev-Console)
Change 4097844 by Ben.Marsh
TBA: Use the trivially relocatable allocator with structured archives, to reduce time taken allocating memory in the constructor.
#jira UE-58593
Change 4097840 by Ben.Marsh
Add a new allocator (TNonRelocatableInlineAllocator) which eliminates conditional logic from GetAllocation(), at the expense of not being trivially relocatable. This provides a significant performance increase for allocators that are dereferenced frequently, but prevents instances of it being stored inside other allocators (which are expected to be trivially relocatable by default).
#jira UE-58593
Change 4097831 by Ben.Marsh
TBA: Add a fast path for serializing to binary archives that don't require callbacks when leaving slots.
#jira UE-58593
Change 4097825 by Marcin.Undak
UAT: don't produce .pak file while cooking on the fly (merged from Dev-Console)
#jira UE-58923
Change 4097783 by Ethan.Geller
[Release-4.20] #jira UE-58004 fix AudioMixer checks in AudioMixerBlueprintLibary, which solves crash when calling recording BP functions. #rb Aaron.McLeran
Change 4097767 by Matt.Kuhlenschmidt
Fix crash processing mainframe keybindings during slow tasks
#jira UE-55765
Change 4097745 by Ben.Marsh
Fixes to UpdateCopyright for latest source.
#jira
Change 4097743 by mason.seay
Test map for Virtual Camera Focus testing
#jira UE-29618
Change 4097723 by Matt.Kuhlenschmidt
Fix crash when importing assets in a folder containing an invalid character for a package name
#jira UE-59166,UE-44071
Change 4097713 by Max.Chen
Sequencer: Fix missing buttons in the particle toggle track.
Fixed CreateKeyEditor and make the the channel handles reflect the channel's inheritance hierarchy.
#jira UE-59542
Change 4097683 by Max.Chen
Sequencer Scripting: Move to "Scripting" category alongside Python Script Plugin
#jira UE-59568
Change 4097681 by Krzysztof.Narkowicz
Missing file for CL 4097655: "Added subsurface profile for eye shading model."
#jira UE-59708
Change 4097655 by Krzysztof.Narkowicz
Added subsurface profile for eye shading model.
#jira UE-59708
Change 4097634 by Max.Chen
Sequencer: Add checks for valid sequencer.
#jira UE-59287
Change 4097627 by Max.Chen
Sequencer: Fix for crash OnKeySelected and GetAutoSizeRange
#jira UE-58343
Change 4097625 by Max.Chen
Sequence Recorder: Fix StopRecording() condition when there is an actor recording that doesn't have a valid actor to record. Fix bool recorder not using bool channels.
#jira UE-58688
Change 4097620 by Max.Chen
Actor Sequence: Fix crash on compiling blueprint with deleted actor sequence
#jira UE-53186
#jira UE-59664
Change 4097616 by Max.Chen
Text Render Component: Fix crash on shutdown.
#jira UE-58116
Change 4097607 by Max.Chen
Sequencer: Use non-throttled spin box for numeric key editor
#jira UE-59219
Change 4097606 by Max.Chen
Sequencer: Check for a valid segment ID in EvaluateStatic
#jira UE-57596
Change 4097538 by Marc.Audy
PR #4755: Fix minor typo in comment (Contributed by Marenz)
#jira UE-59671
Change 4097518 by Marcin.Undak
UBT: fix for platforms overriding project generation (merge from Dev-Console)
#jira UE-59485
Change 4097417 by Benn.Gallagher
Fixed barycentric computation case causing a check. Should really just output an invalid sentinel value. Warns about failures but no longer crashes.
#jira UE-57097
Change 4097407 by Jason.Bestimt
Changing MLSDK missing callback to launch MagicLeap URL
#JIRA: UE-58631
Change 4097404 by Jason.Bestimt
Proper fix for UE-58864 (crash for Android derived platforms in Launch on menu)
#JIRA: UE-58864
Change 4097296 by Matt.Kuhlenschmidt
Fix rotation widget no longer correctly displaying rotation label while rotating in high dpi
#jira UE-58983
Change 4097284 by Matt.Kuhlenschmidt
PR #4650: Git plugin: fix crash on commit error (Contributed by SRombauts)
#jira UE-57562
Change 4097275 by Matt.Kuhlenschmidt
Fix crash if slate shuts down while a drag drop operation is in progress
#jira UE-58888
Change 4097261 by Matt.Kuhlenschmidt
Undo //UE4/Release-4.20/Engine/Source/Runtime/Slate/Private/Framework/Application/... changelist 4097249
#jira 0
Change 4097249 by Matt.Kuhlenschmidt
Fix crash if slate shuts down while a drag drop operation is in progress
#jira UE-58888
Change 4097165 by Nick.Shin
#jira UE-58441 HTML5 package crashes on several key combinations: uncaught exception: ASM_CONSTS
Change 4097163 by Nick.Shin
#jira UE-58423 HTML5 Quicklaunch through UnrealFrontEnd fails on Stage Command: Error: System.NullReferenceExeception
Change 4096984 by Ben.Marsh
Merging changes to //UE4/Main after 4.20 stream was created.
#jira
Change 4096873 by Ben.Marsh
Fix compile errors for UE4Editor when Oodle SDK is not available.
#jira
Change 4095992 by Ben.Marsh
Update stream for analytics.
#robomerge none
#jira
Change 4111924 by Ben.Marsh
Force Win32/Win64 game targets in the installed engine build to be compiled with VS2015, to fix missing symbols linking object files built with VS2017 with VS0215 MSVCRT.
#jira UE-59891
Change 4106160 by Ben.Marsh
UBT: Fix intermittent PDB errors when compiling with ParallelExecutor, caused by MSPDBSRV.EXE instances being terminated while generating multiple PDBs in parallel.
#jira UE-59691
Change 4101702 by Mark.Satterthwaite
Duplicate 4098660 & 4101604
Restore the MacGraphicsSwitching plugin removed in 3212253 and begin refactoring it to support switching the Editor between Metal GPUs - primarily this is of benefit to those with eGPUs.
- Changing the GPU will ask you to restart.
- Fixes a bug where 27" iMacs report an Intel GPU even though it is physically disabled.
Add support for Metal device notiications and amend the MacGraphicsSwitching plugin to use it to update when GPUs are added or removed.
#jira UERNDR-404
Change 4101598 by Andrew.Grant
Changed RemoteSession background to something more generic.
#jira UE-59062
Change 4101553 by Mark.Satterthwaite
Duplicate 4072923 & 4081236 & 4082081 & 4084046 & 4084647
- Fixes LLM double-counting in MetalRHI.
- MetalProfiler improvements.
#jira NA
Change 4099406 by Ben.Marsh
Disable building IOS in installed builds on Windows by default. We don't support this on the cross-compile toolchain.
#jira UE-57801
[CL 4112874 by jason bestimt in Dev-VR branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3808185 by Cody.Albert
Added missing calls to FEditorViewportClient::AddReferencedObjects in overrides
Change 3809824 by Michael.Trepka
Improved the way we generate groups in Xcode project's source code navigator. They are now sorted alphabetically and have correct paths so Xcode no longer displays them in red. Also, added __INTELLISENSE__ to preprocessor definitions for indexing to improve indexing without game header files generated.
Change 3810089 by Jamie.Dale
Fixed PO files failing to import translations containing only whitespace
Change 3811281 by Matt.Kuhlenschmidt
PR #4331: Toggle SIE shortcut only in PIE (Contributed by projectgheist)
Change 3813031 by Matt.Kuhlenschmidt
Fix undocked tabs not dropping at users mouse location
#jira UE-53427
Change 3813361 by Brandon.Schaefer
Print what SDL video driver we are using
Change 3818430 by Matt.Kuhlenschmidt
PR #4365: Incorrect font name and forgotten undef (Contributed by projectgheist)
Change 3818432 by Matt.Kuhlenschmidt
PR #4366: Asset Color Strip updates correct on drag and drop (Contributed by projectgheist)
Change 3818436 by Matt.Kuhlenschmidt
PR #4367: Improved logging (Contributed by projectgheist)
Change 3819886 by Matt.Kuhlenschmidt
Add a way to optionally disable the warning about referenced actors being moved to other levels. Useful for bulk actor moves via script
Change 3819888 by Matt.Kuhlenschmidt
Avoid crashing when a window size becomes too large to render. Instead just ensure and clamp to the maximum allowed size. Avoids crashes where the screen dimensions are saved with super large numbers for unknown reasons
Change 3821773 by Brandon.Schaefer
Fix crash when importing to level
#jira UE-31573
Change 3821892 by Jamie.Dale
Improved the localized asset cooking so that it only cooks L10N variants if their source asset is cooked
#jira UE-53010
Change 3823714 by Christina.TempelaarL
#jira UE-52179 added support for grayscale PSD files
Change 3826805 by Christina.TempelaarL
#jira UE-49636 SceneCaptureComponent2D hidden actor and show only actors disabled in blueprints
#jira UE-53445 SceneCaptureComponent2D hidden actors always disabled in details layout
Change 3828444 by Anthony.Bills
Add LXC container script for building third party libraries.
The intention is that this should become the only way to rebuild the third party libraries that require system dependencies not included in the cross-compile toolchain and also to rebuild the toolchains. Other third party libraries without any system dependencies could be rebuilt via the cross-compile toolchains/UBT.
This script has been tested running on CentOS 7 and Ubuntu 17.10.
Buy default the x86 and x86_64 builds will be built against a CentOS 6 container (and targeting glibc 1.12) and the aarch64 and armhf builds will use an Ubuntu Ubuntu Trusty (14.04) but this is not yet complete.
Change 3828754 by Brandon.Schaefer
Linux: Fix gamepad thumbstick clicks not registering (github #4209 thanks J??rn M??ller)
#jira UE-45722
#review-3828733 Arciel.Rekman
Change 3830414 by Brandon.Schaefer
Remove circular referencing to a parent window. Move to use AddSP vs AddRaw as well to be safe manually remove ourselves from the selection event delegate list due to Linux pending deletion of windows.
Looks like this should fix UE-28322 as well which I've removed the work around placed in for that.
#jira UE-53918
#review @michael.trepka, @matt.kuhlenschmidt, @arciel.rekman
Change 3830916 by Brandon.Schaefer
More verbose message about missing VK extensions (from Marcin Undak)
#review-3830710 marcin.undak, arciel.rekman
Change 3831339 by Brandon.Schaefer
Default to as-needed for debug mode
#jira none
#review-3830658 Arciel.Rekman
Change 3833102 by Jamie.Dale
Re-added warning for duplicate package localization IDs when gathering asset localization
Change 3834600 by Jamie.Dale
Optimized asset registry filter intersection
Change 3838024 by Brandon.Schaefer
Remove tracking of CLion/CMake build files (from github #4346 thanks reapazor!)
#jira UE-53551
#review-3835803 arciel.rekman
Change 3839969 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
Change 3840049 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840071 by Matt.Kuhlenschmidt
- Combine some shader params for slate in order to reduce overhead setting uniform buffers
- Added better stats for slate draw call rendering
- cleaned up huge lambda in Slate rendering main function so we can read the main slate rendering function again
Change 3840291 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840840 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3842072 by Michael.Dupuis
#jira UE-50299: Include NumSubsection in calculation of component quad factor
Change 3842487 by Christina.TempelaarL
#jira UE-50573 HighResShot has wrong res in immersive mode
Change 3845702 by Matt.Kuhlenschmidt
PR #4381: DefaultASTCQualityBySpeed too high max value. (Contributed by kallehamalainen)
Change 3845706 by Matt.Kuhlenschmidt
PR #4388: Only restore window if minimized (Contributed by projectgheist)
Change 3845993 by Christina.TempelaarL
#jira UE-41558 crash when selecting PostProcessingVolumes in separate levels
Change 3856395 by Brandon.Schaefer
No longer using ALAudio on Linux
#jira UE-53717
Change 3858324 by Michael.Trepka
Preserve command line arguments in Xcode project when regenerating it
Change 3858365 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858492 by Michael.Trepka
Updated dependencies for Mac dSYM files so that only cross-referenced modules have their dSYMs recreated on subsequent builds instead of all modules.
Change 3859470 by Michael.Trepka
CIS fix. Make sure a scheme file exists before trying to read it when generating Xcode project.
Change 3859900 by Joe.Conley
Fix for "Check Out Assets" window not properly receiving focus.
Change 3865218 by Michael.Dupuis
#jira UE-45784: Exposed the possibility to edit LDMaxDrawDistance
Change 3866957 by Michael.Dupuis
#jira UE-42509: Added BodyInstance to ULandscapeSplineSegment and ULandscapeSplineControlPoint
Deprecated bEnabledCollision and migrate data as it's replaced by BodyInstance
Change 3867220 by Cody.Albert
Fixed Project Launcher scrollbar to properly stay anchored at the bottom of the scroll area.
Change 3869117 by Michael.Dupuis
#jira UE-42509:Fixed compile error when not having editor data
Change 3872478 by Arciel.Rekman
Linux: disable PIE if compiler enables it by default.
Change 3874786 by Michael.Dupuis
#jira UE-46925: Remove the guessing functionality when importing a heightmap, and instead propose to the user valid size that can be used for the import through a combo button.
Improved usability of the UI by disabling size field when no file was specified
Change 3875859 by Jamie.Dale
Implemented our own canonization for culture codes
Change 3877604 by Cody.Albert
We now validate actor names passed to SetActorLabel to ensure None isn't passed in, which can corrupt levels
Change 3877777 by Nick.Shin
PhysX build fix - this came from CL: 3809757
#jira UE-54924 Cannot rebuild Apex/PhysX/NvCloth .emscripten missing
Change 3881693 by Alexis.Matte
Fix local path search to not search in memory only
#jira UE-55018
Change 3882512 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3886926 by Arciel.Rekman
Linux: fixed checking clang settings during the cross-build (UE-55132).
#jira UE-55132
Change 3887080 by Anthony.Bills
Updated SDL2 build script.
- Now allows compiling inside a CentOS 6 or Ubuntu 12.04 container with wayland support when using the ContainerBuildThirdParty.sh.
- Added multiple build arch support to the BuildThirdParty script and pass this down to the SDL2 build script.
Change 3887260 by Arciel.Rekman
Linux: fix leaking process handles in the cross-toolchain.
Change 3889072 by Brandon.Schaefer
Fix RPath workaround, to better handle both cases
#jira UE-55150
#review-3888119 @Arciel.Rekman, @Ben.Marsh
Change 3892546 by Alexis.Matte
Remove fbx exporter welded vertices options
#jira UE-51575
Change 3893516 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
Change 3894365 by Brandon.Schaefer
Pass FileReference over a raw string to the LinkEnvironment
#jira none
#review-3894241 @Ben.Marsh, @Arciel.Rekman
Change 3895251 by Brandon.Schaefer
Use X11 pointer barriers to bound the cursor to a region over warping the pointers. Patch from Cengiz
#jira UE-25615
#jira UE-30714
#review-3894886 @Arciel.Rekman
Change 3897541 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3904143 by Rex.Hill
#jira UE-55366: Fix crash when overwriting existing level during level save as
#jira UE-42426: Map '_BuiltData' can now be deleted when selected at same time as map
- Map '_BuiltData' package is now garbage collected when switching maps in the editor
Change 3906373 by Brandon.Schaefer
Fix splash image. Use alias format for big/little endian machines.
#jira none
Change 3906711 by Rex.Hill
#jira UE-42426: BuiltData now deleted with maps
Change 3907221 by Cody.Albert
Add support for relative asset source paths in content plugins
Change 3911670 by Alexis.Matte
Fix assetimportdata creation owner
#jira UE-55567
Change 3912382 by Anthony.Bills
Linux: Add binaries for GoogleTest and add to BuildThirdParty script.
Change 3914634 by Cody.Albert
Added missing include that could cause compile errors if IWYU was disabled.
Change 3916227 by Cody.Albert
Fixing some cases where we check #ifdef WITH_EDITOR instead of #if WITH_EDITOR
Change 3917245 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsection and material containing grass spawning
Change 3918331 by Anthony.Bills
Linux: Bundled Mono - Explicilty pick libc.so.6 as libc.so is a linker script and store the config file directly.
Change 3920191 by Rex.Hill
#jira UE-44197 Fix saving sub-level level causing MapBuildData to be deleted
Improved MapBuildData rename, move, duplicate, copy
Change 3920333 by Matt.Kuhlenschmidt
Render target clear color property now settable in editor
#jira UE-55347
Change 3926094 by Michael.Dupuis
#jira UE-51502: Added some min/max values to foliage and grass settings to prevent overflow/crash
#coderevew jack.porter
Change 3926243 by Michael.Dupuis
#jira UE-54669: cleaned up invalid/duplicate shader and moved some shaders to appropriate list
Change 3926760 by Jamie.Dale
Added support for TTC/OTC fonts
These can be used via a sub-face index on FFontData, which can be set via a new combo in the font editor. You can also see the cached list of sub-faces within a font file from the UFontFace asset.
Change 3927793 by Anthony.Bills
Mono: Remove SharpZipLib and references from bundled Mono.
#review-3887212 @ben.marsh, @michael.trepka
Change 3928029 by Anthony.Bills
Linux: Add support for UnrealVersionSelector.
- Supports using UVS to launch without a project file. This will then launch the selected engine's project wizard.
- Linux UVS uses Slate for the version selection and error log dialogs.
- Mime-types and desktop file support added to DesktopPlatformLinux to allow associating with UVS as per the Windows binary and git builds.
- Icons added for Linux.
#review-3882197 @arciel.rekman, @brandon.schaefer
Change 3931293 by Alexis.Matte
Add generic Levenshtein edit distance to core algo. This algorithm will help suggesting name matching when users have to resolve material name conflict when re-import fbx meshes.
Add also plenty of automation tests for it.
#jira none
Change 3931436 by Arciel.Rekman
Stop RHI thread before shutting down RHI.
- Prevents crashes for some drivers that create TLS objects with destructors; those destructors will get called after the thread exited, but the library will already be unloaded on RHI shutdown.
Change 3934287 by Alexis.Matte
Fix crash when re-importing skeletal mesh. Skinned component render data resource is now release when re-importing.
#jira none
Change 3937585 by Lauren.Ridge
Added labels to the colors stored in the theme bar.
Change 3937738 by Alexis.Matte
Make sure content browser do not show a preview asset created when we cancel an export animation preview
#jira UE-49743
Change 3941345 by Michael.Dupuis
#jira UE-26959: Prevent reusing multiple type the same grass type into the same material grass output node
Change 3941453 by Michael.Dupuis
#jira UE-47492: Added a guard to validate LayerIndex
Change 3942065 by Jamie.Dale
Fixed crash trying to use FSlateApplication when it wasn't available (eg, in a commandlet)
Change 3942573 by Alexis.Matte
Fix static analysis
Change 3942623 by Michael.Dupuis
#jira 0
Cast to ulong as TaskIndex * NumStripes could exceed an int limit and add an assert if the wraparound is negative
Change 3942993 by Matt.Kuhlenschmidt
PR #4547: Verify the return value of FT_New_Memory_Face (Contributed by jorgenpt)
Change 3942998 by Matt.Kuhlenschmidt
PR #4554: Cleanup log printing (Contributed by projectgheist)
Change 3943003 by Matt.Kuhlenschmidt
PR #4534: Prevent Fatal log when alt tabbing during a level save (Contributed by projectgheist)
Change 3943011 by Matt.Kuhlenschmidt
PR #4518: edit (Contributed by pdlogingithub)
Change 3943027 by Matt.Kuhlenschmidt
PR #4524: Notifications always render on the screen with the main viewport (Contributed by projectgheist)
Change 3943074 by Matt.Kuhlenschmidt
PR #4484: Add group actor to folder (Contributed by ggsharkmob)
Change 3943079 by Matt.Kuhlenschmidt
PR #4431: Git Plugin: replace usage of the 2 cli args "--work-tree" and "--git-dir" by "-C" (Contributed by SRombauts)
Change 3943092 by Matt.Kuhlenschmidt
PR #4434: Git plugin: configure the default remote URL 'origin' (Contributed by SRombauts)
Change 3943132 by Matt.Kuhlenschmidt
PR #4247: Add File picker to Git Path setting on GitSourceControl (Contributed by shiena)
Change 3943141 by Matt.Kuhlenschmidt
PR #4303: Fix ULevelExporterT3D so that it works in a commandlet (Contributed by DSDambuster)
Change 3943349 by Jamie.Dale
Cleaned up PR #4547
Made the assert non-fatal to avoid it being able to take down the editor if you load up a bad font.
Fixed some code that was deleted during the merge.
Change 3943976 by Michael.Trepka
Copy of CL 3940687
Fixed long link times when building for Mac in Debug by passing -no_deduplicate flag to the linker, which is what Xcode does in Debug configs.
#jira none
Change 3944882 by Matt.Kuhlenschmidt
Fix a few regressions with scene viewport activation locking can capturing the cursor in editor
#jira UE-56080, UE-56081
Change 3947339 by Michael.Dupuis
#jira UE-55664: Fixed undo/redo buffer handling so we remove from the beginning of the buffer during undo buffer where buffer is at max memory and from the end during redo operation.
Fixed cancel also to re add removed transaction at the end or the start depending if we're doing a redo or undo operation
Fixed the Undo History UI to listen to an event when the undo buffer changed instead of checking every frame, as when the buffer was full, no changes would occur, thus no UI update.
Change 3948179 by Jamie.Dale
Fixed monochromatic font rendering
- All non-8bpp images are now converted to 8bpp images for processing in Slate.
- We convert the gray color of any images not using 256 grays (eg, monochromatic images that use 2 grays).
- Fixed a case where the temporary bitmap wasn't being deleted.
- Fixed a case where the bitmap could be used after it was deleted.
- Added a CVar (Slate.EnableFontAntiAliasing) to control whether you want anti-aliased (256 grayscale) rendering (default), or monochromatic (2 grayscale) rendering.
Change 3949922 by Alexis.Matte
Ensure fbx node name are not empty when loading a fbx file. I use the same naming convention as Maya
#jira UE-56079
Change 3950202 by Rex.Hill
Fix crash during editor asset automation tests.
Now skips showing modal progress window when opening asset editor window. ActiveTopLevelWindow is not set when modal windows are open.
#jira UE-56112
Change 3950484 by Michael.Dupuis
#jira UE-52176: delete the Cluster tree when the builder is no longer needed
Change 3954628 by Michael.Dupuis
Bring back 4.19/4.19.1 Landscape changes
Change 3957037 by Michael.Dupuis
#jira UE-53343: Add foliage instances back when changing component size
Changed the formulation for the Clip/Expand behavior to make it more explicit on what will happen
Added SlowTask stuff to manage big landscape change
Change 3959020 by Rex.Hill
Rename/move file MallocLeakDetection.h
Change 3960325 by Michael.Dupuis
Fixed static analysis
Change 3961416 by Michael.Dupuis
#jira UE-46100: Exposed UseDynamicInstanceBuffer on Foliage type, so user can decide if they want to update them dynamically
#jira UE-55092: Fixed the warning to appear when having resource array as empty but VB as set up
Added data conssitency that when using Dynamic buffer, Keep CPU Access should also be true, even if implicitly it's already the case, now it's explicit
Change 3962372 by Michael.Trepka
Copy of CL 3884121
Fix for SProgressBar rendering incorreclty on Mac
#jira UE-56241
Change 3964931 by Anthony.Bills
Linux: Add cross-compiled binary of UVS Shipping.
Change 3966719 by Matt.Kuhlenschmidt
Fix parameters out of order here
#jira UE-56399
Change 3966724 by Matt.Kuhlenschmidt
PR #4585: Export symbols for the FDragTool (Contributed by Begounet)
Change 3966734 by Matt.Kuhlenschmidt
PR #4596: fix the slider issue of the HighResolutionScreenshot window (Contributed by mamoniem)
Change 3966739 by Matt.Kuhlenschmidt
Removed duplicated code
#jira UE-56369
Change 3966744 by Matt.Kuhlenschmidt
PR #4602: Fixes check for existing extensions when generating "All Extensions". (Contributed by PhilBax)
Change 3966758 by Matt.Kuhlenschmidt
PR #4604: Fixed an issue where the Modules and DebugTools tabs would be unrecognized after startup if docked in the level editor (Contributed by tstaples)
Change 3966780 by Matt.Kuhlenschmidt
Fix crash accessing graph node title widgets when objects have become stale.
#jira UE-56442
Change 3966884 by Alexis.Matte
Fix speedtree uninitialized values
#jira none
Change 3967568 by Alexis.Matte
Do not override the screensize when importing a skeletal mesh, let the value set by the AddLodInfo function
#jira UE-56493
Change 3968333 by Brandon.Schaefer
Fix order of operation
#jira UE-56400
Change 3969070 by Anthony.Bills
Linux: Make sure to set the UE_ENGINE_DIRECTORY
#jira UE-56503
#review-3966609 @arciel.rekman, @brandon.schaefer
Change 3971431 by Michael.Dupuis
#jira UE-56515: Fixed an issue where ForcedLOD > MaxLOD and make sure that LastLOD will at least contain current streamed in LOD.
#jira UE-56517: When using ParallelInitView 1 there was a memory leak related to a reallocate that happen with the TArray of FMemstack
Pass correctly LODDistanceFactor instead of View.LODScale as we do not want StaticMeshScale to affect us.
Change 3971467 by Matt.Kuhlenschmidt
Fixed crash deleting a texture with texture painting on it
#jira UE-56994
Change 3971557 by Matt.Kuhlenschmidt
Fix temporary exporter objects being potentially GC'd and causing crashes during export
#jira UE-56981
Change 3971713 by Cody.Albert
PR #4597: [FPS Template] Small null pointer check fix and cleanup (Contributed by TheCodez)
Change 3971846 by Michael.Dupuis
#jira UE-56517: Properly "round" the count so we have the right amount of memory reserved
#jira UE-56515: Still had a edge case left, so when using forced lod i simply make sure the value is in valid range, and allocate all the required data for this range
Change 3973035 by Nick.Atamas
Line and Spline rendering changes:
* Lines/Splines now use 1 UV channel to anti-alias (this channel can be used for texturing)
* Anti-aliasing filter now adjusted based on resolution
* Modified Line/Spline topology to accomodate new UV requirements
* Disabled vertex snapping for anti-aliased lines/splines; previously vertexes were snapped, but vertex positions did not affect line rendering (behavior effectively unchanged)
* Splines now adaptively subdivided to avoid certain edge-cases
Change 3973345 by Nick.Atamas
- Number tweaks to maintain previously perceived wire thickness in various editors.
Change 3977764 by Rex.Hill
MallocTBB no longer debug fills bytes in development configuration
Change 3978713 by Arciel.Rekman
UVS: Fix stale dependency.
Change 3980520 by Matt.Kuhlenschmidt
Fix typo
#jira UE-57059
Change 3980557 by Matt.Kuhlenschmidt
Fixed negative pie window sizes causing crashes
#jira UE-57100
Change 3980565 by Matt.Kuhlenschmidt
PR #4628: Fixed revert action, now correctly uses CanRevert() condition (Contributed by Kryofenix)
Change 3980568 by Matt.Kuhlenschmidt
PR #4626: UE-57111: Handle CaptureRegion for HighResShot in PIE (Contributed by projectgheist)
Change 3980580 by Matt.Kuhlenschmidt
PR #4567: [Editor UI] Pick Parent Class dialog: set keyboard focus and handle Escape & Enter (Contributed by SRombauts)
Change 3980581 by Matt.Kuhlenschmidt
PR #4565: [Editor UI] Add C++ Class dialog: set keyboard focus and handle Escape & Enter (Contributed by SRombauts)
Change 3981341 by Jamie.Dale
Re-added GIsEditor condition around package namespace access
#jira UE-55816
Change 3981808 by Ryan.Brucks
Added LandscapeProxy functions to push RenderTarget data to Heightmaps and Weightmaps
Change 3983344 by Jack.Porter
#include fixes for CL 3981808
#jira 0
Change 3983391 by Jack.Porter
One for #include fix for CL 3981808
#jira 0
Change 3983562 by Michael.Dupuis
#jira UE-53787: Make sure the material array is valid before trying to generate static mesh batch element
#jira UE-56451: Instead of asserting, simply skip this element as it had invalid custom data anyway, so we can't render it
Change 3983600 by Matt.Kuhlenschmidt
PR #4289: Pragma Once/Include guard cleanup (Contributed by projectgheist)
Change 3983637 by Matt.Kuhlenschmidt
PR #4408: Add a template pregeneration hook (Contributed by mhutch)
Change 3984392 by Michael.Dupuis
#jira UE-56314: Correctly apply LODBias on calculated LOD
Fixed some Landscape popping that could occur when we were forcing a LOD that didn't match the component screen size
Change 3984950 by Rex.Hill
Optimized texture import speed 2-3x depending on number of cpu cores and image size
Change 3985033 by Rex.Hill
File drag and drop is more quick to respond when editor is in background
#jira UE-57192
Change 3986218 by Jack.Porter
Missing template parameter fix for CL 3981808
#jira 0
Change 3986376 by Michael.Dupuis
#jira UE-56453: Do not use the CreateDynamicMaterialInstance as it will change the parenting of the actor used material, instead simply use the function to generate the MID and parent it correctly.
Change 3989391 by Matt.Kuhlenschmidt
Fix constant FName lookup in level editor when checking various states of level editor tabs
Change 3990182 by Rex.Hill
Optimize editor startup time: GetCurrentProjectModules
Change 3990365 by Alexis.Matte
Fix crash with spline mesh when the attach SM get a new imported LOD
#jira UE-57119
Change 3991151 by Rex.Hill
VR Editor module now waits to load images until VR mode activated in editor. Saves 0.4 seconds of editor startup time.
Change 3991164 by Rex.Hill
Optimize editor startup time: FindModulePaths()
- Invalidates cache when search paths added
- Use cache during wildcard searches containing * and ?
Change 3995366 by Anthony.Bills
Update BuildCrossToolchain script to allow a Linux host targeting multiple Linux architectures (including the hosts arch). Added a patch to support a gcc 4.8.5 based toolchain on windows (potentially useful for users crosscompiling using GCC and libstdc++ and targeting CentOS 7).
#review-3848487 @arciel.rekman, @brandon.schaefer
Change 3996109 by Jamie.Dale
Reworked BP error messages to be more localization friendly
#jira UETOOL-1356
Change 3996123 by Michael.Dupuis
#jira UE-57427: Update random color on load of the component
#jira UE-56272:
Change 3996279 by Merritt.Cely
Removed hardware survey from editor
#jira an-2243
#tests launched the editor
Change 3996626 by Alexis.Matte
Fix crash when SkeletalMesh tangent buffer is empty after the build and we serialize the tangent array.
#jira UE-57227
Change 3996663 by Max.Chen
Sequencer: Fix fbx animation export - rotation and scale channels were flipped.
#jira UE-57509
#jira UE-57512
#jira UE-57514
Change 4000331 by Brandon.Schaefer
Add a GFNameTableForDebuggerVisualizers_MT back only for Unix under the Core module
#review-3999426 @Arciel.Rekman
#jira UE-55298
Change 4000450 by Matt.Kuhlenschmidt
Another guard against a factory being destroyed during import
#jira UE-57674
Change 4000459 by Matt.Kuhlenschmidt
Added check for valid game viewport to see if this is the problem in UE-57677
#jira UE-57677
Change 4000493 by Matt.Kuhlenschmidt
Remove stale GC'd components when refreshing paint mode to prevent crashes
#jira UE-52618
Change 4000683 by Jamie.Dale
Fixed target being incorrect when added via the Localization Dashboard
#jira UE-57588
Change 4000738 by Alexis.Matte
Add a section settings to ignore the section when reducing
#jira UE-52580
Change 4000920 by Alexis.Matte
PR #4219: Fix for SColorGradingPicker preventing PIE (Contributed by projectgheist)
author projectgheist projectgheist@gmail.com
Change 4001432 by Alexis.Matte
Add a fbx re-import resolve material windows, user can now help resolving the material in case the importer fail to found a match.
Change 4001447 by Jamie.Dale
Fixed property table not working with multi-line editable text
Change 4001449 by Jamie.Dale
PR #4531: Localization multiline fix (Contributed by Lallapallooza)
Change 4001557 by Alexis.Matte
Fix a check in fbx scene importer, in case the user import a fbx LOD group with no geometry under it
#jira UE-57676
Change 4002539 by Alexis.Matte
Make the fbx importer global transform options persist in the config file
#jira UE-50897
Change 4002562 by Anthony.Bills
Linux: Enable UVS registering for git builds only and remove old Mono and pre-UVS script code.
Change 4003241 by Alexis.Matte
Fix the staticmesh import socket logic, it was duplicating socket when re-importing
#jira UE-53635
Change 4003368 by Michael.Dupuis
#jira UE-57276:
#jira UE-56239:
#jira UE-54547:
Make sure we can't go above MaxLOD even for texture streaming
Change 4003534 by Alexis.Matte
Fix re-import mesh name match
#jira UE-56485
Change 4005069 by Michael.Dupuis
#jira UE-57594: Add a guard to prevent crash if we have an invalid resource for the heightmap texture (happen when component is deleted, for example)
Change 4005468 by Lauren.Ridge
Widgets should not be removed from parent when they are pending GC
#jira UE-52260
Change 4006075 by Michael.Dupuis
Fixed foliage density scaling to be applied even in editor, except in Foliage edit mode.
Change 4006332 by Arciel.Rekman
UBT: Adding support for bundled toolchains on Linux.
- Authored by Anthony Bills, with modifications.
Change 4007528 by Matt.Kuhlenschmidt
PR #4665: Source control History Window: enlarge column Description (Contributed by SRombauts)
Change 4007531 by Matt.Kuhlenschmidt
PR #4656: UE-57200: Ignore reference to actor if same actor (Contributed by projectgheist)
Change 4007548 by Matt.Kuhlenschmidt
PR #4664: Set Password on EditableText (Contributed by projectgheist)
Change 4007730 by Brandon.Schaefer
Add a new way to symbolicate symbols for a crash at runtime
Two new tools are used for this.
1) dump_syms Will generate a symbol file, which is to large to read from at runtime
2) BreakpadSymbolEncoder Takes the dump_syms file and encodes it in such a way we can do
a binary search at runtime to find a Program Counter to a symbol we are looking for
#review @Arciel.Rekman, @Anthony.Bills
#jira UETOOL-1206
Change 4008429 by Lauren.Ridge
Fixing undo bug when deleting user widgets from the widget tree
#jira UE-56394
Change 4008581 by Cody.Albert
Reinitialize needs to set the audio and caption tracks in addition to the video track or the currently selected track will be lost
Change 4009605 by Lauren.Ridge
Added Recently Opened assets filter under Other Filters in the Content Browser
Change 4009797 by Anthony.Bills
Linux: Update MultiArchRoot path to not cache. Move in tree toolchain location to match UBT convention and make sure the MultiArchRoot is checked before the system.
Change 4010266 by Michael.Trepka
Copy of CL 4010052
Moved some key event handling calls to the main thread on Mac to satisfy new macOS requirements
#jira UE-54623
Change 4010838 by Arciel.Rekman
Linux: limit allowed clang versions to 3.8-6.0.
Change 4012160 by Matt.Kuhlenschmidt
Changed the messagiing on the crash reporter dialog to reflect new bug submission process
#jira UE-56475
Change 4013432 by Lauren.Ridge
Fix for non-assets attempting to add to the Content Browser's recent filter
#jira none
Change 4016353 by Cody.Albert
Improved copy/paste behavior for UMG editor:
-Pasting in the designer while a canvas is selected will place the new widget under the cursor
-Pasting multiple times while a canvas panel is selected in the hierarchy view will cascade the widgets starting at 0,0
-Pasting while something that isn't a panel is selected is now allowed, and will cascade the pasted widgets off the position of the selected widget (as siblings)
-Newly pasted widgets will now be selected automatically
-Pasting multiple widgets at once will try and maintain their relative positions if they're being pasted into a canvas panel
Change 4017274 by Matt.Kuhlenschmidt
Added some guards against invalid property handle access
#jira UE-58026
Change 4017295 by Matt.Kuhlenschmidt
Fix trying to apply delta to a mix of scene components and non scene components. Its acceptable to not have scene components in the selected component list
#jira UE-57980
Change 4022021 by Rex.Hill
Fix for audio desync and video fast-forwarding behavior.
There long delay (500ms+) until samples start arriving unless we use RequestedTimeCurrent.
After delay occurs samples begin arriving at accelerated speed until caught up to playback time leading to visual and audio problems.
#jira UE-54592
Change 4023608 by Brandon.Schaefer
Downscale memory if we dont have enough
#jira UE-58073
#review-4023609 @Arciel.Rekman
Change 4025618 by Michael.Dupuis
#jira UE-58036: Apply world position offset correctly
Change 4025661 by Michael.Dupuis
#jira UE-57681: Added guard to prevent possible crash if either we have an invalid material or the material parent is invalid
Change 4025675 by Michael.Dupuis
#jira UE-52919: if no actor was found in the level skip moving the instances
Change 4026336 by Brandon.Schaefer
Manually generate *.sym files for Physx3
This should be done in the BuildPhysx file
Change 4026627 by Rex.Hill
Fix memory leak fix when playing video and main thread blocks
#jira UE-57873
Change 4029635 by Yannick.Lange
Fix VRMode loading assets only when VRMode starts.
#jira UE-57797
Change 4030288 by Jamie.Dale
Null FreeType face on load error to prevent potential crashes
Change 4030782 by Rex.Hill
Fix save BuildData after changing reflection capture in a new level
#jira UE-57949
Change 4033560 by Michael.Dupuis
#jira UE-57710: Added some guard to prevent crash/assert
Change 4034244 by Michael.Trepka
Copy of CL 4034116
Fixed arrow keys handling on Mac
Change 4034708 by Lauren.Ridge
PR #4699: UE-8508: Update config file to keep folder color in sync (Contributed by projectgheist)
#jira UE-58251
Change 4034746 by Lauren.Ridge
PR #4701: Add option to close tabs to the right of the active tab (Contributed by jesseyeh)
#jira UE-58277
Change 4034873 by Lauren.Ridge
Fix for not being able to enter simulate more than once in a row.
#jira UE-58261
Change 4034922 by Lauren.Ridge
PR #4387: Commands mapped in incorrect location (Contributed by projectgheist)
#jira UE-53752
Change 4035484 by Lauren.Ridge
Tentative fix for crash on pasting comment. All other accesses to UMaterialExpressionComment check its validity first
#jira UE-57979
Change 4037111 by Brandon.Schaefer
Try to use absolute path from dladdr if we can to find the sym files
#jira UE-57858
#review-4013964 @Arciel.Rekman
Change 4037366 by Brandon.Schaefer
Dont check the command line before its inited
#review-4037183 @Arciel.Rekman
#jira UE-57947
Change 4037418 by Alexis.Matte
Remove the checkSlow when adding polygon
Change 4037745 by Brandon.Schaefer
Use as much info as we can during ensure
Just as fast as the old way but with more information
#review-4037495 @Arciel.Rekman
#jira UE-47770
Change 4037816 by Rex.Hill
Import mesh optimization, BuildVertexBuffer
Change 4037957 by Arciel.Rekman
UBT: make it easier to try XGE on Linux.
Change 4038401 by Lauren.Ridge
Reordering is now correctly handled by undo. Reordering and then undoing will no longer cause a "ghost" widget to also be part of the tree.
#jira UE-58206
Change 4039612 by Anthony.Bills
Unix: Check for null StdOut and ReturnCode parameters, otherwise the code may dereference a null variable when the process fails to create.
Change 4039754 by Alexis.Matte
Remove the Render meshdescription, no need to carry this temporary data in the staticmesh
Change 4039806 by Anthony.Bills
Linux: UVS fixes
- Update to use new Unix base platform.
- Use bin/bash instead of usr/bin/bash (may need revisiting later).
- Recompile Shipping version with changes.
- Update Setup.sh to run from correct CWD (due to current limitations in the relative directory handling).
Change 4039883 by Lauren.Ridge
PR #4576: Save editor config to file first time a fav folder is added in the co. (Contributed by projectgheist)
#jira UE-56249
Change 4040117 by Lauren.Ridge
Replacing widgets should now also clear out references to the widget
#jira UE-57045
Change 4040790 by Lauren.Ridge
Tentative fix for Project Launcher crash when platform info not found
#jira UE-58371
Change 4042136 by Arciel.Rekman
UBT: refactor of LinuxToolChain to make it leaner and more configurable.
- Made it possible to override SDK passed to the toolchain.
- Simplified the code by using the same executable names on Windows and Linux (as .exe is optional), except where File.Exists() is needed (also remove a few)
- Some minor renames to make it clear that SystemSDK means system compiler (which otherwise may be unclear)
- Made changes to accomodate the new debug format.
Change 4042930 by Brandon.Schaefer
GCoreObjectArrayForDebugVisualizers was changed to FChunkedFixedUObjectArray reflect that in the Unix part
Change 4043539 by Brandon.Schaefer
Fix callsite address being used at times for the Program Counter
Fix only reporting the actual callstack and not the crash handling callstacks
#review-4041370 @Arciel.Rekman
#jira UE-58477
Change 4043674 by Arciel.Rekman
Added Linux ARM64 (AArch64) lib for MikkTSpace.
- Now required for standalone games due to EditableMesh runtime plugin.
Change 4043677 by Arciel.Rekman
Linux: updated ARM64 (AArch64) version of SDL2.
Change 4043690 by Arciel.Rekman
Linux: allow compiling VulkanRHI for AArch64 (ARM64).
Change 4045467 by Brandon.Schaefer
Add Anthony Bills SetupToolchain.sh script
Used to download the latest toolchain
Change 4045940 by Michael.Trepka
Return empty list instead of null from Mac GetDebugInfoExtensions() in UBT
#jira UE-58470
Change 4046542 by Alexis.Matte
Fix skeletal re-import material assignation
#jira UE-58551
Change 4048262 by Brandon.Schaefer
Rebuild SDL with pulse audio libs
#jira UE-58577
Change 3887093 by Anthony.Bills
Add bundled mono binary for Linux.
- Unify some of the script structure across Mac and Linux.
- This currently uses the same mono C# assemblies as Mac to keep the additional source size down.
- If the Mac mono version is updated, the Linux version will also need to be updated to match the same mono git revision.
- The system version of mono can still be used by setting the UE_USE_SYSTEM_MONO env var to 1.
Change 4003226 by Michael.Dupuis
Refactored StaticMeshInstancing to now use a command buffer to communicate with the GPU to prevent concurent access issues. It's mostly used in Editor or if runtime changes occur, otherwise the data is built and send to the GPU directly without keeping CPU copy.
Changed how the density scaling was applied to be more optimal
Removed UseDynamicInstanceBuffer as the concept is now irrelevant
Change 3833097 by Jamie.Dale
Localization Pipeline Optimization
Manifest/Archives:
Added FLocKey to keep an immutable string and its hash. This is used in several places within manifests and archives to minimize string hashing. FLocTextHelper also now take these in its API.
This also fixes some places where manifests were being iterated by key rather than source string (as this was causing redundant work).
Portable Object:
Cleaned up a lot of redundant code, changed things to use FLocKey, and simplified a lot of string manipulation to use algorithms instead (which proved to be faster).
Asset Gathering:
Optimized the way garbage collection runs while gathering from assets so that we avoid purging assets that we still need to gather from (or are still active dependencies). This also sorts the assets so that we can try and evict dependencies from memory as soon as possible (in much the same way that the cooker does).
Automation:
The gather commandlet can now take multiple configs to process. This is used by automation to avoid starting the editor several times (which can save a significant amount of start-up overhead).
[CL 4052378 by Lauren Ridge in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3774677 by Arne.Schober
DR - Deprecated SetLocal from the RHICmdlist
Fixed some unnecessary PSO collisions.
Change 3809579 by Chris.Bunner
Back out changelist 3774677.
#jira UE-53483
Change 3810363 by Mark.Satterthwaite
More random fixes to mtlpp: most important is the extension to Buffer that allows creation of sub-buffers that are merely views onto a sub-range of the parent. These sub-buffers are valid to use throughout the mtlpp API with two exceptions: they may not be used for visibilityResultsBuffers and Set*BufferOffset functions cannot take this offset into account (as the encoder does not hold onto the buffers and I don't want it to). In the case of Set*BufferOffset the caller has to know what is going on and in the case of visibilityResultsBuffers it'll just assert as it isn't sensible.
This makes it *much* easier to do things like sub-buffer allocation, though the caller must be aware of the alignment restrictions of their intended usage as they are not possible to enforce. For example, a call to SetVertexBuffer requires an offset alignment must match the alignment of the data-type in the shader for "device" resources, or for "constant" data it must be max(4, sizeof(datatype)) on iOS and 256 on macOS. This should allow for much more tightly packed sub-allocations than earlier approaches, though older drivers (e.g. Mac OS X 10.11) enforce only the coarser "constant" data restriction everywhere.
Change 3810407 by Marcus.Wassmer
PR #4322: ShadowSetup Bug Fix: Only stencil mask drawn meshes (Contributed by DSDambuster)
Change 3810676 by Guillaume.Abadie
Makes r.Test.SecondaryUpscaleOverride work with any arbitrary pixel size.
Change 3810696 by Guillaume.Abadie
Adds support for #include "../MyFile.ush" in the shader compiler.
Change 3810698 by Guillaume.Abadie
Implements enum class based shader permutation dimension.
Change 3810699 by Guillaume.Abadie
Implements Diaphragm DOF ground work.
Change 3811536 by Guillaume.Abadie
Pulls the trigger on CircleDOF's setup pass for DiaphragmDOF.
Change 3811958 by Mark.Satterthwaite
More fixes for mtlpp.
Change 3811964 by Mark.Satterthwaite
Only views onto a mtlpp::Buffer should return a valid parent-buffer.
Change 3812604 by Guillaume.Abadie
Changes Diaphragm DOF's source file layout.
Change 3812827 by Mark.Satterthwaite
More missing/broken functionality in mtlpp fixed and fixed obvious leaks.
Change 3812920 by Guillaume.Abadie
Adds support for per mip level UAV in FSceneRenderTarget.
Change 3812926 by Mark.Satterthwaite
Change the way we handle mtlpp resource construction to avoid leaks.
Change 3812960 by Rolando.Caloca
DR - vk - Disable DFGI
Change 3812968 by Rolando.Caloca
DR - Linker fix
Change 3813318 by Mark.Satterthwaite
Fix linear texture allocation from a buffer sub-view.
Change 3813326 by Mark.Satterthwaite
Fix another Metal mtlpp sub-buffer allocation failure.
Change 3813328 by Guillaume.Abadie
Removes global samplers in TAA for GL4, Vulkan and Switch.
Change 3813937 by Rolando.Caloca
DR - Fix logs not getting dumped when r.DumpSCWQueuedJobs is on
Change 3813947 by Rolando.Caloca
DR - noshaderworker should override r.XGEShaderCompile
Change 3817017 by Uriel.Doyon
Fixed texture editor black screen
#jira UE-53653
Change 3818568 by Rolando.Caloca
DR - Fix log when shader jobs crash
- Move log10 to common
- Added COMPILER_VULKAN define
Change 3818603 by Uriel.Doyon
Fix to static analysis warning
Change 3818623 by Rolando.Caloca
DR - Workaround hlslcc loop unrolling bug
Change 3819070 by Uriel.Doyon
Fix to stat duplication.
Change 3819105 by Uriel.Doyon
Refactored volume sample shader to avoid using texture dimension.
Change 3819136 by Rolando.Caloca
DR - vk - Per platform files (empty)
Change 3819180 by Rolando.Caloca
DR - vk - Move defines out of config into per platform
Change 3819247 by Rolando.Caloca
DR - vk - Remove more defines into platform settings
Change 3819318 by Rolando.Caloca
DR - vk - Fixes for linking
Change 3819868 by Rolando.Caloca
DR - vk - Linux & Android fixes
Change 3819873 by Guillaume.Abadie
Adds support for PermutationId on r.DumpShaderDebugInfo=1
Change 3819940 by Rolando.Caloca
DR - vk - Fix Linux issues
Change 3819956 by Rolando.Caloca
DR - vk - Invalid check
Change 3819961 by Michael.Lentine
Hide attributes when plugin is not present
Change 3819980 by Rolando.Caloca
DR - vk - Standard validation always
Change 3820039 by Rolando.Caloca
DR - vk - Fix invalid ensure
Change 3820326 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3820422 by Michael.Lentine
Add back GBufferAO.
Change 3820433 by Rolando.Caloca
DR - Fix D3D12 crash on 20 thread (10x2 cores) machines
Change 3821677 by Rolando.Caloca
DR - vk - Win32 compile fix
Change 3821961 by Rolando.Caloca
DR - Vulkan uses real UB by default on non-Android
Change 3821968 by Rolando.Caloca
DR - vk - Update glslang 1.0.65.1
Change 3821969 by Uriel.Doyon
Added support for stat groups that must be sorted by name. Defined by DECLARE_STATS_GROUP_SORTBYNAME.
Change 3821983 by Rolando.Caloca
DR - vk - Change to static array (0.1ms on 10k draw calls)
Change 3824141 by Rolando.Caloca
DR - vk - Fix static analysis
- Bumped up some (c) 2017->2018
Change 3824355 by Rolando.Caloca
DR - vk - Accessor to find out if a cmd buffer has been submitted
Change 3824420 by Rolando.Caloca
DR - Sanity check number of queries per batch on D3D11 as to not break other RHIs
Change 3824463 by Rolando.Caloca
DR - Removed dummy ensure for D3D12
Change 3824609 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3826074 by Mark.Satterthwaite
Start IMP-caching the various descriptor types in mtlpp.
Change 3826098 by Rolando.Caloca
DR - vk - Dump layer compile fixes
Change 3826113 by Rolando.Caloca
DR - vk - Missing dump functions
Change 3826302 by Rolando.Caloca
DR - vk - Compile fix
- Change dump handles to %p
Change 3826635 by Mark.Satterthwaite
Forward declarations required for mtlpp compilation without exposing Metal headers - plus fixes to the mtlpp test compiler.
Change 3827072 by Mark.Satterthwaite
Switch some more mtlpp descriptors over to IMPTables from objc_msgSend.
Change 3827909 by Guillaume.Abadie
Replaces diaphragm DOF's prefiltering with LDS bank coherent bilateral reduction, and implements 1/8 res background gathering pass.
Change 3827952 by Guillaume.Abadie
Updates copy right to year 2018 on diaphragm DOF's new files.
Change 3828055 by Rolando.Caloca
DR - vk - Rename in prep for changes
Change 3828229 by Guillaume.Abadie
Avoids to log multiple time global shader type name that have multiple permutations when verifying global shader map.
Change 3828427 by Guillaume.Abadie
Reimplements Max3x3 gathering post filtering for Diaphragm DOF with proper shader permutation.
Change 3829979 by Guillaume.Abadie
Fixes a color NaN source in diaphragm DOF's TAA pass.
Change 3830116 by Rolando.Caloca
DR - vk - Fix GPU queries/frame time on old system
- New system in place, disabled temporarily
Change 3830169 by Rolando.Caloca
DR - vk - Fix async pso creation crash
Change 3830193 by Rolando.Caloca
DR - vk - CPU RHI thread improvement
Change 3830291 by Guillaume.Abadie
Automatically lower the number of gathering rings on background half res gather pass as far CoC is getting smaller.
Change 3830300 by Rolando.Caloca
DR - vk - Static analysis fix: Split VulkanCommon.h out of VulkanConfiguration.h
Change 3830589 by Mark.Satterthwaite
In mtlpp cache the IMPTables for all the Metal @protocol's that are dependent on the MTLDevice, this avoids a mutex & map lookup. Also make all the concrete types store their IMPTable statically as it won't change.
Change 3830793 by Mark.Satterthwaite
Fix a small number of bugs introduced with the mtlpp descriptor and table caching.
Change 3831491 by Jian.Ru
Fix driver version unknown
#jira UE-53688
Change 3832335 by Rolando.Caloca
DR - vk - Change include
Change 3832550 by Rolando.Caloca
DR - vk - Occlusion query rewrite WIP
Change 3832589 by Rolando.Caloca
DR - vk - Minor refactor to pools in prep for timestamps
Change 3832618 by Rolando.Caloca
DR - vk - Do not block timestamp queries
Change 3832636 by Rolando.Caloca
DR - vk - Fix old timestamp queries
Change 3833138 by Rolando.Caloca
DR - vk - Fix timestamp queries
Change 3833249 by Rolando.Caloca
DR - vk - Test lock
Change 3833667 by Rolando.Caloca
DR - vk - Old queries wait on the RHI thread now instead of the driver (disabled)
Change 3833907 by Daniel.Wright
Fixed NextStartOffset UAV index out of bounds
Change 3833918 by Daniel.Wright
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC or Xbox. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3834852 by Rolando.Caloca
DR - vk - Missing file
Change 3834858 by Guillaume.Abadie
Implements r.DOF.MinimalFullresBlurringRadius
Change 3834979 by Rolando.Caloca
DR - vk - Fix
Change 3836117 by Rolando.Caloca
DR - vk - Update to 1.0.65.1
Change 3836122 by Rolando.Caloca
DR - vk - Added r.Vulkan.SubmitOcclusionBatchCmdBuffer
- Added new error codes/messages
Change 3836421 by Mark.Satterthwaite
For the purposes of debugging and conformance testing mtlpp make it possible to compile *without* the IMP cache so that we call the underlying Objective-C.
Change 3836896 by Uriel.Doyon
Fixed concurrency and exit issues around d3d12 pipeline states on windows.
Change 3837385 by Rolando.Caloca
DR - vk - Dump memory on OOM
Change 3837427 by Rolando.Caloca
DR - vk - Change some arrays to array views
Change 3837800 by Guillaume.Abadie
Implements SHADER_PERMUTATION_RANGE_INT to make contiguous integer permutations that does not start to 0.
Change 3838128 by Rolando.Caloca
DR - vk - Support for non-cached memory types
Change 3838540 by Guillaume.Abadie
Refactors Diaphragm DOF's CoC tile buffer under a single API for better maintainability.
Change 3838731 by Rolando.Caloca
DR - vk - Descriptor pools per command buffer pool (turned off)
Change 3838961 by Rolando.Caloca
DR - vk - Use ring buffer for per frame uniform buffers
- Enable descriptor pools per layout recycled per command buffer
Change 3839087 by Rolando.Caloca
DR - vk - Compile fixes for Android
Change 3839106 by Marcus.Wassmer
PR #4413: Removing unnecessary call to FString::ToLower (Contributed by gsfreema)
Change 3839252 by Mark.Satterthwaite
Fix mtlpp::Resource move operators.
Change 3839426 by Marcus.Wassmer
Duplicate 380972
Make PC GPU Benchmarks more reliable
Change 3840041 by Guillaume.Abadie
Fixes shader compilation failure in TAA with alpha channel through post processing support.
Change 3840257 by Chris.Bunner
Swapping a mul() to * in HLSLTranslator::Dot to allow scalar transformations per a UDN ticket.
Change 3840308 by Rolando.Caloca
DR - vk - Support for UB & non-UB on emulation mode
Change 3840586 by Rolando.Caloca
DR - Copy 3840577
Fix for CPUs with more than 16 cores
Change 3840671 by Rolando.Caloca
DR - vk - Copy from 3840663
Fix for layout ensure on HMD projects on Vulkan
Change 3840980 by Rolando.Caloca
DR - vk - Android compile fixes
Change 3841989 by Guillaume.Abadie
Slices Diaphragm DOF's Gather pass in multi shader files, and CFLAG_StandardOptimization flag for faster iteration time.
Change 3842216 by Guillaume.Abadie
Fixes DDOF's foreground alpha channel.
Change 3842217 by Guillaume.Abadie
Implements r.DOF.MaximalForegroundBlurringRadius
Change 3842353 by Guillaume.Abadie
Allows to disable foreground gathering with r.DOF.MaximalForegroundBlurringRadius=0
Change 3842747 by Rolando.Caloca
DR - vk - Missing use of GPoolSizeVRAMPercentage
- Support for smaller allocations if page size is not available
Change 3842791 by Rolando.Caloca
DR - vk - Use 95% of available GPU memory to handle some fragmentation
Change 3843690 by Guillaume.Abadie
Fixes diaphragm DOF's foreground after all this refactoring.
Change 3844439 by Guillaume.Abadie
Improves Coc dilate pass to make the gather pass as fast as possible, but still without artifacts caused by the fast gathering optimisation.
Change 3844946 by Mark.Satterthwaite
rd_route v1.1.1 with attached TPS approval.
For macOS function interposition which is useful for debugging and the occasional workaround.
Change 3845164 by Mark.Satterthwaite
Add LLM support for macOS, including tracking of memory allocated in Objective-C. This makes use of runtime method swizzling in the Objective-C runtime and the rd_route library I added for Richard Wallis, which allows for arbitrary runtime function interposition and allows me to hook the custom allocators used in Apple's many Objective-C frameworks on which the whole macOS edifice is built. Objective-C objects are charged to the calling scope as they are too common to impose their own without murdering frame rate.
We would need a TPS approval for an iOS function interposition library for this to work fully on iOS, if desired in the short term discarding LowLevelFree events that aren't in the map rather than asserting will workaround the problem.
Change 3845849 by Marcus.Wassmer
Fix clang and some normal refactor errors
Change 3846026 by Rolando.Caloca
DR - vk - Descriptor set allocation scheme rewrite
- Type hash for each pool
- Desc sets Pool on device
Change 3846169 by Rolando.Caloca
DR - vk - Remove old code for non-layout descriptor set pools
Change 3846205 by Mark.Satterthwaite
Disambiguate the PatchControlPointOut struct definitions in Metal tessellation shaders at Apple's suggestion to avoid a metallib gotcha.
Change 3846346 by Arne.Schober
DR - Missing Vector instructions
Change 3847037 by Arne.Schober
DR - Fix issue with GPU skincache where the offset of the clothbuffer is not relative to the offset of the actual vertexbuffer.
Fixed MorphTarget Skincache Offset mixxup
Change 3847275 by Marcus.Wassmer
Copying MGPU to Dev-Rendering (//UE4/Dev-Rendering)
Change 3847464 by Rolando.Caloca
DR - vk - Fix static analysis warning
Change 3847707 by Michael.Lentine
Only use MorphTargetOffset when the shader enables morph targets.
Change 3848533 by Richard.Wallis
Handle Metal adding FirstInstance into [[ instance_id ]] which is different to other APIs. SV_InstanceID and SV_VertexID should now have their respective base instance and base vertex ID's subtracted before use in the shader.
#jira UE-51716
Change 3848625 by Richard.Wallis
Compile Fix
Change 3848725 by Rolando.Caloca
DR - Remove use of Build/SetLocalGraphicsPipelineState
Change 3848797 by Rolando.Caloca
DR - Deprecate Build/SetLocalGraphicsPipelineState
Change 3849237 by Arne.Schober
DR - AddCustom Ver for ModelVertex Serialization
Change 3851247 by Rolando.Caloca
DR - vk - Util functions
Change 3851523 by Arne.Schober
DR - Update Reflection Comparission shot from the BuildFarm.
Change 3851859 by Rolando.Caloca
DR - vk - Skip loader
Change 3851889 by Krzysztof.Narkowicz
Removed lights with lighting channels out of tiled deferred light list. Tiled deferred lights do not support lighting channels and it's wasn't worth to add extra complexity to this shader in order support this special case.
#jira UE-51512
Change 3852181 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3852547 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852637 by Arne.Schober
DR - Fixing Normal Automated Test Result
Change 3853167 by Richard.Wallis
AvfPlayer - support for streaming media. Due to an operator new/delete mismatch in Apples CFNetwork - we've had to change out one of that framework allocators using rd_route to avoid the memory corruption.
#jira UE-35637
Change 3853447 by Chris.Bunner
Fixing typos.
Change 3853645 by Krzysztof.Narkowicz
Fixed light functions on subsurface materials
Removed strange code from blending between static and dynamic shadows
#jira UE-50275
Change 3853660 by Rolando.Caloca
DR - Fix OpenGL overwriting texture samplers on forward renderer
Change 3853945 by Mark.Satterthwaite
Duplicate #3831616
Fix the black ground scattering on Metal - we've had issues with the atmospheric fog calculations for a long time - one or more intermediate operations generates different precision on Metal so we end up passing -ve values into sqrt which then generates NaN/INF. For Metal when compiling this file and this file only #define sqrt() to sqrt(abs()) so that we don't see anymore unexpected black in atmospheric rendering. This is far from ideal but I don't want to make abs all inputs into every sqrt because AFAIK this is the only case where we have an issue, and until we to investigate each intermediate calculation that isn't ridiculously, soul-crushingly tedious, it isn't practical to identify the source of the error.
#jira UE-53720
Change 3853966 by Mark.Satterthwaite
Duplicate #3835852
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3854250 by Uriel.Doyon
Fix fbx automation tests
Change 3854736 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3855047 by Jian.Ru
Fix DFAO getting NANs when samples out of ViewRect
#jira UE-54403
Change 3858197 by Krzysztof.Narkowicz
View frustum shadow caster culling for pointlights/spotlights
#jira UE-54381
Change 3860081 by Krzysztof.Narkowicz
Tighter bounding sphere for a spotlight
Replaced IntersectSphere(LightProxy->Origin, LightProxy->Radius) with LightProxy->SphereBounds for tighter culling of spotlights
Directional light GetBoundingSphere() now everywhere returns Sphere((0,0,0),HALF_WORLD_MAX) for consistency and proper SphereBounds
#jira UE-54258
Change 3860324 by Mark.Satterthwaite
Update the macOS deployment target version to 10.12 from 10.11 as we officially ended support for El Capitan a while ago. Should mean that libraries compiled for 10.12 and up won't cause link warnings.
Change 3860945 by Arne.Schober
DR - Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3861129 by Jian.Ru
Prevent distance culled objects from casting distance field direct shadows
#jira UE-54533
Change 3861502 by Jian.Ru
Exclude distance culled objects from DFAO calculation
#jira UE-54533
Change 3862243 by Krzysztof.Narkowicz
Changed radius of a directional light's bounding sphere from HALF_WORLD_MAX to WORLD_MAX in order to encopass entire WORLD_MAX box
Change 3863476 by Krzysztof.Narkowicz
Added BuildReflections option to ResavePackages commandlet
#jira UE-54581
Change 3863717 by Rolando.Caloca
DR - vk - Missed using pipeline cache on compute PSOs
Change 3865332 by Arne.Schober
DR - Fix UE-52356 Bone Weight
Change 3866220 by Rolando.Caloca
DR - vk - Fixed GetNativeResource missing on textures
- Added support for -preferNvidia|AMD|Intel
- Added VulkanRHIBridge.h
- Minor fixes
Change 3866222 by Rolando.Caloca
DR - vk - Missed file
Change 3866951 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3867231 by Guillaume.Abadie
Adds alpha mode to allow the tonemapper to passthrough the alpha channel for broadcast industry.
Change 3867233 by Guillaume.Abadie
Fixes a compilation failures in TAAU with r.PostProcessing.PropagateAlpha==2
Change 3867594 by Daniel.Wright
Removed EditorOnlyDefaultMaterials, which added 79s of shader compilation during startup
Added a dialog when opening the Material Editor on a Default Material, warning of advanced workflow
Preventing Material Editor Apply or Save for a Default Material when the preview material has compilation errors
Change 3870048 by Daniel.Wright
Cleaned up formatting in TranslucentRendering from merges
Change 3870106 by Krzysztof.Narkowicz
Fixed some FArchive Tell()/Seek() 64bit->32bit truncations
Change 3870211 by Rolando.Caloca
DR - vk - Added -vulkanvalidation=N/-vulkanstandardvalidation/-novulkanstandardvalidation to set validation layer behaviour from cmd line
Change 3870225 by Rolando.Caloca
DR - vk - Some platforms do not use a standard swapchain
Change 3870267 by Arne.Schober
DR - SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
Change 3870647 by Daniel.Wright
Moved FogRendering.h to Renderer
Change 3872130 by Krzysztof.Narkowicz
Disable USE_GLOBAL_CLIP_PLANE for MATERIAL_DOMAIN_POSTPROCESS and MERIAL_DOMAIN_UI
Merging GitHub Pull request #4459
"When material domain is not needing global clip plane there is no need to generate any code involving it. This does not alter output but removes lot of code at vertex shader and pixel shaders. At least on mobile rendered was actually generating clipping code for ui materials."
#jira UE-54616
Change 3872145 by Rolando.Caloca
DR - vk - Optional SupportsMarkersWithoutExtension
Change 3872404 by Uriel.Doyon
Added some guards when streaming virtual textures.
Fixed optimized UCanvasRenderTarget2D::RepaintCanvas() to prevent resolving the texture twice.
Fixed bad mipmap generation with UCanvasRenderTarget2D.
Change 3872507 by Arne.Schober
Back out changelist 3870267
Change 3874176 by Ben.Marsh
IncludeTool: Add an flag to prevent scanning source files for exported symbols.
Change 3874935 by Krzysztof.Narkowicz
Fixed white thumbnails and other issues with sky lighting on ES3_1 path, by disabling GGX prefiltering, as mobile path doesn't have a single cubemap with all initialized mips. Instead it ping-pongs between 2 partially initialized.
#jira UE-54656
Change 3875710 by Daniel.Wright
Renamed uniform buffer member macros to be much shorter for readability
Change 3876665 by Guillaume.Abadie
Cherry-pick 3870715: Implements DOF's hybrid scatering bare bones.
Change 3876666 by Guillaume.Abadie
Cherry-pick 3871786: DOF hybrid scatering: fixes NaN source, transition to gather on close to screen edge and low intensity.
Change 3876677 by Guillaume.Abadie
Cherry-pick 3872348: Implements neighbor comparison for DOF's scattering compilation pass.
Change 3876680 by Guillaume.Abadie
Cherry-pick 3872357: Oups... fixes build...
Change 3876683 by Guillaume.Abadie
Cherry-pick 3872475: Controls number of mip to generate with DOF's reduce pass.
Change 3876687 by Guillaume.Abadie
Cherry-pick 3874104: Fixes various bugs in diaphragm DOF's hybrid scattering.
Change 3876690 by Guillaume.Abadie
Cherry-pick 3874144: Packs multiple DOF scattering group into same draw instance.
Change 3876694 by Guillaume.Abadie
Cherry-pick 3874275: Switches hybrid scattering with indexed indirect draw call to reduce scatter vertex shader invocation.
Change 3876695 by Guillaume.Abadie
Cherry-pick 3874674: Records min and max coc on DOF's setup's draw event.
Change 3876783 by Rolando.Caloca
DR - Static analysis fix
Change 3876845 by Guillaume.Abadie
Implements USceneCaptureComponent::ProfilingEventName
Change 3877197 by Rolando.Caloca
DR - vk - OQ fixes (disabled)
Change 3877428 by Krzysztof.Narkowicz
Merged with tiny tweaks Ansel photography plugin improvements from Adam Moss (GitHub pull request #4426):
-The free-roaming photography camera has new constraints by default, i.e. it can't pass through walls
-Photography session can be started and stopped programmatically, e.g. making it possible to bind photography to an alternative hotkey or button combo. This was an often-requested feature.
-Tweakables and utilities are now exposed through a Blueprint Function Library (rather than direct manipulation of console variables)
-The Ansel photography session UI now exposes some engine effect tweakables as sliders. For example, if the game is using depth-of-field then sliders are made available to allow the photographer to change the focal depth etc. The developer may suppress this behavior through the Blueprint Function Library.
-Letterboxing is now removed during multi-part capture, d'oh.
-Tiled shots are taken at full resolution even if ScreenPercentage < 100
-SSR is enabled during super-resolution shots since Ansel is now better at hiding any ensuing artifacts
-Postprocess settings are frozen at session start to avoid discontinuities during photography, i.e. wandering between postprocess volumes when the camera auto-moves for stereo and 360 shots.
#jira UE-54244
#4426
Change 3879086 by Krzysztof.Narkowicz
Fixed sky/reflection capture (without owner) update - they are now updated only with a correspoding world
Change 3879090 by Guillaume.Abadie
Fixes tones of regressions on diaphragm DOF's recombine passes.
Change 3879198 by Rolando.Caloca
DR - vk - Support for real uniform buffers on Android platforms
Change 3879993 by Krzysztof.Narkowicz
-Fixed int64->int32 FArchive offset truncation in TShaderMap, VertexFactory and TextureDerivedData
-Fixed FSerializationHistory bug, when trying to serialize 0 bytes
#jira UE-43203
Change 3881462 by Guillaume.Abadie
Implements full res DOF's setup pass for cheaper full res gathering in recombine pass.
Change 3881524 by Krzysztof.Narkowicz
Fixed compilation by removing FTickableEditorObject from FPreviewScene
Change 3881724 by Chris.Bunner
Static analysis fix.
#jira UE-54762
Change 3881861 by Rolando.Caloca
DR - vk - Fix layout warning when generating mip chain
Change 3881864 by Rolando.Caloca
DR - Use render passes on HZB
Change 3882236 by Yuriy.ODonnell
IndirectLightingColorScale is now applied to SubsurfaceLighting and DiffuseLighting. Was previously only applied to DiffuseLighting.
#jira UE-42534
#github 3326
Change 3882325 by Guillaume.Abadie
Implements FocusOnly lower gathering pass for Diaphragm DOF's slight out focus temporal stability.
Change 3882340 by Rolando.Caloca
DR - vk - Fix api dump
Change 3882430 by Rolando.Caloca
DR - vk - KHR_maintenance2
Change 3882563 by Rolando.Caloca
DR - Add depth-stencil access mode to PSO initializer
Change 3882929 by Rolando.Caloca
DR - vk - Proper fix for maintenance extension macros
Change 3883087 by Mark.Satterthwaite
Allow disabling VSync in windowed mode for macOS 10.13.4+ and above.
Change 3883597 by Guillaume.Abadie
Collapses full and half res DOF setup passes together.
Change 3883702 by Guillaume.Abadie
Fixes mac's build.
Change 3884747 by Uriel.Doyon
Fix for static analysis warning
Change 3884975 by Rolando.Caloca
DR - vk - Move some platform defines to platform properties
Change 3884988 by Rolando.Caloca
DR - vk - Make an override per platform
Change 3885832 by Rolando.Caloca
DR - vk - Cosmetic change to group similar members
Change 3885891 by Rolando.Caloca
DR - vk - Some _RenderThread functions to avoid stalls
Change 3886044 by Rolando.Caloca
DR - Added RHI api _RenderThread version of
RHICreateTextureReference
RHICreateShaderLibrary
RHICreateRenderQuery
Change 3886560 by Guillaume.Abadie
Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
Change 3886749 by Guillaume.Abadie
Cherry-pick 3884748: Implements DOF's BuildBokehLUT for diaphragm blades simulation.
Only used in hybrid scattering for now.
Change 3886750 by Guillaume.Abadie
Cherry-pick 3885457: Simulates diaphragm blades' curvature on bokeh.
Change 3886752 by Rolando.Caloca
DR - Fix metal static analysis
Change 3887460 by Uriel.Doyon
Fixed to more static analysis warning.
Change 3888201 by Rolando.Caloca
DR - vk - Added r.Vulkan.SubmitAfterEveryEndRenderPass
- Fixed bad layout on rendering back buffer
Change 3888209 by Rolando.Caloca
DR - vk - Unity compile fix
Change 3888254 by Rolando.Caloca
DR - vk - Fix async texture layout
Change 3888893 by Guillaume.Abadie
Simulates bokeh in DOF's slight out of focus.
Change 3889085 by Guillaume.Abadie
Fixes DOF's reduce pass sampling outside viewport.
Change 3889924 by Rolando.Caloca
DR - vk - Skip seemingly bad validation error
Change 3890573 by Daniel.Wright
Only initialize FDiaphragmDOFGlobalResource in Feature Level 5
Change 3890590 by Arne.Schober
DR - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890638 by Arne.Schober
DR - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3891099 by Krzysztof.Narkowicz
1.5 texel shadow offset fix inside Manual2x2PCF based on #4485 GitHub pull request
#jira UE-54985
#4485
Change 3891234 by Krzysztof.Narkowicz
Optimized PCF2x2 and PCF3x3 - merged #4494 GithHub pull request
#jira UE-55121
Change 3891407 by Rolando.Caloca
DR - vk - Set vendor id earlier
Change 3891417 by Rolando.Caloca
DR - vk - Missing layout transitions
Change 3891718 by Arne.Schober
DR - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891925 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891987 by Rolando.Caloca
DR - vk - Support for dedicated allocations
Change 3892339 by Jian.Ru
Fix a crash when tessellation shaders are used in dx12
#jira UE-55127
Change 3892528 by Rolando.Caloca
DR - vk - Update Linux headers
Change 3892867 by Rolando.Caloca
DR - vk - Don't create swapchain if not needed
Change 3893416 by Guillaume.Abadie
Implements bokeh simmulation on foreground and background gather.
Change 3893732 by Chris.Bunner
GetRelevance_Internal should use the immediate parent resource, not the base, as some features are overridden by permutations e.g. UsesWorldPositionOffset.
#jira UE-53404
Change 3893868 by Guillaume.Abadie
Allocates diaphragm DOF's buffers and structered buffer only on supported platforms.
Change 3893917 by Chris.Bunner
Potential fix for CIS.
Change 3893933 by Chris.Bunner
Duplicating CL 2647737 as this is the same issue from that JIRA where accessing game-thread data was being prevented. We don't have this check in UMaterial::GetMaterialResource already, but presumably the UMaterialInstance case was never removed as we've not been calling it until now.
Change 3894218 by Rolando.Caloca
DR - vk - Remove stat counters per draw call, gains 10% CPU on Infiltrator
Change 3894579 by Arne.Schober
RT - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894724 by Rolando.Caloca
DR - vk - New API for batching barriers
Change 3894909 by Arne.Schober
DR - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3895414 by Rolando.Caloca
DR - Add a configurable threshold for SCWs time outs
Change 3896429 by Marcus.Wassmer
Allow variable frame-latency delay in FrameGrabber frames. For performance you want at least a 1 frame delay so you don't sync the GPU to the CPU.
Change 3896495 by Marcus.Wassmer
Set pointer properly
Fix CIS
Change 3897253 by Guillaume.Abadie
Fixes CIS warning in diaphragm DOF
Change 3899179 by Guillaume.Abadie
Implements background hybrid scatter occlusion for diaphragm DOF.
Change 3903654 by Rolando.Caloca
DR - vk - Rework dump layer to allow other layers
Change 3903766 by Rolando.Caloca
DR - vk - More wrappers
Change 3904025 by Rolando.Caloca
DR - vk - More wrappers
Change 3904342 by Rolando.Caloca
DR - vk - Track image resources & callstacks
Change 3904346 by Rolando.Caloca
DR - vk - Copy fix from 4.19 for flickering grass
Change 3904510 by Rolando.Caloca
DR - vk - Compile fix
Change 3904914 by Daniel.Wright
[Integrate] Fixed PS4 transitions with forward shading
Change 3904916 by Daniel.Wright
[Integrate] Fixed PS4 transitions with occlusion queries
Change 3905975 by Rolando.Caloca
DR - vk - Missing wrappers
Change 3905977 by Rolando.Caloca
DR - vk - Missed file
Change 3907829 by Rolando.Caloca
DR - Move depth bounds to the PSO
Change 3907832 by Rolando.Caloca
DR - vk - Prep for delaying transitions
Change 3907834 by Rolando.Caloca
DR - vk - Fix for depth stencil issues/validation errors
Change 3907967 by Rolando.Caloca
DR - vk - Linux compile
Change 3908093 by Rolando.Caloca
DR - vk - Fix depthstencil layout on descriptors
Change 3908393 by Rolando.Caloca
DR - vk - Disable dedicated allocation as it causes crashes on Nvidia 700 series
Change 3908401 by Rolando.Caloca
DR - Do transitions outside render pass
Change 3908422 by Rolando.Caloca
DR - vk - Fix transition state not getting stored
Change 3908735 by Guillaume.Abadie
Cherry-pick 3896619: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3908736 by Guillaume.Abadie
Cherry-pick 3891352: Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3908753 by Guillaume.Abadie
Lets the renderer layout the views in the internal render targets like it prefers.
Change 3909119 by Daniel.Wright
Fix some static analysis warnings
Change 3911943 by Rolando.Caloca
DR - vk - Fix for packaging Vulkan projects
Change 3912145 by Rolando.Caloca
DR - vk - Fix layout on streaming textures
Change 3913029 by Rolando.Caloca
DR - Fix missing transition
Change 3913048 by Rolando.Caloca
DR - Fix for hlslcc
Change 3913054 by Rolando.Caloca
DR - vk - Fix number of layers on barrier
Change 3913171 by Rolando.Caloca
DR - vk - Fix for decal missing transition
Change 3913211 by Rolando.Caloca
DR - vk - Add debug name to image tracking
Change 3913449 by Rolando.Caloca
DR - vk - Restore transition
Change 3913466 by Rolando.Caloca
DR - Fix Vulkan EngineTest
Change 3913537 by Rolando.Caloca
DR - vk - Fixes independent samplers & textures (contributed by AMD)
Change 3913548 by Rolando.Caloca
DR - vk - Warning fix
Change 3913691 by Rolando.Caloca
DR - vk - Fixes for parallel (wip)
Change 3914656 by Rolando.Caloca
DR - vk - Fix bug when using separate samplerstates and textures
Change 3914730 by Rolando.Caloca
DR - vk - Bump version
Change 3914764 by Rolando.Caloca
DR - vk - Don't crash on exit
Change 3915532 by Rolando.Caloca
DR - vk - Parallel context fixes
Change 3915589 by Rolando.Caloca
DR - vk - Hoist and rename transition and layout manager class out of the context
Change 3915592 by Rolando.Caloca
DR - Fix gpu marker name
Change 3917607 by Rolando.Caloca
DR - vk - Fix depth bounds on Vulkan
Change 3917609 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3917616 by Rolando.Caloca
DR - Fix D3D11 initialization
Change 3920569 by Rolando.Caloca
DR - vk - Prep for layout mgr refactor
Change 3921023 by Rolando.Caloca
DR - vk - Dump layer fixes
Change 3921623 by Rolando.Caloca
DR - vk - Prep refactor for layouts
- Dump now shows marker tree
Change 3922007 by Rolando.Caloca
DR - vk - Fix extra allocation per draw call
Change 3922442 by Rolando.Caloca
DR - vk - Detect potential issues
Change 3922470 by Rolando.Caloca
DR - vk - Minor optimization
Change 3922482 by Rolando.Caloca
DR - vk - More minor optimizations
Change 3923158 by Rolando.Caloca
DR - Move r.DisableEngineAndAppRegistration out to common RHI and use it on Vulkan
Change 3923486 by Rolando.Caloca
DR - vk - Minor cpu optimizations
Change 3923505 by Rolando.Caloca
DR - vk - Use bigger allocations for uniform buffers
Change 3923516 by Rolando.Caloca
DR - vk - Android compile fix
Change 3923557 by Rolando.Caloca
DR - vk - Cache descriptorset layouts, refactor duplicated code
Change 3923851 by Rolando.Caloca
DR - vk - Linux compile fix
Change 3924153 by Rolando.Caloca
DR - vk - Support for dynamic UBs
Change 3924193 by Rolando.Caloca
DR - vk - Remove old per pso descriptor pools
Change 3924197 by Rolando.Caloca
DR - vk - Remove unused global uniform buffer pool
Change 3924220 by Rolando.Caloca
DR - vk - Wrap some unused classes in their define
Change 3924234 by Rolando.Caloca
DR - vk - Show ring buffer wrapping messages
Change 3924243 by Rolando.Caloca
DR - vk - Fix bad dynamic buffer
Change 3924902 by Rolando.Caloca
DR - vk - Fix crash running infiltrator
Change 3925209 by Rolando.Caloca
DR - vk - Fix bug with dynamic buffers
- Remove old defines
Change 3925300 by Rolando.Caloca
DR - vk - Allow packed uniforms as dynamic UBs (with r.Vulkan.DynamicGlobalUBs)
Change 3925627 by Rolando.Caloca
DR - vk - Move DynamicOffsets into the pipeline state
Change 3925834 by Rolando.Caloca
DR - vk - Cache per stage information
Change 3925835 by Daniel.Wright
Fixed DisplayName for UParticleModuleCollisionGPU
Change 3925897 by Rolando.Caloca
DR - vk - Split update descriptors loop
Change 3926488 by Rolando.Caloca
DR - vk - 16MB for ring buffer on desktop, 8 MB for mobile
Change 3928168 by Guillaume.Abadie
Cherry-pick 3917219: Implements r.DOF.RecombineQuality
Change 3928173 by Guillaume.Abadie
Cherry-pick 3927888: Enables r.DOF.HybridScatter.BackgroundCompositing and r.DOF.HybridScatter.ForegroundCompositing to work when both enabled.
Change 3928216 by Rolando.Caloca
DR - vk - Fix Android
- Fix static analysis
Change 3929119 by Rolando.Caloca
DR - vk - Rename some classes for clarity
- Fix read-only cvar
Change 3929151 by Rolando.Caloca
DR - vk - Rename class
Change 3930046 by Rolando.Caloca
DR - Temp fix Vulkan flickering grass
Change 3930148 by Rolando.Caloca
DR - vk - Only update dirty descriptors
- Use dynamic descriptors for packed global uniform buffers
Change 3930998 by Guillaume.Abadie
Packs shader permutation in different XGE submissions.
Change 3931079 by Rolando.Caloca
DR - vk - Fixes for Android and non-real ubs platforms
Change 3931942 by Krzysztof.Narkowicz
Depth rendering - When EarlyZPassMode is set to DDM_AllOccluders, dynamic objects need also to test bUseAsOccluder just like static ones
#jira none
Change 3932819 by Daniel.Wright
[Integrate] Scene Textures uniform buffer
* Base Pass Uniform Buffer now contains a Scene Textures uniform buffer. Previously the translucent base pass had to check ~40 loose scene texture parameters every draw.
* FMeshMaterialShader's must now bind PassUniformBuffer and supply a valid pass uniform buffer. For most passes this is just FSceneTextureUniformParameters.
* FRendererModule::DrawTileMesh can now cleanly set dummy scene texture resources, just by configuring how the pass uniform buffer is created.
* Moved scene texture shader functions out of Common, into SceneTexturesCommon which must be manually included by shaders that want to use them
* Separate Mobile Scene Textures uniform buffer to silo the platform complexities
Moved DBuffer inputs out of FDeferredPixelShaderParameters and into FOpaqueBasePassUniformParameters
Removed per-frame material uniform expressions. GameTime material node with period is now implemented with an fmod in the shader, without the use of MaterialFloat, so that it will happen at full precision.
* Per-frame expressions were used when the GameTime material node had a period, to do the fmod on the CPU where 32 bit precision is guaranteed, for mobile GPU's where pixel shader precision is sometimes less than 32fp.
Moved forward shading data into the Base Pass Uniform Buffer
Removed instanced stereo support for the light cull grid - will have to be reimplemented without changing SRV's per draw
Base pass sets View Uniform Buffer from DrawRenderState instead of choosing which one to set per-draw
Fixed padding in nested uniform buffer structs
Skip SRV members on Feature Level SM4 and below
Change 3932964 by Rolando.Caloca
DR - vk - Renderdoc on Android
Change 3933095 by Daniel.Wright
Moved FSceneTextureUniformParameters out of the opaque base pass uniform buffer.
* Base Pass shaders now enable SCENE_TEXTURES_DISABLED when compiling for a material of any domain other than MD_Surface. These are used when rendering thumbnails of a material in a different domain, which could be opaque, but the opaque base pass drawing policy does not bind a scene textures uniform buffer, so the shader must not bind it.
* Opaque materials can no longer use EyeAdaptation.
Change 3933096 by Daniel.Wright
Better d3d11 assert message when a uniform buffer was not set by the renderer
Change 3933176 by Rolando.Caloca
DR - vk - Prefer mailbox if available
Change 3933271 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3934000 by Guillaume.Abadie
Fixes Win32 build in ShaderCompilerXGE.cpp
Change 3934299 by Guillaume.Abadie
Fixes a bug in DOF's reduce operator that was casusing color leaking between background and foreground.
Change 3934699 by Daniel.Wright
Added bAffectDistanceFieldLighting to landscape
Change 3935190 by Daniel.Wright
Forward Light Grid SRV's use StructuredBuffer on Metal, instead of 'invariant Buffer', which throws off RemoveUniformBuffersFromSource parsing
Change 3935606 by Daniel.Wright
Removed LightmapPolicy::Set which was needed for vertex lightmaps
Renamed FVertexFactory::Set to SetStreams to make it findable
Change 3936510 by Rolando.Caloca
DR - vk - Update glslangValidator.exe to 1.0.65.1 for dumped debug SPIRV shaders
Change 3936545 by Richard.Wallis
Clone of CL's (3925763, 3925430, 3925424, 3925385, 3925278) Mark Satt's Xcode fixes from task stream //Tasks/UE4/Dev-UERNDR-354-mtlpp/
Plus XCode 9.2 compile fix in ApplicationPlatformCompilerPreSetup.h for -Wunused-lambda-capture.
Change 3938061 by Daniel.Wright
Vulkan: Added support for SRV's in Uniform Buffers
Change 3938123 by Daniel.Wright
Vulkan: Slightly better assert for null resources in uniform buffer
Change 3939197 by Rolando.Caloca
DR - vk - Disable custom memory mgmt
Change 3939677 by Rolando.Caloca
DR - vk - Fix static analysis warning
Change 3939809 by Rolando.Caloca
DR - vk - Fixes for async compute
Change 3939875 by Rolando.Caloca
DR - vk - Support for -vktrace
Change 3939977 by Rolando.Caloca
DR - vk - Skip a condition during gather UBs
- Set up efficient compute async var
- Fix validation cmd line
Change 3939982 by Rolando.Caloca
DR - vk - Revert mipchain
Change 3939984 by Rolando.Caloca
DR - vk - Remove unnecessary asserts
Change 3940082 by Rolando.Caloca
DR - vk - Custom mem mgr
Change 3940475 by Rolando.Caloca
DR - vk - Fix DFAO (indirect draw offset)
Change 3940555 by Rolando.Caloca
DR - vk - Minor fixes
Change 3940675 by Rolando.Caloca
DR - vk - Fix indirect type mismatch
Change 3941111 by Rolando.Caloca
DR - Renderpass bGeneratingMips
Change 3941847 by Daniel.Wright
Fixed Volumetric Lightmaps on Static geometry only working if the geometry had been built with Surface Lightmaps before
Change 3941978 by Rolando.Caloca
DR - vk - Minor fixes for presenting on compute queue
Change 3942074 by Rolando.Caloca
DR - vk - Remove some RHI stalls
- Fixed swap chain stat
Change 3943946 by Daniel.Wright
Fixed Texcoord0 on Volume materials on a particle sprite, including SubUV particles.
Change 3944065 by Daniel.Wright
Fixed SceneDepth collision getting broken on GPU particles when a scene capture is rendering
Change 3944158 by Daniel.Wright
Fixed ViewUniformShaderParameters accessing GEngine->PreIntegratedSkinBRDFTexture too early during slate loading screen
Change 3944865 by Rolando.Caloca
DR - vk - Prep for render passes
Change 3945196 by Rolando.Caloca
DR - Move render pass validate to cpp
Change 3945202 by Rolando.Caloca
DR - vk - Some fixes for using real render passes
Change 3945357 by Rolando.Caloca
DR - Fix bad condition
Change 3946295 by Yuriy.ODonnell
Added a sentinel member to FLightMap, which is initialized in the ctor and reset in the dtor. Sentinel is then checked in FLightCacheInterface::GetLightMapInteraction().
This aims to shed some more light on a hard-to-repro crash, which is suspected to be a use-after-free bug: http://crashreporter/Buggs/Show/1785593
Change 3946407 by Rolando.Caloca
DR - vk - Prep for refactor
Change 3946648 by Rolando.Caloca
DR - vk - Fixes for async compute (wip)
Change 3947299 by Rolando.Caloca
DR - vk - FIx static analysis
Change 3948434 by Rolando.Caloca
DR - vk - Fix exiting with parallel
Change 3948928 by Rolando.Caloca
DR - vk - Fix enabling draw markers for tools
Change 3949021 by Rolando.Caloca
DR - vk - Buffer tracking layer
Change 3949602 by Rolando.Caloca
DR - vk - static analysis fix
Change 3949757 by Rolando.Caloca
DR - vk - Remove bogus parameter
Change 3949810 by Rolando.Caloca
DR - vk - Move waits for cmd buffer
Change 3950270 by Guillaume.Abadie
Implements dedicated gather pass for foreground hole filling to avoid being VGPR bound in foreground gather pass, but still being hable to amend foreground.
Change 3950272 by Rolando.Caloca
DR - vk - Minor refactor for semaphores
Change 3950279 by Guillaume.Abadie
Oups... fixes build
Change 3950298 by Rolando.Caloca
DR - vk - Gather wait semaphores in the cmd buffers
Change 3950371 by Rolando.Caloca
DR - vk - fixes for async compute
Change 3950597 by Rolando.Caloca
DR - vk - Fix for clip distance (fixes planar reflections)
Change 3951075 by Rolando.Caloca
DR - vk - Fix for async compute
Change 3952524 by Guillaume.Abadie
Some DOF enum refactoring.
Change 3955016 by Daniel.Wright
Fixed BuiltData package getting renamed into the map package during a content browser folder move, causing a redirector to be incorrectly placed in the map package
Change 3955668 by Guillaume.Abadie
Fixes a bug where full res coc buffer was computed even if not doing slight out of focus.
Change 3956722 by Guillaume.Abadie
Fixes a bug where r.DOF.MaximalForegroundBlurringRadius was screen percentage dependent.
Change 3959212 by Guillaume.Abadie
Prefixes all DOF's shaders files with DOF keyword.
Change 3959705 by Guillaume.Abadie
Optimises the DOF setup pass outputing half res and full res with LDS downsample.
Change 3959941 by Guillaume.Abadie
Halfs DOF's hybrid scatter compilation by using a unique downsampling for both foreground and background, instead of 2 reduce passes.
Change 3962273 by Rolando.Caloca
DR - Fix typos
#jira UE-56317
PR #4586
Change 3962615 by Rolando.Caloca
DR - vk - Compile fix
Change 3962949 by Rolando.Caloca
DR - Fix DOFDownsample extension
Change 3962993 by Guillaume.Abadie
Back out changelist 3962949
Change 3963016 by Guillaume.Abadie
Adds missing DOFDownsample.usf
Change 3963041 by Rolando.Caloca
DR - vk - Misc changes to help integrate
Change 3964293 by Guillaume.Abadie
Fixes DOF's setup pass reading outside of the viewport.
Change 3964475 by Guillaume.Abadie
Collapses DOF's hybrid scatter compilation passes into reduce passes.
Change 3964883 by Daniel.Wright
Fixed 3d texture in uniform buffer on unsupporting RHI
Change 3964897 by Rolando.Caloca
DR - Compile fixes
Change 3964914 by Guillaume.Abadie
Fixes a bug on r.DOF.RecombineQuality=0
Change 3965153 by Guillaume.Abadie
Fixes compile warning in D3D12Commands.cpp.
Change 3965814 by Rolando.Caloca
DR - Prep for integration conflict resolve
Change 3965899 by Rolando.Caloca
DR - Fix odd linkage issue
Change 3966072 by Rolando.Caloca
DR - More prep for merge
Change 3966163 by Rolando.Caloca
DR - Merge prep
Change 3966844 by Guillaume.Abadie
Packs multiple DOF scattered bokeh per instance and uses PT_RectList in DOF for platforms that can.
Change 3967116 by Rolando.Caloca
DR - Compile fixes for integration
Change 3967273 by Rolando.Caloca
DR - Use same path for mip generation
Change 3967277 by Rolando.Caloca
DR - vk - Fix mips on cubemaps
Change 3967693 by Rolando.Caloca
DR - Copying //UE4/Dev-Main@3912313 to //UE4-DevRendering, missing shaders
Change 3967851 by Rolando.Caloca
DR - Copying //UE4/Dev-Main@3912313 to //UE4-DevRendering, Engine 2/2
Change 3968083 by Rolando.Caloca
DR - Integration compile fixes
Change 3968240 by Rolando.Caloca
DR - Shader compile fixes for integration
Change 3968270 by Rolando.Caloca
DR - Fix for missing hash calculation
Change 3969426 by Rolando.Caloca
DR - vk - Fix warning
Change 3969869 by Krzysztof.Narkowicz
Back out changelist 3946295 - UE-54537 is fixed, so no need for this debug sentinel.
#jira none
Change 3969944 by Rolando.Caloca
DR - Warning fix
Change 3970020 by Rolando.Caloca
DR - Bump after integration
Change 3970052 by Rolando.Caloca
DR - Fix for mobile
Change 3970236 by Daniel.Wright
Causing decal shader to recompile to fix a merge bug
Change 3970270 by Daniel.Wright
Bump shader version from merge
Change 3970339 by Olaf.Piesche
Replace series of locks/unlocks with a single one for curve injection
#tests QAGame
Change 3970390 by Rolando.Caloca
DR - Rename FSceneTextureUniformParameters to FSceneTexturesUniformParameters
- Remove duplicate method for occlusion queries
Change 3970523 by Rolando.Caloca
DR - Fix serialization of shaders
Change 3970533 by Arne.Schober
DR - fix for removing the Speed tree wind when the scene gets deleted. The original enque rendercommand requeues the element onto the renderthread although the call already came from the Renderthread and the scene can get lost in between.
#jira UE-56322
Change 3971160 by Guillaume.Abadie
Fixes CompositeEditorPrimtive pass and SelectionOutline pass for VR editor to work with TAAU.
Change 3971516 by Guillaume.Abadie
Cherry-pick 3912629: Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3971594 by Krzysztof.Narkowicz
Fixed assert inside BindLightMapVertexBuffer. FSplineMeshSceneProxy was calling BindLightMapVertexBuffer for invalid (still not generated) lightmap UV channel after mesh reimport. Simplified assert, as at the moment almost all of the high callsites already clamp lightmap uv channel.
#jira UE-56321
Change 3971622 by Krzysztof.Narkowicz
Fixed crash inside Indirect Lighting Cache. Data (reflection captures and lightmap) generation calls ULevel::GetOrCreateMapBuildData(), which can destroy lightmap data if level has legacy data. Last Lightmap generation step recreates this data, but if user cancels lightmap generation - it won't do that.
#jira UE-56171
Change 3974788 by Rolando.Caloca
DR - Remove GSupportsGenerateMips
Change 3974789 by Rolando.Caloca
DR - Remove bogus function
Change 3974986 by Rolando.Caloca
DR - vk - Tracking fixes
Change 3974989 by Rolando.Caloca
DR - vk - Don't submit dummy barriers
Change 3975075 by Olaf.Piesche
Update for particle curve injection improvement, fixing ES2 problems
#tests QAGame tm-shadermodels, various color curve tests in-editor
Change 3975957 by Uriel.Doyon
Fixed invalid max texture resolution when using the bake material tools.
Change 3978471 by Daniel.Wright
New cvar r.SkylightUpdateEveryFrame
Change 3978779 by Rolando.Caloca
DR - Accessor for texture sizes
Change 3978797 by Rolando.Caloca
DR - Clean up RHI CopyTexture API
Change 3978832 by Rolando.Caloca
DR - vk - Workaround for RenderDoc crashing due to Descriptor Pool reset
Change 3978836 by Rolando.Caloca
DR - vk - Remove generate mips
Change 3979201 by Rolando.Caloca
DR - vk - RHI CopyTexture. Uses general layout for generating mips
Change 3979204 by Rolando.Caloca
DR - Use render passes and CopyTexture to generate mips
Change 3979592 by Rolando.Caloca
DR - Warning fix
Change 3980855 by Krzysztof.Narkowicz
Optimize bounding sphere radius after non-uniform scale by using bounding box extent.
#jira UE-56227
Change 3981065 by Rolando.Caloca
DR - vk - Fix bad layout
#jira UE-56238
Change 3981346 by Rolando.Caloca
DR - Copy from 3707257
Support for not flushing compute jobs (r.D3D11.UAVFlushNV)
Change 3981347 by Rolando.Caloca
DR - Copy from 3707257
Don't flush between morph dispatched
Change 3981932 by Mark.Satterthwaite
Generate the shader hash and function name when a Metal shader error needs to be reported so that even without shader code we get something to go on.
Change 3982442 by Rolando.Caloca
DR - Fix warning
Change 3982652 by Rolando.Caloca
DR - vk - Signal semaphore cleanup
Change 3983917 by Richard.Wallis
Clone of CL 3974146 converted for mtlpp along with extra mtlpp usage suggestions by Mark Satt:
Fix for black flickering on first paint with weighted material landscape on Mac. When using AsyncCopyFromBufferToTexture in Metal we put the blit operation on the prologue encoder - however after a draw call using that resource the copy operation should happen after on the current encoder, this keeps the correct order of operations.
Added Bool return from various Asnyc renderpass resource requests so caller can decide correct further action. Updated to include the other async functions.
Change 3984409 by Guillaume.Abadie
Attempts to make static analysis happy again.
Change 3984435 by Nick.Bullard
Checking in Performance Test level provided to us by Tor Frick based on UE-44841.
This has been utilized for checking issues against Aftermath performance impact.
The Map includes 2 Level Book marks, most testing has been done against Bookmark 1 view, in fullscreen, in game mode
Change 3985087 by Mark.Satterthwaite
Make sure that the particle scratch buffer is large enough to hold all the data for the curve texture we are rendering to, otherwise a full set of curves will start scribbling memory after 64Kb (the curve texture is 256Kb of data - 512x512x4 as sizeof(RGBAUInt8) == 4). This happens in ElementalDemo.
Change 3985201 by Rolando.Caloca
DR - Fix bad CopyTexture
Change 3985258 by Mark.Satterthwaite
Try and detect orientation changes so that we don't blow-up on iOS due to a huge mismatch between the drawable texture for the display and the scene's depth-stencil target. I can't just fiddle with the depth-stencil texture itself without running the risk of obliterating in-use data and really we shouldn't permit such a mismatch anyway but it is fallout from 3620990.
#jira UE-55756
Change 3986449 by Rolando.Caloca
DR - vk - Update & consolidate Vulkan headers to 1.1.70.1
Consolidate SDK into one
Change 3986571 by Guillaume.Abadie
Makes PVS-Studio happy again in DOF.
Change 3987039 by Yuriy.ODonnell
Initial implementation of tracing profiler to show CPU and multiple GPUs on the same timeline. Currently only supported on DX12 platforms.
Use `TracingProfiler frames=N` console command to trigger a capture of the next N frames. Trace is saved to disk as a JSON file into `Saved/Profiling/Traces` directory.
Trace file uses Google Tracing format and can be visualized in Chrome built-in profiler (chrome://tracing).
`r.GPUStatsChildTimesIncluded=1` CVar makes timing scopes hierarchical.
`TracingProfiler.BufferSize=N` CVar controls the size of the tracing buffer, which may need to be increased for long traces (default is 65k events). Only can be set at startup.
Change 3987074 by Yuriy.ODonnell
Implemented timestamp calibration on DX11. Calibration is only performed when tracing profiler session starts.
Change 3987160 by Yuriy.ODonnell
Added thread naming and ordering to the tracing profiler output
Change 3987331 by Mark.Satterthwaite
Remove the Nvidia hack to retain resource references in command-buffers for UE-46604 as the mtlpp refactor provides stronger resource lifetime guarantees.
#jira UE-46604
Change 3987754 by Mark.Satterthwaite
Fix MetalRHI memory reporting in non-default path.
PR #4568
Change 3988184 by Arciel.Rekman
Linux: Fix editor OpenGL performance (UE-55960).
- GetCurrentThreadId() calls became much more frequent with the OpenGL RHIT refactor.
- We used to only cache that value in monolithic builds, because having per-thread static variables in dynamic libraries is risky due to OS limits.
- This change adds dynamically-managed per-thread cache for non-monolithic builds.
#jira UE-55960
Change 3988394 by Rolando.Caloca
DR - vk - Improve memory mgmt
- Use 256MB pages for Device heap (or 1/8th if less).
- Remove texture allocations not going through resource manager
Change 3988405 by Marcin.Undak
Fix VulkanQuery crash on exit #codereview rolando.caloca #codereview arciel.rekman #rb arciel.rekman
Change 3988567 by Rolando.Caloca
DR - vk - Support for packed global UBs on pci aperture heap
Change 3988668 by Rolando.Caloca
DR - vk - Remove old comments
Change 3988956 by Marcin.Undak
RecordPerformance: added option to skip building/cooking before tests #rb none #codereview arciel.rekman
Change 3989161 by Yuriy.ODonnell
Static analysis error fix
Change 3989196 by Guillaume.Abadie
Fixes a crash in light shaft's TAA pass.
#jira UE-57366
Change 3989207 by Yuriy.ODonnell
Refactored FRealtimeGPUProfilerFrame to avoid splitting profile events when calculating exclusive times of scopes. This allows tracing profiler to retain the hierarchical view of the data, while keeping CSV and GPU Stat system behavior intact.
Change 3989469 by Rolando.Caloca
DR - vk - Fix for bad index; fix for bad transition
Change 3989772 by Yuriy.ODonnell
Implemented timestamp calibration on Vulkan
Change 3990040 by Marcus.Wassmer
Aftermath enabled by default.
Removed unnecessary warning for other vendors
Change 3990064 by Mark.Satterthwaite
Ensure that packed globals are reuploaded when the command-encoder is restarted - don't simply invalidate the existing parameters. This properly handles cases where a single logical render-pass is broken into multiple command-encoders and/or command-buffers - otherwise all shaders must reset all parameters each time. When we move between frames we *do* want to perform a full state reset though as previous frame globals are treated as invalid.
Change 3990080 by Mark.Satterthwaite
Change the way we invalidate the visibility buffer between command-buffers and command-encoders so that on iOS you can reuse the same buffer within the same command-buffer, but not across more than one. The code provides an exception to this rule when running under the MetalRHI validation tools which can break each draw call into its own buffer.
Change 3990084 by Mark.Satterthwaite
Get MetalStatistics compiling again.
Change 3990381 by Arciel.Rekman
Bring back D3D12 in RecordPerformance.
Change 3991113 by Rolando.Caloca
DR - Fix crash on RHI thread on mobile preview
- Check RHI objects are not null in the PSO initializer
Change 3991191 by Ryan.Vance
#jira UE-55952
Reimplemented instanced stereo for forward lighting cull grid after the srv/ub clean up.
Change 3991343 by Rolando.Caloca
DR - Copy from 3911492
UE4 - Disabled parallel mobile bass pass by default. This is experiemental and not known to be useful on any mobile platform.
Change 3991375 by Mark.Satterthwaite
Proper copyright assignment in the mtlpp debugger header.
Change 3993151 by Daniel.Wright
Fix RTDF resource transition found by Rolando
Change 3993818 by Rolando.Caloca
DR - Missed file
Change 3993923 by Krzysztof.Narkowicz
Fixed crashes inside RemoveSpeedTreeWind() and RemoveSpeedTreeWind_RenderThread().
FStaticMeshComponentRecreateRenderStateContext didn't flush deferred render updates causing stale RenderData to be left:
1. Thumbnail manager called SetStaticMesh(nullptr), which added StaticMeshComponent to deferred render updates.
2. UStaticMesh::Build called FStaticMeshComponentRecreateRenderStateContext and destroyed DenderData, but didn't touch Thumbnail's manager StaticMeshComponent as it was nullptr.
3. This resulted in a StaticMeshComponent with stale RenderData pointer.
#jira UE-54544
Change 3994033 by Rolando.Caloca
DR - vk - Reworked layers & extensions, as we were not doing it properly
- Remove -vulkanstandardvalidation and -novulkanstandardvalidation as they are not needed anymore
Change 3994275 by Mark.Satterthwaite
Change to linking against mtlpp via AddEngineThirdPartyPrivateStaticDependencies and marking its header with THIRD_PARTY_* macros in the vain hope that might convince the remote compilation code to distribute the module to the remote machine when building MetalRHI.
#jira UE-57507
Change 3994365 by Mark.Satterthwaite
Pilfer some code from the old MetalHeap file to handle calculating texture memory size on older macOS and iOS builds when running with stats or LLM enabled.
#jira UE-57513
Change 3994382 by Rolando.Caloca
DR - vk - Some missing locks during image tracking
Change 3994422 by Rolando.Caloca
DR - vk - Remove bogus shader format
Change 3995530 by Rolando.Caloca
DR - vk - Fix for crash when validation is enabled
Change 3995531 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3995532 by Rolando.Caloca
DR - vk - Added support for r.Vulkan.SaveValidationCache
Change 3995610 by Uriel.Doyon
Texture Streaming Changes and Fixes:
- Using the small FOV items (like scopes) now only affect visible primitives (through "r.Streaming.MaxHiddenPrimitiveViewBoost").
- Static components added after the level is registered in the streaming manager are now handled correctly (fixes the low quality on the chests)
- Dynamic components do not need to register to the streaming manager anymore.
- Optimized dynamic component management by removing duplicate entries in the update list.
- Added a pregarbage collect pass to the dynamic component management to optimize GC handling.
- Added a budget reset logic whenever the scene requirements change significantly.
- PIE worlds now have correct visibility information.
- Fixed possible invalid memory access when processing the streaming manager slave views.
- Refactored the incremental level texture data build to prevent new components from being unhandled.
- Removed StreamingManager callbacks for NotifyActorSpawned() and NotifyPrimitiveAttached()
- Added a StreamingManager callback NotifyPrimitiveUpdated(), to be used whenever a primitive streaming state must be updated.
#jira none
Change 3995908 by Arciel.Rekman
Fix compile errors when using new Vulkan queries.
Change 3995990 by Arciel.Rekman
More compile fixes to new Vulkan queries.
- MSVC did not catch this, clang did.
Change 3996101 by Rolando.Caloca
DR - vk - Win32 compile fix
Change 3996323 by Mark.Satterthwaite
Use the right include path to export the mtlpp headers.
#jira UE-57507
Change 3996392 by Arciel.Rekman
Vulkan: fix crash on start when using new queries.
- CommandBufferManager was not yet set at that point and the code in queries relied on it.
Change 3996585 by Rolando.Caloca
DR - Slight improvement to GL being black, but just a temporary 'workaround' as it's not correct.
Change 3998806 by Arciel.Rekman
Fix Linux build (UE-57602).
#jira UE-57602
Change 3998866 by Arciel.Rekman
SubwaySequencer: fix old shader platform name.
Change 3998947 by Mark.Satterthwaite
Silence deprecation warnings in CEF on macOS now that we've moved to 10.12 as the minimum.
#jira UE-57577
Change 3998951 by Mark.Satterthwaite
Fix last of the deprecation errors that I am aware of for macOS 10.12.
#jira UE-57581
Change 3998984 by Mark.Satterthwaite
Build mtlpp for iOS 9.0 not 9.3.
#jira UE-57586
Change 3999065 by Rolando.Caloca
DR - vk - Make sure we use version 1.0.0
#jira UE-57521
Change 3999071 by Arne.Schober
DR - [UE-55433, UE-57361] Hack SNORM support in OpenGL by re-interpreting UNORM. Underlying data is always SNORM.
#jira UE-55433, UE-57361
Change 3999494 by Rolando.Caloca
DR - Enable r.UnbindResourcesBetweenDrawsInDX11 in debug
- Clear compute resources when r.UnbindResourcesBetweenDrawsInDX11 is enabled
Change 4000197 by Krzysztof.Narkowicz
Mesh simplifier - normalize TexCoordWeights using min/max TexCoord range. This fixes precision issues for very big TexCoord values and allows to optimize for all TexCoord channels when channels have values of different magnitudes (e.g. non standard TexCoord data).
#jira UE-54935
Change 4000305 by Yuriy.ODonnell
Suppress PVS Studio warning V547 (Expression is always true) related to Aftermath
Reported issue to PVS team and to NVIDIA. Confirmed false positive, fix coming in future PVS version (v6.24).
#jira UE-57579
Change 4000853 by Arciel.Rekman
Linux: fix not calling CrashReportClient (UE-57678).
#jira UE-57678
Change 4001504 by Rolando.Caloca
DR - vk - Fix transition
Change 4002460 by Krzysztof.Narkowicz
Toggle for contant shadow length in word space
Exposed contact shadows to Blueprints
#jira none
Change 4002608 by Rolando.Caloca
DR - vk - Fix static analysis
- Fix potential debug image tracking crash
- Comment out unused methods
Change 4002615 by Rolando.Caloca
DR - vk - Allow r.Vulkan.WaitForIdleOnSubmit to be set at startup (e.g. in ConsoleVariables.ini)
Previously, if your map needed to UpdateSkyCaptureContents on startup, an ensure would fail if GWaitForIdleOnSubmit was set.
PrepareForCPURead needs to wait for the command buffer to finish before trying to read the results back, but the wait has already happened when r.Vulkan.WaitForIdleOnSubmit is set. Trying to wait again correctly complains that the command buffer is not in the correct state. So, skip the WaitForCmdBuffer call when r.Vulkan.WaitForIdleOnSubmit is set.
Change 4002640 by Rolando.Caloca
DR - vk - Missing support for CVarDefaultBackBufferPixelFormat
Change 4002919 by Guillaume.Abadie
Implements DOF's temporal upsampling pass for better dynamic resolution stability.
Change 4002984 by Guillaume.Abadie
Integrates Sebastian Aaltonen's ALU optimisations for TAAU.
Change 4003112 by Olaf.Piesche
Fir for TBB stall (resulting in severe hitches and hangs in the editor with stats active); tested multiple scenarios and encountered no hitches.
#tests QAGame PerformanceTest and RenderTest map with various stats on and off
Change 4003159 by Mark.Satterthwaite
Undo parts of changelist 3970553 - the ref-counted pointer approach to returning textures to the pool is not working as expected so we'll remove that. It'll be faster on the CPU without it and everything works thanks to the changes this CL made to the way textures were released.
#jira UE-57538
Change 4003287 by zachary.wilson
Adding reflection capture content to TM-LightingScenarios
Change 4003395 by Arne.Schober
DR - Fix unitzialised value when clicking Go To in the editor
#jira UE-57048
Change 4003425 by Rolando.Caloca
DR - vk - Fix for new occlusion queries
Change 4003530 by Arne.Schober
DR - Disable GPU Benchmark in headless configurations
#jira UE-57673
Change 4003717 by Rolando.Caloca
DR - vk - Fix for depth not store, stencil store
Change 4003719 by Rolando.Caloca
DR - Minor switch to render pass
Change 4003720 by Mark.Satterthwaite
Don't suballocate private memory buffers on Vega and only Vega as there is something wrong with the blits in those cases but I can't capture a GPU trace to find out what right now (the driver is broken) - could be a bug in my code but this works on Polaris and Nvidia so it will need to be filed as a radar for AMD.
Remove the FMetalBufferChunk from FMetalBuffer and simply store a pointer to the owning Heap/Magazine allocator. The FMetalResourceHeap now calls a new Release function to return the buffer to the allocator which will be faster on the CPU.
#jira UE-57659
Change 4003854 by Mark.Satterthwaite
Undo parts of 3990064 and try a different approach to get the uniforms to upload and remain available in the right places. As the original bug has been lost to time we should keep an eye out for missing buffer bindings by running under the Metal validation layer periodically.
#jira UE-57576
Change 4004709 by Rolando.Caloca
DR - Support for D3D 11, 12 & Vulkan for UAVs off Index Buffers
Change 4005149 by Guillaume.Abadie
Adds shader permutation to avoid clamping input buffer UV in DOF's gather pass.
Change 4005284 by Uriel.Doyon
Resaved volume texture assets with proper engine version.
#jira UE-57534
Change 4005286 by Guillaume.Abadie
Reduces constant setup in DOF's gather pass.
Change 4005359 by Rolando.Caloca
DR - vk - Fix annoying warning
Change 4005363 by Rolando.Caloca
DR - Fix android not finding vulkan shaders
Change 4005457 by Rolando.Caloca
DR - vk - Fix swapchain crash
Change 4005473 by Patrick.Kelly
UE-57135: Editor crash if set Reflection Capture Resolution to be 64 and New a Default level
Codde by Daniel
Tested by Patrick
Change 4005474 by Rolando.Caloca
DR - vk - Remove glsl code from shaders. Packaged QAGame goes from 176MB to 162MB
Change 4005759 by Krzysztof.Narkowicz
Fixed a bug, where reflection capture build is called, even though we are in mobile preview mode.
#jira UE-57743
Change 4005774 by Mark.Satterthwaite
Update the wave intrinsics to avoid implicit bool->uint conversion that Apple don't like.
#jira UE-57750
Change 4005974 by Mark.Satterthwaite
Don't use cubemap array types on iOS Metal as they aren't available on all devices and we need to maintain backward compatibiliy for years to come.
#jira UE-57083
Change 4006056 by Mark.Satterthwaite
Remove the use of the PrimitiveType argument from Metal draw calls.
#jira UE-57822
Change 4006139 by Mark.Satterthwaite
- Move the render-pass functions into the MetalRHI implementation for later alteration.
- Implement Index buffer UAVs for Metal - makes them more like vertex-buffers so this is one more step on the road to a unified buffer base-class implementation.
Change 4006215 by Mark.Satterthwaite
Metal's begin & end render/compute pass API implementation will take some time, but for now make it not depend on the parent stub implementation.
Change 4006394 by Mark.Satterthwaite
In lieu of a real instruction count just use the number of lines in the "Main" function of the shader as the instruction count for Metal.
#jira UE-57551
Change 4006493 by Mark.Satterthwaite
MetalRHI can currently support 4-component formats for Buffer UAVs - this might need some thought in the future as the API evolves but we might as well take advantage while we can.
Change 4006495 by Daniel.Wright
Integrate from Refactor branch
* New FMaterialRenderProxy function GetMaterialWithFallback which provides both the FMaterialRenderProxy and FMaterial. Needed when falling back to default material, so that proxy and material resource match.
* Local vertex factory uniform buffer
Change 4006851 by Brian.Karis
Fix for joined charts forming an L to inflate both axii.
Thanks to Jess Kube of The Coalition.
Change 4006852 by Brian.Karis
Fix for hard coded reflection capture cube map size. Should fix light static light aliasing in captures
Change 4006918 by Brian.Karis
New ByteBuffer functionality. Memcpy and scatter upload. Can implement GPU side TArray reflection.
Not yet used by checked in code. WIP optimization.
Change 4007246 by Guillaume.Abadie
Creates lower quality permutation for DOF's gathering pass, without Coc based weighting of the samples, and lower number of gathering ring for fast accumulator.
Change 4007291 by Guillaume.Abadie
Exposes more DOF scalability settings.
Change 4007328 by Guillaume.Abadie
Optimises DOF's half res only setup pass using gather4
Change 4007627 by Richard.Wallis
Fix for when Magic Mouse cannot zoom in World Composition editor. Missing default SNodePanel::OnMouseMove behaviour. Tested using a classic 2xbutton + wheel mouse and a Mac MagicMouse.
#jira UE-57030
Change 4007682 by Richard.Wallis
No video when playing HLS streaming video on Mac. 2 Issues, FPS was zero making duration for video sample buffer nonsense and Video Track dimensions were going to zero on the AVAsset once fully initialized when playing HSL streams. Now cache relevant details and handle zero frame rate.
Notes:
- Caching the frame rate is not as important as we could look it up each time and fix for zero - ignoring that at the moment.
- Assume we DO NOT want the FrameSize to be the last fetched video frame size from the AvfMediaVideoSampler as I think that is the video quality for streaming video and not the media frame size.
- Renamed a variable in the AvfMediaVideoSample - was called FrameRate but it was the FrameDuration by that point.
#jira UE-56734
Change 4007731 by Rolando.Caloca
DR - Disable byte buffers on non-hlsl based platforms
#jira UE-57851
Change 4007741 by Rolando.Caloca
DR - Disable byte buffers on hlslcc platforms
Change 4007782 by Mark.Satterthwaite
Force Metal shaders, including the stdlib, to recompile.
Change 4007918 by Rolando.Caloca
DR - vk - Some static asserts
Change 4008404 by Arciel.Rekman
Do not crash on incompatible Vulkan drivers (UE-57521).
#jira UE-57521
Change 4008442 by Daniel.Wright
Better comments on ERHIFeatureLevel expectations
Change 4008494 by Arne.Schober
DR - moved bDeletedThroughDeferredCleanup before begincleanup to catch cases where the reference is added twice to the array. also removed finishcleanup as all they ever did was deleting the pointer anyway, and it sould be adfded if such functionallity is ever required fom outside of the regular destructor.
#jira UE-57754
Change 4008730 by Mark.Satterthwaite
After the most recent changes to handling uniform buffer dirty bits in MetalRHI we should guard against attempts to set an unbound uniform buffer.
#jira UE-57870
Change 4008949 by Brian.Karis
Fix compile warning
Change 4008951 by Brian.Karis
Added LTC LUT textures
Change 4009326 by Guillaume.Abadie
Compiles out DOF's gathering bokeh simulation on platform other than desktop.
Change 4009380 by Krzysztof.Narkowicz
Moved area light code before the contact shadows, so contact shadows use representative light's direction.
Merged all contact shadows shader code.
Contact shadows keep constant screen space length independent of FoV settings.
Contact shadows for translucents.
Contact shadows for eye.
Change 4009555 by Guillaume.Abadie
Splits DOFCocTile.usf in two.
Change 4009999 by Yuriy.ODonnell
MallocStomp can now be enabled on certain platforms using '-stompmalloc' command line argument.
Previously it was necessary to modify MallocaStomp.h and re-compile the engine.
Currently supported platforms: Win64, Mac, Linux.
Replaced hard-coded page size with FPlatformMemory::GetConstants().PageSize.
Change 4010288 by Rolando.Caloca
DR - vk - Fix for vertex streams
Change 4010289 by Krzysztof.Narkowicz
D3D12 - fixed depth bounds bug, where depth bounds wasn't properly set to [0;1] after disabling.
#jira UE-57510
Change 4010297 by Rolando.Caloca
DR - vk - Remove some functions for android
Change 4010315 by Rolando.Caloca
DR - vk - Remove create info macro
Change 4010451 by Rolando.Caloca
DR - vk - Reuse samplers
- Infiltrator goes from 5759 to 24 samplers!
Change 4010627 by Rolando.Caloca
DR - vk - Fix missing values for tracking swapchain validation
Change 4011924 by Guillaume.Abadie
Implements tile based early return optimisation on DOF's postfiltering method.
Change 4011941 by Guillaume.Abadie
Shaves some ALU in DOF's accumulator for LowQuality permutation.
Change 4012093 by Yuriy.ODonnell
Disable MallocStompOverrunTest() in static analysis config, as it intentionally performs an out-of-bounds access.
Change 4012195 by Rolando.Caloca
DR - vk - Fix for mobile backbuffer layout
Change 4012202 by Rolando.Caloca
DR - vk - Don't use staging buffers on UMA
Change 4012467 by Rolando.Caloca
DR - Remove redundant check
Change 4012486 by Rolando.Caloca
DR - Fix missing transition
Change 4012518 by Guillaume.Abadie
Implements fast shader permutation for DOF's TAA pass.
Change 4013084 by Arciel.Rekman
Fix for Linux clock discrepancy.
- Causing at least one precision issue, possibly more.
(Edigrating 4003273, 4012462 from //UE4/Dev-Editor/... to //UE4/Dev-Rendering/...)
Change 4013266 by Uriel.Doyon
Fixed crash when setting SceneDepthTextureNonMS and not having valid depth buffers in the SceneContext.
Change 4013626 by Uriel.Doyon
Fixed crash in the lighting build when creating a blueprint of the ALight and placing a light component in it.
#jira UE-51672
Change 4013805 by Rolando.Caloca
DR - Fix more missing transitions
Change 4014128 by Arne.Schober
DR - Do not create LocalVFUniformBuffer when running without MVF
#jira UE-57929
Change 4014193 by Uriel.Doyon
Editing component transforms now invalidate the component's lighting cache.
#jira UE-48134
Change 4014282 by Rolando.Caloca
DR - vk - Remove extra validation during dump
Change 4014584 by Uriel.Doyon
Duplicated static meshes now generate a new GUID to prevent possible issues with lightmass.
#jira UE-49064
Change 4014604 by Uriel.Doyon
UStaticMesh postduplicate now only generates a new GUID if !bDuplicateForPIE.
Change 4015460 by Guillaume.Abadie
Composes separate translucency within DOF's recombine pass.
Change 4015571 by Guillaume.Abadie
Refactors tonemapper to use global shader permutation API, that adds permutation for HDR output device rather than dynamic branching that some shader compiler are not very well optimizing.
Change 4015984 by Krzysztof.Narkowicz
Fixed crash inside DFAO resource allocation, when DFAO viewport has zero area.
#jira UE-58000
Change 4016056 by Mark.Satterthwaite
Fix Mac Metal shader compilation of texture cube arrays.
Change 4016062 by Richard.Wallis
Convert things like Space, Delete, F6 etc to unicode so they display correctly on the Mac menu rather than first letter of word. Added the default Mac commands to the GenericCommands so we get a Chord overwrite message and stop things like cmd+ q / w / h from getting bound.
#jira UE-46999
Change 4016109 by Mark.Satterthwaite
One unified Metal buffer implementation - will make further changes a heck of a lot easier.
Change 4016221 by Patrick.Kelly
UE-57617: Ensure changing viewmode to ShaderComplexity while in -game
Change 4016238 by Guillaume.Abadie
Makes clang happy again in Tonemapper.
Change 4016309 by Mark.Satterthwaite
More *_RenderThread implementations for MetalRHI.
Change 4016414 by Mark.Satterthwaite
And MetalRHI version of CreateStructuredBuffer_RenderThread...
Change 4016498 by Mark.Satterthwaite
Don't hold on to the uniform buffers bound to the hull shader when switching to a tessellated draw call as they'll have the wrong buffer layout.
#jira UE-57930
Change 4017394 by Juan.Canada
OpenGL: Fixed shading artifacts due incorrect UNORM/SNORM conversions in skin/skincache/computetangent shaderss.
#jira UE-57691
Change 4017522 by Rolando.Caloca
DR - vk - Remove unused code path (old mip generation detection)
Change 4017539 by Rolando.Caloca
DR - vk - Fix for sky lighting mips showing green on AMD
Change 4017542 by Arciel.Rekman
Moved appCountTrailingZeros to a non-SSE header (fixes ARM64 build).
- Arguably WITH_SLI shouldn't apply to Linux on ARM but the fact that the function wasn't available is bad on its own.
Change 4017827 by Guillaume.Abadie
Optimises DOF's scattering cost by a third.
Change 4017835 by Rolando.Caloca
DR - Only allow a render pass to generate mips for one color render target
Change 4017889 by Mark.Satterthwaite
Cache all the Metal state objects to avoid hitting the API unnecessarily.
Change 4018251 by Mark.Satterthwaite
Fix broken rendering on Metal that tracked back to the innocuous looking changes in CL #4006495 (no blame attached - these changes are entirely reasonable) and cause various bugs in QAGame's TM-DistanceFields, ElementalDemo and probably more. Doesn't fix broken SpeedTree rendering :(.
MetalRHI was allowing uniform buffers to blow away linear texture buffers when the constant buffer has been elided due to dead-code elimination. This problem can manifest without linear textures if the uniform buffer contains both constant data and a resource-table but the shader doesn't use any of the constant data. That's because Metal doesn't separate constant buffers from any other kind of buffer unlike D3D which separates all the slots out - and Metal doesn't provide enough buffers to emulate the D3D arrangement. So far this has only manifested in the MVF + Linear Texture case but a more robust solution will be necessary long term.
Change 4018514 by Guillaume.Abadie
Implements r.DOF.Scatter.MinCocRadius.
Change 4018553 by Guillaume.Abadie
Implements r.DOF.Scatter.MaxSpriteRatio to control the budget upperbound of DOF's scattering
Change 4020369 by Yuriy.ODonnell
Disable MallocStompOverrunTest in all static analysis configs (using USING_CODE_ANALYSIS macro)
Previously was only disabled for PVS-Studio.
Change 4020620 by Arciel.Rekman
Fix XboxOne CIS (fallout of appCountTrailingZeros move).
Change 4020949 by Guillaume.Abadie
Configures DOF in scalability settings.
Change 4021593 by Rolando.Caloca
DR - vk - Support for Aftermath style api on AMD
Change 4021740 by Rolando.Caloca
DR - vk - Change log output
Change 4022008 by Uriel.Doyon
Fixed renderthread stalls when streaming texture mips on low end systems.
Change 4022135 by Rolando.Caloca
DR - vk - Fix last mip's layout during mip chain creation
Change 4022607 by Jian.Ru
Speculative fix for a bug where an invalid vertex buffer is deferenced
#jira UE-56229
Change 4022890 by Rolando.Caloca
DR - Fix reference count not getting released
Change 4023540 by Mark.Satterthwaite
Avoid some pointless retain/release calls on Metal Encoders.
Change 4023796 by Marcus.Wassmer
Tell users they are over the maximum size when allocating very large rendertargets.
Change 4025337 by Yuriy.ODonnell
Improved use-after-free detection mechanism and physical memory usage of MallocStomp on Windows.
MallocStomp on Windows will now reserve virtual address space for every allocation and then commit physical pages only to the valid usable part.
Physical pages will be unmapped on Free, but virtual address space will not be released and therefore will never be re-used.
Virtual address space is allocated from the OS in blocks of 1GB and then linearly sub-allocated.
This reduces VA space usage, as VirtualAlloc returns blocks on 64KB granularity even if we just need 4KB. As a small bonus, this also reduces number of syscalls per allocation.
This dramatically increases accuracy of use-after-free detection, but consumes significant amount of memory for the OS page table.
Virtual memory limit for a process on Win10 is 128 TB, which means we can afford to keep virtual memory reserved for a long time.
Running Infiltrator demo consumes ~700MB of virtual address space per second.
Additionally, committing physical pages only for the usable part of the entire virtual block reduces physical memory usage by ~30% compared to old behavior,
which allocated and committed entire block of pages via BinnedAllocFromOS and then marks border page as non-accessible.
Change 4026047 by Rolando.Caloca
DR - Fix test/shipping
#jira UE-58148
Change 4026150 by Krzysztof.Narkowicz
Force proper ordering of buffer visualization materials - after tonemapping (so exposure doesn't influence it) and before editor stuff like icons.
#jira UE-57992
Change 4026226 by Rolando.Caloca
DR - Fix static analysis
#jira UE-58150
Change 4026354 by Jian.Ru
Debug check trying to catch a crash. Only enabled in editor build
#jira UE-50111
Change 4026655 by Rolando.Caloca
DR - Fix for static analysis
#jira UE-58149
Change 4026763 by Rolando.Caloca
DR - Remove references to defunct CCT to avoid confusing licensees
Change 4027167 by Uriel.Doyon
Fixed possible out of bound buffer access when serializing with FDuplicateDataWriter.
#jira UE-56509
Change 4027850 by Jian.Ru
Prevent log spam
#jira UE-50111
Change 4029546 by Rolando.Caloca
DR - Compile fixes
Change 4029624 by Yuriy.ODonnell
Addressed static analysis errors in MallocStomp
- VirtualAlloc return value is now explicitly checked.
- C6250 is suppressed, as VirtualFree does not release address space by design.
Change 4030225 by Yuriy.ODonnell
Static analysis warning fix: make sure declaration of Sleep() is consistent between Windows headers and TBB
The complexity with this particular case is that the warning is generated in synchapi.h, which is included by some Windows headers.
If a module includes TBB and then Windows platform headers, static analyzer will report this warning.
Suppressing it would require wrapping all instances of Windows header includes in third-party macros.
Current pragmatic solution is to modify the Sleep() declaration in TBB header to be consistent with Windows and to report the issue to Intel for a permanent fix.
Change 4030440 by Rolando.Caloca
DR - Fix crash on mobile
#jira UE-58222
Change 4030570 by Daniel.Wright
Allow null SRV's in uniform buffers for feature levels that don't support SRV's in shaders
Change 4030618 by Arne.Schober
DR - missing tangent/normal sign conversion after integration from main
#jira UE-58224
Change 4031588 by Rolando.Caloca
DR - vk - Fix compile error when missing vkCmdWriteBufferMarkerAMD
Change 4032145 by Mark.Satterthwaite
Fix UE-58268 by only emitting the base_instance/base_vertex variables required to fix-up the instance/vertex ID values to match D3D when the Metal version is 1.1 or higher, earlier versions don't support these features.
#jira UE-58268
Change 4032209 by Rolando.Caloca
DR - Fix crash on EngineTest: Mesh Batch's UserIndex is not a union anymore
Change 4033178 by Guillaume.Abadie
Fixes FXAA sampling outside viewports, that was causing black outline on bottom and right edge of the screen when ViewSize != BufferSize, problematic for some screenshot automated test.
#jira UE-58151
Change 4034489 by Daniel.Wright
Fixed UStaticMeshComponent modifying its UStaticMesh when undoing a change. This caused a crash when other static mesh components using the same mesh asset were rendered, since their rendering state was not recreated. A component should not modify its asset during PostEditUndo.
* This behavior has been present for a long time but was previously hidden because only the vertex factory of the mesh asset is cached in static draw lists, not any of its rendering resources (eg vertex declaration).
Change 4035157 by Uriel.Doyon
Fixed deadlock in the streaming code when running with -onethread.
#jira UE-58299
Change 4035198 by Rolando.Caloca
DR - vk - Fix issue when an older SDK was installed, UBT would pick it (should pick the newer of ThirdParty\Vulkan or installed SDK).
#jira UE-58267
Change 4035730 by Arne.Schober
DR - Fix missing Fog parameters during LightScattering Injection
#jira UE-57608
Change 4035843 by Daniel.Wright
Reimplemented support for EyeAdaptation node in opaque materials
Change 4036837 by Marcus.Wassmer
Replace some of the screenshots to match new un-tonemapped buffer visualization
Change 4036980 by Rolando.Caloca
DR - vk - Fix deadlock contention during mem allocation on Linux
Change 4037225 by Guillaume.Abadie
Fixes jittering selection outline.
#jira UE-58350
Change 4038056 by Marcus.Wassmer
roll back changelist 4026150. breaks a bunch of automated tests by cutting off half the image.
Change can go back in later with that part fixed also
Change 4038296 by Jian.Ru
Static analysis fix
#jira UE-58377
Change 4038402 by Ben.Marsh
Suppress IncludeTool warnings caused by CL 3998947.
Change 4038514 by Arne.Schober
DR - Fix case with MVF where instance offset is not supported by the API (in this case only foliage OpenGL and TvOS), usually the buffers are offsetted instead but with MVF we do not use offsetted buffers, therfore the offset needs to be passed into the shader although we are drawing with offset of 0.
#jira UE-57652
Change 4038747 by Marcus.Wassmer
Back out changelist 3853645, causing us to lose shadows in the shaderhair test
Change 4040138 by Rolando.Caloca
DR - Fix compile warning
Change 4041614 by Rolando.Caloca
DR - vk - Fix for Oculus module
#jira UE-58267
Change 3810277 by Daniel.Wright
Ray Traced Distance Field shadows use a two pass tile culling algorithm with no tile max - fixes flickering from tile overflow in dense areas or with a low sun angle. Costs .2ms on PS4.
The distance field scene buffers now use float4 on PS4 and Xbox, saves .1ms on PS4.
Change 3817029 by Uriel.Doyon
Added UVolumeTexture, which use 3D textures. Compressed formats are supported on DX11, DX12, PS4 and XB1.
Projects targetting OpengGL don't have access to compressed formats (as the implementation has texture tiling issues).
Add "r.AllowVolumeTextureAssetCreation" set as 0 by default, which controls whether volume texture can be sampled in materials and whether they can be created from 2D texture assets.
Platform not supporting BC7, will now fallback on RGBA8 instead of DXT to preserve quality, in an attemps to increase usage of BC7.
#jira UE-32263
Change 3819960 by Michael.Lentine
Expose UEPhysics Clothing Parameters through UI.
Change 3823401 by Rolando.Caloca
DR - Add NumQueriesInBatch to RHIBeginOcclusionQueryBatch
Change 3844805 by Arne.Schober
DR - Increased Intermediate normal of Umodel and Skelmesh from 8bit Unorm Compressed to float. A resave/rebuid/reimport of the meshes is recommended to recover some lost precision.
Fixed an issue with compressed (packed) normals on the GPU which were off by one integer representation. Also switched from UNORM to SNORM to get a discrete zero representation and removed some mads from all the VertexShaders.
Change 3847283 by Marcus.Wassmer
Extra fixes from Uriel
Change 3876607 by Rolando.Caloca
DR - Use render passes when running occlusion queries
- Removes the RHI(Begin|End)OcclusionQueryBatch API
Change 3903799 by Daniel.Wright
[Integrate] Pass Uniform Buffers
* All pass-constant shader inputs should go into the appropriate pass uniform buffer, instead of being set per-draw
* Moved many per-draw base pass parameters over to the Base Pass Uniform Buffer
* Opaque and Translucent base pass shaders have different uniform buffers, which allows compile errors when accessing an invalid resource (eg GBuffer in Opaque), instead of silently falling back to GBlackTexture
Uniform buffers can now contain nested structs with UNIFORM_MEMBER_STRUCT()
* This allows composing a uniform buffer at a particular update frequency out of many features, with encapsulation of each feature's parameters in a struct.
* Eg deferred fog uses FFogUniformParameters, but so does translucency in the base pass, where FFogUniformParameters is reused nested inside the base pass uniform buffer.
* Resources can now be located anywhere in the uniform buffer. Padding is inserted to the cbuffer representation to keep memory layouts matching. In the future the cbuffer could be compacted.
* RemoveUniformBuffersFromSource() which works around HLSLCC lack of struct initializers now handles nested structs
Change 3917500 by Rolando.Caloca
DR - Change depth bounds so only the enable bit is in the PSO, allow min/max to be dynamically modified
Change 3964907 by Guillaume.Abadie
Implements RectList topology support in RHI.
Change 3979171 by Mark.Satterthwaite
Copying //Tasks/UE4/Dev-UERNDR-354-mtlpp to Dev-Rendering (//UE4/Dev-Rendering):
Rewrites MetalRHI in terms of mtlpp, which is a C++ wrapper library built around Metal's Objective-C API that attempts to reduce overheads and eliminate resource lifetime errors.
Regarding mtlpp:
- The mtlpp library uses C++ constructor/destructor and smart-pointer style management of Objective-C retain/release calls to prevent over- and under-release problems.
- To reduce Objective-C overheads the mtlpp library caches the internal C-function that implements the Objective-C selectors for the most commonly used Metal protocol types and calls the function directly - this avoids objc_msgSend which does this look-up dynamically and thus improves CPU performance slightly.
- Another advantage is that mtlpp provides infrastructure to extend the Metal API slightly to help improve MetalRHI - the two important aspects are mtlpp::CommandBufferFence which provides a consistent CPU<->GPU synchronisation primitive and sub-buffer allocations from mtlpp::Buffer which allow for far superior memory management.
- Validation functionality is also provided by mtlpp to detect CPU vs. GPU data races and resource lifetime validation - this is expensive and is thus optional and compiled out from Shipping binaries that should be used when performance is most critical. The validation only works between resource modification and *submitted* command-buffers - anything that is being actively encoded on the CPU is ignored and it remains the responsibility of the application to validate the order of operations when encoding.
Apple Platform:
- LLM support which tracks Objective-C objects is enabled only on macOS - we don't have the necessary libraries to intercept and override the internal system calls on iOS.
MetalRHI:
- All the types are switched over, (mostly) insuling the external API from the horror of Metal and Objective-C.
- Buffers are now managed quite differently, small buffers are allocated from a magazine allocator that allocates in fixed blocks from a larger parent buffer, intermediate sized buffers are allocated from a simple heap allocator that wraps a larger buffer and anything of reasonable size (>2Mb) will use the pooled allocator. This *radically* reduces the number of buffer resources, by as much as a factor of 10, because they are now sub-allocated without the need to use MTLHeap or MTLFence so they are performance equivalent to the existing implementation on the GPU and much faster on the CPU. Total memory use is approximately the same.
- Vertex & index buffer management has been updated to reflect changes in the management and to avoid reallocating buffers which provide a Linear Texture (for SRVs) unless strictly necessary. This ensures that even in cases where a dynamic buffer is updated multiple times in a frame it will still work acceptably well.
- The Metal ring-buffer implementation is completely different again, this time it can use Managed memory on macOS which allows for much better performance on eGPUs which will be more and more important for Mac.
- Everyone that needs to wait on a command-buffer fence (rather than a command-buffer itself) now use mtlpp::CommandBufferFence, which prevents race conditions between the different command-buffer handlers (which sometimes execute out of order).
- LLM tracking should now report the same data as the MetalRHI stats group for buffer & texture allocations - there is no segmentation for Vertex/index/Structured/Uniform allocations in Metal so these numbers are going to be wrong and will need to be rethought.
- What will be unseen are the number of small but important resource usage fixes that avoid stale resources from being bound to the device after the point at which they become invalid. This should eliminate a class of errors where the GPU uses a resource pointer that is modified by the CPU and was necessary to satisfy the new mtlpp validation code.
Other:
- Remove the Metal focused workarounds from the ClothBuffer resource binding and related vertex-buffer SRV - these were put in when MetalRHI/MetalShaderFormat couldn't handle float->uint conversions correctly and they should now.
- Fix a validation error caused by trying to render a 0-sized scissor rect which is invalid in Metal and simply pointless elsewhere.
- Consistency of disabling the Manual Vertex Fetch behaviour in shaders.
#jira UERNDR-354
Change 3979312 by Rolando.Caloca
DR - Remove bogus bKeepOriginalSurface parameter in CopyToResolveTarget
Change 4005122 by Rolando.Caloca
DR - Support for PS4 Index Buffer UAVs
Change 4016298 by Guillaume.Abadie
Fixes DOF hybrid scattering on platforms that supports RectList topology.
Change 4018575 by Guillaume.Abadie
Optimises DOF's reduce pass when doing scattering compilation.
Change 4020317 by Guillaume.Abadie
Implements WaveBroadcastIntrinsics.ush.
[CL 4042226 by Marcus Wassmer in Main branch]
#rb none
#lockdown Nick.Penwarden
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3804281 by Fred.Kimberley
Improve contrast on watches in blueprints.
Change 3804322 by Fred.Kimberley
First pass at adding a watch window for blueprint debugging.
Change 3804737 by mason.seay
Added some Descriptions to tests that didn't have any, and fixed some typos
Change 3806103 by mason.seay
Moved and Renamed Timers test map and content appropriately
Change 3806164 by Fred.Kimberley
Add missing property types to GetDebugInfoInternal.
#jira UE-53355
Change 3806617 by Dan.Oconnor
Function Terminator (and derived types) now use FMemberReference instead of a UClass/FName pair. This fixes various bugs when resolving the UFunction referenced by the function terminator
#jira UE-31754, UE-42431, UE-53315, UE-53172
Change 3808541 by Fred.Kimberley
Add support for redirecting user defined enums.
This is in response to the following UDN thread: https://udn.unrealengine.com/questions/404141/is-is-possible-to-create-a-redirector-from-a-bluep.html
Change 3808565 by mason.seay
Added a few more struct tests
Change 3809840 by mason.seay
Renamed CharacterMovement.umap to CharacterCollision. Fixed up content to reflect this change.
Change 3809847 by mason.seay
Added Object Timer tests. Fixed up existing timer test to remove delay dependency
Change 3811704 by Ben.Zeigler
Fix issue where identical enum redirects registered to different initial names would throw an incorrect error, it's fine if the value change maps are identical
Change 3811946 by Ben.Zeigler
#jira UE-53511 Fix it so it is possible to set a user defined struct value back to it's default. The UDS hack in PropertyValueToString is no longer needed, but this could affect some other user struct editor operations
Change 3812061 by Dan.Oconnor
Stepping over or in to nodes that are expanded at compile time (e.g. event nodes, spawn actor nodes) no longer requires multiple 'steps'
#jira UE-52854
Change 3812259 by Dan.Oconnor
Fix asset broken by removal of an unkown enum
#jira UE-51419
Change 3812904 by Ben.Zeigler
Make ResolveRedirects on StreamableManager public as it can be used to validate things
Change 3812958 by Ben.Zeigler
#jira UE-52977 Fix crashes when binding blueprint editor commands to keys and using from invalid contexts
Change 3812975 by Mieszko.Zielinski
Added contraptions to catch a rare eidtor-time EQS crash #UE4
#jira UE-53468
Change 3818530 by Phillip.Kavan
Fix incorrect access to nested instanced subobjects in nativized Blueprint ctor codegen.
Change summary:
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to properly reference the outer and check ptr validity when creating/obtaining nested default subobjects.
- Modified FEmitDefaultValueHelper::HandleClassSubobject() to better guard against code generation based on an invalid local variable name.
#jira UE-52167
Change 3819733 by Mieszko.Zielinski
Marked UAISenseConfig_Blueprint and UAISense_Blueprint as hidedropdown #UE4
#jira UE-15089
Change 3821776 by Marc.Audy
Remove redundent code in SpawnActorFromClass that already exists in ConstructObjectFromClass parent class
Change 3823851 by mason.seay
Moved and renamed blueprints used for Object Reference testing
Change 3824165 by Phillip.Kavan
Ensure that subobject class types are constructed prior to accessing a subobject CDO in a nativized Blueprint class's generated ctor at runtime.
Change summary:
- Modified FFakeImportTableHelper to tag subobject class types as a preload dependency of the outer converted Blueprint class type and not of the CDO.
#jira UE-53111
Change 3830309 by mason.seay
Created Literal Gameplay Tag Container test
Change 3830562 by Phillip.Kavan
Blueprint nativization bug fixes (reviewed/taken from PR).
Change summary:
- Modified FSafeContextScopedEmitter::ValidationChain() to ensure that generated code calls the global IsValid() utility function on objects.
- Modified FBlueprintCompilerCppBackend::EmitCreateArrayStatement() to generate a proper cast on MakeArray node inputs for enum class types.
- Modified FBlueprintCompilerCppBackend::EnimCallStatementInner() to more correctly identify an interface function call site.
- Modified FEmitHelper::GenerateAutomaticCast() to properly handle automatic casts of enum arrays.
- (Modified from PR source) Added new FComponentDataUtils statics to consolidate custom init code generation for converted special-case component types (e.g. BodyInstance). Ties native component DSOs to the same pre/post as converted non-native component templates around the OuterGenerate() loop.
- Modified FExposeOnSpawnValidator::IsSupported() to include CPT_SoftObjectReference property types.
- Modified UBlueprintGeneratedClass::CheckAndApplyComponentTemplateOverrides() to no longer break out of the loop before finding additional ICH override record matches.
#4202
#jira UE-52188
Change 3830579 by Fred.Kimberley
Add support for turning off multiple watches at once in the watch window.
#jira UE-53852
Change 3836047 by Zak.Middleton
#ue4 - Dev test maps for overlaps perf tests.
Change 3836768 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
Change summary:
- Modified FEmitDefaultValueHelper::AddStaticFunctionsForDependencies() to emit the correct signature for constructing FBlueprintDependencyData elements when the EDL boot time optimization is disabled.
#jira UE-53908
Change 3838085 by mason.seay
Functional tests around basic blueprint functions
Change 3840489 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Change 3840648 by mason.seay
Updated Descriptions on tests
Change 3842914 by Ben.Zeigler
Improve comments around stremable handle cancel/release
Change 3850413 by Ben.Zeigler
Fix asset registry memory reporting, track some newer fields and correctly report the state size instead of static size twice
Copy of CL #3849610
Change 3850426 by Ben.Zeigler
Reduce asset registry memory in cooked build by stripping out searchable names and empty dependency nodes by default
Add option to strip dependency data for asset data with no tags, this was always true before but isn't necessarily safe
Copy of CL #3850389
Change 3853449 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
Change summary:
- Consolidated FComponentDataUtils into FDefaultSubobjectData and extended FNonativeComponentData from it in order to handle both native & non-native DSO initialization codegen through a more common interface.
- Exposed FEmitDefaultValueHelper::HandleInstancedSubobject() as a public API and added a 'SubobjectData' parameter to allow initialization codegen to be deferred until after all default subobjects have been mapped to local variables within the current scope.
- Modified FEmitDefaultValueHelper::GenerateConstructor() to first map all default subobjects to local variables and then emit any delta initialization code for property values.
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to return an empty string for an instanced reference to a default subobject. This allows us to avoid emitting initialization statements to unnecessarily reassign instances back to the same property.
- Modified FEmitDefaultValueHelper::InnerGenerate() to better handle instanced references to default subobjects, ensuring that we don't emit unnecessary assignment statements and array initialization code to the converted class constructor in C++.
- Fixed a few typos.
#jira UE-53960
Change 3853465 by Phillip.Kavan
Fix plugin module C++ source template to conform to recent public include path changes.
Change 3857599 by Marc.Audy
PR #4438: UE-54281: Make None a valid default value to select (Contributed by projectgheist)
#jira UE-54281
#jira UE-54399
Change 3863259 by Zak.Middleton
#ue4 - Save bandwidth for replicated characters by only replicating 4 byte timestamp value to clients if it's actually needed for Linear smoothing. Added option to always replicate the timestamp ("bNetworkAlwaysReplicateTransformUpdateTimestamp", default off), in case users still want this timestamp for some reason, or if smoothing mode changes dynamically and the server won't know.
#jira UE-46293
Change 3863491 by Zak.Middleton
#ue4 - Reduce network RPC overhead for players that are not moving. Added ClientNetSendMoveDeltaTimeStationary (default 12Hz) to supplement existing ClientNetSendMoveDeltaTime and ClientNetSendMoveDeltaTimeThrottled. UCharacterMovementComponent::GetClientNetSendDeltaTime() now uses this time if Acceleration and Velocity are zero, and the control rotation matches the last ack'd control rotation from the server.
Also fixed up code default for ClientNetSendMoveDeltaTime to match default INI value.
#jira UE-21264
Change 3865325 by Zak.Middleton
#ue4 - Fix static analysis warning about possible null PC pointer.
#jira none
Change 3869828 by Ben.Zeigler
#jira UE-54786 Fix it so -cookonthefly cooperates with -iterate by writing out a development asset registry
Change 3869969 by mason.seay
Character Movement Functional Tests
Change 3870099 by Mason.Seay
Submitted asset deletes
Change 3870105 by mason.seay
Removed link to anim blueprint to fix errors
Change 3870238 by mason.seay
Test map for Async Loading in a Loop
Change 3870479 by Ben.Zeigler
Add code to check CoreRedirects for SoftObjectPaths when saving or resolving in the editor. This is a bit slow so we don't want to do it on load
We don't have any good way to know the type of a path so I check both Object and Class redirectors, which will also pickup Module renames
Change 3875224 by mason.seay
Functional tests for Event BeginPlay execution order
Change 3875409 by mason.seay
Optimized and fixed up character movement tests (because a potential bug in FunctionalTestActor is always passing a test when it can fail)
Change 3878947 by Mieszko.Zielinski
CIS fixes #UE4
Change 3879000 by Mieszko.Zielinski
More CIS fixes #UE4
Change 3879139 by Mieszko.Zielinski
Even moar CIS fixes #UE4
Change 3879742 by mason.seay
Added animation to Nativization Widget asset
Change 3880198 by Zak.Middleton
#ue4 - CanCrouchInCurrentState() returns false when character capsule is simulating physics.
#jira UE-54875
github #4479
Change 3880266 by Zak.Middleton
#ue4 - Optimize UpdateCharacterStateBeforeMovement() to do cheaper tests earlier (avoid CanCrouchInCurrentState() unless necessary, now that it tests IsSimulatingPhysics() which is not trivial).
#jira UE-54875
Change 3881546 by Mieszko.Zielinski
*.Build.cs files clean up - removed redundant dependencies from NavigationSystem and AIModule #UE4
Change 3881547 by Mieszko.Zielinski
Removed a bunch of DEPRECATED functions from the new NavigationSystem module #UE4
Removed all deprecates prior 4.15 (picked this one because I do know some licencees are still using it).
Change 3881742 by mason.seay
Additional crouch test to cover UE-54875
Change 3881794 by Mieszko.Zielinski
Fixed a bug in FVisualLoggerHelpers::GetCategories resulting in losing verbosity information #UE4
Change 3884503 by Mieszko.Zielinski
Fixed TopDown code template to make it compile after navsys refactor #UE4
#jira UE-55039
Change 3884507 by Mieszko.Zielinski
Switched ensures in UNavigationSystemV1:SimpleMoveToX to error-level logs #UE4
It's an error rather than a warning because the functions no longer do anything. Making it work would require a cyclic dependency between NavigationSystem and AIModule.
#jira UE-55033
Change 3884594 by Mieszko.Zielinski
Added a const FNavigationSystem::GetCurrent version #UE4
lack of it was causing KiteDemo to not compile.
Change 3884602 by Mieszko.Zielinski
Mac editor compilation fix #UE4
Change 3884615 by Mieszko.Zielinski
Fixed FAIDataProviderValue::GetRawValuePtr not being accessible from outside of AIModule #UE4
Change 3885254 by Mieszko.Zielinski
Guessfix for UE-55030 #UE4
The name of NavigationSystem module was put in wrong in the IMPLEMENT_MODULE macro
#jira 55030
Change 3885286 by Mieszko.Zielinski
Changed how NavigationSystem module includes DerivedDataCache module #UE4
#jira UE-55035
Change 3885492 by mason.seay
Minor tweaks to animation
Change 3885773 by mason.seay
Resaving assets to clear out warning
Change 3886433 by Mieszko.Zielinski
Fixed TP_TopDownBP's player controller BP to not use deprecated nav functions #UE4
#jira UE-55108
Change 3886783 by Mieszko.Zielinski
Removed silly inclusion of NavigationSystemTypes.h from NavigationSystemTypes.h #UE4
Change 3887019 by Mieszko.Zielinski
Fixed accessing unchecked pointer in ANavigationData::OnNavAreaAdded #UE4
Change 3891031 by Mieszko.Zielinski
Fixed missing includes in NavigationSystem.cpp #UE4
Change 3891037 by Mieszko.Zielinski
ContentEample's navigation fix #UE4
#jira UE-55109
Change 3891044 by Mieszko.Zielinski
PR #4456: Fix bug in UAISense_Sight::OnListenerForgetsActor (Contributed by maxtunel)
#UE4
Change 3891598 by mason.seay
Resaving assets to clear out "empty engine version" spam
Change 3891612 by mason.seay
Fixed deprecated Set Text warnings
Change 3893334 by Mieszko.Zielinski
Fixed a bug in navmesh generation resulting in not removing layers that ended up empty after rebuilding #UE4
#jira UE-55041
Change 3893394 by Mieszko.Zielinski
Fixed navmesh debug drawing to properly display octree elements with "per instance transforms" (like instanced SMs) #UE4
Also, added a more detailed debug drawing of navoctree contents (optional, but on by default).
Change 3893395 by Mieszko.Zielinski
Added a bit of code to navigation system's initialization that checks the enegine ini for sections refering to the moved navigation classes, and complain about it #UE4
The message is printed as an error-level log line and it says what should the offending section be renamed to.
Change 3895563 by Dan.Oconnor
Mirror 3895535
Append history from previous branches in source control history view
#jira none
Change 3896930 by Mieszko.Zielinski
Added an option to tick navigation system while the game is paused #UE4
Controlled via NavigationSystemV1.bTickWhilePaused, ini- and ProjectSettings-configurable.
#jira UE-39275
Change 3897554 by Mieszko.Zielinski
Unified how NavMeshRenderingComponent draws navmesh and octree collision's polys #UE4
Change 3897556 by Mieszko.Zielinski
Fixed what kind of nav tile bounds we're sending to nav-colliding elements when calling 'per-instance transform' delegate #UE4
#jira UE-45261
Change 3898064 by Mieszko.Zielinski
Made SM Editor display AI-navigation-related whenever bHasNavigationData is set to true #UE4
#jira UE-50436
Change 3899004 by Mieszko.Zielinski
Fixed UEnvQueryItemType_Actor::GetItemLocation and UEnvQueryItemType_Actor::GetItemRotation to return FAISystem::InvalidLocation and FAISystem::InvalidRotation respectively instead of '0' when hosted Actor ptr is null #UE4
Note for programmers: this changes the default behavior of this edge case. You might want to go through your code and check if you're comparing UEnvQueryItemType_Actor::GetItem*'s results to 0.
Change 3901733 by Mieszko.Zielinski
Made FEnvQueryInstance::PrepareContext implementations returning vectors and rotators ignore InvalidLocation and InvalidRotation (respectively) #UE4
Change 3901925 by Ben.Zeigler
#jira UE-55395 Fix issue where the cooker could load asset registry caches made in -game that do not have dependency data, leading to broken cooks
Change 3902166 by Marc.Audy
Make ULevel::GetWorld final
Change 3902749 by Ben.Zeigler
Fix it so pressing refresh button in asset audit window actually refreshes the asset management database
Change 3902763 by Ben.Zeigler
#jira UE-55407 Fix it so editor tutorials are not cooked unless referenced, by correctly marking soft object paths imported from editor project settings as editor-only
Change 3905578 by Phillip.Kavan
The UX to add a new parameter on a Blueprint delegate is now at parity with Blueprint functions.
#4392
#jira UE-53779
Change 3905848 by Phillip.Kavan
First pass of the experimental Blueprint graph bookmarks feature.
#jira UE-10052
Change 3906025 by Phillip.Kavan
CIS fix.
Change 3906195 by Phillip.Kavan
Add missing icon file.
Change 3906356 by Phillip.Kavan
Moved Blueprint bookmarks enable flag into EditorExperimentalSettings for consistency with other options.
Change 3910628 by Ben.Zeigler
Partial fix for UE-55363, this allows references to ObjectRedirectors to be switched from parent class to a child class on load as this should always be safe
This does not actually fix UE-55363 because that case is changing from UMaterial to UMaterialInstanceConstant, and those are siblings instead of parent/child
Change 3912470 by Ben.Zeigler
#jira UE-55586 Fix issue with saving redirected soft object paths where the export sort could accidentally cause the parent CDO to get modified between name tagging and writing exports, which is unsafe because due to delta serialization it would try to write names that were not previously tagged
Change 3913045 by Marc.Audy
Fix issues where recursion in to child actors wasn't being handled correctly
Change 3913398 by Fred.Kimberley
Fixes a misspelled name for one of the classes in the ability system.
PR #4430: Fixed spelling of FGameplayAbilityInputBinds. (Contributed by IntegralLee)
#github
#jira UE-54327
Change 3918016 by Fred.Kimberley
Ensure AllocGameplayEffectContext is being used in all cases where FGameplayeEffectContext is being created.
#jira UE-52668
PR #4250: Only create FGameplayEffectContext via AbilitySystemGlobals::.AllocGameplayEffectContext (Contributed by slonopotamus)
#github
Change 3924653 by Mieszko.Zielinski
Fixed LoadEngineClass local to UnrealEngine.cpp to check class redirects before falling back to default class instance #UE4
#jira UE-55378
Change 3925614 by Phillip.Kavan
Fix ForEachEnum node to skip over hidden enum values in new placements by default.
Change summary:
- Added FKismetNodeHelperLibrary::ShouldHideEnumeratorIndex() as an internal-only Blueprint node support API.
- Modified FForExpandNodeHelper::AllocateDefaultPins() to add a "Skip Hidden" input pin (advanced). Pin default value is false.
- Added a UK2Node_ForEachElementInEnum::PostPlacedNewNode() override to set the default value of the "Skip Hidden" input pin to 'true' for all new node placements.
- Modified UK2Node_ForEachElementInEnum::ExpandNode() to include additional expansion logic based on the "Skip Hidden" input pin. For new placements (i.e. when the pin defaults to 'true'), an intermediate branch node will now be inserted into the compiled execution sequence to test for "hidden" metadata on the value before executing the loop body. If the input pin is linked, another intermediate branch will be inserted into the execution sequence prior to the "hidden" metadata test. All existing placements of the node will remain as-is after compilation (i.e. no additional intermediate branch nodes will be included in the expansion).
#jira UE-34563
Change 3925649 by Marc.Audy
Fix up issue post merge from Main with navigation system refactor
Change 3926293 by Phillip.Kavan
Temp fix to unblock CIS.
#jira UE-34563
Change 3926523 by Marc.Audy
Ensure that a renamed Actor is in the correct Actors array
#jira UE-46718
Change 3928732 by Fred.Kimberley
Unshelved from pending changelist '3793298':
#jira UE-53136
PR #4287: virtual additions for AttributeSet extendability (Contributed by TWIDan)
#github
Change 3928780 by Marc.Audy
PR #4309: The display names of the functions. (Contributed by SertacOgan)
#jira UE-53334
Change 3929730 by Joseph.Wysosky
Submitting test assets for the new Blueprint Structure test cases
Change 3931919 by Joseph.Wysosky
Deleting BasicStructure asset to rest MemberVariables back to default settings
Change 3931922 by Joseph.Wysosky
Adding BasicStructure test asset back with default members
Change 3932083 by Phillip.Kavan
Fix Compositing plugin source files to conform to updated relative include path specifications.
- Encountered while testing Blueprint nativization of assets with dependencies on Composure/LensDistortion APIs.
Change 3932196 by Dan.Oconnor
Resetting a property to default now uses the same codepath as assigning the value from the slate control
#jira UE-55909
Change 3932408 by Lukasz.Furman
fixed behavior tree services attached to task nodes being sometimes recognized as root level
#jira nope
Change 3932808 by Marc.Audy
PR #4083: Change to UK2Node_BaseAsyncTask to have pin tooltips on latent nodes (Contributed by dwrpayne)
#jira UE-50871
Change 3934101 by Phillip.Kavan
Revise ForEachEnum node expansion logic to exclude hidden values at compile time.
Change summary:
- Removed UKismetNodeHelperLibrary::ShouldHideEnumeratorIndex() (no longer in use).
- Modified UK2Node_ForEachElementInEnum::ExpandNode() to include an enum switch node in the expansion, which will exclude hidden values when constructed. The additional expansion will occur if the enum type contains at least one hidden value.
#jira UE-34563
Change 3934106 by Phillip.Kavan
Mirrored 4.19 fixes to allow for EngineTest iteration w/ nativization enabled.
Change summary:
- Mirrored CLs 3876918, 3878968, 3883257, 3885566, 3912161 and 3920519.
Change 3934116 by Phillip.Kavan
UBT: Explicitly define the DEPRECATED_FORGAME macro only for non-engine modules.
Change summary:
- Modified UEBuildModule.SetupPrivateCompileEnvironment() to check the 'bTreatAsEngineModule' flag from the rules assembly rather than testing the module's build type.
Change 3934382 by Phillip.Kavan
Avoid inclusion of monolothic engine header files in nativized Blueprint codegen.
Change 3936387 by Mieszko.Zielinski
Added a flag to NavModifierComponent to control whether agent's height is being used while expadning modifier's bounds during navmesh generation #UE4
Change 3936905 by Ben.Marsh
Disable IncludeTool warning for DEPRECATED_FORGAME macro; we expect this to be different for game modules.
Change 3940537 by Marc.Audy
Don't allow maps, sets, or arrays with an actor inner type in user defined structs to select an actor from the currently open level as default value.
#jira UE-55938
Change 3940901 by Marc.Audy
Properly name CVar global to reflect what it is for
Change 3943043 by Marc.Audy
Fix world context functions not being able to be used in CheatManager derived blueprints
#jira UE-55787
Change 3943075 by Mieszko.Zielinski
Moved path-following related delegats' interface from NavigationSystemBase over to a new IPathFollowingManagerInterface #UE4
Change 3943089 by Mieszko.Zielinski
Fixed how WorldSettings.NavigationSystemConfig gets created #UE4
Made it so that there's always a NavigationSystemConfig instance present, but added a 'Null' config - this was required due to issues with creation/serialization of instanced subobjects.
The change required adding copying constructors to FNavAgentProperties and FNavDataConfig.
Also, fixed FNavAgentProperties.IsEquivalent to be symetrical.
Change 3943225 by Marc.Audy
Fix spelling of Implements
Change 3950813 by Marc.Audy
Include owner in attachment mismatch ensure
#jira UE-56148
Change 3950996 by Marc.Audy
Fix cases where bit packed properties used the entire byte not just the bit when interacting with boolean arrays
#jira UE-55482
Change 3952086 by Marc.Audy
PR #4483: Add Missing Radial Damage Multicast Delegate (Contributed by error454)
#jira UE-54974
Change 3952720 by Marc.Audy
PR #4575: Check if *Pawn* is a null Pointer (Contributed by dani9bma)
#jira UE-56248
Change 3952804 by Richard.Hinckley
Changes to BP API export commandlet to support better plugin exporting. Contributed by Harry Wang of Google.
Change 3952962 by Marc.Audy
UHT now validates that ExpandEnumAsExecs references a valid parameter to the function.
#jira UE-49610
Change 3952977 by Phillip.Kavan
Fix EDL cycle at load time in nativized cooked builds when a circular dependency exists between converted and unconverted assets.
Change summary:
- Added FGatherConvertedClassDependencies::MarkUnconvertedClassAsNecessary().
- Modified FFindAssetsToInclude::MaybeIncludeObjectAsDependency() to mark unconverted BPGCs (e.g. DOBPs) as necessary for conversion when the potential for a circular dependency exists so that we generate stub wrappers rather than depend on them directly.
- Fixed a few typos in existing API names.
#jira UE-48233
Change 3953658 by Marc.Audy
(4.19.1) Fix inserting a reroute node causing connections to break on a GetClassDefaults node
#jira UE-56270
Change 3954727 by Marc.Audy
Add friendly name to custom version mismatch message
Change 3954906 by Marc.Audy
(4.19.1) Fix crash when undoing changes related to reroute nodes connected to a GetClassDefaults node
#jira UE-56313
Change 3954997 by Marc.Audy
Ensure and return null if GetOuter<WithinClass> is called on a CDO for uclasses declared as within another so we don't get a UPackage c-style cast to the expected outer type
Change 3955091 by Marc.Audy
Do not register subcomponents that are not auto register
#jira UE-52878
Change 3955943 by Marc.Audy
Make AbilitySystemComponent pass parameters by const& instead of ref as no state is being changed
Change 3956185 by Zak.Middleton
#ue4 - Fix Characters using scoped movement updates (the default) not visually rotating when rotated at small rates at high framerate.
This was caused by FScopedMovementUpdate::IsTransformDirty() using a larger FTransform comparison tolerance than USceneComponent::UpdateComponentToWorldWithParent().
#jira none
Change 3958102 by Marc.Audy
Clean out dead code path from k2node_select
Select node now resets pins to wildcard if none of the pins are in use
Change 3958113 by Lukasz.Furman
added OnSearchStart call to root level behavior tree services
#jira UE-56257
Change 3958361 by Marc.Audy
Fix literal input pins on select being set to wildcard during compilation
Change 3961148 by Dan.Oconnor
Mirror 3961139 from Release 4.19
Fix for placeholder objects being left behind when loading certain UMG assets - this could causea crash when loading UMG assets
#jira UE-55742
Change 3961640 by Marc.Audy
Select node now displays Add Pin button
Undo of changing select node index type now works correctly.
Connections to option pins now maintained across change of index pin type
#jira UE-20742
Change 3962262 by Marc.Audy
Display "Object Reference" instead of "Object Object Reference" and "Soft Object Reference" instead of "Object Soft Object Reference"
Change 3962795 by Phillip.Kavan
Fix for a crash when cooking with Blueprint nativization enabled after encountering a nested instanced editor-only default subobject inherited from a native C++ base class.
- Mirrored from //UE4/Release-4.19 (3962782)
#jira UE-56316
Change 3962991 by Marc.Audy
Modify Negate/Increment/Decrement Int/Float so that the output is always the desired result even if a non-mutable pin is passed in.
Note that this can mean the result being returned and the value of the pin passed in if queried again will not be the same (in the case of pure nodes).
#jira UE-54807
Change 3963114 by Marc.Audy
Fix ensures/crash as a result of UClass expecting to be able to access the UPackage of CDOs via the GetOuterUPackage call.
Change 3963427 by Marc.Audy
Fix initialization order
Initialize bUseBackwardsCompatForEmptyAutogeneratedValue
Change 3963781 by Marc.Audy
Fix without editor compiles
Change 3964576 by Marc.Audy
PR #4599: : Working category for timelines (Contributed by projectgheist)
#jira UE-56460
#jira UE-26053
Change 3964782 by Dan.Oconnor
Mirror 3964772 from Release 4.19
Fix crash when force deleting certain blueprints, we can only check for authoritativeness while reinstancing
#jira UE-56447
Change 3965156 by Mieszko.Zielinski
PR #4592: Visual Logger optimization to fix rapid FPS drop when many items are hidden (Contributed by tstaples)
#jira UE-56435
Change 3965173 by Marc.Audy
(4.19.1) Fix incorrectly switching a cooling down tick to be an enabled tick when marking it enabled.
#jira UE-56431
Change 3966117 by Marc.Audy
Fix select nodes inside macros using wildcard array inputs having issues resolving type.
#jira UE-56484
Change 3878901 by Mieszko.Zielinski
NavigationSystem's code refactored out of the engine and into a new separate module #UE4
The CL contains required changes to all of our internal projects. Fortnite and Paragon have been tested, while the rest have been only compiled.
Change 3879409 by Mieszko.Zielinski
Further fallout fixes after ripping out NavigationSystem out of the engine #UE4
- Fixed bad ini redirects (had NavigationSystem.NavigationSystem instead of NavigationSystem.NavigationSystemV1)
- Added missing FNavigationSystem::GetDefaultNavDataClass binding (resulting in QAGame's func tests failing)
Change 3897655 by Ben.Zeigler
#jira UE-55211 Fix it so literal soft object pins on blueprint nodes get correctly cooked/referenced
It now sets the thread context to skip internal serialize and calls the archive's serialize function instead of bypassing it, which allows it to pick up references
Change 3962780 by Marc.Audy
When preventing a split pin from being orphaned, all sub pins must also be prevented.
#jira UE-56328
Repack members of UEdGraphPin to avoid wasted space (saves 16bytes)
[CL 3967553 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3944462 by Jack.Porter
Prevent TVOS packaging from PC from attempting to build an asset catalog
#jira UE-56114
Change 3943602 by Leslie.Nivison
Adding licenses for additional TPS
#jira none
Change 3943597 by Leslie.Nivison
Adding Enterprise licenses; licenses for additional TPS.
#jira none
Change 3941962 by Leslie.Nivison
Updating 4.19 credit list
#jira none
Change 3941865 by Mark.Satterthwaite
Fix the incorrect landscape rendering and the incorrect render-to-texture from blueprint bugs with MetalRHI.
- Track outstanding AsyncCopyBufferFromBufferToBuffer operations to identify attempts to modify overlapping ranges within the same prologue command-buffer. This doesn't work and requires that we break the current render-pass and issue on the current command-buffer. A log warning will be emitted when this occurs.
- Don't attempt to alias private memory buffers the moment they are released from the RHI resource because that can lead to incorrect sharing of the memory when used by AsyncCopyBufferFromBufferToBuffer.
#jira UE-56021
Change 3940993 by Marc.Audy
Do not return the last column if the specified column does not exist.
Allow display names to be used when looking for a property if the table is backed by a user defined struct.
Do not crash if a property with the given name is not found.
#jira UE-56017
Change 3939179 by Ben.Marsh
Revert change to not poison memory in development configuration. Making a tradeoff that editor stability and consistency is more important than performance.
#jira
Change 3938566 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Missed a case.
Change 3938533 by Dan.Oconnor
Fix uninitialized variable exposed by recent MallocTBB change
#jira UE-56013
Change 3938508 by Aaron.McLeran
Fixing CIS error, init order issues.
#jira UE-55940
Change 3938490 by Aaron.McLeran
#jira UE-55940 Fix for wavetable synth
Change 3938352 by josh.jensen
Show an error message for Windows iOS builds when packaging/launching and icons are present but no remote Mac is specified
#jira UE-55987
Change 3938345 by Peter.Sauerbrei
fix to Icons not being built on Mac
#jira UE-53492
Change 3938305 by Mark.Satterthwaite
For whatever reason moving the buffer initialisation into the prologue command buffer doesn't work - this make absolutely no sense to me. I suspect that this is *merely* moving a render pass boundary around somewhere and forcing raster-state to be reapplied.
#jira UE-56005
Change 3937968 by Ben.Marsh
Disable the boot DDC if we're not in the editor. Fixes access violations when multiple SCW instances attempt to read/write to the same file.
#jira UE-56003
Change 3937573 by Mitchell.Wilson
Saving asset to resolve empty asset warning.
#jira UE-56004
Change 3937561 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
Copied from Dev-Sequencer CL# 3937516
#jira UE-55986
Change 3937305 by Mike.Beach
Resaving google VR model content with UGS build to fix the empty file version error.
#jira UE-55984
Change 3935595 by Arne.Schober
Fix missing UV precission on BSP surfaces
#jira UE-54014
Change 3935411 by josh.jensen
Fixed Windows iOS remote Mac build issue where the user icons were considered remote Mac compilation targets coming solely from the Engine directory
#jira UE-55899
Change 3934982 by Marc.Audy
Fix shadow variable issue
#jira UE-55957
Change 3934892 by Mark.Satterthwaite
In MetalRHI treat BUF_Volatile buffers as Shared or Managed memory in all circumstances so that multiple updates within a render pass are respected even though this will hurt CPU performance. This fixes GPU particles on macOS. Also push initialisation upload into the async. command buffer to avoid it overwriting a later Lock/Unlock! Only read-back and copy-buffer operations should be on the 'current' command buffer as they need to be inline with all outstanding commands.
#jira UE-55956
Change 3934421 by Arciel.Rekman
Fix lockup/OOM when setting audio sources to 2 (UE-53968).
#jira UE-53968
Change 3934156 by Peter.Sauerbrei
fix for backgrounding problems on iOS and tvOS
this will re-open UE-50979 as the fix for that was not correct and would have caused crashes when backgrounding during startup
#jira UE4-55609
Change 3933547 by Aaron.McLeran
#jira UE-55940 Fix for wavetable sample duration and seek
Change 3933544 by Aaron.McLeran
#jira UE-55939 Hiding channel format
Submix channel format is an experimental feature and shouldn't be exposed to the submix editor for 4.19.
Change 3933540 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3933280 by Ethan.Geller
[Release-4.19] #jira UE-55810 Ensure AudioComponent is created before we start using it. #rb Aaron.McLeran
Change 3933079 by Ryan.Vance
#jira UE-55936
Fixed missing referenced uniform bindings on AR pass-through camera shaders.
Change 3932319 by Ben.Zeigler
#jira UE-55885 Fix corruption of packages when starting and then cancelling an async load of a package that already exists, or attempting to async load a script package
It now keeps track of which packages were created by the async load system and will only throw those away on cancel
Copy of CL #3932312
Change 3932287 by Matt.Kuhlenschmidt
Updated substance texture
#jira UE-55081
Change 3931729 by josh.jensen
Ensure the tvOS and iOS Assets.car is always produced as part of a regular remote/local build
#jira UE-55899
Change 3929723 by josh.jensen
Removed packaging requirement on Windows of a remote Mac after setting an app icon to default
#jira UE-53495
Change 3929722 by josh.jensen
Fixed iOS asset catalog generation issues when swapping out/resetting to default app icons for both code- and BP-projects
#jira UE-53492, UE-51879
#robomerge
Change 3929350 by Mike.Erwin
"Save As" support for
#jira UE-55732
Change 3927829 by Steve.Robb
Out-of-memory handler for MallocStomp.
#jira UE-55550
Change 3926404 by Mike.Erwin
#jira UE-55732
Change 3926394 by Dan.Oconnor
Recompile bytecode dependencies when compiling an individual blueprint interface, this prevents crashes due to stale bytecode
#jira UE-55813
Change 3926098 by Guillaume.Abadie
Do not allow dynamic resolution to be enabled on unsupported platforms avoiding game breaker experience by security.
#jira UE-55697
Change 3925927 by Guillaume.Abadie
Enables TAA's AA_BORDER on all permutation for dynamic resolution.
#jira UE-55353
Change 3925882 by Matt.Kuhlenschmidt
Fix substance uri having one extra /
Fix substance menu option showing up for github (incompatible with plugin)
#jira UE-55766
Change 3925873 by Ben.Zeigler
#jira UE-55783 Fix issue introduced in 4.18 where user structs did not handle converting AssetPtrs to SoftObjectPtrs properly
Copy of CL #3925871
Change 3925163 by Guillaume.Abadie
Fixes DFAO's temporal AA passes that was handling FViewInfo::ViewRect.Min wrongly.
#jira UE-55788
Change 3924839 by Guillaume.Abadie
Fixes a crash of LDR android preview with OS DPI scale != 0.
#jira UE-43622
Change 3924542 by Cosmin.Sulea
Merged fixes:
UE-55299 - XGE Shader Compile Interferes with Remote Shader Compiling Causing Materials to Fail to Compile #7
UE-51086 - No clear editor activity during remote shader compiling
#jira UE-55299
Change 3922398 by Mark.Satterthwaite
Compile fix for 3922273.
#jira UE-53993
Change 3922273 by Mark.Satterthwaite
Fix validation error caused by the game updating its orientation before the drawable system catches up. We need to drop drawables that are incorrectly sized until we get one with the correct size.
#jira UE-53993
Change 3921127 by Ethan.Geller
[Release-4.19] #jira UE-55744: Add OnTick virtual to IAudioPluginListener, fix thread safety issue in Resonance Audio. #rb aaron.mcleran
Change 3920632 by Lina.Halper
Fix render thread crash when morphtarget is deleted or added
#jira: UE-55521
Change 3920557 by Lauren.Ridge
Fixing material editor resetting background to off
#jira UE-55267
Change 3920519 by Phillip.Kavan
Fix a regression in which elements would not be initialized when constructing the value assignment for UDS-typed container members in nativized Blueprint C++ code.
Change summary:
- Modified FEmitDefaultValueHelper::InnerGenerate() to remove UDS from the list of special cases that avoid calling InitializeStruct() as part of new element construction. Previously the conversion code assumed the compiler would perform value initialization of a nameless temporary, but that is no longer valid in 4.19, as UDS types have been changed to function more like native structs, and as such all converted UDS types will now emit an explicit default ctor which is now used to assign defaults that differ from the zero-initialized value.
#jira UE-55628
Change 3920476 by Michael.Trepka
Clean up Mac menu item cache at exit before SlateApplication is fully destroyed.
#jira UE-55599
Change 3920336 by Ben.Marsh
Ignore license warnings from PVS-Studio.
#jira UE-55729
Change 3920134 by Jurre.deBaare
Moving over:
"HLOD: Building HLOD for P map with sublevels requires HLODSetupAsset when it should not
#fix Ensure that we dynamically add HLOD level treeview items whenever they are required, rather than adding a static number of levels according to the worldsettings"
#jira UE-55619
Change 3920126 by Max.Preussner
MediaCompositing: Implemented media track for Sequencer
Copied from Dev-Sequencer
#jira UE-53974
Change 3920004 by Jack.Porter
Disable Manual Vertex Fetch SRV creation when MVF is disabled.
Made a single RHISupportsManualVertexFetch(EShaderPlatform) to control whether to use MVF. The Shader Platform (or alternatively, feature level) is the only thing that can decide whether or not to use MVF because we need to know when we compile the shaders if we're going to do MVF or not. Checking GSupportsResourceView at runtime is useless because the shaders can't change and so if GSupportsResourceView can ever be false for a platform, the shaders need to have been built without it.
Creating SRVs without using them on mobile is not harmless because several devices don't support formats that are needed.
#jira UE-54764
#jira UE-55622
Change 3919069 by Aaron.McLeran
#jira UE-55718 Fix for playback progress.
Change 3918942 by Graeme.Thornton
Added "ProjectBuildMutatorFeature" modular feature, allowing plugins to register said feature and dictate whether the current project requires a code build. CryptoKeys plugin uses this feature to force a code build when encryption or signing is enabled.
#jira UE-55686
Change 3918721 by Zak.Parrish
Lighter version map for Gremlin + new Engine.ini - result is 60Hz #jira none
Change 3918236 by Joe.Graf
Added a bFlipTrackedRotation to give a better result when mirroring the rotation of a tracked face
#jira: UE-55531
Change 3917970 by Martin.Wilson
Expose curve data in remap assets to blueprints
#jira UE-55585
Change 3917740 by Olaf.Piesche
Properly checking for presence of buffer SRV capability via GSupportsResourceView so ES3.1 and Metal devices don't crash using GPU particles (and possibly in other circumstances);
#jira UE-55591
Change 3917713 by Cody.Albert
Build fixes for Match3 on iOS
#jira UE-53742
Change 3917472 by zak.parrish
added mouthPressLeft and MouthPressRight back into debug screen #jira none
Change 3917244 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsections and material containing grass spawning node
Change 3916775 by Ben.Marsh
Add missing files for packaging IOS on Windows.
#jira UE-53873
Change 3916293 by Joe.Graf
Removed the redundant GetTransform() from UARFaceGeometry since GetLocalToWorldTransform() is exposed on a base class
#jira: UE-55531
Change 3916011 by Joe.Graf
Added an accessor to get the transform of the face mesh or a face mesh component
#jira: UE-55531
Change 3915967 by Mark.Satterthwaite
Place buffer updates into the prologue command-buffer in MetalRHI to avoid breaking the current command-encoder. This improves performance, though the semantics of Metal now differ subtly to other RHI implementations as the buffer updates happen prior to the SetRenderTargets call in the GPU's view of the world.
#jira UE-54858
Change 3915751 by Nick.Atamas
Merging CL 3913931 from //UE/Partner-Google-VR/... to //UE4/Release-4.19/...
#jira UE-55639
Change 3915421 by Martin.Wilson
Fix crash from live link message bus heartbeat manager
#jira UE-55644
Change 3915326 by Dan.Oconnor
Make compilation manager's skeleton class layout better match the old compilation path's skeleton class layout, fixes a crash when renaming blueprint functions
#jira UE-55592
Change 3915250 by JeanLuc.Corenthin
Can't add C++ code to Enterprise projects (when enterprise is installed)
Root cause: When compiling a C++ project, Datasmith modules are included in the build process (with the wrong path)
Fix:
- Added two more Enterprise directories, Plugins and Intermediate, to the Enterprise directories to check against
- Build the correct path for the Datasmith modules and plugins in FindOrCreateModuleByName. Added check to see if module is under one of the Enterprise directories.
- Added modules to list of precompiled modeules in UEBuildTargets.AddPrecompiledModules if Engine and Enterprise are 'installed and the module is under Enterprise.
#jira UEENT-1032
Change 3915240 by Ben.Marsh
Reduce editor startup times by ~15s on Windows.
Platform loading code recursively scans every module for dependent DLL modules to load first. Change to make it early-out as soon as it encounters a module which is already in memory (via a call to GetModuleHandle() from ResolveMissingLibraryImportsRecursive). Also use a TSet<> to store set of visited modules rather than an Array.
Now spends <0.1s total in this function on editor startup.
(Change looks larger than it is due to moving functions out of WindowsPlatformProcess.h to avoid introducing TSet dependency into this header).
#jira UE-55642
Change 3914803 by Gil.Gribb
UE4 - Removed memory track from the lock free list links. This is not safe and will sometimes assert in debug.
#jira UE-49600
Change 3914616 by zak.parrish
Adding Calibrate button #jira none
Change 3914599 by Andrew.Rodham
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
Change 3914479 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3914347 by Martin.Wilson
Stop anim preview instance from ever running in parallel
#Jira UE-55577
Change 3914179 by Benn.Gallagher
Fixed clothing sections not displaying in LOD section list in skeletal mesh editor, due to no longer duplicating clothing sections in the model data.
#jira UE-55528
Change 3914122 by Steven.Barnett
Fix perf regression in BSP queries by changing suppression of PhysX mesh cleaning failure message.
#jira UE-54081
Change 3913950 by zak.parrish
Clamping my normalization math #jira none
Change 3913926 by Zak.Parrish
First pass at Gremlin Calibrate button. Also added shirt/backpack to boy so he's not a floating head. #jira none
Change 3913668 by Matt.Kuhlenschmidt
Adding missing substance styling info
#jira UE-55081
Change 3913667 by Nick.Atamas
Merging CL 3912976 from //UE4/Partner-Google-VR/... //UE4/Release-4.19/...
Upgrading to support ARCore 1.0 runtime.
#jira UE-55602
Change 3913645 by Aaron.McLeran
#jira UE-55618 fix for mono audio devices
Change 3913509 by Cody.Albert
Removing PhsX build exclusion from Match3
#jira UE-53742
Change 3913380 by Dan.Oconnor
Preload Sequence Bindings node at proper time
#jira UE-55412
Change 3913300 by Mitchell.Wilson
Updating iOS default startup movie to H.264, 1280x720, 30 fps.
#jira UE-55382
Change 3913291 by Cody.Albert
More iOS build fixes for Match3
#jira UE-53742
Change 3913169 by Cody.Albert
Fixed iOS build issues for UnrealMatch3
#jira UE-53742
Change 3913131 by Krzysztof.Narkowicz
Fixed remaining quad overdraw viewmode contents on screen after switching to certain other viewmodes (e.g. light overlap or complexity)
#jira UE-54580
Change 3912851 by Lina.Halper
Fixed issue with pose asset blending additively multiple poses suming up to 1 weight.
#jira: UE-55603
Change 3912629 by Guillaume.Abadie
Fixes SSR that was computing vigneting according to PrevScreen that could let some outside viewport samples going through when rotating the camera.
#jira UE-55353
Change 3912170 by Martin.Wilson
Add logging for UE-55511 (NaN crash)
#jira UE-55511
Change 3912161 by Phillip.Kavan
Fix editor-only default subobjects inherited from a native C++ parent class not being handled correctly during nativized Blueprint class ctor generation.
Change summary:
- Modified FEmitDefaultValueHelper::HandleSpecialTypes() to skip editor-only checks for instanced default subobjects. These will have already been created by a native parent class.
- Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert before creating a "dummy" component in place of an editor-only instance if we're not supposed to be creating it.
#jira UE-55474
Change 3912100 by Luke.Thatcher
[RELEASE] [^] Merging (as edit) fix for building pak patches (CL 3911754) from //UE4/Dev-Core to //UE4/Release-4.19
#jira UE-55340
Change 3912072 by Mike.Beach
Art cleanup pass on AR template icon.
#jira UE-55587
Change 3912057 by Michael.Trepka
Additional widget path validity check in FSlateUser::NotifyWindowDestroyed()
#jira UE-55580
Change 3911592 by Jurre.deBaare
Crash on merge actor when Use specific LOD Level
#fix make sure we use the correct array to determine the number of components being merged
#jira UE-55508
Change 3911466 by Cosmin.Sulea
Mega change list for the following related issues:
UEMOB-417 - Support Xcode automagical code signing
UE-49829 - Remote build fails to use / sign distribution provisions coming from PC
UE-39501 - Packaging for tvOS in Distribution fails to find valid provision
UE-55334 - XCode managed provisions don╞t operate gracefully with manual provisions
UE-55330 - Automatic signing doesn't work with tvOS
UE-10969 - Remote build fails if there is no development provision provided
#jira UEMOB-417
Change 3911454 by Luke.Thatcher
[RELEASE] [!] Fix rendering thread memory leak in FLandscapeComponentSceneProxy::InitViewCustomData
- FViewCustomDataLOD is allocated on a memstack, but contains a TArray, so is not trivially destructible.
- The SubSections array is leaked when the memstack is popped.
- Fix replaces the TArray with a TStaticArray of max size MAX_SUBSECTION_COUNT (which is 4).
(Merging as edit CL 3911422 from //Fortnite/Release-3.1/... to //UE4/Release-4.19/...)
#jira UE-54835
Change 3911370 by Dragan.Jerosimovic
changed browOuterLeft -> browOuterUpLeft, browOuterRight->browOuterUpRight
updated KiteBoyHead_JointsAndBlends.fbx
#jira none
Change 3910545 by Dan.Oconnor
PR #4512: Fix FNetNameMapping::GetUniqueName regression (Contributed by dfb)
#jira UE-55513
Change 3910449 by Michael.Trepka
Fix for crash on exit on Mac when closing the root editor window with Cmd+W
#jira UE-54973
Change 3909601 by Patrick.Boutot
Expose to Blueprint GetProjectDirectory functions.
#jira UE-55548, UEENT-999
Change 3909543 by Patrick.Boutot
Rename ECollisionResponse to CollisionResponseType in script to prevent collision with FCollisionResponse.
Python's help function now output the Python type instead of the cpp type.
Do not export hidden enum entry from Python.
#jira UE-55545, UEENT-961
Change 3909289 by Zak.Parrish
Adding shirt/chest to faceAR sample #jira none
Change 3908808 by Dragan.Jerosimovic
added combination shapes network
#jira none
Change 3908788 by Mitchell.Wilson
Updaing Match3Camera to resolve clipping issue on iPhone X
#jira UE-54723
Change 3908374 by Jack.Porter
Fix viewport offset problem for preview PIE window
#jira UE-52583
Change 3907108 by Shane.Caudle
#JIRA
Added DefaultDeviceProfiles.ini to set the [IOS DeviceProfile]
+CVars=r.ShadowQuality=4
Change 3907105 by Lauren.Ridge
Fix for thumbnails not resetting when layers/blends reset and for them being incorrectly scaled when null
#jira UETOOL-1303
Change 3907011 by Chris.Phillips
UE-52667 Unable to package an Android DLC Using "Android APK" and "Android DLC" profiles in Project Launcher.
#jira UE-52667
Change 3906792 by Lauren.Ridge
When constructing the material editor viewport, use the direct method to set the environment visibility.
#jira UE-55267
Change 3906734 by Chris.Babcock
Fix issue with vertex fetch disable
#jira UE-55475
Change 3906721 by Rolando.Caloca
UE4.19 - Check if the results file from SCW is corrupt
#jira UE-53124
Change 3906648 by Chris.Phillips
UE-53184 Assertion when running mobile PIE in iPhone 5S mode.
Updated the iPhone5s.json Metal settings.
#jira UE-53184
Change 3906474 by David.Hibbitts
Added default constructor for FLiveLinkWorldTime.
#jira UEENT-879 #rb none
Change 3906467 by Lauren.Ridge
Swapping sibling materials now correctly swaps the overridden parameters out
#jira nojira demobug
Change 3906156 by Michael.Trepka
Reverting CL 3728924 as it's causing problems with modal windows. A different, much more involved fix for UE-51711 will be needed.
#jira UE-52492
Change 3906144 by Michael.Dupuis
#jira UE-54547: Added guard to be sure that material is valid
Change 3905882 by Matt.Kuhlenschmidt
Enable substance buttons again
#jira UE-55081
Change 3905513 by Sorin.Gradinaru
UE-55394 iOS crash exiting app during startup movie: SPRINGBOARD, process-exit watchdog transgression
#jira UE-55394
#jira UE-52328
#iOS
#4.19
This is a particular case of UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
Found several issues on iOS if the game is forced closed when the startup movie is playing and "Wait for movies to complete" is enabled in Project Settings
- the game thread is waiting for the movie to complete on game shutdown - more that 5 sec
- crash on FDefaultGameMoviePlayer::Shutdown if the above is fixed
- HTTP module no longer has time to wait for the requests to complete.
Change 3905506 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
#jira 0
Change 3905498 by Lina.Halper
Fix multiple pose asset issue - fallout from CL 3903509
- as for fullbody, went back to old mathod because in the fullbody, we want shortest path most of times and you don't blend more than 1 weight, so this is likely fine
- as for additive, change to use blend from identity.
#jira: UE-55439, UE-55448, UE-55250
Change 3905325 by Sorin.Gradinaru
UE-54764 UnrealMatch3 spams Kindle device log with "Unsupported EPixelFormat"
#jira UE-54764
#4.19
Also reproduced on Samsung Galaxy S5 Neo (SM-G903F, GPU Mali-T720).
Check GMaxRHIFeatureLevel > ERHIFeatureLevel::ES3_1 (not mobile) before creating RSV params used with SupportsManualVertexFetch: (Positions, Tangents, TextureCoordinates, Color buffers)
Change 3905307 by Jack.Porter
Removed iPhone5 PIE json file as it's not a supported device
#jira UE-53184
Change 3905132 by Shane.Caudle
#JIRA
Pushed it a little more out of the yellow.
Change 3905117 by Shane.Caudle
#JIRA
Got SSS working and made some tweaks.
Change 3904936 by Max.Chen
Fix editor only
#jira UE-55459
Change 3904269 by Chris.Babcock
Disable manual vertex fetch on mobile
#jira UE-55389
#ue4
#android
#ios
Change 3904186 by Lina.Halper
Pose asset crash when skeleton not existing during serialization
#jira: UE-55422
Change 3904063 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene spawn register.
Copy from Dev-Sequencer
#jira UE-55314
Change 3904060 by Lauren.Ridge
Fix for saving a child out of a layer stack capturing the wrong parameters
#jira UETOOL-1280
Change 3904050 by Luke.Thatcher
[CONSOLE] [^] Added RHI Command List Enqueue Lambda method (merging as edit CL 3879722 from //Fortnite/Main to //UE4/Release-4.19)
- Can be used to enqueue arbitrary tasks on the RHI thread from the render thread (similar to how EURC works for GT -> RT tasks), without having to write lots of bolierplate FRHICommand functor classes.
- The first overload of EnqueueLambda method will check Bypass() to determine if it should run the lambda immediately or defer to the RHI thread.
- This can be overriden via the 2nd overload if you need to check additional things such as IsRunningRHIInSeparateThread.
- The function returns true if the lambda was enqueued and deferred to the RHI thread, otherwise false. This can be used to optionally add RHIThreadFences for unlock commands etc.
#jira UE-55437
Change 3904004 by Lauren.Ridge
Fix for material layer output nodes being able to be placed in other graphs
#jira UE-54867
Change 3903931 by Aaron.McLeran
#jira UE-55435 Crash in google resonance when toggling visualization
fix for issue described here -- https://github.com/resonance-audio/resonance-audio-unreal-sdk/issues/1
Change 3903722 by David.Hill
The ProxyLOD plugin is experimental: don't load it by default.
#jira: ue-55402
Change 3903583 by Ben.Marsh
Include .version and .modules files in manifest. Should fix missing version information in precompiled binaries.
#jira
Change 3903529 by Richard.Hinckley
#jira UEDOC-7180
4.19 API Documentation manual update.
Change 3903509 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: Fix issue with pose blending with shortest path - causing additive to blend linearly between pose if the rotation is same direction.
#jira: UE-55250
Change 3903501 by Michael.Dupuis
#jira UE-55122: Fixed bad neighbors updating for mobile
Change 3903387 by Will.Fissler
; r.XGEShaderCompile is now enabled by default in source. Uncomment to disable XGE shader compilation.
;r.XGEShaderCompile = 0
#jira UE-55286
Change 3903251 by Sungjin.Hong
#JIRA UE-55349
#loc added KO locallization for VR, Handheld AR templates
Change 3903219 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54738
removed redundant iOS warning when IOnlineIdentity::Login is called by FOnlineExternalUIIOS::ShowLoginUI
#jira UE-54738
#iOS
Change 3903130 by Cody.Albert
Updated build configuration to resolve iOS build error on UnrealMatch3
#jira UE-53742
Change 3903056 by Shane.Caudle
#JIRA
Latest tweaks to lighitng and rendering for boy.
Change 3903032 by Cody.Albert
Added missing include that was preventing iOS builds from succeeding on TopDown template
#jira UE-54341
Change 3902669 by Lauren.Ridge
Fix for thumbnail crash after saving material instances that contain layers
#jira crash
Change 3902581 by Mitchell.Wilson
Updating Samples and Template Min iOS Version to iOS 9.
#jira UE-55148
Change 3902448 by Lauren.Ridge
Fix for crash due to unparented material instance
#jira crash
Change 3902206 by Chris.Phillips
UE-52612 External textures only work in pixel shaders.
Sampling external textures are now only limited to pixel shaders when the shader model is < SM4.
#jira UE-52612
Change 3902120 by Peter.Sauerbrei
bvringing over the fix for backgrounding crash on iPhone X from Fortnite
#jira UE-54883
Change 3902097 by Lina.Halper
Merging using //UE4/Dev-AnimPhys/->//UE4/Release-4.19/
#DUPE MERGE: CL 3901939
#jira: UE-55401
Change 3902082 by Mike.Beach
Fixing an issue with the fix from CL 3889470 - fully matching the old UEnum name check (checking both the value name and the typed name, for example: "Left" and "EControllerHand::Left").
#jira UE-55153
Change 3901963 by Peter.Sauerbrei
bring over the fix from Fortnite for Remote Shader Compilation not respecting settings in the passed in shader
#jira UE-52797
Change 3901959 by Ethan.Geller
[Release-4.19] #jira UE-55225: Stop RtAudio stream on StopRecording in sequence recorder. #rb Aaron.McLaren
Change 3901482 by Lauren.Ridge
Fix for crash on opening materials due to array out of bounds
#jira crash
Change 3901181 by Michael.Dupuis
#jira UE-55313: To enable tessellation we MUST have 2 materials in the list
Change 3900935 by Nick.Bullard
Updating Default_Startup.mp4 with more recent UE branding.
This still requires another update for final version with audio
#jira UE-55382
Change 3900660 by Aaron.McLeran
#jira UE-55381 crash in sound submix
Bringing fix from FN to 4.19 (CL 3890630)
Change 3900643 by Aaron.McLeran
#jira UE-55380 fixing synth envelopes
Change 3900617 by Aaron.McLeran
#jira UE-55151 Fixing crash w/ mic component
Change 3900544 by tim.gautier
QAGame: Submitting asset for AsNumber fix submitted with UE-10310
#jira UE-29618
Change 3900430 by Ryan.Brucks
KismetRenderingLibrary: Applied a fix from FN to make it possible to create textures from BP created RTs. Without the fix the assets would be created but invisible to the user due to missing RF_Public and RF_Standalone.
#JIRA none
Change 3900399 by Lauren.Ridge
Fixing global parameters not working
#jira UE-55242
Change 3900297 by Ben.Marsh
Speculative fix for hot reload causing version files to be updated with a locally made installed build.
#jira UE-55072
Change 3900116 by Chris.Bunner
Removing outdated tests and test assets.
#jira UETOOL-1298
Change 3900042 by Chris.Bunner
Deleted SharedInputCollection and associated material graph nodes.
#jira UETOOL-1298
Change 3899887 by Lauren.Ridge
Fix for background checkbox stomping profile info for material editor. Note that you may have to delete Saved/Config/Windows/Editor.ini to get this to work.
#jira UE-55267
Change 3899824 by Chris.Phillips
UE-52813 Editor's mobile preview doesn't serialize the landscape's cooked heightmap data.
Now only regenerating landscape pixel data when needed when using Mobile Preview Rendering Levels.
#jira UE-52813
Change 3899775 by Lauren.Ridge
Fix for crash on opening material layer material
#jira crash
Change 3899673 by Jamie.Dale
Fixed Functions sometimes being exposed to Python as if they were Structs
#jira none
Change 3899487 by Chris.Bunner
Duplicate [CL 3852020, 3896571] - Disabling non-performant code only required by experimental material layers feature. Users can opt-in per-project through experimental renderer settings, replacing the previous editor experimental flag.
#jira UETOOL-1298
Change 3899156 by Phillip.Kavan
Include address of object reference in persistent frame debug info.
#jira UE-51952
Change 3899146 by Rolando.Caloca
UE4.19 - hlslcc - Workaround for intrinsics with two output arguments
#jira UE-52477
Change 3899060 by Bart.Hawthorne
Add a null check for the game mode pointer in UWorld::SpawnPlayActor
#jira UE-54461
Change 3899015 by Krzysztof.Narkowicz
Fixed initialization of instancing random vertex stream.
#jira UE-53605
Change 3899008 by Michael.Dupuis
Fix issue with landscape mobile vertex factory accessing unbound LodTessellationParams when r.ShaderDevelopmentMode=1
#jira 0
Change 3898994 by Phillip.Kavan
More verbose debug logging if an invalid object reference is detected in the BP ubergraph frame during garbage collection.
#jira UE-51952
Change 3898962 by Guillaume.Abadie
Fixes wrong parameters about whether GPU timing may have CPU generated bubbles to the dynamic resolution heuristic.
#jira UE-55352
Change 3898826 by Sorin.Gradinaru
UE-54784 StrategyGame crashes entering game on KindleFire 7 - Assertion failed: ViewSize.GetMin
#4.19
#Android
#jira UE-54784
Wrong code to make an integer even + operator precedence
Change 3898822 by Sorin.Gradinaru
UE-52328 iOS reporting crash on application exit: SPRINGBOARD, process-exit watchdog transgression
FORT-70783 FHttpManager::Flush is immediately canceling all HTTP requests
#jira UE-52328
#jira FORT-70783
#iOS
#PC
#4.19
UE-52328 reopened because of FORT-70783
iOS only: Delay Request->CancelRequest() on Http module shutdown - wait for 2 sec on FHttpManager::Flush to allow pending requests to be sent to the server.
Change 3898705 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3898108 by Michael.Dupuis
#jira UE-54547: Remove the FORCEINLINE so we get a proper callstack of what's happening
Change 3898076 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3897897 by Matt.Kuhlenschmidt
Disable substance buttons for now
#jira UE-55081
Change 3897742 by Aaron.McLeran
Merging fix for UE-55223 to 4.19
#jira UE-55223
Change 3897538 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3897406 by Phillip.Kavan
Back out local debug logs.
#jira UE-51952
Change 3897400 by Phillip.Kavan
Serializing object will now be passed to GC so that it can be logged in case the referenced objects is garbage.
- Mirrored from //UE4/Dev-Core (3871863).
#jira UE-51952
Change 3897391 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897274 by Krzysztof.Narkowicz
Fixed issues with loading shaders from DDC - hardcoded CustomAttributes initialization instead of filling them inside UObject costructors in order to properly initialize CustomAttributes before DDC key was created. Added an assert that CustomAttributes are initialized before the AttributeDDCString, so we won't run into this issue again in the future.
#jira UE-54683
Change 3897148 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-55147
#4.19
#iOS
#jira UE-55147
Change 3897138 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Copy from Dev-Sequencer
#jira UE-55309
Change 3897045 by Jack.Porter
Fix for crash in ALandscapeProxy::UpdateGrass
#jira UE-54362
Change 3897036 by Jack.Porter
Fix InstancedStaticMesh crash with invalid lightmap coordinates
#jira UE-54423
Change 3896801 by Dmitriy.Dyomin
Fixed: Planar reflections does not handle origin rebasing
#jira UE-52351
Change 3896743 by Dmitriy.Dyomin
Discard CPU copy of vertex/index buffers in OpenGL RHI
#jira UE-52133
Change 3896619 by Guillaume.Abadie
Cherry-pick 3896598: Fixes after TAAU post process material that had wrong default buffer UV.
#jira UE-55317
Change 3895718 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3895426 by Rolando.Caloca
UE4.19 - Add an increased timeout for SCW to avoid OOM situations
#jira UE-55306
Change 3895245 by tim.gautier
QAGame: Submitting updated test assets. Broke ML_Base out into individual components
#jira UE-29618
Change 3895194 by Marc.Audy
Prevent crash due to a null entry in the linked to graph of the destination pin
#jira UE-54606
Change 3894913 by Arne.Schober
REL - Fix crash in Speedtree wind where Renderdata is unavailable
#jira UE-54544
Change 3894625 by Arne.Schober
REL - Fix assert not in RenderingThread from Triangle Renderer.
#jira UE-55247
Change 3894464 by Martin.Wilson
Extra debugging info for UE-54705 plus remove check so it is no longer fatal
#jira UE-54705
Change 3894450 by Martin.Wilson
Remove pinnable ness of retarget asset. Paves the way for exposing retarget asset properties on the node
#jira none
Change 3893948 by Jostin.Bilyeu
Adding default player start location to help with launch on testing within level TM-Materials_POM
#jira UE-55063
Change 3893495 by Robert.Manuszewski
Fixing a crash when running DDC commandlet
#jira UE-54646
Change 3893451 by Jurre.deBaare
Altered fix for actor merging with negative scaling to get correct normals
#jira UE-54996
#misc updated automated test to include this test-case
Change 3892913 by Ethan.Geller
[Release-4.19] #jira UE-55151 Fix for Mic Component crashing on re-init. #rb aaron.mcleran
Change 3892871 by Ryan.Vance
Multi-view requires the day dream compositor.
#jira UE-55253
Change 3892785 by Arciel.Rekman
Linux: fix inability to create a C++ project (UE-55222).
- NullSourceCodeAccessor will unconditionally allow C++ project creation in source builds.
- Installed build will check for more compilers in commonly found locations.
#jira UE-55222
Change 3892687 by Jostin.Bilyeu
Checking in replacement Built Data for map TM-Materials_POM
#jira UE-55063
Change 3892674 by Jostin.Bilyeu
Adding an invisible plane to TM-Materials_POM to help testing on mobile devices
#jira UE-55063
Change 3892622 by Aaron.McLeran
#jira none Fixing scope lock in phonon probe volume
Change 3892511 by Matt.Kuhlenschmidt
Fix zero engine version warning
#jira UE-55081
Change 3892211 by Yuriy.ODonnell
Fix/workaround for inconsistent preprocessor definitions for NVAftermath that result in FD3D11DynamicRHI class layout mismatch. NVAftermath support is now enabled by default for Win64.
NVAftermath is declared as a private dependency in D3D11RHI. It does not automatically propagate to modules that explicitly include private RHI headers (OculusHMD, OSVR, OSVRInput). This results in NV_AFTERMATH being defined while compiling RHI module and not defined when compiling other modules, causing memory corruption at runtime.
The long-term solution for this and similar issues requires some mechanism for adding transitive module dependencies, so that anyone that depends on D3D11RHI module would automatically also get the NVAftermath. Additionally, private headers should *never* be included directly by external modules.
The short-term solution is to explicitly add NVAftermath dependency to OculusHMD, OSVR and OSVRInput.
Additionally, NV_AFTERMATH is no longer forced by D3D11RHIPrivate.h when it's not defined. This allows catching this kind of mismatch in the future through a compiler warning (C4668).
#jira UE-53065
Change 3891732 by Brian.Zaugg
Re-adding iPhoneX launch images with correct case.
#JIRA UE-53541
Change 3891727 by Arne.Schober
REL - Do not recreate one Frame Resource for dynamic draws
#jira UE-55063
Change 3891716 by Ben.Marsh
Fix buffer overrun when generating callstack.
#jira
Change 3891697 by Brian.Zaugg
Deleting iPhoneX launch images that have incorrect case.
#jira UE-53541
Change 3891678 by Brian.Zaugg
IPP binaries for iPhoneX support.
#jira UE-53541
Change 3891525 by Lauren.Ridge
Thumbnails now update correctly w/parameters
#jira UETOOL-1333
Change 3891520 by Lauren.Ridge
Fixing SA error in material editor
#jira UE-55206
Change 3891495 by Jurre.deBaare
Normal are different after Merge Actor on scaled objects
#fix Make sure we do not apply scale when transform Normals/Tangents
#jira UE-54996
Change 3891352 by Guillaume.Abadie
Fixes ensure when visualizing HDR with TAAU.
#jira UE-55019
Change 3891323 by Matt.Kuhlenschmidt
Added substance buttons to content browser and material editor
#jira UE-55081
Change 3891033 by David.Hibbitts
#JIRA UE-55135
Moved Message Bus Source heartbeats to their own thread using a new FHeartbeatManager singleton. This prevents sources from incorrectly being removed during Slate UI operations.
Change 3890642 by Arne.Schober
REL - Better fix for Paper2d which honors batching
#jira UE-55063
Change 3890593 by Arne.Schober
REL - Fix Paper2d crash. When addMesh is called the Vertex and Indexbuffers are nulled out. re-create Dynamic Mesh builder for every Mesh instead.
#jira UE-55063
Change 3890502 by Mike.Erwin
Fix reported VRAM size on Metal
We were getting correct value in MB from system but overflowing uint32 arithmetic when converting to bytes.
This led 4GB and 8GB configs to report 0 total VRAM, 0 dedicated tex mem, and GTexturePoolSize = 0.
Noticed the problem on my 6GB FirePro, which reported 2GB and set GTexturePoolSize to 70% of that.
Also fixed log of texture pool size to show MB. Other platforms' RHIs already report this in MB.
#jira none
Change 3890404 by Jostin.Bilyeu
Updating Demo Display names to remove redundant spaces
#jira UE-29618
Change 3890401 by Dan.Oconnor
Fix for property table performance regression
#jira UE-54984
Change 3890194 by Dan.Oconnor
Make sure a CDO's subobjects are preloaded when running in -game
#jira UE-54242
Change 3890182 by Krzysztof.Narkowicz
Moving CL3867594 from Dev-Rendering to fix missing shaders in cooked Binary Editor DCC. USE_EDITOR_ONLY_DEFAULT_MATERIAL_FALLBACK generated default material shaders had no cooking code path.
#jira UE-54683
Change 3890140 by Rob.Cannaday
Merging cacert.pem from //UE4/Dev-Online to //UE4/Release-4.19
Includes latest cacert.pem from https://curl.haxx.se/docs/caextract.html as of January 17, 2018
#jira none
Change 3889850 by Shaun.Kime
Now initializing Niagara scripts and emitters even if the config file isn't ready yet.
#jira UE-54168
#jira UE-54169
#tests can create a blank emitter and all script sub-types
Change 3889833 by Michael.Trepka
Disabled Clang's unused-lambda-capture warning added in Xcode 9.3
#jira none
Change 3889696 by Patrick.Boutot
Allow rename from AssetTool when there is no source control enabled.
Fix crash when you rename an asset without an enabled source control.
#jira UEENT-803
Change 3889470 by Mike.Beach
Switching the source-name to legacy hand enum lookup functions to use a static table instead of finding a UEnum object and iterating over reflection data (to prevent a GC lockup with the UObject query).
#jira UE-55153
Change 3889319 by Matt.Kuhlenschmidt
Disable hardware survey on build machines. They run windows server and lack the necessary win32 api functionality to execute it properly
#jira UE-55166
Change 3889087 by Jostin.Bilyeu
Minor adjustments TM-SceneTexture for better testing clarity. Minor adjustments to TM-MipLevels for test map clean up
#jira UE-29618
Change 3889073 by Sorin.Gradinaru
UE-55117 Android virtual keyboard can have text input hidden by software buttons
#jira UE-55117
#Android
#4.19
Adjusted x-coord and width for the native EditText
Change 3888841 by Jurre.deBaare
Make FSkeletalMeshRenderData::GetMaxBonesPerSection an ENGINE_API exported function
#jira none
Change 3888837 by Guillaume.Abadie
Fixes a crash in dynamic resolution when doing UE4Editor -server
#jira UE-55158
Change 3888831 by Dragan.Jerosimovic
added fbx files
#jira none
Change 3888340 by Ethan.Geller
[Release-4.19] #jira UE-54787 edit settings for Strategy Game to prevent stuttering in AudioMixer on low performance Android Devices #rb Aaron.McLeran #fyi Aaron.McLeran #lockdown Cristina.Riveron
Change 3888133 by Michael.Karambelas
QAGame: Adding a BP Actor to test the Mic component feature that AaronM implemented with UE-51471.
#jira UE-29618
Change 3887957 by Krzysztof.Narkowicz
"Fixed" Vulkan instancing in by doing Metal style set instance offset to 0 hack
#jira UE-54367
Change 3887912 by Jostin.Bilyeu
Adding content to TM-SceneTexture to verify Screen Positioning as well as Scene Color and Depth. Adding a new map (TM-MIPLevels) for testing custom mip levels
#jira UE-29618
Change 3887571 by Zak.Parrish
Adding FaceAR content and cleanup #jira none
Change 3887458 by Dan.Oconnor
Fix 'Step Out' functionality for macro and collapsed graphs
#jira UE-55000, UE-55002, UE-55022
Change 3886883 by zachary.wilson
Add testing content to QAGame: Texture and material for testing mip levels. Postprocess material for testing scene buffer sampling.
#jira UE-29618
Change 3886848 by Max.Preussner
Engine: Workaround for uninitialized external textures causing white flashes in media playback
Copied from Fortnite-Main and Dev-Sequencer
#jira UE-53357
Change 3886720 by Matt.Kuhlenschmidt
Guard against mac menus updating during slow tasks.
#jira UE-55068
Change 3886657 by Guillaume.Abadie
Cherry-pick 3886626: Cherry-pick 3886560: Fixes strong aliasing on TAAU's fast shader permutation.
This adds a 6th neighbor sampling, and switch AA_TONE ON as TAA does for its fast shader permutation.
#jira FORT-69961
Change 3886653 by Matt.Kuhlenschmidt
Perforce Plugin: Removed all calls to methods that would update the P4PASSWD environment variable. Perforce stores this as plain text so it is not safe and we do not want the editor to be responsible for this being set. All users should be using ticket based p4 servers for the best security but if they are unable to then they can call p4 passwd on their own to set a slightly better hashed password directly. They may also log in each time to the editor which prevents any password from being stored
#jira UE-55111
Change 3886621 by Benn.Gallagher
Fixed crash closing clothing tab if workflow centric application puts the tab spawners in a bad state due to incorrect handling of tab context menus.
#JIRA UE-55067
Change 3886552 by Thomas.Sarkanen
Fixed crash loading an anim instance with a re-instanced class
Unable to repro, but in editor we dont need the optimization that this provides. Now we always re-initialize functions and properties in case the class has changed out from under us.
#jira UE-55065 - [CrashReport] UE4Editor_Engine!FExposedValueHandler::Initialize() [animnodebase.cpp:521]
Change 3886442 by Cosmin.Sulea
UE-53033 - Editor Rapidly Spawns Multiple Empty Windows Throughout Remote Shader Compiling
#jira UE-53033
Change 3886441 by Cosmin.Sulea
UE-54598 - Using an Invalid iOS Mobile Provision does not give descriptive error in Project Launcher, IPhonePackager
#jira UE-54598
Change 3886427 by Sorin.Gradinaru
UE-54139 Possible crash with new virtual keyboard on Android if suggestions not disabled - from //Dev-Mobile@CL3843552
#4.19
#Android
#jira UE-54139
S8 on 7.0 is not hiding suggestions and disabling predictive input. There are cases with this that can cause a crash.
Fix: On text change, downgrade to simple suggestions all the easy correction spans that are not a spell check span (remove android.text.style.SuggestionSpan.FLAG_EASY_CORRECT flags)
Change 3886210 by Ethan.Geller
[Release-4.19] #jira UE-53867 Ensure we don't read off into garbage memory for uncompressed PCM.
Change 3886005 by Zak.Parrish
Checking in faceAR work on behalf of 3Lateral #jira none
Change 3885925 by Mike.Erwin
Material preview label off-center on HiDPI screen
#jira UE-52533
Change 3885778 by Dan.Oconnor
Fix stepping over collapsed graph and macro nodes
#jira UE-54950, UE-54955
Change 3885713 by Mike.Erwin
glTF: fix material using wrong textures
Imported material could plug the wrong textures into its inputs. The previous code tracked a material's textures based on image source index, corrected code uses texture (source + sampler) index. This is more general allowing an image to be referenced by multiple textures.
Bug reported yesterday via email, demonstrated using the Khronos TextureSettingsTest sample model.
#jira none
Change 3885603 by Ben.Marsh
Fixes for compiler errors in nightly builds of VS2017 in /permissive- mode.
#jira
Change 3885566 by Phillip.Kavan
Fix a scoping issue related to inaccessible property reference caching in nativized Blueprint code.
Change summary:
- Modified FDefaultSubobjectData::EmitPropertyInitialization() to utilize the FScopeBlock utility to manage the inaccessible property cache during code generation for instanced subobject initialization.
#jira UE-55061
Change 3885481 by Mark.Satterthwaite
Attempt to workaround an Intel shader compiler bug without reopening a related AMD bug. This may cost performance unless function constants are available and the runtime compiler actually bothers to perform optimisation (AMD's did not in 10.12.6 and earlier).
#jira UE-54333
Change 3885461 by Lauren.Ridge
Fix for slot not being initialized to null
#jira UE-55069
Change 3885455 by zak.parrish
Adding initial files for FaceAR scene lookdev #jira none
Change 3885446 by Zak.Parrish
Adding test assets for Gremlin look dev. May get removed later prior to release. #jira none
Change 3885424 by Krzysztof.Narkowicz
Fixed skeletal mesh LODs inside editor. If skeletal mesh wasn't recently visible, code was incorrectly changing LOD settings without updating LOD data on render thread.
#jira UE-53861
Change 3885406 by Zak.Parrish
Rollback //UE4/Release-4.19/Samples/FaceARSample/Content/UI/FaceARDebugUI.uasset to revision 1 #jira UE-54639
Change 3885340 by Arne.Schober
REL - Bitarray FindFromLast was masking incorrectly for the corner case where there is no slack
#jira none
Change 3885143 by Marc.Audy
Merge memory corruption fix in CL# 3884991 from Fortnite-Staging to Release-4.19
#jira UE-54977
#jira UE-54976
#jira UE-54898
Change 3885093 by Mark.Satterthwaite
Apple don't like testing for the validation layer in iOS App Store builds - it is unnecessary so we can disable this for shipping builds.
#JIRA N/A
Change 3884622 by Jurre.deBaare
Moving over missing file from changelist for UE-54508
#jira UE-54508
Change 3883391 by Nick.Atamas
Fix for UE-54622 : PIE in VR available when ARKit/ARCore plugins enabled.
Only create ARKit/ARCore tracking systems on iOS/Android.
#jira UE-54622
Change 3883257 by Phillip.Kavan
Fix a Blueprint compile error for the GetClassDefaults node Map value outputs introduced by stronger type checking in 4.19 between Map pin types.
#jira UE-55026
Change 3883024 by Lauren.Ridge
Fixing static analysis warning
#jira SA
Change 3882510 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3882502 by Lauren.Ridge
Fix for material layer parameters not rebuilding and adding save child button
#jira UETOOL-1275
Change 3882458 by Krzysztof.Narkowicz
Copying cached shadow map assert fix from Fortnite-Main (CL3802813)
#jira UE-54747
Change 3882366 by Michael.Karambelas
QAGame: made changes to QABP_Debugging, QABP_FunctionLib, and QA_TestHelper for Blueprint debugger tests.
#jira UE-29618
Change 3881971 by andrew.porter
QAGame: Removing actor from Shot_003
#jira UE-29618
Change 3881795 by Krzysztof.Narkowicz
Added encoded HDR reflection capture cooking if targeting ES 2.0/3.1 on Windows
#jira UE-53875
Change 3881550 by David.Hibbitts
#JIRA UEENT-879
Subject frames now store world time explictly as a double with optional scene timecode as MetaData. This allows for use cases such as posing a single frame in Maya where the world time would be changing but the scene timecode associated with the animation remains fixed.
THIS IS A BREAKING CHANGE: Sources from before this change will no longer compile.
Change 3881339 by Jurre.deBaare
Moving over:
"Editor crashed when attempting to bake out all the material channels
#jira UE-54508
#misc small UDN Merge actor / bake material fixes
Change 3879557 by Dan.Oconnor
Fix stepover behavior when no debug target is selected
#jira UE-54978
Change 3879485 by Mike.Beach
Limiting the number of stereo layers on Oculus android to 4 (otherwise, their lib crashes).
#jira UE-54999
Change 3879438 by David.Hibbitts
#JIRA UEENT-880 Added support for Subject level MetaData to LiveLink #rb martin.wilson #fyi james.golding, simon.tourangeau
Change 3879343 by Lina.Halper
Last min change that skiped compiling
#jira: none
Change 3879337 by Lina.Halper
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
#jira: UE-54806
Change 3878968 by Phillip.Kavan
Fix deprecation warnings in compiled stub class wrapper codegen for Blueprint class dependencies excluded from nativization.
Change summary:
- Modified FBlueprintCompilerCppBackendBase::GenerateWrapperForClass() to const-correct the assignment of cached weak pointers to referenced properties.
#jira UE-54981
Change 3878962 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-54831 (No error occurs accepting if Android SDK license file cannot be written, but user cannot accept license)
#4.19
#jira UE-54831
#android
- shows an error message box informing that the license file could not be written.
Change 3878821 by Andrew.Rodham
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field, and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3878171 by Chris.Phillips
Android: Fixed crash after splash screen when using Vulkan.
#jira UE-54299
Change 3877950 by Ethan.Geller
Fix copyright information from previous CL #jira none #rb none #lockdown Cristina.Riveron
Change 3877859 by Nick.Shin
rebuilt lighting for TM-ShaderModels and resaved the level
#jira UE-53374 Client displays "lighting needs to be rebuilt (1 unbuilt object(s))" when launching TM-Shadermodels onto HTML5
Change 3877854 by tim.gautier
Adding additional (temp) ML Test asset
#jira UE-29318
Change 3877609 by Ethan.Geller
[4.19] Change FWhiteNoise generate function to use SRand, due to weird distribution in FRandRange #jira UE-54965 #rb aaron.mcleran #lockdown cristina.riveron
Change 3877474 by Lauren.Ridge
Adding WITH_EDITOR wrappers to editor-only section of code
#jira fixingcompiles
Change 3877271 by Arne.Schober
REL - Integrate 3872827 - The VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should not be neccessary
#jira none
Change 3877260 by Lina.Halper
If revision is too far away, ignore the request and send current buffer
- this is exactly how it used to do and it is still required, but this means motion vector will be ignored when this happens
#jira: UE-54398
Change 3876950 by Lauren.Ridge
Renaming layers in a material instance - from 4.19 preview feedback
#jira UETOOL-1296
Change 3876932 by Arciel.Rekman
Linux: updated the link to the cross-toolchain (UE-54597).
#jira UE-54597
Change 3876918 by Phillip.Kavan
Fix a regression that could cause packaging to fail and/or data loss with Blueprint nativization enabled.
Change summary:
- Removed logic that attempted to avoid redundant assignments of instanced default subobject references. This was not compatible with editinline characteristics that can allow certain object reference values to be overridden by the Blueprint class.
- Explicitly defer to ExportTextItem() when generating C++ code for UObjectProperty/UInterfaceProperty reference values in which the underlying object reference is NULL.
#jira UE-54870
Change 3876759 by tim.gautier
Updated Material Layer test assets to include Opacity and Emissive.
#jira UE-29318
Change 3876575 by Michael.Karambelas
Updating the QABP_Debugging asset in QAGame with a couple of interfaces and additional logic for testing purposes.
#jira UE-29618
Change 3876406 by Robert.Manuszewski
Fixed a crash when reporting linker errors
#jira UE-51037
Change 3875891 by Nick.Atamas
Fixed scenario where geometries were being updated once per pin, instead of just being updated once.
Also fixes a scenario where there are no pins and geometries fail to update.
#jira UE-54914
Change 3875880 by Aaron.McLeran
#jira UE-54916
Fixing up submix effect templates
Change 3875673 by Brandon.Schaefer
Fix Apex dependencies
Depend on static Apex libraries in Apex.Build.cs versus Physx.Build.cs
#jira UE-54861
Change 3875498 by Lauren.Ridge
PR #4477: 4.19 Fixed a crash caused by the layered material property widget of the material instance editor. (Contributed by mlaveaux)
#jira UE-54862
Change 3875322 by tim.gautier
Recreating Material Layer test assets (asset version has changed)
#jira UE-29318
Change 3875157 by Aaron.McLeran
#jira UE-54901 Synth components do not allow sends to buses
Change 3875103 by Brandon.Schaefer
Need to use our bundled libc++.so not libstdc++.so when building Apex/PhysX/NvCloth libraries
#jira UE-54815
Change 3875037 by Aaron.McLeran
#jira UE-54896 Fixing up audio capture component to parameterize the delay
Parameterize the jitter latency delay.
Change 3875026 by Aaron.McLeran
#jira UE-54895 Filter frequency values don't update live with EQ effects and 0-frequency cutoff causes pops
Change 3874927 by Ryan.Vance
#jira UE-54894
Ensure we don't delete aliased texture resources, they are managed externally.
Change 3874925 by Martin.Wilson
Remove XR post fix from live link code written during motion controller integration
#jira none
Change 3874354 by Ben.Marsh
Use the compiler matching the user's preferred IDE if they don't have a specific compiler selected in the project settings.
#jira UE-54272
Change 3877545 by Ben.Marsh
Replace FPlatformMisc::DebugBreak() with the UE_DEBUG_BREAK() macro. VS2017 is able to show force-inlined calls on the callstack, which makes debugging asserts and ensures annoying.
Use similar logic for expanding ensure() macros in place.
#jira UE-54961
[CL 3963579 by Ben Marsh in Main branch]
============================
MAJOR FEATURES & CHANGES
============================
Change 3873906 by Dan.Oconnor
Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type
#jira UE-51726
Change 3873614 by Dan.Oconnor
Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled
#jira UE-51726
Change 3873428 by Ben.Zeigler
#jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget
Copy of 3873408
Change 3873083 by Ethan.Geller
[4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron
Change 3872714 by Dan.Oconnor
Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously
#jira UE-53840
Change 3872648 by Ben.Zeigler
#jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets
Copy of CL #3872636
Change 3872500 by Arne.Schober
Back out changelist 3870283
#jira UE-54838
Change 3872412 by Mark.Satterthwaite
Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles.
#jira UE-54853
Change 3872313 by Martin.Wilson
Add UI to Live Link Client to warn live link users about background performance throttling
#jira none
Change 3872272 by Martin.Wilson
Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance
#jira none
Change 3872238 by Mark.Satterthwaite
Duplicate CL #3871025
Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders.
#jira UE-54843
Change 3872087 by Yasiman.Ahsani
Adding Python, libdisasm, musl, and LSS licenses.
#JIRA n/a - adding licenses for new TPS
Change 3872037 by Ben.Marsh
BuildGraph: Add a task for compiling MSBuild projects.
#jira
Change 3871934 by Lina.Halper
#jira: UE-54703
Change 3871595 by Michael.Trepka
Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function
#jira UE-54830
Change 3870829 by Joe.Barnes
Fix unintentional change to PhysX libs used in Debug builds.
#jira ue-54817
Change 3870820 by Nick.Atamas
Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19)
#jira UE-54816
Change 3870755 by Chance.Ivey
Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas
Change 3870547 by Krzysztof.Narkowicz
Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel.
#jira UE-53640
Change 3870546 by Krzysztof.Narkowicz
Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path
#jira UE-54471
Change 3870284 by Ben.Zeigler
#jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time
Copy of CL #3870279
Change 3870283 by Arne.Schober
SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources)
Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary
#jira none
Change 3870098 by Ben.Marsh
Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly.
#jira UE-53855
Change 3870013 by Ben.Marsh
UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked.
#jira UE-54179
Change 3870010 by Ben.Marsh
UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window.
#jira
Change 3869814 by Ben.Marsh
UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported.
Also remove the RemoteRoot option, which was not used anywhere.
#jira
Change 3869786 by Martin.Wilson
Fix Live Link Remove Source button not working
#Jira UE-54652
Change 3869660 by Martin.Wilson
Fix missing message bus sources in the live link client (not repolling for new sources)
#Jira UE-54712
Change 3869659 by Guillaume.Abadie
Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame.
Credits for fixing the issue to Ron Radeztsk.
#jira UE-54780
Change 3869401 by Lauren.Ridge
Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent
#jira UE-51470
Change 3869384 by Brandon.Schaefer
Open the project in the explorer when NullSourceCodeAccess is done creating the project
#jira UE-54630
Change 3869308 by Ben.Marsh
PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337)
#jira UE-54568
Change 3869265 by Martin.Wilson
Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin
-Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory)
-Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have)
-rebuild binaries for Engine/Extras
#Jira UE-54643
Change 3869206 by Benn.Gallagher
Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application.
#jira UE-54116
Change 3869064 by Benn.Gallagher
Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function.
#jira UE-52557
Change 3869062 by Guillaume.Abadie
Fixes "dynamic resolution is not supported on this platform" warning message being always visible.
#jira UE-54655
Change 3868202 by Lauren.Ridge
Fix for assert on expanding vector param in layered material
#jira UE-54737
Change 3868161 by zak.parrish
Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639
Change 3867750 by Ethan.Geller
[4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron
Change 3867657 by Lauren.Ridge
Adding if with editor wrapper to new function
#jira cis fix
Change 3867646 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867340 by Lauren.Ridge
Fixes to Material Layers from 4.19 preview feedback
-Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings)
-Parent in function should be editable
-Enforce only two layers in a blend
-Mat layer should warn if it has incorrect output in the layer itself
-Enforce not being able to delete outputs
-Warn about creating a MAL node inside a function
#jira UETOOL-1312
Change 3867317 by Aaron.McLeran
#jira UE-53867 Access violation on Switch when playing sound with specified time out of range
Change 3867000 by Lauren.Ridge
Fix for folder favorites possibly becoming very large
#jira UE-54704
Change 3866892 by Martin.Wilson
Fix crash if clicking ok on message bus add source without having a source selected
#jira UE-54572
Change 3866391 by Matt.Kuhlenschmidt
Fix static analysis
#jira UE-53379
Change 3866241 by Ryan.Vance
#jira UE-54681
Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge.
Change 3866071 by Nick.Shin
UDN 412414
update HTMl5 readme file
#jira none
Change 3866005 by Max.Preussner
Messaging: Preventing dangling references when removing message subscribers
#jira UE-54680
Change 3865988 by Simon.Tourangeau
Fix static analysis warnings
#jira none
Change 3865895 by zachary.wilson
Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame.
#JIRA UE-29618
Change 3865469 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3865461 by Chris.Babcock
Add a wait for audio thread to pause audio on going to background
#jira UE-54301
#ue4
#android
Change 3865350 by Matt.Kuhlenschmidt
Fix issue where cascade emitter UI would disapper
#jira UE-53379
Change 3865336 by Arne.Schober
REL - Fix UE-52356 Bone Weight
#jira UE-52356
Change 3865257 by Ben.Marsh
Fix editor failing to load content-only projects when compiled in DebugGame.
#jira UE-54661
Change 3865238 by Simon.Tovey
Pulling Olaf's fix from 3832595 over to release
#tests EngineTests boots in vulkan
#JIRA UE-54394
Change 3865191 by Sorin.Gradinaru
UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format
#jira UE-54317
#Android
#4.19
From //Dev-Mobile/3863322
Change 3865190 by Sorin.Gradinaru
UE-54175 Selecting For Distribution no longer sets configuration to Shipping
#UE4
#4.19
#jira UE-54175
From //Dev-Mobile/3863371
"For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845)
Change 3865056 by Jamie.Dale
Fixed culture being incorrect when added via the Localization Dashboard
#jira none
Change 3864826 by Max.Preussner
WmfMedia: Added missing scope lock
#jira UE-54365
Change 3864055 by Aaron.McLeran
#jira UE-54213
Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects.
Change 3863775 by Andrew.Porter
MediaFrameworkTest: Removing Platform Media Source TVOS test content
#jira UE-29618
Change 3863714 by Dan.Oconnor
Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred
#jira UE-54634
Change 3863696 by Max.Chen
Sequencer: Fix crash open a new sequence while another is still active.
#jira UE-54620
#jira UE-54624
Change 3863638 by Dan.Oconnor
Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior
#jira UE-54193
Change 3863494 by Jamie.Dale
Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized
#jira UE-54345
Change 3863433 by Max.Preussner
MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets
tvOS currently reports itself as iOS, so it cannot have its own setting.
#jira UE-54559
Change 3863406 by Lauren.Ridge
Fix for a crash when filtering a dropdown with no set value
#jira UE-54631
Change 3863238 by Michael.Kirzinger
#jira UE-52730: Fix mac voip crash
Change 3862586 by Marc.Audy
Clean up rendering thread heartbeat checks that got mangled in various integrations
#jira
Change 3862247 by Guillaume.Abadie
Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel.
#jira UE-53830
Change 3862120 by Guillaume.Abadie
Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor.
#jira UE-51458
Change 3861363 by Jamie.Dale
Static analysis fixes
#jira none
Change 3861150 by Matt.Kuhlenschmidt
Fix static mesh editor displaying 0 for all stats on LODs > 0
#jira UE-53776
Change 3860990 by Dan.Oconnor
Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject
#jira UE-54551
Change 3860972 by Nick.Shin
HTML5 - detect "SyntaxError: " and do a forced reload
- an actual syntax error would be caught during compile time
- this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page
#jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit
Change 3860951 by Arne.Schober
Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer.
#jira UE-54587
Change 3860950 by tim.gautier
QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions
#jira UE-29618
Change 3860833 by Michael.Dupuis
#jira UE-54181: Repopulate the foliage list when existing simulate mode
Let the GC know that internal struct hold UObject ptr
Change 3860762 by Jamie.Dale
Ensure we invoke the correct version of Python from UBT
#jira UE-54345
Change 3860676 by Simon.Tourangeau
Remove DirectoryWatcher warning in output log
#jira UEENT-846
Change 3860598 by Lauren.Ridge
Fix for crash on opening new material instance
#jira UE-54589
Change 3860338 by Michael.Lentine
Integrate changes for fixing MorphTargets.
#jira 54398
Change 3860215 by Ben.Marsh
UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class.
#jira UE-54578
Change 3860186 by Matt.Kuhlenschmidt
Fix crash top 10 with the font editor shutting down and then a dpi event occuring
#jira UE-54543
Change 3859854 by Graeme.Thornton
PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed)
#jira UE-51289
Change 3859848 by Graeme.Thornton
Fix crypto.cs reading the wrong ini setting names for uasset encryption settings
#jira UE-54566
Change 3859684 by Ben.Marsh
PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey)
#jira UE-54392
Change 3859657 by Ben.Marsh
Fix FTransform being passed by value, causing alignment error when compiling for Win32.
#jira
Change 3859312 by nick.bullard
Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278
Still need to update menu to remove selection
#jira UE-50784
Change 3859278 by Nick.Bullard
Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well.
"This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only.
We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time."
#jira UE-50784
Change 3859124 by Dan.Oconnor
Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16
#jira UE-54468
Change 3859086 by Ryan.Vance
#jira UE-54470
We need to set the viewport in both cases.
Change 3859006 by Dan.Oconnor
Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class
#jira UE-54541
Change 3858990 by mason.seay
Cleaned up blueprints to remove compile errors
#jira UE-29618
Change 3858945 by Aaron.McLeran
#jira UE-54265
PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins)
Change 3858719 by Aaron.McLeran
#jira UE-54552 Fix for sample buffer reader
Change 3858647 by Ethan.Geller
PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel)
#jira UE-54407
Change 3858364 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858268 by Dan.Oconnor
Prevent postload logic running on REINST and SKEL classes
#jira UE-54531
Change 3858205 by Mitchell.Wilson
Removed particle looping from some emitters to resolve anim notify warnings.
#jira UE-53823
Change 3858148 by Lauren.Ridge
Changes based on Material Layer Feedback from previews
- (Temporary) Disabled being able to create a layer or blend in the asset dropdown
- Sections of the stack that have been disabled now inactivate that part of the UI
- Create Function Instance now indicates if you are making a layer or a blend
- Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead.
#jira UETOOL-1328
Change 3857933 by Michael.Dupuis
#jira UE-45854: Properly unregister callback when replacing foliage type with another one
Change 3857898 by Michael.Dupuis
#jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation
Change 3857878 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
Copy from Dev-Sequencer
#jira UE-54462
Change 3857808 by Michael.Dupuis
#jira UE-54421: Prevent edition during Simulate when clicking on actor
Change 3857786 by Rolando.Caloca
UE4.19 - Fix recompute tangents and skin cache for OpenGL
#jira UE-42108
PR #3271
Change 3857549 by Lina.Halper
another jittering issue due to revision number change
clear the motion vector after compile
#jira: UE-53930
Change 3857439 by Lina.Halper
Clear motion vector when end of sequencer when in editor world
#jira:UE-54057
Change 3857384 by Graeme.Thornton
Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio
#jira UE-50020
Change 3856596 by Chris.Babcock
Fix ResonanceAudioApi Android library architecture filtering
#jira UE-54478
#ue4
#android
Change 3856449 by Michael.Dupuis
#jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design.
Change 3856415 by Dan.Oconnor
Fix regression when loading instances that have had their class deleted. Issue detected by static analysis
#jira UE-54467
Change 3856332 by Ben.Marsh
Resaving TP_HandheldARBP assets to fix version again.
#jira
Change 3856319 by Ben.Marsh
Back out changelist 3855588
Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0.
#jira UE-54472
Change 3856292 by Ben.Marsh
Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds.
#jira UE-54448
Change 3856190 by Martin.Wilson
Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too)
#jira UE-54266
Change 3856169 by Ben.Marsh
Tag XGEControlWorker.exe as a build product, so it's included in the binary distro.
#jira UE-54283
Change 3856123 by Chris.Babcock
Fix missing ARCore file
#jira UE-54453
#ue4
#android
Change 3856005 by Richard.Wallis
Clone of Dev-Rendering CL 3855993 - turn off FShaderCache.
#jira UE-52928
Change 3855961 by Jian.Ru
Copy 3855047 - fix DFAO Nan problem
#jira UE-54403
Change 3855811 by Martin.Wilson
Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018)
#jira none
Change 3855758 by Cosmin.Sulea
UE-53569 - tvOS does not package or launch-on
#jira UE-53569
Change 3855727 by Ben.Marsh
Resaving assets with a versioned build in the editor, to fix warnings building DDC.
#jira
Change 3855626 by Adrian.Siminciuc
https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep)
#jira UE-50979
Change 3855588 by Graeme.Thornton
Fix visual studio solution path being incorrect for content projects
#jira UE-50020
Change 3855283 by Ben.Marsh
Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor.
#jira
Change 3855009 by Chance.Ivey
Resaving with version number. #JIRA-54330 #rb none
Change 3854943 by Dan.Oconnor
Fix archetype lookup when searching hierarchy that has been partially reinstanced
#jira UE-53840
Change 3854882 by Ryan.Vance
#jira UE-54438
Removing vr related references to screen percentage.
Removing previously removed gvr screen percentage code that came back in an integration from google.
Change 3854806 by Mike.Beach
Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up.
#jira UE-54214
Change 3854680 by Chance.Ivey
Saving assets with version number#JIRA UE-54330 #rb none
Change 3854652 by Uriel.Doyon
Added a tooltip to the EV100 slider in the exposure menu.
Using game settings now disables the slider.
#jira UE-53945
Change 3854605 by Dan.Oconnor
Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't)
#jira UE-53954
Change 3854274 by Brandon.Schaefer
Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux
#jira UE-54302
#codeview Arciel.Rekman
Change 3854255 by Phillip.Kavan
Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties.
- Mirrored from //UE4/Dev-Framework (3853349).
#jira UE-53960
Change 3854177 by Ethan.Geller
#jira UE-54415 set EnabledByDefault to false for Resonance Audio
Change 3854123 by Ethan.Geller
#jira UE-54410 set AudioComponentID
Change 3853775 by Lauren.Ridge
Minor cleanup
#jira UE-54054
Change 3853772 by Lauren.Ridge
Don't create widgets when just testing if the selected widget is a replacement candidate
#jira UE-54054
Change 3853715 by Rolando.Caloca
UE4.19 - Fix for OpenGL overwriting texture units
#jira UE-54401
Change 3853655 by Ben.Marsh
Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders.
#jira
Change 3853535 by Ben.Marsh
Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release.
#jira
Change 3852583 by Nick.Atamas
Resaved assets so they don't produce DDC warnings.
#jira none
Change 3852552 by Uriel.Doyon
Fixed Pre-Exposure shader compilation and Temporal AA issue.
#jira UE-54276
Change 3852354 by Nick.Atamas
Hopefully fixes the static analysis warning from jira issue.
#jira UE-54332
Change 3852281 by Nick.Atamas
Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/...
#jira UE-54331
Change 3852274 by Simon.Tourangeau
Back out changelist 3851041 until Win7 issue is resolved.
#jira UE-54354
Change 3852208 by Jamie.Dale
Merging CL# 3821754 from //UE4/Dev-Enterprise
Class property conversion now goes through NativizeClass/PythonizeClass
This allows it to coerce from Python wrapped object types
#jira none
Change 3852202 by Jamie.Dale
More explicit handling of EngineDir for Python SDK
#jira UE-54345
Change 3851982 by Brandon.Schaefer
Workaround using a hardcoded path
#jira UE-54136
Change 3851748 by Michael.Dupuis
#jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions
Change 3851545 by Marc.Audy
Remove debugging code that slipped in
#jira none
Change 3851461 by Ben.Marsh
Fix #includes with backslashes from crashing UBT.
#jira UE-53996
Change 3851391 by Jamie.Dale
Updated Python to prefer our TPS SDK
#jira UE-54345
Change 3851372 by Jamie.Dale
Added bat file to copy the Python SDK into TPS
#jira UE-54345
Change 3851218 by Ben.Marsh
Add missing template to installed engine build.
#jira UE-54339
Change 3851117 by andrew.porter
QAGame: Removing duplicate map
#jira UE-29618
Change 3851041 by Simon.Tourangeau
Support for DX11 quad buffer stereo rendering
#jira UEENT-704
Change 3850548 by Ben.Marsh
Add TP_HandheldARBP to installed engine build.
#jira
Change 3850424 by Ben.Zeigler
Fix reported memory for asset registry to be correct, extracted from a larger change
#jira none
Change 3850324 by Ryan.Vance
#jira UEVR-1050
Hook up the Rift dynamic res to the new IDynamicResolutionState framework
Change 3849819 by JeanLuc.Corenthin
Unhide Datasmith plugins in "regular" projects to allow easy project conversion
#jira UEENT-795
Change 3849302 by Martin.Wilson
Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation)
#jira none
Change 3849238 by Max.Chen
Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged.
#jira UE-54248
Change 3849211 by Michael.Dupuis
#jira UE-54181: Prevent foliage edition during PIE or simulate mode
#coderevire jack.porter
Change 3849123 by Benn.Gallagher
Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices
#jira UE-53741
Change 3849120 by Benn.Gallagher
Fixed crash adding empty materials to destructible meshes in the destructible mesh editor
#jira UE-53938
Change 3849047 by Jurre.deBaare
Move material baking out of experimental
#fix follow-up also remove the entry from experimental settings
#jira UE-52685
Change 3848808 by Michael.Dupuis
#jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now.
Fixed dynamic shadow code path issue vs static code path
Change 3848659 by Lina.Halper
Fix issue with animation resetting in the sequencer
#jira: UE-54047
Change 3848635 by Rolando.Caloca
UE4.19 - Fix static analysis
#jira UE-50449
Change 3848515 by Sorin.Gradinaru
Unshelved from pending changelist '3843541':
WebBrowser Android crash on 4.4.3
#jira UE-53247
#Android
#4.19
Crash on Android 4.x.x caused by a call to a Api Level 21 method
Change 3848514 by Jurre.deBaare
Moving over:
CL 3832173
"Failed to import Alembic files
#jira UE-53941
#fix Change Alembic thirdparty library setup
- Removed old unused library files
- Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path
- HDF5 is now build as a Dynamic library (which also enableds multi-threading)
- Added DLLs for HDF5 to build.cs file
CL 3838053
"Adding missing hdf5 dynamic libraries
Change 3848245 by Ben.Marsh
Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE.
#jira UE-54237
Change 3847300 by Phillip.Kavan
Fix shadowed local variable.
#jira UE-54141
Change 3846922 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
Copied from Dev-Sequencer CL# 3846902
#jira UE-54247
Change 3846831 by Arciel.Rekman
Linux: only use lld for x86_64 (UE-54144).
- lld support for other architectures seems to not ready for prime time.
#jira UE-54144
Change 3846771 by Lauren.Ridge
Material window now uses the background color set in preview scene.
#jira UE-52215
Change 3846705 by Ben.Marsh
Fix batch file paths not being quoted correctly when run through XGE.
#jira
Change 3846550 by Lauren.Ridge
Toggling Show Background now updates the background as well
#jira UE-52250
Change 3846417 by Matt.Kuhlenschmidt
Fix crash resizing shootergame window
#jira UE-53137
Change 3846295 by Rolando.Caloca
UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android)
#jira UE-50449
Change 3846273 by tim.gautier
QAGame: Updating Material Layer test assets to include more Params
- Added temp assets, quicker repros for bugs
#jira UE-54176, UE-54165
Change 3846255 by Lauren.Ridge
Parameter tab is the primary tab for material instances
#jira UE-54092
Change 3846086 by Chris.Babcock
Add missing SecureHash.h include
#jira UE-54026
#PR #4417
#ue4
#android
Change 3846049 by Martin.Wilson
Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag)
#jira UE-54220
Change 3846033 by Martin.Wilson
Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself )
#Jira UE-54219
Change 3845991 by andrew.porter
QAGame: Updating bindings on activechannels sequencer test content
#jira UE-29618
Change 3845933 by Lauren.Ridge
Check for original material being valid
#jira UE-54166
Change 3845920 by Martin.Wilson
Optimized redundant key removal
#jira UE-51303
Change 3845812 by Matt.Kuhlenschmidt
Fix not being able to change BSP brush shape
#jira UE-53738
Change 3845790 by Martin.Wilson
Fix for assert failure when accumulating root motion in debug.
#jira UE-53955
Change 3845730 by JeanLuc.Corenthin
Fix build breakage
warning: resaved disc.uasset with 4.19.0 preview #1
failure: set the correct default mesh for AreaLightStruct.uasset
#jira none
Change 3845693 by Lina.Halper
Fix issue with previewing pose asset with curve data
#jira: UE-53967
Change 3845533 by Andrew.Rodham
Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects
#jira UE-54173
Change 3845472 by Thomas.Sarkanen
Prevented debug object selection dropdown from displaying objects with pending kill outers
#jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance
Change 3845401 by Yannick.Lange
Reverting thumbnail capture from viewport.
#jira UE-53775
#jira UE-53701
Change 3844693 by JeanMichel.Dignard
Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high.
#jira UEENT-632
Change 3844689 by JeanLuc.Corenthin
Update Datasmith content assets to latest
Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803
Updated assets with correct release version
Cleanup some paths on static meshes and texture
#jira UEENT-759
#jira UEENT-657
Change 3844571 by Martin.Wilson
Fix motion controller motion source pin still showing when pin is connected to something
#Jira UE-53236
Change 3844564 by Martin.Wilson
Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them
#Jira UE-54174
Change 3844545 by Jamie.Dale
No longer attempt to parse group separators for numeric inputs
This avoids some ambiguity when parsing numbers for languages such as German
#jira UE-54170
Change 3844221 by Nick.Shin
HTML5 - filter out "windows/super" keys - these are not used in UE4
- but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead...
#jira UE-54056 HTML5 crashes inside browser upon pressing windows key
Change 3843937 by JeanMichel.Dignard
Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin).
#jira UEENT-764
Change 3843929 by Peter.Sauerbrei
pull over fix for bad directory when copying launch images
#jira UE-53177
Change 3843658 by Thomas.Sarkanen
Text is red again in anim viewports
#jira UE-53224 - Colouring removed from "Animation is being edited" warning messages
Change 3843657 by Thomas.Sarkanen
Enable picking via Enter for details panel asset pickers
The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira.
#jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry
Change 3843120 by Dan.Oconnor
Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized
#jira UE-54009
Change 3842841 by Ben.Zeigler
#jira UE-50020
Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157
Change 3842582 by Lauren.Ridge
Guards against the widget passed to scrollwidgetintoview being null
#jira UE-54037
Change 3842575 by Max.Chen
Sequence Recorder: Stop recording if the preview window is destroyed.
#jira UE-49778
Change 3842551 by Michael.Dupuis
#jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk.
Change 3842371 by Max.Preussner
Media: Merged 4.19 fixes from Dev-Sequencer
CL 3807293 WmfMedia: Fixed YUY2 video format strides
CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource
CL 3804183 MediaAssets: Added missing lock in media sound component
CL 3831580 MfMedia: Media open events generated in same order as on other platforms
CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks
#jira UE-53532
#jira UE-53328
Change 3842356 by Max.Preussner
ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource
#jira UE-51631
Change 3842335 by Aaron.McLeran
#jira UE-54087
PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel)
Change 3842286 by Rolando.Caloca
UE4.19 - Fix for static analysis
- Glslang 1.0.65.1
#jira UE-54128
Change 3842222 by andrew.porter
QAGame: Updating framerate of EXR_Sequence
#jira UE-29618
Change 3842211 by Ben.Marsh
Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo().
#jira UE-54035
Change 3842163 by Cosmin.Sulea
UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured
#jira UE-53303
Change 3841770 by Max.Chen
Sequencer: Fix to allow keying of an arbitrarily deep property path.
#jira UE-54095
Change 3841758 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3841415 by Lauren.Ridge
Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack
#jira UE-53942
Change 3841327 by Arciel.Rekman
Linux: fix Debug build (UE-53855)
- A workaround. UBT should be using proper PCH files instead.
#jira UE-53855
Change 3840975 by Rolando.Caloca
UE4.19 - Updated VulkanRHI
- Fixes for GPU frame time
- Fixes for CPU performance
#jira UE-50449
Change 3840838 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3840693 by Ben.Zeigler
#jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization
Copy of CL #3840692
Change 3840680 by Aaron.McLeran
Bringing fixes from Dev-AnimPhys to 4.19.
#jira UE-53903 crash on load with oculus audio and old audio engine
#jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine.
Change 3840663 by Rolando.Caloca
UE4.19 - Fix for layout ensure on HMD projects on Vulkan
#jira UE-50265
Change 3840577 by Rolando.Caloca
UE4.19 - Fix for CPUs with more than 16 cores
#jira UE-53434
Change 3840551 by andrew.porter
QAGame: Setting Allow Bindings from Asset to false
#jira UE-29618
Change 3840491 by Ben.Zeigler
#jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing
Copy of CL #3840489
Change 3840297 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840284 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840215 by Sorin.Gradinaru
Unshelved from pending changelist '3812852':
UE-53550 Level doesn't render on Lenovo 939
UE-53592 Assertion right after rendering scene on Lenovo S939
#jira UE-53550
#jira UE-53592
#4.19
#Android
UE-53550
Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices
The problem was that the shader compiler complains about code lines before the #extension directives.
Placeholder // end extensions in the original shader code - to be replaced with round() functions
UE-53592
Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread
Change 3840048 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840005 by Richard.Wallis
Clone of CL 3835252
Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook.
Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook.
Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin.
#jira UE-53815
Change 3839968 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
##codereview jack.porter
Change 3839924 by Richard.Wallis
Clone of CL 3838093
Fix for rewind / seek bugs in AvfMediaPlayer.
- Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need.
- Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either.
- SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only.
#jira UE-54019, UE-53027
Change 3839321 by andrew.porter
QAGame: Adding missing bookmark to QA-Sequencer_Blending
#jira UE-29618
Change 3839286 by Marcus.Wassmer
Duplicate CL: 3823296
#jira UE-52784
Change 3839229 by Brandon.Schaefer
Fix audio clean up crash when exiting PIE
#jira UE-54050
#review-3839109 @Arciel.Rekman, @Aaron.McLeran
Change 3839223 by andrew.porter
QAGame: Rebinding pointlight actor to sequences
#jira UE-29618
Change 3839098 by andrew.porter
QAGame: Fixing missing sequencer blending test content
#jira UE-29618
Change 3838919 by Mike.Erwin
glTF: binary format's BIN chunk is not necessarily right after the JSON chunk.
Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177
Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first.
#jira UE-50695
Change 3838909 by Mike.Erwin
glTF: base64 decoding of data buffers and images
Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data.
#jira UE-50695
Change 3838812 by Uriel.Doyon
Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming.
#jira none
Change 3838773 by Lauren.Ridge
Fixing material layer filters
#jira UE-54064
Change 3838748 by Michael.Trepka
Fixed EngineTest runtime warning caused by CL 3838626
#jira UE-53893
Change 3838730 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3838626 by Michael.Trepka
Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released.
#jira UE-53893
Change 3838392 by Arciel.Rekman
Fix assert on a policy removal (UE-54042).
- Applying Gil's safe fix which just sweeps the problem under the rug.
#jira UE-54042
Change 3838162 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
#jira UE-54040
(Edigrating 3819174 to Release-4.19)
Change 3838156 by Rolando.Caloca
UE4.19 - Support for Vulkan devices that have no cached memory type
#jira UE-54039
Change 3838096 by Brandon.Schaefer
Set sound to unfocused volume multiplier if not focused
#jira UE-51327
#review-3835736 arciel.rekman
Change 3838087 by Brandon.Schaefer
Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides
#jira UE-53901
#review-3838088 arciel.rekman
Change 3837072 by Phillip.Kavan
Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18.
- Mirrored from //UE4/Dev-Framework (3836768).
#jira UE-53908
Change 3837071 by Phillip.Kavan
Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled.
- Mirrored from //UE4/Dev-Framework (3835944, 3835965).
#jira UE-42614
Change 3837070 by Phillip.Kavan
#4202 - Blueprint nativization bug fixes (PR).
- Mirrored from //UE4/Dev-Framework (3830562, 3832292).
#jira UE-52188
Change 3836507 by Ryan.Vance
#jira UE-53992
Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions.
Change 3836390 by Dan.Oconnor
Fix failure to resolve archetype when using the compilation manager
#jira UE-53840
Change 3836251 by Ryan.Vance
#jira UE-53992
Change 3835852 by Mark.Satterthwaite
Fix tessellation shaders in Metal with Manual Vertex Fetch enabled:
- The control points idnex buffer shouldn't collide with anything else.
- We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures.
#jira UE-53851
Change 3835802 by JeanMichel.Dignard
UBT changes for Enterprise deployment
- Allow building enterprise against an installed engine version
- Added enterprise to the cleanup process if its not installed
#jira UEENT-748
Change 3835625 by Bogdan.Vasilache
UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning
#jira UE-50257
Change 3833649 by Mike.Beach
Enabling debug layer when multiview is enabled.
#jira UE-49954
Change 3833525 by Ethan.Geller
Fix copyright in ActiveSound.cpp #jira none #rb none
Change 3642649 by Stewart.Lynch
Renamed loctext key to stop it clashing with an existing entry
#jira UE-49432
Change 3644762 by Stewart.Lynch
LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv.
* removed CheckSize arg from OnLowLevelFree
* show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch.
* minor optimization in LLMMap::GetMaxIndex - cache Mask value
* added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv.
* added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time.
* renamed Binned stats to FMemory to make it more general
* added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed.
* added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing
* fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type.
* Trackers now maintain totals for each enum tag
* tracking of Texture and mesh allocation on Windows D3D11 & D3D12
Change 3651334 by Joe.Barnes
Fix misspelled function name.
#jira 39441
#3016
Change 3653857 by Ben.Woodhouse
Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/...
Change 3656553 by Joe.Barnes
Add path for SCS_DeviceDepth.
Change 3662703 by Ben.Woodhouse
Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...:
[FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism
- Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame.
- Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe.
- r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency.
Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup.
A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index.
In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread.
[~] Unified platform specific sync interval CVars into one: rhi.SyncInterval
- 1 == 60Hz
- 2 == 30Hz
- 3 == 20Hz
Change 3675239 by Keith.Judge
Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit.
#jira UE-50626
Change 3676709 by Ben.Woodhouse
Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/...
Change 3689712 by Ben.Woodhouse
Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/...
Change 3701778 by Ben.Woodhouse
Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/...
Change 3677043 by Ben.Woodhouse
From StewartL:
I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336
Change 3726532 by Luke.Thatcher
[CONSOLE] [~] Enable XGE shader compilation by default.
- Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently.
Change 3726554 by Luke.Thatcher
[CONSOLE] [+] Improved Scoped Named Events
- Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings.
- Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out.
- Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings.
Change 3751378 by Ben.Woodhouse
Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/...
Change 3751812 by Ben.Woodhouse
Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/...
Change 3728571 by Luke.Thatcher
[CONSOLE] [!] Drop another XGE controller warning to log.
Change 3747150 by Joe.Barnes
Add AuthoringToolHelper.bat file to installed build copy list.
Change 3768585 by Ben.Woodhouse
Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/...
Change 3772333 by Ben.Woodhouse
Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/...
Change 3786872 by Ben.Woodhouse
Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/...
Change 3787279 by Luke.Thatcher
[CONSOLE] [~] Unified present threshold CVars.
- CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom.
- Platform implementations will be checked in shortly.
Change 3787445 by Luke.Thatcher
[CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console
Original CLs
- 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds.
- 3712693 - Fix for crash on startup in new frame syncing.
- 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off).
Change 3788417 by Ben.Woodhouse
Duplicate from FN CL 3712515
CSV profiler GPU and pre-declared stat support
- refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds
- add support for pre-declared CSV stats, using FNames (these are required for GPU stats)
- add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations
Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats
Change 3807818 by Ben.Woodhouse
Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/...
Change 3818577 by Ben.Woodhouse
Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/...
Change 3821198 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/...
Change 3821519 by Ben.Woodhouse
Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/...
#robomerge none
Change 3813513 by Ben.Woodhouse
CSV profiler refactor+ bug fix
- Move the CSV profiler to core, so we can use it in modules other than engine
- Profiler no longer enqueues RT commands - this is handled by a new core delegate type
- Make begin/end requests more robust, enqueued via a command queue and processed in order
- Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated
- Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures
- Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now
- Fix longstanding bug in first frame renderthread time in the engine
Change 3814039 by Ben.Woodhouse
More Csvprofiler improvements
- Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data
- Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types
Change 3814041 by Ben.Woodhouse
Integrate as edit CL 3796390 from Fortnite/Main:
Fix CsvProfiler not compiling in shipping for now
Change 3814229 by Ben.Woodhouse
Integrate + refactor of CL 3792591 to reduce complexity and fix bugs
Original changelist description:
CSV profiler improvements:
- The CSV profiler is now always compiled in on the server
- The CSV profiler can now handle both int32 and float stats
- In BeginCapture, the function can take additional arguments for some customization of filenames
Fixes to the above:
- Remove FCustomValue class
- Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together)
- FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value)
- FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical
- Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride
Change 3814242 by Ben.Woodhouse
Disable CSV unit stats on the dedicated server
Change 3817339 by Ben.Woodhouse
Duplicate from 3816641: CSV profiler improvements
- Added a low-pri processing thread to compress raw timing data into a much more efficient format
- Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB
- Processing time : 0.1ms per frame
- Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat
- Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class
- Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data
- Reduced #include dependencies for CSVProfiler.h
- Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity
- Added a simple test harness
Change 3817582 by Ben.Woodhouse
Fix android compile warning
Change 3823242 by Ben.Woodhouse
Integrate as edit from Fortnite/Main 3820067:
Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock.
Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says:
// This function should be used with caution.
// It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should
// not treat it as such.
// E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called.
Change 3823840 by Ben.Woodhouse
Edigrate from 3823816
Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen
Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored.
Change 3827787 by Ben.Woodhouse
Integrate-as-edit CL 3820678 from Fortnite/Main
Allow the CSV Profiler to be compiled in to shipping dedicated server builds
Change 3827842 by Ben.Woodhouse
Integrate-as-edit CL 3827079 from Fortnite/Main
CSV profiler category support
Change 3827918 by Luke.Thatcher
[CONSOLE] [!] Fix compile error in CSV custom stats.
Change 3827964 by Luke.Thatcher
[CONSOLE] [!] Fix inverted logic and spelling of boolean.
- Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool.
Change 3831661 by Ben.Woodhouse
Integrate-as-edit CL 3830630 from Fortnite/Main
Fix CSVProfiler assert in dev builds on XB1
Change 3860300 by Joe.Barnes
Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels.
Change 3860347 by Joe.Barnes
Delete existing SourceConfigFile before allocating a new one to prevent them leaking.
Change 3860348 by Joe.Barnes
Completely encapsulate GetLLMAlloc() in #ifdef.
Change 3861772 by Ben.Woodhouse
Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes
Change 3861774 by Ben.Woodhouse
Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW):
D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled.
Change 3862214 by Ben.Woodhouse
Integrate-as-edit CL 3859637 from Fortnite/Main
Dynamic resolution console tweaks
- Dynamic resolution high level switch driven by a cvar instead of code
- Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability
- Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds
Change 3863919 by Ben.Woodhouse
[Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639
Change 3864347 by Ben.Woodhouse
Fix the editor build. This will need a proper fix before 4.19 ships.
#lockdown Nick.Penwarden
#rb none
[CL 3913399 by Ben Marsh in Main branch]