izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixed skylight show flag not working properly for stationary skylight.

Browse Source 
#jira UE-116828
#rb Kevin.Ortegren

#ushell-cherrypick of 16531585 by Sebastien.Hillaire

#ROBOMERGE-SOURCE: CL 16533144 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16533149 by sebastien hillaire in ue5-release-engine-test branch]
This commit is contained in:
sebastien hillaire
2021-06-02 08:34:47 -04:00
parent d72abfcfd5 bc2c16f875
commit 4111525100
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Engine/Source/Runtime/Renderer/Private/SceneRendering.cpp
View File

@@ -1680,7 +1680,11 @@ void FViewInfo::SetupUniformBufferParameters(
{
FSkyLightSceneProxy* SkyLight = Scene->SkyLight;
ViewUniformShaderParameters.SkyLightColor = SkyLight->GetEffectiveLightColor();
// Setup the sky color mulitpler, and use it to nullify the sky contribution in case SkyLighting is disabled.
// Note: we cannot simply select the base pass shader permutation skylight=0 because we would need to trigger bScenesPrimitivesNeedStaticMeshElementUpdate.
// However, this would need to be done per view (showflag is per view) and this is not possible today as it is selected within the scene.
// So we simply nullify the sky light diffuse contribution. Reflection are handled by the indirect lighting render pass.
ViewUniformShaderParameters.SkyLightColor = Family->EngineShowFlags.SkyLighting ? SkyLight->GetEffectiveLightColor() : FLinearColor::Black;
bool bApplyPrecomputedBentNormalShadowing =
SkyLight->bCastShadows