Commit Graph

409 Commits

Author SHA1 Message Date
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
james singer
af3dc341fd Linux: Fix IsVanilla check by implementing EnumerateLauncherEngineInstallations for Linux
- Also add -BuildId flag to allow released builds to be registered as "launcher" builds.
- This gets us telemetry and the ability to open projects made on the Mac and Windows builds without being prompted to open a copy

#jira UE-187968
#rb zack.neyland, ryan.hummer

[CL 27716361 by james singer in ue5-main branch]
2023-09-08 12:55:33 -04:00
zousar shaker
ca374bd482 Add a setting that controls whether the modal acknowledgement dialog is shown before a browser is launched for OIDC authentication in editor. This setting is editor-wide (not per project), but:
1. A project can override the default value in that project's DefaultEditorSettings.ini
2. A user can indicate they don't want to see the dialog in the future, and thata setting is persisted to the user's editor settings file

If the setting indicates (either through defaults or user choice) that the acknowledgement dialog can be skipped, then unattended operations (eg: commandlets like cook etc..) are permitted to attempt interactive login by launching the browser.  If the browser login succeeds within a fixed timespan (30 seconds), then the unattended operation can proceed having successfully obtained an oidc token.  If the browser login hasn't succeeded in the fixed timespan, then the unanttended operation will proceed but will have failed to obtain an oidc token.  In neither case do we block indefinitely on completion of browser login to obtain an oidc token.

#rb joakim.lindqvist
[FYI] stefan.boberg
#jira UE-191803

[CL 27177449 by zousar shaker in ue5-main branch]
2023-08-17 13:13:20 -04:00
david harvey
bdb4199eeb Remove unnecessary WindowsHWrapper.h & MinWindows.h include - both files will be automatically included by AllowWindowsPlatformTypes.h
#jira UE-152863
#rnx
#rb Josh.Adams

[CL 26912096 by david harvey in ue5-main branch]
2023-08-08 05:50:53 -04:00
Ryan Hummer
3ebc0e1bcf Removing mono/xbuild part 1
* Updating references to use dotnet
* Add new RunDotnet scripts
* Removing Mono sh scripts and references to them

#rnx
#jira UE-153293
#rb josh.adams, zack.neyland, brandon.schaefer

[CL 26737744 by Ryan Hummer in ue5-main branch]
2023-08-01 10:02:58 -04:00
Joakim Lindqvist
3924fcb886 DDC is Derived Data Cache - update the message to reflect that.
#preflight none
#rb none

[CL 25674030 by Joakim Lindqvist in ue5-main branch]
2023-05-30 05:49:24 -04:00
devin doucette
90200ff6d0 DDC: Fixes related to the use of OIDC functionality from DesktopPlatform
- Fixed a crash when HttpCacheStore is used without DesktopPlatform.
- Fixed GetOidcAccessToken and GetOidcTokenStatus failing for targets with no Intermediate directory.
- Added DesktopPlatform to DerivedDataTool to allow it to use HttpCacheStore with OIDC.

#rb Zousar.Shaker
[FYI] Dan.Engelbrecht

[CL 25072527 by devin doucette in ue5-main branch]
2023-04-17 15:23:51 -04:00
Matt Peters
4472fb067c Fix compile error found by UHT validation error due to matching .h file not being first include.
#rb None, trivial
#rnx
#fyi William.Belcher
#preflight None, fix build break

[CL 24991608 by Matt Peters in ue5-main branch]
2023-04-11 11:12:03 -04:00
William Belcher
51883b4c5b QOL: Enable the Slate based file browser on Windows when using the NullPlatform
#rb
#jira UE-181579
#preflight https://horde.devtools.epicgames.com/job/642a4b9e89339023eb527855
#fyi

[CL 24986815 by William Belcher in ue5-main branch]
2023-04-10 20:48:21 -04:00
matt peters
c6a6899e09 OidcToken: Delete temporary files from Intermediate directory after we no longer need them.
#rb Devin.Doucette
#rnx
[FYI] Joakim.Lindqvist
#preflight 6427238550546ea336c81554

[CL 24878299 by matt peters in ue5-main branch]
2023-03-31 16:51:28 -04:00
devin doucette
7d6179f8b9 Fixed a compile error caused by the removal of FLogTime::GetCycles()
#jira none
#preflight none
#rb Zousar.Shaker
#rnx
#lockdown Zousar.Shaker

[CL 24689945 by devin doucette in ue5-main branch]
2023-03-17 11:21:52 -04:00
robert seiver
4b4c06ddff Add SVG icon for uprojects and ubinaries, which scales down to small icon scales without truncating.
#jira UE-125129
#review-24672911 @James.Singer
#preflight none

[CL 24676511 by robert seiver in ue5-main branch]
2023-03-16 15:03:43 -04:00
Ben Marsh
0e5d960c8a Use relative paths in TargetInfo.json to make them portable between machines (eg. when including in a zip of PCBs).
#preflight 640804f02559570cc71dba41

[CL 24554724 by Ben Marsh in ue5-main branch]
2023-03-07 23:01:27 -05:00
james singer
b3f19818b5 Remove a debugging check that was erroneously checked in as part of fix for UE-171276
#jira UE-178212
#review-24379986 @Zack.Neyland, @Robert.Seiver
#rb Brandon.Schaefer, Robert.Seiver
#preflight 63f7828da134e0b059ff25de

[CL 24380268 by james singer in ue5-main branch]
2023-02-23 10:31:41 -05:00
joakim lindqvist
40c47276bd Error -> Warning when we are unable to resolve a token for Cloud DDC. This will not cause the build to fail, but it will typically be slower for it so error is harsh (as that in itself causes the build to fail)
[FYI] zousar.shaker
#preflight 63ef6b8b90198dffbae12467

[CL 24281972 by joakim lindqvist in ue5-main branch]
2023-02-17 10:25:12 -05:00
zousar shaker
3b6feebfad Build break fix - Changed DesktopPlatform/LockFile to be unimplemented on non-desktop platforms instead of being a compile time error for them as DesktopPlatform is getting built for more than just Windows, Linux, and Mac.
[FYI] matt.peters

[CL 24263258 by zousar shaker in ue5-main branch]
2023-02-16 13:34:15 -05:00
zousar shaker
6aa9ea1e0f Allow for pre-booting the cooker and injecting one or more plugins to be cooked after the pre-boot has happened.
#rb matt.peters
#rb yliang.siew

[CL 24263249 by zousar shaker in ue5-main branch]
2023-02-16 13:34:04 -05:00
joakim lindqvist
ff73a7f021 OidcToken - Improved error message when running unattended to clarify that you can login using the editor.
#preflight 63ee14787e76998e9a9f5547
[FYI] zousar.shaker

[CL 24256982 by joakim lindqvist in ue5-main branch]
2023-02-16 09:11:24 -05:00
james singer
85828bb4a6 Fix for installed builds on linux not having a stable UUID from machine to machine
Note: Since Linux has no launcher, EnumerateLauncherEngineInstallations doesn't take care of this for us in Epic created Linux installed builds

#rb @Brandon.Schaefer, @Zack.Neyland
#jira UE-171276
#preflight 63ed495f5c7bd278c1fd149e

[CL 24241578 by james singer in ue5-main branch]
2023-02-15 16:20:13 -05:00
Joakim Lindqvist
9d1e86e2c3 OidcToken Fixes
Support multiple redirect uris (so that we can attempt to use multiple ports)
Handle invalid json in state file, ignoring the state file in those cases
Also made sure to delete oidc token result file after consuming it from the editor

#preflight 63d27dd26730a500ffafd80d
#fyi zousar.shaker

[CL 23882301 by Joakim Lindqvist in ue5-main branch]
2023-01-27 08:12:35 -05:00
rex hill
eab6f67207 Fix unicode character being used instead of ' in team's
#jira UE-174908
#rb brandon.schaefer
#preflight skip
[FYI] joakim.lindqvist

[CL 23834204 by rex hill in ue5-main branch]
2023-01-24 13:20:50 -05:00
Devin Doucette
c5b66c56b9 Fixed a missing include in MacNativeFeedbackContext.cpp
#preflight 63ce93c3574ab9cae434c349
#rb none
#rnx

[CL 23810391 by Devin Doucette in ue5-main branch]
2023-01-23 09:14:04 -05:00
Devin Doucette
d51817a175 Logging: Updated Mac feedback contexts to support structured logging
This relies on the base feedback context doing most of the work, as on other platforms.

Coloring was removed from the default Mac feedback context because it has no effect on the default output devices anyway. Output devices that do want to set color based on verbosity should incorporate that logic themselves in a thread-safe way instead of relying on the color being changed globally.

#jira UE-152840
#preflight 63cabcf76e7995c750c919da
#rb Zousar.Shaker
#rnx

[CL 23790894 by Devin Doucette in ue5-main branch]
2023-01-20 11:19:46 -05:00
Joakim Lindqvist
611799154b Wait up to 30 seconds before prompting users to finish the login - it can take a while if users need to enter their password and such, it is still quite short but on the other hand we do not want the editor to just sit around waiting for ever in case something has gone wrong.
#preflight 63bff0f2bf54fa7b3657f9c6

[CL 23660685 by Joakim Lindqvist in ue5-main branch]
2023-01-12 06:44:58 -05:00