Commit Graph

14254 Commits

Author SHA1 Message Date
catalin dragoiu
b23770a38e Fix static analysis error.
[CL 30266237 by catalin dragoiu in ue5-main branch]
2023-12-12 12:03:49 -05:00
zousar shaker
49d387e6c5 Use the low speed limit with zen cache store client, but with really tolerant threshold (only require 30 bytes over 60 seconds).
#rb dan.engelbrecht, Devin.Doucette

[CL 30265167 by zousar shaker in ue5-main branch]
2023-12-12 11:23:43 -05:00
devin doucette
7f3b930d93 DDC: Temporarily restored blocking during get requests in HttpCacheStore
#rb Zousar.Shaker
#rnx

[CL 30264462 by devin doucette in ue5-main branch]
2023-12-12 11:01:57 -05:00
helge mathee
fce83bdfa2 Control Rig: Refactor schematic view
#rb sara.schvartzman
#jira UE-173816
#rnx

[CL 30264435 by helge mathee in ue5-main branch]
2023-12-12 11:01:19 -05:00
laura hermanns
db7ba575fc Return EAgentMessageType::None instead of asserting null-pointer when reading a response to detect end of stream.
#rb Ben.Marsh
#rnx

[CL 30264192 by laura hermanns in ue5-main branch]
2023-12-12 10:49:21 -05:00
ionut matasaru
b48a4a7ce4 [Insights]
- Fixed crash when excuting TimingInsights.ExportTimerStatistics command with -region=*. In Editor traces, there are many (200000+) timing regions and some have names containing invalid characters for a file name. Using region name to make the output csv file fails. Fixed the issue by replacing all invalid characters with "_".
  - Fixed the slow enumeration of regions for TimingInsights.ExportTimerStatistics command.
  - Limited the number of export files to 100 for a single region (like "<SlowTask>") and to 10000 for the total number of csv files exported.

#jira UE-202381
#rb Catalin.Dragoiu

[CL 30261117 by ionut matasaru in ue5-main branch]
2023-12-12 08:07:42 -05:00
wouter burgers
5204069750 Skein / ConflictUE: Fixed 'check in changes' no longer redirecting to the 'conflict resolution' window when there are conflicts remaining. This was introduced in #29863963 when SSourceControlControls was created.
#rb Marco.Anastasi
#rnx

[CL 30260472 by wouter burgers in ue5-main branch]
2023-12-12 07:03:52 -05:00
catalin dragoiu
35f3568730 [Insights] Add metadata filter to the Filter Configurator. Add support for filters with custom UI.
#rb ionut.matasaru
#jira UE-140771

[CL 30259460 by catalin dragoiu in ue5-main branch]
2023-12-12 05:34:37 -05:00
halfdan ingvarsson
a1f38f2da4 AltSkin Import: When determining which points to process, ignore points that don't contribute to the mesh at all. FBX does not guarantee that all vertices are actually used by the mesh itself.
#rnx

[CL 30257247 by halfdan ingvarsson in ue5-main branch]
2023-12-11 23:48:04 -05:00
matt peters
63946ec48a MessageLog: Remove message logged during MessageLogListingModel::NewPage to remove spammy log messages when cooking projects with many UWorld assets.
#rnx
#rb Thomas.Sarkanen
[FYI] Thomas.Sarkanen

[CL 30250418 by matt peters in ue5-main branch]
2023-12-11 17:17:02 -05:00
dan engelbrecht
b30f7932e4 If we find an active parsed note in the ddc graph when creating it, return it instead of returning nullptr.
The main cooker process sets up the environment variable UE-ZenSharedDataCacheHost as part of it's initialization so the ZenShared instance is created by the worker processes when they initialize before the redirection for the file share is detected.

In the main cooker process that env-variable is not set so it skips creating the ZenShared instance until it finds the redirection.

Renamed ICacheStoreGraph::Create -> ICacheStoreGraph::FindOrCreate to better reflect the functionality.

#rb Devin.Doucette, Zousar.Shaker

[CL 30248058 by dan engelbrecht in ue5-main branch]
2023-12-11 15:52:04 -05:00
sebastien lussier
0af6dcbbc1 Merge Actor - Mesh Merge: Fix corner case where a merged mesh section was assigned an invalid material index (INDEX_NONE)
* Required a source mesh with two sections with identical materials
* Occured only when created a merged mesh without baking down textures
#jira UE-201699
#rb Patrick.Enfedaque

[CL 30245768 by sebastien lussier in ue5-main branch]
2023-12-11 14:29:20 -05:00
christopher waters
e9661bc768 Preparing for dependency cleanup.
[CL 30244022 by christopher waters in ue5-main branch]
2023-12-11 13:55:22 -05:00
sebastien lussier
5509a705b4 Material Baking - Better handle invalid entries
* Do not include empty entries in the array to be processed
#rb Patrick.Enfedaque

[CL 30243892 by sebastien lussier in ue5-main branch]
2023-12-11 13:53:14 -05:00
sebastien lussier
6f8486c231 Material Baking - When packing metallic/specular/roughness textures, also add "use" switches for these
* Fixes baking with some flattening materials that placed the UseXXX switch after testing for packed properties support
#rb Patrick.Enfedaque

[CL 30243305 by sebastien lussier in ue5-main branch]
2023-12-11 13:41:32 -05:00
ionut matasaru
2b3210e823 [Insights] Fixed ASan "unreachable code" error.
#jira UE-202213
#rb Catalin.Dragoiu

[CL 30237074 by ionut matasaru in ue5-main branch]
2023-12-11 09:09:52 -05:00
oleg krasnov
9650d68fce AutomationTest - Use FApp::GetInstanceId() instead of Messaging Address to identify Automation worker
#jira UE-200940
#rb Jerome.Delattre
#rnx

[CL 30232238 by oleg krasnov in ue5-main branch]
2023-12-11 01:29:09 -05:00
matt peters
64658cf6ae GetAssetRegistryTags deprecation: Make the old GetAssetRegistryTags and related functions deprecated.
Upgrade the overrides and callsites in all of Epic's code.
Every class that can be subclassed by licensees that has its override change needs to keep the old version of the function as deprecated. Otherwise subclasses that call Super::GetAssetRegistryTags will have a compile error instead of a deprecation warning.
Several classes had their own extension method for GetAssetRegistryTags being passed on to user data classes. Updated all of those to take FAssetRegistryTagsContext just like GetAssetRegistryTags does.
#rnx
#rb Francis.Hurteau

[CL 30224166 by matt peters in ue5-main branch]
2023-12-08 21:45:21 -05:00
chris constantinescu
e53e2611f7 Catch2 - enable exceptions for all platforms (allows SKIP to work properly)
#rb sebastian.lewicki
#jira UE-201146

[CL 30216424 by chris constantinescu in ue5-main branch]
2023-12-08 14:07:38 -05:00
dan elksnitis
be1f64ef8d [shaders] remove unused remnants of TEXT macro parsing code
#rb massimo.tristano

[CL 30214077 by dan elksnitis in ue5-main branch]
2023-12-08 12:36:13 -05:00
devin doucette
59dd82d717 DDC: Eliminated most blocking during get requests in HttpCacheStore
This restores the changes from 29016116 that were temporarily reverted.

#rb Zousar.Shaker
#rnx

[CL 30210802 by devin doucette in ue5-main branch]
2023-12-08 10:24:22 -05:00
sara schvartzman
49ecfd6bde Control Rig: Show possible matches during dragging of connector
#jira UE-202195
#rb Helge.Mathee
#rnx

[CL 30209690 by sara schvartzman in ue5-main branch]
2023-12-08 09:02:09 -05:00
paul chipchase
82618a9ffd Capture info messages for all perforce commands, the calling code can then decide if the info is important or not.
#rb juan.legaz
#jira UE-175581

### Perforce Connection
- FP4ClientUser now takes a FSourceControlResultInfo structure to store the warning/error messages generated during a perforce command, in addition we can now store info messages.
-- In almost all cases the array that was being passed in to store the warning/error messages came from a FSourceControlResultInfo so it doesn't change the overall flow.
- Rather than override ClientUser::OutputInfo to get the info messages we have overridden FP4ClientUser::Message instead as this is the preferred way in the cpp p4 api to capturing messages.
-- One difference between ::Message and the older capturing methods is that the older methods seemed to result in a newline character at the end of the message, which we do not see with the newer capture method. As some of our result parsing code relies on this behavior FP4ClientUser::Message will append this newline character for now until the parsing code can be fixed.
- For now FP4ClientUser still overrides ::OutputInfo, ::OutputError and ::HandleError but only to add a checkNoEntry() to each one. This is so that we can confirm that there are no remaining uses of it before removing it entirely.
- All classes derived from FP4ClientUser have been updated to work with the changes. In some cases this meant changing the override of ClientUser::OutputInfo to ClientUser::Message.
-- With a little bit of work we could probably remove these derived classes now that FP4ClientUser supports capturing the info messages which would help simplify the code base however this should be done in a future work item.

### Misc
- Remove ::FPerforceSourceControlProvider::GetWorkspaceList rather than update it, as it is not used.
- Add FSourceControlResultInfo::HasErrors to check if the struct contains errors or not.
-- Did not replace existing use of FPerforceSourceControlProvider::ErrorMessages.IsEmpty() that should be done as it's own work item.

[CL 30208418 by paul chipchase in ue5-main branch]
2023-12-08 06:47:37 -05:00
will brown
3a3e27c70e AutomationTool changes to support game projects overriding how to copy files during staging. InternalUtils.SafeCopyFile now takes an optional delegate to call when copying files. A CustomStageCopyHandler can be implemented to supply the copy operation. This is useful for transforming files during staging.
#rb Josh.Adams

[CL 30192577 by will brown in ue5-main branch]
2023-12-07 16:35:45 -05:00
eric renaudhoude
2eec3ab794 OCIO: Moved library wrapper module to runtime, fixing "non-editor build cannot depend on non-redistributable modules" warning after adding non-editor mode support in MRQ.
Minor cleanup of wrapper tests, preventing their presence unless the library is available.

#jira UE-202105
#rb rod.bogart, Ruslan.Idrisov

[CL 30192162 by eric renaudhoude in ue5-main branch]
2023-12-07 16:16:30 -05:00