Commit Graph

26 Commits

Author SHA1 Message Date
Max Preussner
976034aede Messaging: Replaced namespaced enums with enum classes
[CL 2326173 by Max Preussner in Main branch]
2014-10-10 20:14:08 -04:00
Max Preussner
661d24ddf0 Messaging: Documentation fix & cosmetic changes
[CL 2316681 by Max Preussner in Main branch]
2014-10-01 18:16:08 -04:00
Steve Robb
dc958ba860 Variadic template implementation of delegates.
* Variadic version is compiler-switched on variadic template support.
* Variadic version doesn't repeatedly include lots of the same headers to generate code.
* Tidying up of some original delegate stuff.
* Removed return type from lambda in K2Node_TemporaryVariable which was causing a Clang ICE.
* TTuple, TIntegerSequence and associated functionality - generic, but currently only implementation details of delegates and not yet for use in general code because there is no non-variadic version of them.
* MessageRouter and MessageTracer updated to use an actual delegate instead of implementation-specific identifiers.
* TTypeWrapper and TUnwrapType added to aid 'recursive' template definitions.
* C4373 disabled on VC - was only hitting this warning during development, but it's good to disable it anyway, as it's a 'this code is now standard' warning.

#codereview robert.manuszewski,mike.fricker,max.preussner,gareth.martin

[CL 2312735 by Steve Robb in Main branch]
2014-09-29 07:29:14 -04:00
Chris Gagnon
0c8fd0ab99 Merging using UE4-Releases-4.5-To-UE4 for JsonMessageSerializer.cpp
Fixed arrays of structs not desirializing properly.
#codereview max.preussner

[CL 2311791 by Chris Gagnon in Main branch]
2014-09-26 19:23:37 -04:00
Max Preussner
6510058ee7 Core: Moved Json out of Core and into its own module
The main changes are as follows:

1. moved Json out of Core into own module 'Json'
2. moved 3 i10n classes (Json serializers) from Core into a new module 'Internationalization' *
3. fixed up 2 i10n classes in Core to not instantiate the 3 Json-based classes. instead they are now passed in as a dependency

*) (2) and (3) were required to decouple the I10n code in Core from Json. Much of the i10n code probably doesn't belong into Core in the first place, but there is no time to fix this right now.

The following cosmetic changes were also made:

- NULL to nullptr
- namespaced enums to enum classes
- renamed the three i10n Json serializer classes to comply with naming conventions
- removed file header comments (not used)
- documentation, spelling, spacing etc,

#UpgradeNotes: If your module is including Json.h then you have to add 'Json' to your Build.cs module dependencies.

#ReviewedBy: justin.sargent, saul.abreu

[CL 2310420 by Max Preussner in Main branch]
2014-09-25 18:03:04 -04:00
Max Preussner
fff1feeb42 Messaging: Documentation updates
[CL 2303149 by Max Preussner in Main branch]
2014-09-18 17:14:28 -04:00
Ben Marsh
e9f8b8d3a1 Fixup multiline comments that are meant to be documentation. Need to start with /** for doxygen to parse them.
[CL 2265840 by Ben Marsh in Main branch]
2014-08-21 08:33:39 -04:00
Max Preussner
1d17536274 Messaging: Documentation cleanup pass
[CL 2239900 by Max Preussner in Main branch]
2014-08-01 11:02:58 -04:00
Mikolaj Sieluzycki
c49bfaac41 Back out splitting MessageEndpoint and MessageEndpointBuilder to .cpp and header.
[CL 2223238 by Mikolaj Sieluzycki in Main branch]
2014-07-18 10:09:45 -04:00
Mikolaj Sieluzycki
ac22d73dbb Add copyright notes to new files.
[CL 2219800 by Mikolaj Sieluzycki in Main branch]
2014-07-15 16:36:26 -04:00
Mikolaj Sieluzycki
7b14c9a0e4 Adding missing MessageEndpoint.cpp
[CL 2219136 by Mikolaj Sieluzycki in Main branch]
2014-07-15 11:15:29 -04:00
Mikolaj Sieluzycki
3eac0f9be7 Remove superfluous headers part 2 of n - Engine module cleanup, Animation headers.
#codereview Robert.Manuszewski

[CL 2219071 by Mikolaj Sieluzycki in Main branch]
2014-07-15 10:25:17 -04:00
Jaroslaw Palczynski
3a35a8dd0e Deprecate and remove checkAtCompileTime.
#ttp 337754
#codereview Robert.Manuszewski

[CL 2106862 by Jaroslaw Palczynski in Main branch]
2014-06-16 08:04:54 -04:00
Max Preussner
3aece47882 Docs: Removed file comments and added missing code documentation
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.

Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks

[CL 2104067 by Max Preussner in Main branch]
2014-06-12 23:22:18 -04:00
Max Preussner
d2e49132a8 renamed NULL to nullptr
[CL 2099934 by Max Preussner in Main branch]
2014-06-09 23:10:33 -04:00
Max Preussner
638a2e99b2 Messaging: Added more documentation, minor fixes
[CL 2099929 by Max Preussner in Main branch]
2014-06-09 23:05:20 -04:00
Max Preussner
6c0dc68c3b renamed OVERRIDE to override
[CL 2099326 by Max Preussner in Main branch]
2014-06-09 14:21:18 -04:00
Max Preussner
2a0981056f Messaging: Documentation cleanup pass
[CL 2095405 by Max Preussner in Main branch]
2014-06-05 00:53:32 -04:00
Jaroslaw Palczynski
724ea452a5 Refactoring thread affinity settings.
There was a bug in setting affinity of a thread that assumed affinity from lookup table with key being a thread name. When names was appended with consecutive numbers (e.g. "RenderingThread 1") the mechanism failed. Refactored this to use special static consts describing affinity override'able by different platforms for different affinity types + possibility of setting affinity per thread.
#codereview Jaroslaw.Surowiec

[CL 2070197 by Jaroslaw Palczynski in Main branch]
2014-05-12 08:40:54 -04:00
Mikolaj Sieluzycki
7a1386bfc9 #ttp 331740 UE4: Core: Runnable thread clean-up
#proj core
#branch UE4
#summary Remove all bAutoDeleteSelf and bAutoDeleteRunnable usage from the runnable.
#codereview Robert.Manuszewski

[CL 2070165 by Mikolaj Sieluzycki in Main branch]
2014-05-12 08:39:12 -04:00
Max Preussner
e497b0499a Messaging: documentation & nullptr cleanup
[CL 2061166 by Max Preussner in Main branch]
2014-05-01 12:13:54 -04:00
Peter Sauerbrei
bd53a23223 #ue4
#messaging
* temporary fix for accessing the messaging module from a thread other than the game thread

#codereview max.preussner

[CL 2053460 by Peter Sauerbrei in Main branch]
2014-04-23 20:08:47 -04:00
Jaroslaw Palczynski
37b8626c43 #ttp 331741 - UE4: CORE: TaskGraph: Move GetTaskName functionality into GetStatId
#proj UE4
#branch UE4
#summary The interface of FGenericTask is now changed. Removed GetTaskName() and changed GetStatId() to non-static and const.
#codereview Robert.Manuszewski
#codereview Jaroslaw.Surowiec

[CL 2048817 by Jaroslaw Palczynski in Main branch]
2014-04-23 19:22:09 -04:00
Max Preussner
a1a873a86f removed the remaining dependencies to the Networking module from the Messaging module;
cleaned up some fallout from incorrectly set up modules

[CL 2048417 by Max Preussner in Main branch]
2014-04-23 19:16:42 -04:00
UnrealBot
db494a6e69 Engine source (Main branch up to CL 2037954) 2014-04-02 18:09:23 -04:00