The main changes are as follows:
1. moved Json out of Core into own module 'Json'
2. moved 3 i10n classes (Json serializers) from Core into a new module 'Internationalization' *
3. fixed up 2 i10n classes in Core to not instantiate the 3 Json-based classes. instead they are now passed in as a dependency
*) (2) and (3) were required to decouple the I10n code in Core from Json. Much of the i10n code probably doesn't belong into Core in the first place, but there is no time to fix this right now.
The following cosmetic changes were also made:
- NULL to nullptr
- namespaced enums to enum classes
- renamed the three i10n Json serializer classes to comply with naming conventions
- removed file header comments (not used)
- documentation, spelling, spacing etc,
#UpgradeNotes: If your module is including Json.h then you have to add 'Json' to your Build.cs module dependencies.
#ReviewedBy: justin.sargent, saul.abreu
[CL 2310420 by Max Preussner in Main branch]
#branch UE4
#project UE4EditorServices
#summary Give the UE4EditorServices the option to choose which editor executable to use to launch with or generate Xcode projects for.
#change Add a simple window, with pop-up menu for selecting which version of the editor to use for launching/building.
#change When handling services, if there are multiple editors installed then ask the user which to use, the dialog can be suppressed and can be forcibly shown (hold Alt when activating the service).
reviewedby michael.trepka
[CL 2042404 by Mark Satterthwaite in Main branch]