Commit Graph

25 Commits

Author SHA1 Message Date
Andrew Rodham
525b290de8 More work to tidy up the target hardware section of the project settings
Applied settings are now written as a string rather than an int
Also added UObject::GetDefaultConfigFilename()

[CL 2305291 by Andrew Rodham in Main branch]
2014-09-22 09:41:38 -04:00
Michael Noland
2863e44464 Editor: Further reduce excess padding in settings editor (40->16)
[CL 2304574 by Michael Noland in Main branch]
2014-09-19 18:15:51 -04:00
Michael Noland
859c0fe02a Editor: Various settings editor fixes
- Fix SSettingsEditor reload config object regression
- Remove double-padding when editing a settings page that has a checkout prompt
- Fix pending hardware targeting settings not showing up if you change pages and come back
- Fix height pop in SSetingsEditorCheckoutNotice when status query finishes

[CL 2303657 by Michael Noland in Main branch]
2014-09-19 00:46:17 -04:00
Michael Noland
f9a1a1361f Editor: Update hardware targetting to use SSettingsEditorCheckoutNotice and devolved much of the bookkeeping in SSettingsEditor into SSettingsEditorCheckoutNotice
#codereview andrew.rodham

[CL 2303634 by Michael Noland in Main branch]
2014-09-19 00:01:10 -04:00
Michael Noland
afce366747 Editor: Start extracting SSettingsEditorCheckoutNotice out as a standalone widget (WIP)
[CL 2303546 by Michael Noland in Main branch]
2014-09-18 23:05:52 -04:00
Michael Noland
7dde40c236 Editor: Some small improvements to project settings dialog
- Change checkout notice for settings ini files to go green when they are editable
- Reworded messages to include the actual ini file name
- Hid 'reset to default' and 'set as default' options when editing a default ini file, since they make no sense in this context and were always disabled
#codereview max.preussner

[CL 2301866 by Michael Noland in Main branch]
2014-09-17 19:13:07 -04:00
Max Preussner
1e1bc2b3fa Settings: layout tweak
[CL 2291031 by Max Preussner in Main branch]
2014-09-09 12:35:07 -04:00
Max Preussner
1c4b5e2683 Settings: Removed category icons and the corresponding APIs
The placeholder category icons were never replaced with actual icons, and hence they do not fulfill any purpose. Icons as a visual language for categories also conflicts with their usage as interactive UI elements, such as buttons and toolbar options.

[CL 2290057 by Max Preussner in Main branch]
2014-09-09 12:13:47 -04:00
Nick Atamas
badf62c330 Slate slots now use a common base class, which has a private '.Widget' member; use GetWidget() instead.
Slate TPanelChildren, TSlotlessChildren are no longer full-fledged arrays; removed any unused Array API.
Fixed up a lot of improper use cases.

This better encapsulates the action of adding/removing Slate Widgets from the runtime tree as a Slate Core concern.
Alows us to add parent pointers in the future with significantly less effort.

#codereview Wes.Hunt
#codereview Nick.Darnell
#codereview Matt.Kuhlendschmidt
#codereview Justin.Sargent

[CL 2234301 by Nick Atamas in Main branch]
2014-07-28 06:53:40 -04:00
Matt Kuhlenschmidt
10126adc7d Record when a preference is changed for analytics. The value of the field is not sent.
[CL 2223627 by Matt Kuhlenschmidt in Main branch]
2014-07-18 14:18:55 -04:00
Thomas Sarkanen
5067159411 Settings editor no longer relies on read-only state of ini files.
The settings editor now queries the appropriate source control state of files that it its editing, rather than using the read-only state (which is only applicable to Perforce).
Also added a throbber to indicate that a source control query is in progress.

TTP# 337061 - EDITOR: SCC: SETTINGS: Settings Editor may not work correctly with some SCC providers

reviewed by Andrew.Brown

[CL 2116519 by Thomas Sarkanen in Main branch]
2014-06-25 05:32:15 -04:00
Max Preussner
3aece47882 Docs: Removed file comments and added missing code documentation
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.

Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks

[CL 2104067 by Max Preussner in Main branch]
2014-06-12 23:22:18 -04:00
Max Preussner
c4ed35f529 SettingsEditor: Documentation cleanup pass
[CL 2095322 by Max Preussner in Main branch]
2014-06-04 23:08:52 -04:00
Max Preussner
9c66d5462a Settings: Fixed Settings UI incorrectly assumes that default INI files are under source control if they are read-only (TTP# 336653)
[CL 2087420 by Max Preussner in Main branch]
2014-05-29 17:31:02 -04:00
Max Preussner
c6855b9f9c documentation fixes
[CL 2073073 by Max Preussner in Main branch]
2014-05-14 14:51:08 -04:00
Max Preussner
26ec746232 added missing documentation; removed redundant line breaks
[CL 2073071 by Max Preussner in Main branch]
2014-05-14 14:50:57 -04:00
Max Preussner
f04f900868 SettingsEditor: Ensuring that there is always a settings section selected
[CL 2067668 by Max Preussner in Main branch]
2014-05-08 20:23:50 -04:00
Max Preussner
61ef24cdc1 SettingsEditor: fixed notification popup always showing error; cosmetic changes
[CL 2065894 by Max Preussner in Main branch]
2014-05-07 14:46:21 -04:00
Andrew Brown
7b4daa53c3 Preferences now inform the user on the sucess of importing and exporting
#ttp 334472 - EDITOR: Feature Request: Preferences: Exporting and Importing could provide more feedback

#branch UE4

reviewed by Thomas.Sarkanen

[CL 2065409 by Andrew Brown in Main branch]
2014-05-07 05:33:38 -04:00
Justin Sargent
36d7edc26c L10N: Fixing localization errors. Missing #undefines, conflicted loc keys and comments being incorrectly detected as expected LOCTEXT macros.
[CL 2052470 by Justin Sargent in Main branch]
2014-04-23 19:57:06 -04:00
Thomas Sarkanen
a5274d1b18 #summary Fixed up issues found when creating a new source control provider.
#ttp 331349 	Editor: Source Control: Some issues with creating new source control provider
#change 	Fixed up conflation of enum with bool in if() blocks when calling Execute().
#fix 	Fixed QueueStatusUpdate not checking for NULL source control state.
reviewed by 	Andrew.Brown

[CL 2049714 by Thomas Sarkanen in Main branch]
2014-04-23 19:31:56 -04:00
Max Preussner
76e85e8a30 forgot to check in
[CL 2049117 by Max Preussner in Main branch]
2014-04-23 19:25:46 -04:00
Max Preussner
ed4038010d the sections in the Settings UI now automatically sort alphabetically
[CL 2049115 by Max Preussner in Main branch]
2014-04-23 19:25:36 -04:00
UnrealBot
db494a6e69 Engine source (Main branch up to CL 2037954) 2014-04-02 18:09:23 -04:00
Tim Sweeney
324683ce78 Engine source (Main branch up to CL 2026164) 2014-03-14 14:13:41 -04:00