Applied settings are now written as a string rather than an int
Also added UObject::GetDefaultConfigFilename()
[CL 2305291 by Andrew Rodham in Main branch]
- Fix SSettingsEditor reload config object regression
- Remove double-padding when editing a settings page that has a checkout prompt
- Fix pending hardware targeting settings not showing up if you change pages and come back
- Fix height pop in SSetingsEditorCheckoutNotice when status query finishes
[CL 2303657 by Michael Noland in Main branch]
- Change checkout notice for settings ini files to go green when they are editable
- Reworded messages to include the actual ini file name
- Hid 'reset to default' and 'set as default' options when editing a default ini file, since they make no sense in this context and were always disabled
#codereview max.preussner
[CL 2301866 by Michael Noland in Main branch]
The placeholder category icons were never replaced with actual icons, and hence they do not fulfill any purpose. Icons as a visual language for categories also conflicts with their usage as interactive UI elements, such as buttons and toolbar options.
[CL 2290057 by Max Preussner in Main branch]
Slate TPanelChildren, TSlotlessChildren are no longer full-fledged arrays; removed any unused Array API.
Fixed up a lot of improper use cases.
This better encapsulates the action of adding/removing Slate Widgets from the runtime tree as a Slate Core concern.
Alows us to add parent pointers in the future with significantly less effort.
#codereview Wes.Hunt
#codereview Nick.Darnell
#codereview Matt.Kuhlendschmidt
#codereview Justin.Sargent
[CL 2234301 by Nick Atamas in Main branch]
The settings editor now queries the appropriate source control state of files that it its editing, rather than using the read-only state (which is only applicable to Perforce).
Also added a throbber to indicate that a source control query is in progress.
TTP# 337061 - EDITOR: SCC: SETTINGS: Settings Editor may not work correctly with some SCC providers
reviewed by Andrew.Brown
[CL 2116519 by Thomas Sarkanen in Main branch]
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.
Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks
[CL 2104067 by Max Preussner in Main branch]
#ttp 334472 - EDITOR: Feature Request: Preferences: Exporting and Importing could provide more feedback
#branch UE4
reviewed by Thomas.Sarkanen
[CL 2065409 by Andrew Brown in Main branch]
Other Updates:
- The WidgetReflector is now in its own module as well. It will be converted to a plug-in later.
- The Public API of both Slate and SlateCore has largely been reorganized for better discoverabilty. More cleanup work is needed.
- Added a lot of missing API documentation and fixed existing ones. More and better documentation is needed.
- Removed dead code, fixed a couple things I stubled upon, and conformed to coding guidelines (NULL vs nullptr, line breaks, etc.)
Upgrade Notes:
- The Slate Remote Server is currently disabled - will be re-enabled shortly!
- If your module previously had a module dependency to 'Slate', it now also needs a PrivateModuleDependency to 'SlateCore' in its Build.cs file.
- If your module exposes in any of its Public header files types that are now declared in SlateCore, it needs a PublicModuleDependency to 'SlateCore'
- The ToolTip property type on SWidget has changed from SToolTip to IToolTip; change local variables to TSharedPtr<IToolTip> instead of TSharedPtr<SToolTip> where needed
- IToolTip is not a widget. If you need access to the actual widget that represents the tool tip, use IToolTip::AsWidget(); If you need access to the tool tip's content, use IToolTip::GetContentWidget()
Troubleshooting:
- After syncing to this changelist you may have to clean your /Engine/Intermediate/Build/ directory and rebuild your entire project
- If in your project you are getting linker errors for unresolved types that are now declared in SlateCore, you may be missing a dependency to 'SlateCore'
- If in the Engine code you are getting linker errors for unresolved types that are now declared in SlateCore, you may need to rebuild the entire Engine
[CL 2057118 by Max Preussner in Main branch]
#ttp 331349 Editor: Source Control: Some issues with creating new source control provider
#change Fixed up conflation of enum with bool in if() blocks when calling Execute().
#fix Fixed QueueStatusUpdate not checking for NULL source control state.
reviewed by Andrew.Brown
[CL 2049714 by Thomas Sarkanen in Main branch]
