Commit Graph

2914 Commits

Author SHA1 Message Date
joe pribele
71694cd010 lazyload support for zenloader
https://p4-swarm.epicgames.net/reviews/24507657
#preflight 640908e0aa00423335d51461

[CL 24568340 by joe pribele in ue5-main branch]
2023-03-08 17:29:42 -05:00
joe pribele
a7673567fe change to FObjectPropertyBase ParseObjectPropertyValue and FindImportedObject to take in a TObjectPtr<UObject> instead of UObject
added `SetObjectPtrPropertyValue(void* PropertyValueAddress, TObjectPtr<UObject> Value)`

this allows objects to be imported from text without resolving the object
#preflight 640900fa8832f48a4dc62ee4

[CL 24567650 by joe pribele in ue5-main branch]
2023-03-08 16:56:59 -05:00
robert millar
c3778410d3 Remove unnecessary access to linker annotation in UObject::AddReferencedObjects.
Lifetime of Linker should be set by Package's BeginDestroy.
Speeds up reference traversal in editor significantly. (Approx 25% decrease in bp reinstancing time in a large test case.)

#rb francis.hurteau
#preflight https://horde.devtools.epicgames.com/job/6408d217827cf9251b30fef5

[CL 24567057 by robert millar in ue5-main branch]
2023-03-08 16:30:33 -05:00
paul chipchase
35134bea20 Saving packages with the package trailer stucture is no longer optional.
#rb PJ.Kack
#jira UE-179504
#rnx
#preflight 64089b4f8832f48a4d9db8b8

- Removed the config file option [Core.System]UsePackageTrailer so we no longer read it, the system is now on permantly
- FPackageTrailer::IsEnabled was the only place reading that config file option. To avoid compiler issues it will now always return true but is marked as deprecated so if any 3rd party has been using this (and I cannot think why they would) they will be alerted to the change.

[CL 24559907 by paul chipchase in ue5-main branch]
2023-03-08 10:22:31 -05:00
Joe Kirchoff
48ab1a4c72 ElementProp=ElementProp -> this lambda capture
#preflight 6407b6ef2559570cc7046546

[CL 24549231 by Joe Kirchoff in ue5-main branch]
2023-03-07 17:25:39 -05:00
Joe Kirchoff
109addf6a3 Cpp20 doesn't allow implicit capture of 'this' via '[=]'
#rb Francis.Hurteau
#preflight 64068c936e1dadfcda41bb82

[CL 24548358 by Joe Kirchoff in ue5-main branch]
2023-03-07 16:49:18 -05:00
Tim Smith
56ede56d0c PR #10110: Skip unnecessary iteration in GetMaxEnumValue (Contributed by KristofMorva)
#rb tim.smith
#preflight 6407353cba12ba641682321c

[CL 24538721 by Tim Smith in ue5-main branch]
2023-03-07 08:14:05 -05:00
joe pribele
1849935546 changed MarkSearchableName to take a TObjectPtr to avoid resolving objects
https://p4-swarm.epicgames.net/reviews/24504202
#rb zousar.shaker
#preflight 64025f51d249add4a287924b

[CL 24507138 by joe pribele in ue5-main branch]
2023-03-03 16:27:25 -05:00
robert millar
47b7b927fa Speculative fix for object being removed from object hash during gc when it was never inserted.
#rb none

[CL 24493733 by robert millar in ue5-main branch]
2023-03-02 20:28:57 -05:00
matt peters
cf3134b007 GarbageCollection support for Cooker SoftGC: When collecting garbage for the cooker, if a package is referenced and will remain in memory, it needs to ensure that all of its public objects will also remain in memory so they can be exported if the package is ever saved.
[REVIEW] [at]graeme.thornton, [at]zousar.shaker
#preflight 6400fb415f3b94d2922766db
#rb Zousar.Shaker
#rnx
#localization none
#tests Fortnite cook, no runtime tests

[CL 24491745 by matt peters in ue5-main branch]
2023-03-02 18:03:52 -05:00
phillip kavan
39e895397a Additional fixes needed around deferring CDO exports on editor loads.
#rnx
#jira UE-175370, UE-178685, UE-178686, UE-178850
#rb Dan.OConnor
#preflight 63ff1444e32cdb7d9a9d8a47

[CL 24471344 by phillip kavan in ue5-main branch]
2023-03-01 16:53:14 -05:00
francis hurteau
63988aa391 Do not broadcast OnAsyncLoadingFlush delegate when they are done in the context of a sync load when using the zen loader
#rb Robert.Millar, Matt.Peters
#preflight 63ff94bcef1b24bf94a3cc39

[CL 24471295 by francis hurteau in ue5-main branch]
2023-03-01 16:51:52 -05:00
julien stjean
c846852672 Allow the loaded objects to query the linker to know if there package was relocated.
Added a warning when loading a level with some external object or actors that was relocated because it is not properly supported and it might cause some data stumping when saving the external objects and actors.

[REVIEW] [at]francis.hurteau
#preflight 63fe8a9dae54ee4ce9e685d8
#localization none

#tests Loaded some relocated level to validate the presence of the warning. Loaded some not relocated level to validate that the warning is not present. Run a preflight to validate that the change is not creating new cis issues.

[CL 24470081 by julien stjean in ue5-main branch]
2023-03-01 16:02:15 -05:00
francis hurteau
44122576f1 ZenLoader in Editor: Respect the LoadObject flags LOAD_Quiet and LOAD_Warn flags to silence warnings about missing packages in this scenario.
Always silence warning about missing package for script packages, just like GetPackageLinker() simply returns nullptr for PKG_InMemoryOnly.
submitted on behalf of [at]PJ.Kack

#rb Matt.Peters
#preflight 63fe8765ae54ee4ce9e59742

[CL 24469377 by francis hurteau in ue5-main branch]
2023-03-01 15:38:55 -05:00
james hopkin
528c83e026 Fixed cyclic header dependency. UnrealType.h was indirectly including itself via CoreNetTypes.h.
#preflight 63ff3f0cac6c61e2b5ae8636

[CL 24465005 by james hopkin in ue5-main branch]
2023-03-01 12:33:17 -05:00
johan torp
4297058fe8 Silence clang static analysis warning
#horde 269934
#rb none
#rnx

[CL 24459205 by johan torp in ue5-main branch]
2023-03-01 03:58:18 -05:00
bart hawthorne
1057c6613a Do not track the garbage flag state in the object serialization for transactions, instead track in the transaction itself if the transaction deleted/restored an object. This prevents where situations where objects could be restored or deleted incompletely if they are gone for some reason without the user making the active change.
[CL 24454366 by bart hawthorne in ue5-main branch]
2023-02-28 18:22:44 -05:00
joe pribele
db7a692cc7 second attempt to fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fe5fc7ac6c61e2b553e9a9

[CL 24449378 by joe pribele in ue5-main branch]
2023-02-28 15:26:26 -05:00
johan torp
cdd1199203 Add GC.DumpTokenStats command
#rb pj.kack
#rnx
#preflight 63fe0c722b1a2765f9ea42b9

[CL 24443930 by johan torp in ue5-main branch]
2023-02-28 11:35:57 -05:00
rex hill
0316b3d9b9 Optimize ResolveName() - Change FString PartialName to TStringBuilder
#preflight skip
#rb pj.kack

[CL 24443923 by rex hill in ue5-main branch]
2023-02-28 11:35:52 -05:00
johan torp
f696e429ea Drop weak token support for CollectReferences/TFastReferenceCollector
#rb  pj.kack
#preflight 63f4f28091018822ccf2579f

[CL 24442012 by johan torp in ue5-main branch]
2023-02-28 09:56:36 -05:00
robert millar
f384701485 Add a CVar to control getting property names and callstacks from FGCObject as it's very expensive.
If we fail/choose not to get property names, get the name of the FGCObject itself.

[REVIEW] [at]daniel.lamb

#localization none
#tests Testing running obj refs command during gameplay in a client. Time reduced from over a minute to ~5s for finding references to a StaticMeshComponent.

[CL 24436838 by robert millar in ue5-main branch]
2023-02-27 20:57:48 -05:00
phillip kavan
f8f5fd63d3 Fix potential for data loss when loading hierarchical Blueprint class assets w/ circular dependencies asynchronously in the editor.
#jira UE-175370
#rb Francis.Hurteau, Dan.OConnor
#preflight 63f5cd08977ceed9151fe3a4

[CL 24436823 by phillip kavan in ue5-main branch]
2023-02-27 20:56:57 -05:00
joe pribele
6d1d492c29 [Backout] - CL24432584
#fyi joe.pribele
Original CL Desc
-----------------------------------------------------------------
fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fd1de9f43e53f6811a37af

[CL 24436160 by joe pribele in ue5-main branch]
2023-02-27 19:54:50 -05:00
joe pribele
bcc680cfa3 fix for performance problem when converting arrays of TObjectPtr to UObject*
changed the access tracking to a bulk operation api to allow for single calls instead of O(n) calls
#preflight 63fd1de9f43e53f6811a37af

[CL 24432584 by joe pribele in ue5-main branch]
2023-02-27 16:37:45 -05:00