izzy/UnrealEngineUWP
0
0
Fork 0
mirror of https://github.com/izzy2lost/UnrealEngineUWP.git synced 2026-03-26 18:15:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

Optimize ResolveName() - Change FString PartialName to TStringBuilder

Browse Source 
#preflight skip
#rb pj.kack

[CL 24443923 by rex hill in ue5-main branch]
This commit is contained in:
rex hill
2023-02-28 11:35:52 -05:00
parent d05bc8e286
commit 0316b3d9b9
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Engine/Source/Runtime/CoreUObject/Private/UObject/UObjectGlobals.cpp
View File

@@ -1129,7 +1129,9 @@ bool ResolveName(UObject*& InPackage, FString& InOutName, bool Create, bool Thro
}
int32 DotIndex = DelimiterOrEnd - *InOutName;
FString PartialName = InOutName.Left(DotIndex);
TStringBuilder<FName::StringBufferSize> PartialName;
PartialName.Append(*InOutName, DotIndex);
bool bIsScriptPackage = false;
if (!InPackage)
@@ -1140,15 +1142,15 @@ bool ResolveName(UObject*& InPackage, FString& InOutName, bool Create, bool Thro
FName* ScriptPackageName = FPackageName::FindScriptPackageName(*PartialName);
if (ScriptPackageName)
{
PartialName = ScriptPackageName->ToString();
ScriptPackageName->ToString(PartialName);
}
bIsScriptPackage = ScriptPackageName || FPackageName::IsScriptPackage(PartialName);
bIsScriptPackage = ScriptPackageName || FPackageName::IsScriptPackage(FStringView(PartialName));
}
// Process any package redirects before calling CreatePackage/FindObject
{
const FCoreRedirectObjectName NewPackageName = FCoreRedirects::GetRedirectedName(ECoreRedirectFlags::Type_Package, FCoreRedirectObjectName(NAME_None, NAME_None, *PartialName));
PartialName = NewPackageName.PackageName.ToString();
NewPackageName.PackageName.ToString(PartialName);
}
}
@@ -1175,7 +1177,7 @@ bool ResolveName(UObject*& InPackage, FString& InOutName, bool Create, bool Thro
}
InPackage = NewPackage;
}
else if (!FPackageName::IsShortPackageName(PartialName))
else if (!FPackageName::IsShortPackageName(FStringView(PartialName)))
{
// Try to find the package in memory first, should be faster than attempting to load or create
InPackage = InPackage ? nullptr : StaticFindObjectFast(UPackage::StaticClass(), InPackage, *PartialName);