Commit Graph

11863 Commits

Author SHA1 Message Date
patrick laflamme
7b2b492042 Optimized the UnsavedAssetsTracker to avoid building the full package pathname for package that are already tracked.
#jira UE-166080 - Large frame rate hit when recording a CineCameraActor
#rb Patrick.Enfedaque
#preflight 63403ee9587d6afac85a7b4d

[CL 22406976 by patrick laflamme in ue5-main branch]
2022-10-07 15:23:52 -04:00
Yuriy ODonnell
9ab9403717 ShaderMinifier - Track and output line directives
#rb Jason.Nadro
#preflight 63406dd22a0a2c1ead8d1145

[CL 22405822 by Yuriy ODonnell in ue5-main branch]
2022-10-07 14:31:38 -04:00
christopher waters
66f2a6bcc5 Make the parsed resource/sampler name be the authoritative casing of the variable names. The rest of the shader system is case insensitive but the shader code that uses the variables isn't, so we need to preserve the case we found in the shader.
#jira UE-166341
#rb Guillaume.Abadie, mihnea.balta, jeannoe.morissette
#preflight 634055772a0a2c1ead83dc02

[CL 22404161 by christopher waters in ue5-main branch]
2022-10-07 13:35:29 -04:00
arciel rekman
1ad6c3648e Fix Lyra crash due to shader decompression failure (UE-165785).
- PCD3D_SM5 and PCD3D_SM6 had a unique situation of having identical (bytecode-wise and output hash-wise) shaders (raytracing is allowed in PCD3D_SM5). This resulted in those IoStore chunks being deduplicated, however, the actual contents were not identical due to optional data (which isn't included in the shader hash, see UE-166389).
- This fix makes sure we don't use just the shader hash alone to produce IoStore chunk hashes. Hash will now include the shader size and the shader format name.
- A few early guards added here and there to detect the problem early.

Also fixed a memory leak in UnrealPak pointed by CM.

#rb [at]Yuriy.ODonnell, [at]CarlMagnus.Nordin, [at]Christopher.Waters, [at]Jason.Nadro
#jira UE-165785
#preflight 633f3beed718720d2d58f37e

[CL 22402802 by arciel rekman in ue5-main branch]
2022-10-07 12:32:35 -04:00
danny couture
933197ef5b Fix TSAN compilation in editor for some TSAN_ATOMIC globals using TGuard scopes
#rb Devin.Doucette
#preflight 633f95992a0a2c1ead572ad6

[CL 22401373 by danny couture in ue5-main branch]
2022-10-07 11:14:15 -04:00
jeanfrancois dube
24188090b0 Fix all known cases of GetTypedOuter<UPackage> since it's not valid anymore with override packages.
#rb francis.hurteau
#preflight 633ee7528579446629e2cb5d
#rnx

[CL 22398835 by jeanfrancois dube in ue5-main branch]
2022-10-07 08:12:45 -04:00
Helge Mathee
1e43bc884a Control Rig: Avoid double initialization of struct instances
#rb sara.schvartzman
#jira UE-158418
#preflight https://horde.devtools.epicgames.com/job/634006d4d718720d2d84554d

[CL 22398526 by Helge Mathee in ue5-main branch]
2022-10-07 07:29:25 -04:00
anton dunchev
bc4c147660 Show module name in a callstack grouping when symbol is not resolved.
#rb ionut.matasaru

[CL 22391970 by anton dunchev in ue5-main branch]
2022-10-06 23:06:54 -04:00
anton dunchev
590396b36e Added more allocator-related symbols to skip when choosing TopFunction
#rb ionut.matasaru

[CL 22390201 by anton dunchev in ue5-main branch]
2022-10-06 20:59:32 -04:00
anton dunchev
fed049da99 Added size column for Modules tab
#rb ionut.matasaru

[CL 22390157 by anton dunchev in ue5-main branch]
2022-10-06 20:58:16 -04:00
anton dunchev
8443b21175 Fix remove\trace command not working because name of a file has extra .utrace at the end
#rb ionut.matasaru

[CL 22387906 by anton dunchev in ue5-main branch]
2022-10-06 19:46:14 -04:00
Devin Doucette
74ce7089b4 DDC: Fixed SharedString reference counting flagged by TSan
#preflight 633f1a48437603cb0edd72a4
#rb Zousar.Shaker
#rnx

[CL 22384667 by Devin Doucette in ue5-main branch]
2022-10-06 17:28:03 -04:00
christopher waters
2a22fbe25b Bindless Resource shader support
- Adding better support for resources that have multiple template arguments (Texture2DMS<float4,2>, etc).
- Requires typedef'ing all Resource types to avoid their extra comments being given to our AUTO_BINDLESS macros
- Adding support for globallycoherent
- Reworked BindlessConversionType to use its own enum.

#jira UE-166341
#rb guillaume.abadie, elizabeth.baumel
#preflight 633f2bde587d6afac82007e4

[CL 22383098 by christopher waters in ue5-main branch]
2022-10-06 16:27:11 -04:00
christopher waters
281072e217 Don't count shader parameters that we don't bind through resource tables. Resources like UEDiagnosticBuffer and vendor extensions are handled through Root Signatures.
#jira
#rb yuriy.odonnell, elizabeth.baumel
#preflight 633ef2f7511dd8cb01cc51db

[CL 22381598 by christopher waters in ue5-main branch]
2022-10-06 15:23:50 -04:00
christopher waters
93ae33e36e Fixing parsing resource types like "Texture3D < uint4 >" where the space between the type and the "<" prevented the type from being found.
#jira UE-166341
#rb yuriy.odonnell
#preflight 633f0069607039cbc1082ef0

[CL 22378331 by christopher waters in ue5-main branch]
2022-10-06 13:04:52 -04:00
Patrick Boutot
d6892b55a5 Find the best available D3D device for standalone Slate application. Use similar options as RHI D3D11.
#jira UE-155771
#rb christopher.waters
#preflight 633ecc6a390c8b9d3f735b1d, 633eef084769293195622c20

[CL 22377270 by Patrick Boutot in ue5-main branch]
2022-10-06 12:03:20 -04:00
christopher waters
38cc1eb3b2 Instead of adding the different D3D shader format versions together, combine their hashes. This will prevent version overlaps when someone changes the shared version.
#jira none
#rb yuriy.odonnell
#preflight 633e43653a20cf302c9fee76

[CL 22371688 by christopher waters in ue5-main branch]
2022-10-05 23:57:45 -04:00
dan engelbrecht
502ded405a Make sure we wait for any async commits in ZenStoreWriter to complete before sending EndCook.
Previous implementation only waited for the commit to be picked up by the worker thread.
Simplified CommitQueue event logic.
#rb zousar.shaker per.larsson
#preflight none

[CL 22364055 by dan engelbrecht in ue5-main branch]
2022-10-05 17:41:51 -04:00
patrick laflamme
fe0523d016 Fixed the unsaved assets tracker crashing when auto-saving package.
Fixed the unsaved assets tracker to correctly work undo/redo.
Fixed the unsaved assets tracker to correctly handle when the temporary 'Untitled' map is discarded or saved.

#rb Patrick.Enfedaque
#preflight 633cbe0a4a2cd8f4b26d43c2

[CL 22361796 by patrick laflamme in ue5-main branch]
2022-10-05 15:48:36 -04:00
christopher waters
41c44beead Cleaning up deprecated items in "Shader" files for 5.2
#jira none
#rb yuriy.odonnell
#preflight 633cab5d0e66c104f1daed41

[CL 22356197 by christopher waters in ue5-main branch]
2022-10-05 11:38:15 -04:00
Devin Doucette
e0a0961a5d DDC: Used InheritedContext to implement the reverted inheritance of memory tags
#preflight 633c89b70e66c104f1cdc505
#rb Andriy.Tylychko, Zousar.Shaker
#rnx

[CL 22353683 by Devin Doucette in ue5-main branch]
2022-10-05 09:23:53 -04:00
jack cai
9d6ee2889b ControlRig: user defined struct used as function argument can trigger an assertion when one of the member variables change its type
#jira UE-165790
#rb Sara.schvartzman, Helge.mathee
#preflight https://horde.devtools.epicgames.com/job/633b1c006b10157eac5fc7ba

[CL 22336420 by jack cai in ue5-main branch]
2022-10-04 15:24:37 -04:00
thomas sarkanen
ae10e0eff9 Fix incorrect asset menu actions appearing for animation blueprints
Also fixes the asset context menu section header for anim BPs to not read as "animation layer interface" (this is just the re-ordering of asset type action registration)

#jira UE-165922
#rb Jurre.deBaare
#preflight 633c33aff96f5ad403a2df41

[CL 22331996 by thomas sarkanen in ue5-main branch]
2022-10-04 12:01:02 -04:00
Andriy Tylychko
ab5a1abe8d InheritedContext
grouped inherited LLM tag, mem tag and trace metadata into FInheritedContext to simplify their usage, avoid forgetting using all of them together, and to hide the ugly conditional compilation. Added FInheritedContext to higher level tasks instead of the low-level tasks to allow batch task launch to capture the inherited context once per batch

#rb ionut.matasaru
#preflight 633c47792f4bf32d31687192

[CL 22331272 by Andriy Tylychko in ue5-main branch]
2022-10-04 11:22:08 -04:00
sebastian nordgren
2d132607b1 SCustomDialog no longer clips any button texts that are longer than the first button text.
This is because the dialog used SUniformGridPanel, which does sizing based on the first button, not the largest one. We now use SHorizontalBox with AutoWidth() instead.

Removed useless log entry.

[REVIEW] [at]dominik.peacock, [at]lauren.barnes
#rnx

[CL 22331033 by sebastian nordgren in ue5-main branch]
2022-10-04 11:06:26 -04:00