Commit Graph

1255 Commits

Author SHA1 Message Date
richard malo
db97c253ae AsyncLoading2 instancing context fix : Don't pass down the request's instancing context to imported packages (FAsyncPackageDesc2::FromPackageImport).
This change has no impact in editor as imports are already handled through InitializeLinkerLoadState.
#rb Andrew.Rodham, JeanFrancois.Dube, Patrick.Enfedaque
#tests Validated the fix in internal projects using instancing context in cooked builds + Validated the fix in in a cooked/staged gym.
[FYI] Francis.Hurteau, danny.couture

[CL 32057625 by richard malo in ue5-main branch]
2024-03-06 12:17:47 -05:00
graeme thornton
6c559c6afd Reduce package hash collision logging to verbose
#rb PJ.Kack

[CL 31996515 by graeme thornton in ue5-main branch]
2024-03-04 14:09:36 -05:00
matt breindel
3c6cf59c14 Infrastructure and general implementation of a new system for providing improve error messages when we skip loading a package during import because the plugin wasn't mounted. the plugin manager and the GameFeatureSubsystem now have an opportunity to provide additional information to the user about why the plugin wasn't loaded or the package wasn't found.
#jira UE-205029
[REVIEW] [at]will.brown [at]*eric.knapik [at]*danny.couture
[FYI] [at]francis.hurteau
#rb danny.couture, Eric.Knapik

[CL 31957199 by matt breindel in ue5-main branch]
2024-03-01 16:48:08 -05:00
danny couture
acf6639d6e [ZenLoader]
- Add stack trace when logging invalid flushes error so we can more easily identify their provenance when running test builds
  - Add unittest to validate the error

#rb mic.rooney

[CL 31868231 by danny couture in ue5-main branch]
2024-02-28 06:58:55 -05:00
daniele pieroni
3cec0eb185 - Pass down the StorageServerConnection if a request needs a staging buffer to decode into it, since the memory used can be uncached or write-combined, usually GPU resource
#jira UE-207219
#rb Per.Larsson

[CL 31839785 by daniele pieroni in ue5-main branch]
2024-02-27 09:55:36 -05:00
maxime mercier
30f81e60d6 Remove the overridable serialization logic when using UPS
#rb kurtis.schmidt, Yoan.StAmant

[CL 31823398 by maxime mercier in ue5-main branch]
2024-02-26 19:00:29 -05:00
charles bloom
c2a859dc88 EditorBulkData add Insights scope around hashing, otherwise nop
[CL 31813567 by charles bloom in ue5-main branch]
2024-02-26 14:54:27 -05:00
danny couture
29d6982b6e [ZenLoader]
- Load the proper package instead of keeping the renamed one when we detect a reference that might be held by the deferred package delete queue.
  - This could happen when streaming out a level and then streaming it back in before the deferred queue had time to be processed.

#rnx
#rb Richard.Malo

[CL 31717563 by danny couture in ue5-main branch]
2024-02-22 07:53:33 -05:00
steve robb
f8d47335a4 Replaced RemoveAt(N, 1, EAllowShrinking::*) with RemoveAt(N, EAllowShrinking::*).
[CL 31626444 by steve robb in ue5-main branch]
2024-02-19 16:51:58 -05:00
kevin macaulayvacher
8a51319dfe DoesPackageExist AssetRegistry optimization: Re-enables optimization to avoid scanning on disk for corrected casing for FNames by changing the check to determine when the IoDispatcher is in use.
We expose the previously private, and unused HasScriptObjectsChunk method to the IODispatcher, as multiple codepaths are relying on this path to determine if the IoDispatcher is being used at runtime to load from chunks.

#jira UE-206417
#rb Per.Larsson
[FYI] Francis.Hurteau

[CL 31615213 by kevin macaulayvacher in ue5-main branch]
2024-02-19 12:40:05 -05:00
dan oconnor
e8a374fff2 Ignore properties that won't be serialized when determining whether we can discard a class's sparse data
#rb ben.zeigler, Jamie.Dale

[CL 31590148 by dan oconnor in ue5-main branch]
2024-02-16 19:25:07 -05:00
anton dunchev
a397241170 [TRACE] Added more information about trace scopes
- AsyncLoading gated by LoadTime channel activation
- GameFeaturePlugin statemachine name during transitions.
- Marked GC under region, because GC destroy objects over multiple frames
#rb jordan.cristiano
#tests PIE

[CL 31572130 by anton dunchev in ue5-main branch]
2024-02-16 13:21:45 -05:00
matt peters
65511c6a9b Fix crash when running game with legacy pakfiles (-skipiostore). FPakReadRequestBase and all subclasses of IAsyncReadRequest need a default implementation for the new EnsureCompletion function rather than a fatal error if called.
#rnx
#rb danny.couture

[CL 31567969 by matt peters in ue5-main branch]
2024-02-16 11:40:30 -05:00
bob tellez
46868f4018 [Backout] - CL31459147
[FYI] dan.oconnor
Original CL Desc
-----------------------------------------------------------------
Ignore properties that won't be serialized when determining whether we can discard a class's sparse data
#rb Jamie.Dale

[CL 31459846 by bob tellez in ue5-main branch]
2024-02-13 23:02:44 -05:00
dan oconnor
ceb7a9ca8c Ignore properties that won't be serialized when determining whether we can discard a class's sparse data
#rb Jamie.Dale

[CL 31459162 by dan oconnor in ue5-main branch]
2024-02-13 21:56:13 -05:00
danny couture
a298487c48 [ZenLoader]
- Always clear constructed objects even for failed packages

#jira UE-204898
#rb Francis.Hurteau

[CL 31213130 by danny couture in ue5-main branch]
2024-02-06 09:41:02 -05:00
danny couture
0b2bdda7be [ZenLoader]
- Apply patching to export table before preloading and postload when the linker export table is modified during reinstantiation.
  - Dispatch constructed objects to their respective package.
  - Properly handle and postload objects constructed during postload (i.e. reinstantiation).

#rb Francis.Hurteau

[CL 31210373 by danny couture in ue5-main branch]
2024-02-06 07:05:26 -05:00
richard malo
8903380246 Enabled FAsyncPackageDesc/FAsyncPackageDesc2 InstancingContext in cooked builds to allow using the provided InstancingContext when loading a package.
This is now required to properly support loading ExternalStreamingObjects for instanced partitioned worlds (used by the new External Data Layer feature).
The loaded instanced ExternalStreamingObject needs to have its softobjectpaths (namely the softobjectpath of its associated outer world) remapped using the provided instancing context.
#rb danny.couture, Francis.Hurteau, JeanFrancois.Dube
#tests Tested PIE and Cooked game

[CL 31180186 by richard malo in ue5-main branch]
2024-02-05 13:12:59 -05:00
per larsson
a71cafc0b6 BulkData - removed return value from issue batch
#rb Paul.Chipchase

[CL 31171929 by per larsson in ue5-main branch]
2024-02-05 09:24:10 -05:00
danny couture
ff4cff14b5 [ZenLoader]
- Fix infinite loop during flush when multiple interdependent packages are waiting on the package currently on stack

#jira UE-205051
#rb Francis.Hurteau

[CL 31170154 by danny couture in ue5-main branch]
2024-02-05 07:41:45 -05:00
dmytro vovk
2c523f4899 Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
Attempt no. 2
#rb Francis.Hurteau, Matt.Peters

[CL 31123996 by dmytro vovk in ue5-main branch]
2024-02-02 09:59:30 -05:00
sean boocock
5a5ab2b7cd [Backout] - 31084550 - Blocking launching FN editor
[FYI] dmytro.vovk
Original CL Desc
-----------------------------------------------------------------
Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
#rb Francis.Hurteau, Matt.Peters

[CL 31088717 by sean boocock in ue5-main branch]
2024-02-01 11:00:01 -05:00
dmytro vovk
08c3036b27 Fixed default initialization of TLS slots to 0 and invalidity check against 0 as 0 is a valid TLS slot index
#rb Francis.Hurteau, Matt.Peters

[CL 31084584 by dmytro vovk in ue5-main branch]
2024-02-01 08:33:08 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
danny couture
0f3f77eb9e [ZenLoader]
- Fix !bAllDone assert that could happen when a node timed out and was resumed during a recursive flush while still executing higher on the stack

#jira UE-203439
#rb kevin.macaulayvacher

[CL 30716086 by danny couture in ue5-main branch]
2024-01-19 10:29:21 -05:00