dan elksnitis
bf79ca67f6
[shaders] fix uninitialized oodle compression fields on FShaderCode struct
...
#preflight 642c42b9f376ab43d27bf471
#rb Jason.Nadro
[CL 24912313 by dan elksnitis in ue5-main branch]
2023-04-04 12:05:21 -04:00
Laura Hermanns
cbc4db6343
Minor improvements in shader backends.
...
#rb Dan.Elksnitis
#jira none
#preflight 642ad56dc6769c6082ade6cf
#rnx
[CL 24892320 by Laura Hermanns in ue5-main branch]
2023-04-03 10:17:45 -04:00
Charles deRousiers
2dd761fc54
Change Subsutrate sRGB encoding.
...
* Default now uses accurate sRGB value encoding.
* Lower platforms using lower shading quality (i.e., r.Substrate.ShadingQuality > 1), will continue to use the cheap sqrt/square encoding/decoding
Using proper sRGB encoding increases occupangy by 8 vgpr on ps4 and a fullscreen quad during the base pass by 0.2ms due to lower occupancy. So keep it disabled on lower platforms.
#rb none
#jira none
#preflight 642ad0058f078cc7031c1ae2
#fyi sebastien.hillaire
[CL 24891794 by Charles deRousiers in ue5-main branch]
2023-04-03 09:35:50 -04:00
Jens Petersam
ebabab6719
Electra: Copy-up from codec refactor task stream
...
#preflight 642a82f389339023eb61b540
#rnx
#fyi Thomas.Engel
[CL 24889800 by Jens Petersam in ue5-main branch]
2023-04-03 03:58:57 -04:00
dan elksnitis
3df31bd37f
[shaders] deprecate FShaderCompilerEnvironment::RemoteServerData field; since backend-specific remote compile functionality was removed (see https://p4-swarm.epicgames.net/changes/13777670 ) this is only used for adding unnecessary ifdef'd out debug info to associated shaders.
...
#rb Laura.Hermanns
#preflight 642735ab486e7cce7dd5b388
[CL 24877333 by dan elksnitis in ue5-main branch]
2023-03-31 15:51:46 -04:00
dan elksnitis
f2c9000b60
[shaders] deprecate GetDefinitions accessor on FShaderCompilerEnvironment; encapsulate internal usage of definitions object in friend classes and remove some superfluous code calling the function unnecessarily
...
#preflight 6425b46391589478cdab0c35
#rb Laura.Hermanns
#rb Sameer.Mirza
[CL 24870640 by dan elksnitis in ue5-main branch]
2023-03-31 09:55:19 -04:00
Wei Liu
8b27864471
Replace RHICommandListImmediate to RHICommandList to enable RDG pass parallelism on mobile platforms.
...
#jira none
#rb Dmitriy.Dyomin, Zach.Bethel
#preflight 6426924f50546ea336902499
[CL 24868436 by Wei Liu in ue5-main branch]
2023-03-31 04:12:33 -04:00
Wei Liu
01a415b564
Sampling SceneDepth instead of fetching SceneDepthAux when full depth prepass is enabled.
...
#jira none
#rb Dmitriy.Dyomin
#preflight 64267ed89621ba9cb48c0edf
[CL 24868190 by Wei Liu in ue5-main branch]
2023-03-31 03:12:41 -04:00
Guillaume Abadie
77df14a99e
Fixes ERHIAccess::CopyDest not being in DumpGPU's output resources
...
#rb trivial
#jira none
#preflight 6425f79c50546ea3365d02ce
[CL 24860823 by Guillaume Abadie in ue5-main branch]
2023-03-30 17:28:52 -04:00
dan elksnitis
49d7985a85
[shaders] Add "compile argument" functionality for generic parameters consumed by compile backends, along with helper to set both a compile arg AND define for cases which require both. The purpose of this is to move towards enforcing that preprocessor defines should _only_ be used during the preprocessing phase itself; the subset of defines that are currently used only as arguments to the compile backends (or used as both actual preprocessor defines and backend arguments) should use this mechanism instead. This allows us to explicitly identify and hash such parameters to be included in a stable key based primarily on a hash of preprocessed/deadstripped source; without it we would need to hash all defines which will defeat most of the deduplication benefit of doing this. A subsequent change will deprecate the GetDefinitions function on the shader compilation environment to enforce that defines cannot be read by anything outside of core shader system functionality.
...
#rb Massimo.Tristano
#rb Laura.Hermanns
#preflight 64258c2e5e52099fe3d03625
[CL 24854110 by dan elksnitis in ue5-main branch]
2023-03-30 10:47:09 -04:00
Sebastien Hillaire
88900c95e5
Compilation error fix for 24853509
...
#rb none
#preflight none
[CL 24853689 by Sebastien Hillaire in ue5-main branch]
2023-03-30 10:16:51 -04:00
Sebastien Hillaire
7e4d413b5f
Substrate - always precompile with DXC when substrate is enabled and if DXC is supported. No need for any ForceDXC cvar anymore.
...
#rb Laura.hermanns
#preflight https://horde.devtools.epicgames.com/job/64253dafe11ce5214fec8ddd
#fyi charles.derousiers
[CL 24853509 by Sebastien Hillaire in ue5-main branch]
2023-03-30 10:01:27 -04:00
Sebastien Hillaire
de532bf488
Substrate - GPULightmass support
...
#rb none
#preflight https://horde.devtools.epicgames.com/job/64241210e11ce5214f740ebd
#fyi charles.derousiers
[CL 24833842 by Sebastien Hillaire in ue5-main branch]
2023-03-29 07:24:23 -04:00
Sebastien Hillaire
1491943760
Substrata - ray tracing material shaders uses fully simplified material for smaller payload.
...
Next would be to have the fully simplified mode disable anisotropy to have an even lower payload size.
#rb charles.derousiers
#preflight https://horde.devtools.epicgames.com/job/6422ad44973e609670e855c8
[CL 24815921 by Sebastien Hillaire in ue5-main branch]
2023-03-28 05:25:01 -04:00
Wei Liu
298d3ebdbe
Fix GPUScene uploader size limit check.
...
#jira none
#rb Dmitriy.Dyomin
#preflight 64225cd9973e609670d68857
[CL 24814549 by Wei Liu in ue5-main branch]
2023-03-27 23:25:48 -04:00
Sebastien Hillaire
1e93e473f4
Substrate - updated / clarified ray tracing common payload byte count to really reflect what is shader dependent and what is Subsutrate dependent.
...
#rb none
#preflight none
#fyi charles.derousiers
[CL 24801328 by Sebastien Hillaire in ue5-main branch]
2023-03-27 08:31:19 -04:00
Sebastien Hillaire
e4d82b5a34
Substrate - fixed InternalGetBytePerPixel to be aligned on uint because the read/write unit is uint32.
...
#rb none
#preflight none
#fyi charles.derousiers
[CL 24801136 by Sebastien Hillaire in ue5-main branch]
2023-03-27 07:57:33 -04:00
PJ Kack
a629b19433
Remove obsolete temp code from 2016 to SuspendAsyncLoading when using FSuspendRenderingThread (a feature that in itself is only used on iOS).
...
#jira none
#rb per.larsson
#rnx
#preflight 642147bb7a393e211acad6c6
[CL 24800090 by PJ Kack in ue5-main branch]
2023-03-27 03:44:52 -04:00
Andriy Tylychko
c238b452c6
made FSharedShaderCodeRequest thread-safe because it's broadcasted concurrently
...
#rb francis.hurteau
#preflight 641da120b72410fc17834abe
[CL 24778527 by Andriy Tylychko in ue5-main branch]
2023-03-24 09:29:00 -04:00
Andriy Tylychko
7b5ca318e0
deprecated FCoreDelegates::OnPakFileMounted2 because it's thread-safe but is used concurrently. Added a thread-safe version FCoreDelegates::GetOnPakFileMounted2() and switched all use cases to the new one
...
#rb francis.hurteau
#preflight 641d99d214423a492d30c75a
[CL 24778298 by Andriy Tylychko in ue5-main branch]
2023-03-24 08:57:53 -04:00
joe pribele
8011e426ec
sorted shader assinfo to make out deterministic
...
makes diffing cooked data easier
#preflight 641b6002ee0aed1347d202e2
[CL 24753547 by joe pribele in ue5-main branch]
2023-03-22 16:21:53 -04:00
dan elksnitis
6324b4ab1c
[shaders] add a template helper to set a define only if not already set; eliminates a few usages of FShaderCompilerEnvironment::GetDefinitions in engine code
...
#preflight 6419e82732723d4a20abe8af
#rb Jason.Nadro
#rb Laura.Hermanns
[CL 24746765 by dan elksnitis in ue5-main branch]
2023-03-22 09:51:56 -04:00
Josie Yang
2f00d270c9
Define FName as static before passing to UE_TRACE_METADATA_SCOPE_ASSET_FNAME as FName lookup has performance impact.
...
Also rename AssetName to OwnerName to better describe what is stored.
#jira UE-167815
#rb Kenzo.Terelst
#preflight 641484d0691c5ebc159b2a5b
[CL 24714010 by Josie Yang in ue5-main branch]
2023-03-20 07:02:50 -04:00
graham wihlidal
0fb04c0a8f
Added CVar to RDG to control whether to enable expensive RDG validation in development builds (on by default).
...
#ushell-cherrypick of 24664569 by zach.bethel
#lockdown michal.valient
#rb graham.wihlidal, yuriy.odonnell
#preflight skip
[CL 24701530 by graham wihlidal in ue5-main branch]
2023-03-17 23:05:14 -04:00
Matt Peters
0027082473
RequestExit Feedback: Add Callsite argument to FPlatformMisc::RequestExit
...
Add the argument to many but not all callsites.
#jira FORT-578919
#rnx
#rb Devin.Doucette
#preflight 6414ca9d691c5ebc15b30410
[CL 24696053 by Matt Peters in ue5-main branch]
2023-03-17 16:46:34 -04:00