Commit Graph

46 Commits

Author SHA1 Message Date
Helge Mathee
d59fb33465 Control Rig variables aren't showing the correct values
The issue here is that we copy the source operand to target - where the source operand might actually be on a sub pin. We need to make sure to remove the registeroffset from the operand used for the debug register - since we only allow debug copies on the root of each register.

#rb jack.cai
#jira UE-102323

Merging

//UE4/Release-4.26/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

to //UE5/Main/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

[CL 14931406 by Helge Mathee in ue5-main branch]
2020-12-15 11:39:01 -04:00
Helge Mathee
057007d906 Control Rig variables aren't showing the correct values
The issue here is that we copy the source operand to target - where the source operand might actually be on a sub pin. We need to make sure to remove the registeroffset from the operand used for the debug register - since we only allow debug copies on the root of each register.

#rb jack.cai
#jira UE-102323

Merging

//UE4/Release-4.26/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

to //UE5/Main/Engine/Source/Developer/RigVMDeveloper/Private/RigVMCompiler/RigVMCompiler.cpp

[CL 14931362 by Helge Mathee in ue5-main branch]
2020-12-15 11:37:17 -04:00
Helge Mathee
44b6bf3d31 Control Rig Encapsulation - UI changes
#rb jack.cai
#jira UEA-564

[CL 14913071 by Helge Mathee in ue5-main branch]
2020-12-14 08:58:12 -04:00
Marc Audy
ada7c144fa Merge //UE5/Release-Engine-Staging @14903491 to //UE5/Main
[CL 14906022 by Marc Audy in ue5-main branch]
2020-12-11 14:21:20 -04:00
Helge Mathee
36706acaa9 Control Rig: Fix EditorStyle.h include
#jira UE-104179
#rb matt.kuhlenschmidt

[CL 14870839 by Helge Mathee in ue5-main branch]
2020-12-07 12:50:32 -04:00
Helge Mathee
a7dfe2f01d Control Rig: Fix missing include for non-unity build
#jira UE-10416
#rb na

[CL 14870314 by Helge Mathee in ue5-main branch]
2020-12-07 11:46:29 -04:00
Helge Mathee
e8e75d44ba Control Rig: Use the node path on the RigVMNode for the uniqueness of register paths
#jira UEA-564
#rb na

[CL 14869924 by Helge Mathee in ue5-main branch]
2020-12-07 11:12:11 -04:00
Helge Mathee
23eb17110e Control Rig: Refactor Blueprint Controller / Model accessor to getters
#jira UEA-564
#rb api refactoring, will audit

[CL 14869080 by Helge Mathee in ue5-main branch]
2020-12-07 07:55:48 -04:00
jack cai
5dfa6fc8d2 RigVM: Minor fixes for bugs found during nativization research
1. Select node's "IntEquals" operand should not be a literal since it stores the result of a runtime comparison
2. Register.CppType now renamed to Register.BaseCppType since it does not include TArray prefix for array type.
3. Added a few missed accessor/convertor functions for rig vm data types

#rb helge.mathee
#jira none

[CL 14855110 by jack cai in ue5-main branch]
2020-12-04 11:37:54 -04:00
Helge Mathee
7cca9cc7d7 Control Rig: Compiler to support node instruction markup for Collapse nodes
#jira UEA-564
#rb na

[CL 14853394 by Helge Mathee in ue5-main branch]
2020-12-04 05:57:00 -04:00
Helge Mathee
63e8d604fb Control Rig: Encapsulation - support for IO pins for expand operation
#jira UEA-564
#rb na

[CL 14853371 by Helge Mathee in ue5-main branch]
2020-12-04 05:44:17 -04:00
Helge Mathee
23c30bf79b Control Rig Encapsulation: Filtering for multi branch for collapse action
#jira UEA-564
#rb na

[CL 14853357 by Helge Mathee in ue5-main branch]
2020-12-04 05:36:01 -04:00
Helge Mathee
d9e96a80a4 Control Rig: Only allow event nodes in top level graph
#rb na
#jira UEA-564

[CL 14845042 by Helge Mathee in ue5-main branch]
2020-12-03 13:20:52 -04:00
Helge Mathee
4ee81886c7 Control Rig: Collapse + Expand working, milestone 2
#rb na
#jira UEA-564

[CL 14844270 by Helge Mathee in ue5-main branch]
2020-12-03 12:09:21 -04:00
Helge Mathee
5ebc320a11 Control Rig: Rename Struct Node to Unit Node
#rb halfdan.ingvarsson
#jira na

[CL 14835217 by Helge Mathee in ue5-main branch]
2020-12-02 10:59:58 -04:00
Helge Mathee
e1913158f9 RigVM: Literal consolidation optimization
#rb na
#jira na

[CL 14827747 by Helge Mathee in ue5-main branch]
2020-12-01 10:22:06 -04:00
Helge Mathee
327117c771 Control Rig: Encapsulation support, next steps
#jira UEA-564
#rb na

[CL 14826854 by Helge Mathee in ue5-main branch]
2020-12-01 04:05:50 -04:00
Helge Mathee
02f602e7bf Control Rig VM: Encapsulation, First steps
Implementation of relevant nodes for collapse feature, controller + actions as well as unit test

To be audited by Jack.Cai

#jira UEA-564
#rb na
#fyi jack.cai

[CL 14815556 by Helge Mathee in ue5-main branch]
2020-11-26 05:45:07 -04:00
Helge Mathee
fc71e04e36 Control Rig: RigVM Inline pass to fold reroutes with parent / child segment paths
#rb na
#jira na

[CL 14785695 by Helge Mathee in ue5-main branch]
2020-11-19 04:52:31 -04:00
jack cai
826293212d Control Rig & Engine Test: Added Unit Test for handling empty arrays in a struct. Added also the fix that prevents this test from crashing. The crash happened because we were skipping empty arrays completely when gettng the default value.
[CL 14785340 by jack cai in ue5-main branch]
2020-11-19 01:31:08 -04:00
Helge Mathee
fbb7b1e70c Control Rig: Perform reroute tracing as part of the inlining pass, clean up unit tests
#rb sara.schvartzman
#jira na

[CL 14771671 by Helge Mathee in ue5-main branch]
2020-11-18 07:48:31 -04:00
Helge Mathee
f4f3d546f9 RigVM: Allow editor only introspection on Register CPP Types and Objects.
#rb jack.cai
#jira na

[CL 14629525 by Helge Mathee in ue5-main branch]
2020-11-02 13:35:21 -04:00
Helge Mathee
9aa62f8a4d Control Rig: Clean up reroute nodes when making bindings from variable node
#rb na
#jira UE-101978

[CL 14597186 by Helge Mathee in ue5-main branch]
2020-10-28 03:33:52 -04:00
Helge Mathee
92ad9cb748 Control Rig: Fix making variable node out of variable binding with segmentpaths
#rb na
#jira na

[CL 14597146 by Helge Mathee in ue5-main branch]
2020-10-28 03:18:50 -04:00
Helge Mathee
21fc6402b0 Control Rig: Rename bUndo to bSetupUndoRedo
#rb na
#jira na
#fyi sara.schvartzman

[CL 14585117 by Helge Mathee in ue5-main branch]
2020-10-27 03:30:51 -04:00