Commit Graph

339 Commits

Author SHA1 Message Date
brandon schaefer
a505415750 Fix compiler error in non unity builds from missing header
#rb none

[CL 28377205 by brandon schaefer in ue5-main branch]
2023-10-02 10:25:53 -04:00
brandon schaefer
ef7b7b98ff Open around getting custom versions which call into a cache with a lock
#rb Neil.Henning

[CL 28376681 by brandon schaefer in ue5-main branch]
2023-10-02 10:10:07 -04:00
steve robb
a84e22104b Replaced GET_VARARGS* macros with GET_TYPED_VARARGS*.
#rb james.hopkin
#jira UE-194628

[CL 28346416 by steve robb in ue5-main branch]
2023-09-29 13:00:07 -04:00
louisphilippe seguin
6c633953d7 Fix convertion of UTF8 to TSAN so it creates null-terminated strings
#rb Devin.Doucette, Kirill.Zorin
#rnx

[CL 27669987 by louisphilippe seguin in ue5-main branch]
2023-09-07 08:34:09 -04:00
louisphilippe seguin
f3f623f537 Fix printf checkf warnings in CompactBinaryWriter due to UTF8 casts to Ansi char.
#rb Kirill.Zorin
#rnx

[CL 27529707 by louisphilippe seguin in ue5-main branch]
2023-08-31 14:00:35 -04:00
paul chipchase
111dc7cd37 Replace some references to UE4 with UE
#rb trivial
#rnx

[CL 27064222 by paul chipchase in ue5-main branch]
2023-08-14 02:34:15 -04:00
peter engstrom
b8d2989d09 Iris - Make sure incoming packet payloads are stored in buffers suitable for Iris bitstreams.
#rb louisphilippe.seguin, mattias.hornlund
#rnx

[CL 26955226 by peter engstrom in ue5-main branch]
2023-08-09 10:25:34 -04:00
dan engelbrecht
b7ecdcbf0b Add a global FCbObjectId SessionObjectId usable to coordinate session id's to zenserver.
Change GUID SessionId in FApp to base it on the SessionObjectId to make it easier to correlate session ids in zenserver

#rb stefan.boberg zousar.shaker

[CL 26841373 by dan engelbrecht in ue5-main branch]
2023-08-04 04:15:04 -04:00
sergio gardeazabal
eb87ac278e Fix for AddressSanitizer: stack-use-after-scope in FCustomVersionContainer::SetVersionUsingRegistry
#preflight 646e4124f85111e06caa45ec
#rb none
[FYI] steve.robb

[CL 25614963 by sergio gardeazabal in ue5-main branch]
2023-05-24 19:34:34 -04:00
sergio gardeazabal
6c50903854 Added an option on FArchive to early out while setting a custom version if that version was already set in the local custom versions container.
In projects with several custom versions, this results in a considerable improvement because the local container is usually smaller than the global one, and therefore the look-up time is faster, also we avoid going through the SetVersion path.

But this means if the version data in the version registry changed to the specific key you were trying to see, this means the local custom versions container of the archive will not be up-to-date. That is the reason this new option is disabled by default

#jira UE-184135
#rb steve.robb
#preflight 646ceaf12c0a5da0dc8b9c04

[CL 25594216 by sergio gardeazabal in ue5-main branch]
2023-05-23 19:05:46 -04:00
Steve Robb
c1216b9280 Replaced some operator TArray new usage - enough to make BlankProgram compile if operator new is deprecated.
#rb james.hopkin
#jira none
#preflight 6452372a0722d4f6a2d71e8e

[CL 25315828 by Steve Robb in ue5-main branch]
2023-05-03 07:02:43 -04:00
brian bekich
2884cabdb2 Removing deprecated network versions from archive to remove potential race condition with newer custom version
#preflight 645156bc634f5d9cd414e40b
#rb jon.fairchild

[CL 25309635 by brian bekich in ue5-main branch]
2023-05-02 18:25:03 -04:00
Steve Robb
a29e63300e Fixed mismatched copy constructor/assignment operator in FHashedName.
#rb none
#jira none
#preflight none

[CL 25124076 by Steve Robb in ue5-main branch]
2023-04-20 05:48:36 -04:00
Ryan Gerleve
9988faf667 Make FBitReader and FNetBitReader Src buffer parameter const.
#jira none
#preflight 6427555e861bf344ce58d994
#rb peter.engstrom

[CL 24892903 by Ryan Gerleve in ue5-main branch]
2023-04-03 10:53:04 -04:00
carlmagnus nordin
024df6d65c ZenCook: Added support for file regions
#preflight 64269c8491589478cdeb2a6f
#rb pj.kack
#rnx

[CL 24869761 by carlmagnus nordin in ue5-main branch]
2023-03-31 08:36:14 -04:00
devin doucette
3b17707bbf CompactBinary: Optimized FCbWriter by fixing an unintentional array shrink
#rb Zousar.Shaker
#rnx

[CL 24756381 by devin doucette in ue5-main branch]
2023-03-22 19:42:37 -04:00
Ryan Gerleve
2f6b307a95 Fix stack corruption in FArchive::SerializeIntPacked64.
#jira none
#rb brian.bekich
#preflight 6414b4c2691c5ebc15add0c1

[CL 24694376 by Ryan Gerleve in ue5-main branch]
2023-03-17 15:15:20 -04:00
Brian Bekich
c962e8f6fc FNetworkGUID now supports uint64 values
#jira UE-93777
#preflight 6411f2f5352bd6a889f950a5
#rb peter.engstrom

[CL 24689288 by Brian Bekich in ue5-main branch]
2023-03-17 10:41:53 -04:00
steve robb
f19a7e55ec Fixed potential invalid quote count in CSV parser.
Added overloaded constructors for FCsvParser which move/copy rather than (move/copy)+move.
Fixed a rather weird const_cast construct.

#rb robert.manuszewski
#preflight 63fcaa40ae54ee4ce90c021b

[CL 24422896 by steve robb in ue5-main branch]
2023-02-27 09:33:19 -05:00
henrik karlsson
c74a887e4b Header unit fixes
* Added ScriptDelegateFwd.h and put it in the right module (CoreUObject). before fwd declarations was in Core.
* Fixed problem with StructuredArchive forward declaring and used functions that was force inlined in another file. header units did not like this and caused linker errors (and I'm surprised it worked before)
* Various fixes related to how global variables are defined (static for global variables means that they are not visible outside header units)
* Various fixes related to how global functions are defined (static for global functions means that they are not visible outside header units)
* Move some method implementations to cpp file to work around header unit compile crashes (and they should probably be there firstplace)
* Removed *_API on some types to fix header unit linker errors
* Added WITH_EDITOR around code that only compiles in editor config (these headers were not included anywhere but HU can't know that)

#preflight 63f50161ac06ce789f9c34d2
#rb steve.robb

[CL 24348303 by henrik karlsson in ue5-main branch]
2023-02-21 15:24:28 -05:00
arciel rekman
a270c807f7 Harden reading/writing frozen memory images.
- Prevent maliciously crafted or damaged memory images from introducing memory stomps or otherwise disrupting loading.

#rb Josh.Adams, Jason.Nadro
[REVIEW] [at]Josh.Adams, [at]Jason.Nadro
#preflight 63efdfc03c1eb56f05d8da13

[CL 24295262 by arciel rekman in ue5-main branch]
2023-02-17 19:38:44 -05:00
henrik karlsson
c8c3d0b8b2 [Core]
* Made code compatible with modules/header units. This includes following things:
   * Removed static in front of global functions/variables (static indicates it is hidden outside of module/header unit which is not what many places want...)
   * Moved dllexport from type to methods in order to get dllexport of static constexpr fields. This is supposed to work according to microsoft but since it is a good change I don't mind doing it anyway)
   * static constexpr -> static constexpr inline for member variables and methods (this makes them available outside module/headerunit)
   * Added HEADER_UNIT_IGNORE markup to includes that are circular
   * Added HEADER_UNIT_SKIP to files that can't compile by themselves

#preflight 63e2aeba3c44c83044bfcc75
#rb steve.robb

[CL 24066986 by henrik karlsson in ue5-main branch]
2023-02-08 00:25:15 -05:00
devin doucette
8650614644 Logging: Fixed the static asserts about the format string to catch non-const format strings
#jira UE-175373
#preflight 63d444cef626715201a7f5b8
#preflight 63d444e85354589b5c0ff3df
#rb Zousar.Shaker

[CL 23919147 by devin doucette in ue5-main branch]
2023-01-30 19:21:20 -05:00
Brian Bekich
2cd4a1c575 Changed engine/game network version to be custom versions
Changed replay header version to be a custom version
Changed local file replay streamer version to be a custom version

#jira UE-149900
#preflight 639a40e12540a78d27a7c884

[CL 23836403 by Brian Bekich in ue5-main branch]
2023-01-24 15:04:19 -05:00
charles bloom
24bf4ddbcd change uses of SerializeCompressed to SerializeCompressedNew with Oodle
provide SerializeCompressedNew with default args for easier use

#preflight https://horde.devtools.epicgames.com/job/63c86c8f2a6acaf16239628d
#rb fabian.giesen

[CL 23766497 by charles bloom in ue5-main branch]
2023-01-18 17:48:24 -05:00