Commit Graph

33 Commits

Author SHA1 Message Date
daren cheng
e0e607f243 Migrate Alloca calls to outside of loop to fix static analysis warnings
#rb trivial
[FYI] Patrick.Boutot
#preflight 637525b6b6636838281c6322

[CL 23160734 by daren cheng in ue5-main branch]
2022-11-16 15:20:46 -05:00
daren cheng
4499f56eda Make PropertyPathHelpers call setters / getters.
Add support for generic structs to be passed to PropertyPathHelpers.
Fix PropertyPath Not working with TEnumAsByte types
Add TIsTEnumAsByte type trait.

#rb Patrick.Boutot Steve.Robb
[FYI] asil.karatas
#preflight 6373e45c953c19d435992ade

[CL 23148054 by daren cheng in ue5-main branch]
2022-11-15 19:45:22 -05:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
patrick boutot
b300814251 Fix bad memory access when the property type doesn't match the provided type and the path is fully resolved.
#jira UE-163727
#preflight 63288dac8c3def91aaa94d77
#rb daren.cheng, sebastian.nordgren

[CL 22097584 by patrick boutot in ue5-main branch]
2022-09-20 13:52:38 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
dave jones2
f8e134ef3c UE-148560 - Unable to bind Float variables to certain properties in Widget elements
Since BP floats default to double precision, we need to relax binding requirements. Most UMG widgets uses delegates that expect single-precision floats, so we need to allow float<->double conversion in the UFloatBinding layer. Without this change, we can't bind any new float variables in UMG, which makes the feature fairly useless.

The fix simply updates UFloatBinding::IsSupportedSource to allow double properties. Additionally, when we need to retrieve the underlying value, we need to inspect the property first. If it's a double, we'll perform a cast. Otherwise, it defaults to existing behavior.

#rb patrick.boutot
#preflight 6262f238cf17922036d8d169
#jira UE-148560

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 20380365 in //UE5/Release-5.0/... via CL 20383016
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20385730 by dave jones2 in ue5-main branch]
2022-05-26 17:11:05 -04:00
robert manuszewski
24c458d268 Fixed PropertyPathHelpers using the wrong version of ExportTextItem when exporting static array value
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19178048 via CL 19178282 via CL 19179079 via CL 19180228
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19203808 by robert manuszewski in ue5-main branch]
2022-03-01 14:41:14 -05:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
sebastian nordgren
6f1682e790 GetOptions now works correctly with multi-selection.
Added test actor to PropertyEditorTestObject.h to allow for testing actor things, like this GetOptions multiselection bug.

Fixed whitespace errors caused by mismerge.

#jira UE-109745
#rb paul.chipchase

[CL 15604138 by sebastian nordgren in ue5-main branch]
2021-03-04 09:02:09 -04:00
Yuriy ODonnell
6679906437 Fixed compile errors when static analyzer is enabled in Test configs.
Static analyzer always evaluates expressions in check(), despite DO_CHECK=0 due to implementation of check():

    #define check(expr) { CA_ASSUME(expr); }

If checked expression depends on something that's wrapped in `#if DO_CHECK`, it will produce a compile error. The fix is to add USING_CODE_ANALYSIS condition where applicable.

#robomerge Release-5.0-EarlyAccess
#rb Steve.Robb

[CL 15527660 by Yuriy ODonnell in ue5-main branch]
2021-02-25 08:57:17 -04:00
Zousar Shaker
3b4c8fc1c5 Automated wrapped object pointer upgrade for Engine + ShooterGame + ShooterGame referenced plugins
#rb none

[CL 15224650 by Zousar Shaker in ue5-main branch]
2021-01-27 17:40:25 -04:00
Christina TempelaarL
a9dd09fc9a Fixed blueprint nativization for SplineComponents/FInterpCurvePoints.
#jira UE-67542
#rb phillip.kavan

[CL 14713419 by Christina TempelaarL in ue5-main branch]
2020-11-10 17:16:52 -04:00
robert manuszewski
b7568cc694 Fix for UE-90683: You can no longer delete conflicting variables
Refactored FindField into FindUField and FindFProperty to avoid confusion caused by the fact that FindField<UField> will no longer return FProperties.

#jira UE-90683
#rb Steve.Robb
#tests Basic editor functionality test, cooked and ran PC client and server, bot soak tests for two hours

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 12190998 in //UE4/Release-4.25/... via CL 12190999
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v661-12148976)

[CL 12191300 by robert manuszewski in Main branch]
2020-03-15 10:33:45 -04:00
robert manuszewski
4e1ca4c60e FFieldPathSegments will now resolve and cache field pointers if their Struct has been serialized (for example when serializing CDOs)
#rb Bob.Tellez


#ROBOMERGE-SOURCE: CL 11309948 via CL 11309980 via CL 11309993
#ROBOMERGE-BOT: (v653-11302973)

[CL 11311368 by robert manuszewski in Main branch]
2020-02-10 16:04:40 -05:00
robert manuszewski
b938e59c9b Reimplementing FProperty changes from //UE4/Main
+ Reimplemented FProperty related fixed from //UE4/Main:
CL#10791312, 10804850, 10851666, 10855122, 10855198, 10942138, 11030611, 11030639, 11032261, 11061515, 11136964,11138881, 11214238, 11214865

#rb none (previously reviewed in Dev-Core)
[FYI] Chris.Bunnner, Daniel.Lamb


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 11302985 via CL 11303011 via CL 11303019
#ROBOMERGE-BOT: (v0-11244347)

[CL 11303183 by robert manuszewski in Main branch]
2020-02-10 08:06:56 -05:00
ryan durand
18322b071e Updating copyright for Engine Runtime.
#rnx
#rb none

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900 via CL 10870549
#ROBOMERGE-BOT: CORE (Main -> Dev-Core) (v626-10872990)

[CL 10897039 by ryan durand in Dev-Core branch]
2020-01-07 15:06:57 -05:00
ryan durand
0f0464a30e Updating copyright for Engine Runtime.
#rnx
#rb none


#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870549 by ryan durand in Main branch]
2019-12-26 14:45:42 -05:00
Matt Peters
cc4ee33fef Restore whitespace.
#rb trivial
#rnx

[CL 10791560 by Matt Peters in Dev-Core branch]
2019-12-18 08:45:13 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
Robert Manuszewski
18c689aed1 Converted UProperties to FProperties
#rb Steve.Robb (at least the most important files)

[CL 10596080 by Robert Manuszewski in Dev-Core branch]
2019-12-06 14:50:00 -05:00
nick darnell
6f03671c45 PropertyPathHelpers - Making several improvements to the property path evaluators. They can now evaluate multiple UFunctions in a chain, better support for some types like FName, and some utility ctors for handling singular segments.
#ROBOMERGE-OWNER: nick.darnell
#ROBOMERGE-AUTHOR: nick.darnell
#ROBOMERGE-SOURCE: CL 6626032 via CL 6626064 via CL 6626939
#ROBOMERGE-BOT: (vundefined-6620334)

[CL 6627092 by nick darnell in Main branch]
2019-05-24 01:08:40 -04:00
helge mathee
6dd5d14bde Re-enable temporarily deprecated property path constructor.
#jira UE-74819
[FYI] nick.darnell

Merging

//Tasks/Fortnite/Dev-UEA-ControlRig/Engine/Source/...

to //Fortnite/Main/Engine/Source/...


#ROBOMERGE-SOURCE: CL 6600780 via CL 6601960
#ROBOMERGE-BOT: (v351-6581450)

[CL 6602069 by helge mathee in Main branch]
2019-05-21 19:31:50 -04:00
helge mathee
d8ccb3d794 Control Rig MVC Refactoring
Merging

//Tasks/Fortnite/Dev-UEA-ControlRig/...

to //Fortnite/Main/...

[FYI] lina.halper


#ROBOMERGE-SOURCE: CL 6597997 via CL 6601432
#ROBOMERGE-BOT: (v351-6581450)

[CL 6601520 by helge mathee in Main branch]
2019-05-21 19:25:23 -04:00
Vincent Gauthier
c0fe68bf80 Fix to ensure on load. On load some binding may not be fully valid because of other depenmdant classes not being loaded yet. In those cases, we may end up with the SourcePath with property name set to Name_None.
#jira UE-73138
#rb helge.mathee

[CL 6180795 by Vincent Gauthier in Main branch]
2019-04-30 14:10:00 -04:00
helge mathee
c119558b25 Merging
//Tasks/Fortnite/Dev-UEA-ControlRig/...

to //Fortnite/Main/...

#code review lina.halper


#ROBOMERGE-SOURCE: CL 6083436 via CL 6088204

[CL 6088230 by helge mathee in Main branch]
2019-04-24 18:34:05 -04:00