Commit Graph

2738 Commits

Author SHA1 Message Date
steve robb
21e8d56a94 Improved comments on SerializeBin() and SerializeBinEx() to make it clear that binary serialization of deprecated properties can cause problems.
Made FProperty::ShouldSerializeValue() easier to debug for why a property is skipped.

#rb robert.manuszewski
#jira UE-170259
#preflight 6372e660b663683828915ccd

[CL 23153394 by steve robb in ue5-main branch]
2022-11-16 09:18:24 -05:00
andrew scheidecker
0d7f15c26f Enable the garbage collector to find UObjects that might be referenced by FDynamicallyTypedValueType.
#preflight 636e3faa953c19d4353c4c24
#rb Robert.Manuszewski

[CL 23134311 by andrew scheidecker in ue5-main branch]
2022-11-15 07:40:17 -05:00
joe pribele
1d8537f20b changed PRAGMA_DISABLE_OPTIMIZATION to UE_DISABLE_OPTIMIZATION_SHIP
#preflight 6372ba60ee4d25f90ae3d207

[CL 23128414 by joe pribele in ue5-main branch]
2022-11-14 17:31:05 -05:00
joe pribele
4e92aea636 fix for PrintScriptCallStack crashing when called from the immedieate window
changed `FWindowsPlatformMisc::IsLocalPrintThreadSafe` to return true if attached in the debugger this allows log calls to immediately print to the debug window

a follow up change is necessary to allow for attaching after the process has started
#preflight 63727f813248425305e8a6a1

[CL 23121763 by joe pribele in ue5-main branch]
2022-11-14 13:16:47 -05:00
bob tellez
9ca814bcd4 #UE Delete FArchiveObjectCrc32NonEditorProperties, and use a plain old FArchiveObjectCrc32 with ArIsFilterEditorOnly set to true to test for cook non-determinism. The logic in FArchiveObjectCrc32NonEditorProperties did not properly ignore FNames serialized in editor-only properties
[FYI] Steve.Robb

[CL 23103381 by bob tellez in ue5-main branch]
2022-11-11 14:56:19 -05:00
zhikang shao
1d9c60ec99 FFieldPath now respects CoreRedirects.
#jira UE-162160 #jira UE-142887 #rb ben.zeigler #rb benjamin.fox
FFieldPathProperty applies redirects on ImportText_Internal, automatically redirecting FFieldPath saved in string format for blueprint graph pins.
FGameplayAttribute applies redirects after deserializing unredirected value and fixes up derived properties, for UObject based assets with FGameplayAttribute properties.
UAttributeSet subclass renaming and adding ClassRedirect works now. Previously, FGameplayAttribute pins would show correct value in blueprint graphs but use incorrect value at runtime.
FGameplayAttribute renaming and adding PropertyRedirect works now. Previously, FGameplayAttribute fields in blueprint assets would break (null out), in addition to blueprint graphs using undirected value at runtime.
#preflight 636e638e8f4cb2e4dcf00c05

[CL 23098214 by zhikang shao in ue5-main branch]
2022-11-11 10:55:46 -05:00
bryan sefcik
45e50a215f Updated UObject::SaveConfig to not flush all the configs but instead only flush the updated config.
Before: 837ms
After: 46ms

#rb josh.adams
#jira
#preflight 63653a331052c15f131063bf

[CL 22998041 by bryan sefcik in ue5-main branch]
2022-11-04 19:05:59 -04:00
bryan sefcik
e0779d1a3b Added FindOrLoadLocalIniFile helper function that looks in the cache before trying to load the ini file.
CreateProfile:
Before: 2387.2ms
After: 9.68ms

LoadConfig:
Before: 2595ms
After: 541ms

U******RuntimeSettings::PostInitProperties:
Before: 27ms
After: 0.47ms

InitializeSerializationOptionsFromIni:
Before: 66ms
After: 0.86ms

#rb josh.adams
#jira
#preflight 63640d965c51adc95f9953e1

[CL 22977330 by bryan sefcik in ue5-main branch]
2022-11-03 23:46:54 -04:00
bob tellez
147734235e #UE Do not cook editor only soft object paths. Fix a regression that came from serializing soft object paths before processing the properties that reference them
[FYI] Francis.Hurteau

[CL 22968383 by bob tellez in ue5-main branch]
2022-11-03 17:59:51 -04:00
henrik karlsson
b985fbd1b1 Removed lots of includes in high traffic headers in order to reduce compile times. Headers are still included if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2 is set to 1
List of highlights
* PlayerController - Removed ForceFeedback and and OnlineReplStructs
* Class - Removed Package.h
* World - Pawn, Blueprint and GameInstance
* Actor - CoreNet, HitResult and ActorDatalayer
* EngineBaseTypes - TaskGraphInterface
* AssetManager - AssetData
* Scene/Child/ActorComponent - CoreNet
* AnimInstance - AttributesRuntime, Skeleton, AnimCurveTypes, AnimMontage, BonePose
* BulkData - IoDispatcher
* AssetData - IoDispatcher, LinkerLoad
* SecureHash - AsyncWork
* CanvasTypes - UnrealEngine, StaticMeshResources
* IpAddress - AsyncWork, Stats

#preflight 6363717ece676ae8688f5d8c
#rb none

[CL 22968258 by henrik karlsson in ue5-main branch]
2022-11-03 17:56:44 -04:00
joe pribele
50cfdde358 [CoreUObject] changed to check for null in TObjectPtr.GetPathName()
#preflight 63643317de2c4dbb5d47122c

[CL 22968073 by joe pribele in ue5-main branch]
2022-11-03 17:47:24 -04:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
scott nelson
8a674181f8 Add Ability to provide Default PackageFlags to each mount point during CreatePackage
#rb Francis.Hurteau
#preflight 6361809f1a32af63a89cb229

[CL 22918043 by scott nelson in ue5-main branch]
2022-11-02 11:48:28 -04:00
Helge Mathee
747879c204 Core: Array Text import not working for ()
#rb Steve.Robb
#jira UE-134101
#preflight https://horde.devtools.epicgames.com/job/63613e16ef6d25c674605ec6

[CL 22908318 by Helge Mathee in ue5-main branch]
2022-11-02 06:16:07 -04:00
henrik karlsson
8f895fef35 Added includes needed after removing includes in headers
#preflight 6360b63e41625be270a6e464
#rb none

[CL 22888775 by henrik karlsson in ue5-main branch]
2022-11-01 15:14:15 -04:00
henrik karlsson
48faa4b230 [CoreUObject]
* StructOnScope - Removed include of Package
* GeneratedCppInclude - Removed include of Package

Both of these files include Class.h which in turn include Package so no need to add backwards compatibility. Will add backwards compatibility in Class.h when Package.h is removed there (require a bit more work)

#preflight skipped
#rb none

[CL 22888526 by henrik karlsson in ue5-main branch]
2022-11-01 15:06:31 -04:00
andrew scheidecker
a8a6f870ca Add a few missing override specifiers and remove a vestigial method that no longer overrides anything.
#preflight 635fadcc3c0af539fdde0caa

[CL 22864389 by andrew scheidecker in ue5-main branch]
2022-10-31 11:43:34 -04:00
CarlMagnus Nordin
b48cb7ed39 AssetLoadingInsights:
Fixed recursive post loads not being tracked properly
Fixed time calculations for recursive scopes
Added support for load time tracing in the editor
Added time selection filtering to the requests tab
#rb ionut.matasaru
#preflight 635fa5cd1803be35c7ff3bc8

[CL 22858164 by CarlMagnus Nordin in ue5-main branch]
2022-10-31 07:09:17 -04:00
josh may
60aa5758b0 Ensure bCooked doesn't get mistakenly unset during reference collection in cooked versions of the editor.
#preflight 635c47003c0af539fd650f34
#rb jamie.dale, rex.hill

[CL 22850789 by josh may in ue5-main branch]
2022-10-29 03:00:34 -04:00
francis hurteau
2419ef2300 Cap the number of reference gathering when printing invalid references during save since they can be pathologically expensive
#rb Matt.Peters
#preflight 635c3504052cb0bae6b189fd

[CL 22850501 by francis hurteau in ue5-main branch]
2022-10-29 01:53:18 -04:00
anton dunchev
90787f42bc Print script warning caller name.
Printing full stack trace could quickly bloat log, but we can print only top level caller actor to narrow down what BP is responsible for the warning.
Main use case is to catch BP which causes Script Msg: Divide by zero: Divide_VectorFloat and other UKismetMathLibrary errors.

#rb andrew.ladenberger, Steve.Robb
#tests replay run

[CL 22823605 by anton dunchev in ue5-main branch]
2022-10-28 00:34:39 -04:00
jeanfrancois dube
e122ebd425 Backout CL22638298 since it's fixed by CL22654868
[FYI] vincent.beauchemin
Original CL Desc
-----------------------------------------------------------------
Move warning to Log on : Short type name \"%s\" provided for TryFindType. Please convert it to a path name since we would need to resaved all previous Level Instance and map done by Quixel forAncient Game project.

#rb jeanfrancois.dube
#jira UE-163818
#preflight n/a

[CL 22660508 by jeanfrancois dube in ue5-main branch]
2022-10-20 12:52:50 -04:00
vincent beauchemin
7810a4c208 Move warning to Log on : Short type name \"%s\" provided for TryFindType. Please convert it to a path name since we would need to resaved all previous Level Instance and map done by Quixel forAncient Game project.
#rb jeanfrancois.dube
#jira UE-163818
#preflight n/a

[CL 22649023 by vincent beauchemin in ue5-main branch]
2022-10-19 22:38:48 -04:00
phillip kavan
d3b60e4fa7 Don't return an in-memory instance as the import object inside a WITH_EDITOR context if it's still pending a deferred load finalization.
#jira UE-166957
#rb Francis.Hurteau, Ben.Zeigler
#preflight 634f3c3c864d9be2365513a8

[CL 22649021 by phillip kavan in ue5-main branch]
2022-10-19 22:38:43 -04:00
bob tellez
df9555fafc #UE Disable relocation for now
[FYI] Francis.Hurteau

[CL 22647524 by bob tellez in ue5-main branch]
2022-10-19 22:01:53 -04:00