Commit Graph

19 Commits

Author SHA1 Message Date
henrik karlsson
2b3ad519a5 Fixed compile error surfaced when orphaned headers got compiled (they were never included in their own module so compiler warning settings was never applied)
Changes include
* Removed #pragma once in cpp files
* Removed dll export on templated types
* Fixed code in headers that didn't compile (probably never included anywhere
* Added casting for code going from int to float. Header was never compiled in the owning module that had warnings as errors

#preflight 637b10c6fa348e848054bd0d
#rb none (devin.doucette for a couple files)

[CL 23218414 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:34 -05:00
devin doucette
5a15aba0e3 Converted the TStringView test to a Low Level Test
#preflight 63642ac7d308b70e66173182
#rb Zousar.Shaker
#rnx

[CL 22988797 by devin doucette in ue5-main branch]
2022-11-04 12:12:57 -04:00
elias lozadabenavent
b4e72ed6c6 Updated TPagedArray:
* Added Append/Assign std::initializer_list overloads.
* Implemented std::initializer_list assignment operator overload in term of Assign.
* Fixed Append debug assertion: it now properly uses Reserve instead of Grow: added a comment to Grow as this method expects the container capacity to be smaller than the value requested.
* Added unit tests for both Append and Emplace that force the container to Grow.

#tests passed PagedArray unit test in Debug and Test: verified no assertions are triggered.

#preflight 6315db24ab25bb91f5dc10d3

#rb steve.robb

[CL 21801519 by elias lozadabenavent in ue5-main branch]
2022-09-05 15:34:01 -04:00
elias lozadabenavent
8299e664ea * Added TPagedArray: a fixed-block chained array container similar to TChunkedArray. The main difference with TChunkedArray is that TPagedArray doesn't default construct its page elements, they are allocated and constructed as requested.
* Added System::Core::Containers::TPagedArray unit tests (26) to LowLevelUnitTests.
* Added debug visualizer.

#review-Number 21718397
#rb steve.robb, andriy.tylychko

#tests passed TPagedArray unit tests.
#preflight 6311ba48fb6213403c49a39c

[CL 21759819 by elias lozadabenavent in ue5-main branch]
2022-09-02 11:17:49 -04:00
bryan sefcik
de407b208f Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

#ushell-cherrypick of 20991367 by bryan.sefcik
#jira

#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21120076 via CL 21120084 via CL 21120291
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142586 by bryan sefcik in ue5-main branch]
2022-07-17 22:49:51 -04:00
bryan sefcik
5774b4842a Added more IWYU pragmas.
#preflight 62c860d0b04c766648963c4f

[CL 21009868 by bryan sefcik in ue5-main branch]
2022-07-08 13:11:06 -04:00
bryan sefcik
a9cc65bca4 Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

[CL 20991367 by bryan sefcik in ue5-main branch]
2022-07-07 16:02:19 -04:00
bryan sefcik
9905eb52bb Pass 2 on running IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.
#preflight 62c703bbd13fac04f11da948

[CL 20985655 by bryan sefcik in ue5-main branch]
2022-07-07 12:30:11 -04:00
bryan sefcik
62489fe2b3 Ran a pass of IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.

#rb Devin Doucette and Marc Audy
#preflight 62c62086756222ced497ff95
#preflight 62c626d12f2d04691814d331
#preflight 62c630107e606620fdd64e31
#preflight 62c635c6756222ced49a13cf

[CL 20979027 by bryan sefcik in ue5-main branch]
2022-07-06 21:44:18 -04:00
Marc Audy
888fdc3aaa Fix warning V501: There are identical sub-expressions to the left and to the right of the '==' operator: Deque.Max() == Deque.Max()
#codereview chris.constantinescu
#rnx
#preflight

[CL 20618477 by Marc Audy in ue5-main branch]
2022-06-11 22:40:16 -04:00
chris constantinescu
79078dc749 Low level tests adapter that can translate Catch2-defined test to a Functional Test
#preflight 629f74c6233ae0a8f8fb1f97
#rb Devin.Doucette

[CL 20540119 by chris constantinescu in ue5-main branch]
2022-06-07 12:37:53 -04:00
chris constantinescu
28111d40fc Redundancy cleanup in UBT Low Level Tests:
- test-specific targets and modules are constructed by RulesAssembly which removes a lot of spaghetti code
- no more excluding the Tests folder by default which is guaranteed to mislead users #fyi Jon.Nabozny
- test compilation in Tests is controlled through WITH_LOW_LEVEL_TESTS
- preparation code for switching tests between Catch2 / TestAutomation Fmwk

Nightly LLT PF 6260431391376845adeb4c40

#rnx
#preflight 62602d50dd47b4ad2173c30b

[CL 19834665 by chris constantinescu in ue5-main branch]
2022-04-20 14:24:59 -04:00
chris constantinescu
e12e6c083e Un-smoke tests that were not previously filtered as Smoke by the AutomationTest framework.
#rb Devin.Doucette
#preflight skip

[CL 19668231 by chris constantinescu in ue5-main branch]
2022-04-07 09:55:58 -04:00
Devin Doucette
07adff9b17 LowLevelTests: Reverted the Core tests that were moved in 19498448 and 19571202
#preflight 62471e0e73665f7d5e634d2d
#rb Chris.Constantinescu, Mark.Lintott
#rnx

[CL 19589944 by Devin Doucette in ue5-main branch]
2022-04-01 12:14:09 -04:00
chris constantinescu
cdcaefe035 Introducing Catch2 disabled test cases, scenarios etc
Motivation: [.] only hides a test and it can still be executed using ~[SomeOtherTag]; It's very easy to fall into the trap of executing an infinite loop test that is decorated with the [.] tag
#rb Andriy.Tylychko, Michael.Balzer
#preflight 6245fb64f4217035fa8f38ec

[CL 19576763 by chris constantinescu in ue5-main branch]
2022-03-31 15:16:31 -04:00
mark lintott
bc9b168688 Add new Unit Tests
#rb Chris.Constantinescu
#preflight 62458f77292f228e09013681

[CL 19571202 by mark lintott in ue5-main branch]
2022-03-31 07:45:37 -04:00
chris constantinescu
ae281656f2 Tests converted from 18848115 made to work multi-platform.
Not all were converted because they were designed for packaged applications whereas low level tests are designed to run as "native" non-packaged applications.
- reporting support for non-desktop platforms, for the moment Catch2 report type "console" is used that is sent to a .out file
- most number of tests possible running multi platform, slower tests excluded on incremental builds
- slow tests are moved to run on the monolithic build
- Catch2 report failure event listener such that Horde detects them as build errors. Must add new Horde matcher for Catch2 failures

#rb Mark.Lintott
#preflight 623c8de389625f0612dabd64

[CL 19498448 by chris constantinescu in ue5-main branch]
2022-03-24 13:28:25 -04:00
mark lintott
dff14a25c8 Updated Low Level Tests
Removed existing SampleTest
Added an example Catch 2 Test for Math Colors into Core Module
Coverted Cbor tests to Catch2
Moved TDeque and TToken tests into Core Module
#fyi chris.constantinescu
#jira none
#preflight 61f9589e8b4112f7cc9a83c8
#preflight 61f95dbbfa6554dff3d52f21
#preflight 61f987b74404d5fadefa98d2

[CL 18812960 by mark lintott in ue5-main branch]
2022-02-01 14:39:50 -05:00
chris constantinescu
9212fef5a7 LLT 2.0 on preflights
- bIncludeAllTests flag on target will compile with all tests: used on LowLevelTests target to run on preflights
- Preflights now running low level tests by default, only those from LowLevelTests and its dependencies stemming from Core and Projects
#preflight 61f930bb8b4112f7cc95e807
#rb Mark.Lintott

[CL 18807604 by chris constantinescu in ue5-main branch]
2022-02-01 09:04:25 -05:00