Commit Graph

48 Commits

Author SHA1 Message Date
henrik karlsson
2b3ad519a5 Fixed compile error surfaced when orphaned headers got compiled (they were never included in their own module so compiler warning settings was never applied)
Changes include
* Removed #pragma once in cpp files
* Removed dll export on templated types
* Fixed code in headers that didn't compile (probably never included anywhere
* Added casting for code going from int to float. Header was never compiled in the owning module that had warnings as errors

#preflight 637b10c6fa348e848054bd0d
#rb none (devin.doucette for a couple files)

[CL 23218414 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:34 -05:00
devin doucette
5a15aba0e3 Converted the TStringView test to a Low Level Test
#preflight 63642ac7d308b70e66173182
#rb Zousar.Shaker
#rnx

[CL 22988797 by devin doucette in ue5-main branch]
2022-11-04 12:12:57 -04:00
michael atchison
a9d34d24ef Add base64URL encoding support.
[REVIEW] [at]andrew.calleja, [at]eric.day, [at]sam.zamani
#preflight 63607fdae271e75dea5d9e39

[CL 22921014 by michael atchison in ue5-main branch]
2022-11-02 13:42:30 -04:00
joe pribele
9397804938 [Core] fix for automation reporting false failures for tests that purposely cause ensure or check failures
#preflight 635c1d0b1b41d36d486bd767

[CL 22835280 by joe pribele in ue5-main branch]
2022-10-28 15:15:39 -04:00
joe pribele
983242d871 [Core] temporarily disabled test
#preflight 634de43b8c653695a77c2368

[CL 22587452 by joe pribele in ue5-main branch]
2022-10-17 19:39:09 -04:00
joe pribele
1366bc3f93 [Core] added support to lowlevel tests validating that ensure and check are executed
added  a tls for an ensure handler callback to let the reporting log of ensures to be overridden

the following macros are supported in lowlevel tests
REQUIRE_ENSURE
CHECK_ENSURE
REQUIRE_CHECK

#rb devin.doucette
#preflight 634827c457048bdb82b43ffe

[CL 22505260 by joe pribele in ue5-main branch]
2022-10-13 11:24:15 -04:00
Devin Doucette
4bea045328 CompactBinary: Fixed LoadCompactBinary to gracefully handle read failures and sizes larger than the archive
#preflight 63200c6be93a80888c231104
#rb Zousar.Shaker

[CL 21983905 by Devin Doucette in ue5-main branch]
2022-09-13 11:45:18 -04:00
Devin Doucette
cb9ac76ce8 CompactBinary: Migrated package tests to LowLevelTests
#preflight 6318053af448dc6e584b212f
#rb Zousar.Shaker
#rnx

[CL 21850779 by Devin Doucette in ue5-main branch]
2022-09-07 10:37:40 -04:00
elias lozadabenavent
b4e72ed6c6 Updated TPagedArray:
* Added Append/Assign std::initializer_list overloads.
* Implemented std::initializer_list assignment operator overload in term of Assign.
* Fixed Append debug assertion: it now properly uses Reserve instead of Grow: added a comment to Grow as this method expects the container capacity to be smaller than the value requested.
* Added unit tests for both Append and Emplace that force the container to Grow.

#tests passed PagedArray unit test in Debug and Test: verified no assertions are triggered.

#preflight 6315db24ab25bb91f5dc10d3

#rb steve.robb

[CL 21801519 by elias lozadabenavent in ue5-main branch]
2022-09-05 15:34:01 -04:00
elias lozadabenavent
8299e664ea * Added TPagedArray: a fixed-block chained array container similar to TChunkedArray. The main difference with TChunkedArray is that TPagedArray doesn't default construct its page elements, they are allocated and constructed as requested.
* Added System::Core::Containers::TPagedArray unit tests (26) to LowLevelUnitTests.
* Added debug visualizer.

#review-Number 21718397
#rb steve.robb, andriy.tylychko

#tests passed TPagedArray unit tests.
#preflight 6311ba48fb6213403c49a39c

[CL 21759819 by elias lozadabenavent in ue5-main branch]
2022-09-02 11:17:49 -04:00
Devin Doucette
a192a75638 MemoryView: Fixed CopyFrom to avoid calling Memcpy with a null pointer or size of 0
Migrated the tests to LowLevelTests at the same time.

#preflight 630eda34556fc14dce850a26
#rb Tim.Smith
#rnx

[CL 21721976 by Devin Doucette in ue5-main branch]
2022-08-31 11:49:33 -04:00
chris constantinescu
0d0ad8e4c8 Remove faulty global GBlockLocalPrint, cleanup unused VS config
All platforms preflight 62f67851b66d5d9313f240b6
#rb Devin.Doucette
#preflight 62f67866bd746abb99c0be54

[CL 21362093 by chris constantinescu in ue5-main branch]
2022-08-12 15:45:37 -04:00
chris constantinescu
1bfe2da3f2 Use platform-dependent LocalPrint and make sure output is redirected to stdout when running LowLevelTests so that local and build machine test runs print debug and fault information directly to stdout.
AssertionMacrosTest is printing out failed asserts using LocalPrint which is undesirable - implemented GBlockLocalOutput as a way to supress LocalPrint output.
Other fixes included:
- ability to select a low level test build based on any configuration, not just Development: useful for Debug builds
- New "printoutput" LLT Gauntlet parameter used for certain platforms to control output redirect to stdout
#rb David.Harvey
#preflight 62f405a05a6f2fec99b64f21

[CL 21334255 by chris constantinescu in ue5-main branch]
2022-08-11 07:31:45 -04:00
joe pribele
ad173b3ee2 [Core] only run ensure tests if ensure is enabled
#rb zousar.shaker
#preflight 62f3f015bc175ec68c477d8a

[CL 21322486 by joe pribele in ue5-main branch]
2022-08-10 14:10:45 -04:00
joe pribele
cc9d66f494 [Core] change to disable breaking in the debugger when running the "ensure" tests
#rb zousar.shaker
#preflight 62f29ac6086f90bbc4ab9de2

[CL 21293430 by joe pribele in ue5-main branch]
2022-08-09 13:50:40 -04:00
bryan sefcik
de407b208f Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

#ushell-cherrypick of 20991367 by bryan.sefcik
#jira

#ROBOMERGE-OWNER: bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21120076 via CL 21120084 via CL 21120291
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142586 by bryan sefcik in ue5-main branch]
2022-07-17 22:49:51 -04:00
chris constantinescu
d17f975071 LLT Catch2-style macros: REQUIRE_(NO)ENSURE and CHECK_(NO)ENSURE
Based on existing Catch2 macros and reusing FDebug number of ensures counter.
#rb Scott.Lindeneau
#preflight skip

[CL 21115661 by chris constantinescu in ue5-main branch]
2022-07-15 15:23:10 -04:00
bryan sefcik
5774b4842a Added more IWYU pragmas.
#preflight 62c860d0b04c766648963c4f

[CL 21009868 by bryan sefcik in ue5-main branch]
2022-07-08 13:11:06 -04:00
bryan sefcik
a9cc65bca4 Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

[CL 20991367 by bryan sefcik in ue5-main branch]
2022-07-07 16:02:19 -04:00
bryan sefcik
9905eb52bb Pass 2 on running IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.
#preflight 62c703bbd13fac04f11da948

[CL 20985655 by bryan sefcik in ue5-main branch]
2022-07-07 12:30:11 -04:00
bryan sefcik
62489fe2b3 Ran a pass of IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.

#rb Devin Doucette and Marc Audy
#preflight 62c62086756222ced497ff95
#preflight 62c626d12f2d04691814d331
#preflight 62c630107e606620fdd64e31
#preflight 62c635c6756222ced49a13cf

[CL 20979027 by bryan sefcik in ue5-main branch]
2022-07-06 21:44:18 -04:00
christopher waters
f147864ef0 Adding String/RemoveFrom.h
#jira none
#rb devin.doucette
#preflight 62c49a5a2f2d046918927fab

[CL 20948877 by christopher waters in ue5-main branch]
2022-07-05 16:22:50 -04:00
Marc Audy
888fdc3aaa Fix warning V501: There are identical sub-expressions to the left and to the right of the '==' operator: Deque.Max() == Deque.Max()
#codereview chris.constantinescu
#rnx
#preflight

[CL 20618477 by Marc Audy in ue5-main branch]
2022-06-11 22:40:16 -04:00
chris constantinescu
79078dc749 Low level tests adapter that can translate Catch2-defined test to a Functional Test
#preflight 629f74c6233ae0a8f8fb1f97
#rb Devin.Doucette

[CL 20540119 by chris constantinescu in ue5-main branch]
2022-06-07 12:37:53 -04:00
Devin Doucette
938e209187 CompositeBuffer: Added EqualBytes to compare the contents of two composite buffers
#preflight 62869550286cf1867a059f88
#rb Zousar.Shaker

[CL 20287260 by Devin Doucette in ue5-main branch]
2022-05-19 16:45:47 -04:00