Commit Graph

7180 Commits

Author SHA1 Message Date
marco anastasi
5bb33d09a8 Automatic checkout and automatic undo on failed checkout
* Add an undo buffer barrier when the skein async checkout operation begins
* Add a delegate handler for skein checkout operation completion
* Make sure auto checkout is only active in UEFN and/or if skein is enabled
* Add UI control for turning on and off Auto-checkout/Auto-undo in Source control settings


#rb stuart.hill, brooke.hubert, zach.rammell
[FYI] wouter.burgers, manuel.lang

#preflight 637b5227f514e1ded97739a4

[CL 23220340 by marco anastasi in ue5-main branch]
2022-11-21 09:32:40 -05:00
henrik karlsson
2b3ad519a5 Fixed compile error surfaced when orphaned headers got compiled (they were never included in their own module so compiler warning settings was never applied)
Changes include
* Removed #pragma once in cpp files
* Removed dll export on templated types
* Fixed code in headers that didn't compile (probably never included anywhere
* Added casting for code going from int to float. Header was never compiled in the owning module that had warnings as errors

#preflight 637b10c6fa348e848054bd0d
#rb none (devin.doucette for a couple files)

[CL 23218414 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:34 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
Joe Kirchoff
afe8737c64 Suppress warnings in Windows SDK headers that weren't wrapped with THIRD_PARTY_INCLUDES_START
#rnx
#rb trivial
#preflight 63780330170bc34a938304d7

[CL 23208584 by Joe Kirchoff in ue5-main branch]
2022-11-18 18:09:50 -05:00
Arne Schober
97b3c17391 Fix memory leak in DepletableQueue as the last node was never deleted and make an accidental concurrent call to Deplete not catastrophic.
Adding a ConsumeAllQueue which is based on a Stack because the Queues have livelock issues and the Stack provides a robust alternative.
#preflight 6377afdb170bc34a936594cc

[CL 23196259 by Arne Schober in ue5-main branch]
2022-11-18 11:35:54 -05:00
carlmagnus nordin
3d76ce80b5 IoDispatcher: Fixed shutdown crash
#preflight 63774398f514e1ded9982c1b
#rb pj.kack

[CL 23192024 by carlmagnus nordin in ue5-main branch]
2022-11-18 05:46:42 -05:00
Jurre deBaare
38e431f722 //UE5/Release-5.1 - Build ContentExamples Win64 - Warning: PoseAsset is out-of-date with its source animation
- Use SmartName display name rather than UID when generating data model GUID
   - Defer PoseAsset out-of-date warning until next resave
#jira UE-163780
#rb Thomas.Sarkanen
#preflight 6377575533774509005eacd6

[CL 23191972 by Jurre deBaare in ue5-main branch]
2022-11-18 05:35:10 -05:00
Jamie Dale
dfa485e6c8 Split the FText comparison API out of FText so that it can be used for FString
FTextComparison now exists to provide static access to the collated comparison functions of FText, without needing to actually create an FText to do the comparison.

This follows the pattern of things like FTextTransformer and FTextChronoFormatter.

#jira
#preflight 6374fd521d25fe8b932dac1d
#rb Leon.Huang

[CL 23164251 by Jamie Dale in ue5-main branch]
2022-11-16 17:37:18 -05:00
steve robb
1f445a2f7a Applied the same SupportsFreezeMemoryImage changes to TArray as to the other containers as in CL# 23153171.
#rb devin.doucette
#jira UE-170263
#preflight 6374edf3ee4d25f90a92d45f

[CL 23154837 by steve robb in ue5-main branch]
2022-11-16 11:14:41 -05:00
steve robb
2723aedc4a Moved all container-level instances of SupportsFreezeMemoryImage out of the class definition so that they can't require the full type definition.
Unified all container freezing function definitions to not use a helper class - neater and removes some PDB symbols.

#rb devin.doucette
#jira UE-170263
#preflight 6374311a32484253055217ef

[CL 23154078 by steve robb in ue5-main branch]
2022-11-16 10:21:23 -05:00
Helge Mathee
ea718104dd RigVMN: lazy compute - core side
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6374ab540c74adb48bd8bf96

[CL 23151939 by Helge Mathee in ue5-main branch]
2022-11-16 05:05:12 -05:00
florin pascu
76d38017d7 Added ECVF_ExcludeFromPreview to exclude ECVF_Scalability Cvars from the preview
#rb Josh.Adams, Jack.Porter
#jira UE-170009
#preflight 63749013953c19d435dc0d1b

[CL 23151913 by florin pascu in ue5-main branch]
2022-11-16 05:02:20 -05:00
daren cheng
4499f56eda Make PropertyPathHelpers call setters / getters.
Add support for generic structs to be passed to PropertyPathHelpers.
Fix PropertyPath Not working with TEnumAsByte types
Add TIsTEnumAsByte type trait.

#rb Patrick.Boutot Steve.Robb
[FYI] asil.karatas
#preflight 6373e45c953c19d435992ade

[CL 23148054 by daren cheng in ue5-main branch]
2022-11-15 19:45:22 -05:00
joe pribele
bc8fcc7f23 deprecating PRAGMA_DISABLE_OPTIMIZATION and PRAGMA_ENABLE_OPTIMIZATION replaced with
`UE_DISABLE_OPTIMIZATION` for temporary development and `UE_ENABLE_OPTIMIZATION_SHIP` to submit

`UE_DISABLE_OPTIMIZATION` will be an error on the farm in a future changelist
#p4v-preflight-copy 23129238
#preflight 6373dd34ee4d25f90a45aea4

[CL 23139676 by joe pribele in ue5-main branch]
2022-11-15 13:54:44 -05:00
Rafa Lecina
df001c1d21 Support enable ARC in modules
#jira UE-107891
#review @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams  @Jack.Porter
#preflight

[CL 23133821 by Rafa Lecina in ue5-main branch]
2022-11-15 06:02:36 -05:00
henrik karlsson
56e354a63e [Core]
* Fixed so all headers that are supposed to be included independently can compile (there are headers that must be included through other headers)

* Added HEADER_UNIT_SKIP to headers that must be included through others

* Added HEADER_UNIT_UNSUPPORTED to headers that are not supported by platform but is part of the include list anyway (files in Clang folder and pthread files).

* Added HEADER_UNIT_UNSUPPORTED to headers that have bad dependencies and include files from modules they don't depend on. (KeyChainUtilities.h and PackageWriter.h)

#preflight 637281309e3bea8079feb733
#rb devin.doucette

[CL 23127795 by henrik karlsson in ue5-main branch]
2022-11-14 17:08:04 -05:00
joe pribele
242962a719 added new macro UE_DISABLE_OPTIMIZATION_SHIP to replace PRAGMA_DISABLE_OPTIMIZATION
will deprecate `PRAGMA_DISABLE_OPTIMIZATION `in a following changelist after converting code to use `UE_DISABLE_OPTIMIZATION_SHIP`

added `UE_CHECK_DISABLE_OPTIMIZATION` to check for
`UE_DISABLE_OPTIMIZATION` being left in by accident

will enable `UE_CHECK_DISABLE_OPTIMIZATION` in a following changelist
#preflight 6372b159953c19d43537b088

[CL 23126725 by joe pribele in ue5-main branch]
2022-11-14 16:37:00 -05:00
joe pribele
4e92aea636 fix for PrintScriptCallStack crashing when called from the immedieate window
changed `FWindowsPlatformMisc::IsLocalPrintThreadSafe` to return true if attached in the debugger this allows log calls to immediately print to the debug window

a follow up change is necessary to allow for attaching after the process has started
#preflight 63727f813248425305e8a6a1

[CL 23121763 by joe pribele in ue5-main branch]
2022-11-14 13:16:47 -05:00
Catalin Dragoiu
2c65745543 Add options to the Insights Status Bar Widget
#rb Ionut.Matasaru
#jira UE-161773
#preflight 636e5b00ee4d25f90af1325a

[CL 23097615 by Catalin Dragoiu in ue5-main branch]
2022-11-11 09:46:20 -05:00
tiago costa
3512c8c0eb Support remainder operator in IntVector.
#rb Andrew.Davidson
#preflight 636e38dcbf76990b713835ab

[CL 23096095 by tiago costa in ue5-main branch]
2022-11-11 07:18:18 -05:00
brandon schaefer
68c446a297 Add support for an Allow Syscall filter file to be passed into the Engine (supports x64 and arm64)
This will cause any syscall *not* in the allow list to cause SIGSYS and then we will exit from our signal handler (unless our signal handler uses a syscall that is not supported in which case we will crash, though a core dump will need to be checked)

Requires explicitly calling this function where you want to actually *setup* the filters:
FPlatformMisc::SetupSyscallFilters();

To use:
-allowsyscallfilterfile=<path/to/allow_filter_file.txt>

Example of file:
read
write
open
mprotect 2 4 0 1

There are only two supported rules for the file:
<syscall_name>
<syscall_name> <syscall_arg_number_zero_based_index> <value> <allow> <check bit only>

#jira UE-169652
#rb Josh.Adams, Robert.Seiver, Calvin.Zheng
#preflight 636d44e81c14fe450503f5cf

[CL 23091532 by brandon schaefer in ue5-main branch]
2022-11-10 20:45:09 -05:00
edwin maynard
c4d4d16da4 [Backout] - CL23087318
[FYI] edwin.maynard
Original CL Desc
-----------------------------------------------------------------
Setting NetCL for 23.00

[FYI] stan.hormell

[CL 23091022 by edwin maynard in ue5-main branch]
2022-11-10 19:57:58 -05:00
edwin maynard
e6aa9476bc Setting NetCL for 23.00
[FYI] stan.hormell

[CL 23091017 by edwin maynard in ue5-main branch]
2022-11-10 19:57:53 -05:00
Matt Peters
40185c7e66 WindowsPlatformMemory: Change the behavior of FGenericPlatformMemoryStats::GetMemoryPressureStatus on Windows; it now uses QueryMemoryResourceNotification instead of the generic implementation.
Cooker: In MPCook Collect garbage based on the Operating System's MemoryPressure event, so that Standby memory does not cause spurious garbage collection.
In all cook modes, tweak the output during garbage collection to have less duplicate information.
In all cook modes, add a cooldown for GC when garbage collection is not impactful.
#rn Minor, Core
#rb Zousar.Shaker, Danny.Couture
#preflight 636d69761c14fe4505163289

[CL 23088442 by Matt Peters in ue5-main branch]
2022-11-10 17:17:20 -05:00
henrik karlsson
b6e84d16d3 [Core]
* Attempt at fixing static analysis errors in Tuple

#rb none
#jira none
#preflight skipped

[CL 23071760 by henrik karlsson in ue5-main branch]
2022-11-10 01:03:25 -05:00