Commit Graph

11383 Commits

Author SHA1 Message Date
semion piskarev
0f26fc0f2b Fix GetModularFeatureImplementation asserting despite promising that it wouldn't in the header comment.
#rb David.Doucette
#jira none
#preflight 6377f7fefa348e8480df698b

[CL 23222151 by semion piskarev in ue5-main branch]
2022-11-21 11:37:20 -05:00
marco anastasi
5bb33d09a8 Automatic checkout and automatic undo on failed checkout
* Add an undo buffer barrier when the skein async checkout operation begins
* Add a delegate handler for skein checkout operation completion
* Make sure auto checkout is only active in UEFN and/or if skein is enabled
* Add UI control for turning on and off Auto-checkout/Auto-undo in Source control settings


#rb stuart.hill, brooke.hubert, zach.rammell
[FYI] wouter.burgers, manuel.lang

#preflight 637b5227f514e1ded97739a4

[CL 23220340 by marco anastasi in ue5-main branch]
2022-11-21 09:32:40 -05:00
Steve Robb
54a578a7cd Replaced some != loop boundary tests with < to workaround false positives in MSVC's static analyser.
#rb trivial
#jira UE-170580
#preflight none
#fyi joe.kirchoff

[CL 23219395 by Steve Robb in ue5-main branch]
2022-11-21 07:25:31 -05:00
henrik karlsson
2b3ad519a5 Fixed compile error surfaced when orphaned headers got compiled (they were never included in their own module so compiler warning settings was never applied)
Changes include
* Removed #pragma once in cpp files
* Removed dll export on templated types
* Fixed code in headers that didn't compile (probably never included anywhere
* Added casting for code going from int to float. Header was never compiled in the owning module that had warnings as errors

#preflight 637b10c6fa348e848054bd0d
#rb none (devin.doucette for a couple files)

[CL 23218414 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:34 -05:00
henrik karlsson
b5164ac775 Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
Change consist of only forward declaration and additional includes

#preflight 63789c1de30d438849c48188
#rb none

[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
Joe Kirchoff
afe8737c64 Suppress warnings in Windows SDK headers that weren't wrapped with THIRD_PARTY_INCLUDES_START
#rnx
#rb trivial
#preflight 63780330170bc34a938304d7

[CL 23208584 by Joe Kirchoff in ue5-main branch]
2022-11-18 18:09:50 -05:00
Dan Thompson
fa34918d88 Update the texture build to route new information out:
1. Whether the source mips detects alpha
2. Several hashes to track the state of data at various stages of the build process.

Move the r.SharedLinearTextureEncoding out of the ConsoleManager as that's The Old Way.
Rename TextureDerivedDataVersion for uniqueness.
#rb devin.doucette
#rb charles.bloom
#preflight 6377fca7815e4b9b75681765

[CL 23206768 by Dan Thompson in ue5-main branch]
2022-11-18 17:09:58 -05:00
Arne Schober
97b3c17391 Fix memory leak in DepletableQueue as the last node was never deleted and make an accidental concurrent call to Deplete not catastrophic.
Adding a ConsumeAllQueue which is based on a Stack because the Queues have livelock issues and the Stack provides a robust alternative.
#preflight 6377afdb170bc34a936594cc

[CL 23196259 by Arne Schober in ue5-main branch]
2022-11-18 11:35:54 -05:00
carlmagnus nordin
3d76ce80b5 IoDispatcher: Fixed shutdown crash
#preflight 63774398f514e1ded9982c1b
#rb pj.kack

[CL 23192024 by carlmagnus nordin in ue5-main branch]
2022-11-18 05:46:42 -05:00
Jurre deBaare
38e431f722 //UE5/Release-5.1 - Build ContentExamples Win64 - Warning: PoseAsset is out-of-date with its source animation
- Use SmartName display name rather than UID when generating data model GUID
   - Defer PoseAsset out-of-date warning until next resave
#jira UE-163780
#rb Thomas.Sarkanen
#preflight 6377575533774509005eacd6

[CL 23191972 by Jurre deBaare in ue5-main branch]
2022-11-18 05:35:10 -05:00
sebastien lussier
c163be6d28 LayoutUV - Fix support for LayoutVersion < ELightmapUVVersion::ScaleByEdgesLength
Bumped DDC key to fix wrong cached data that could have been stored before this fix
#rb jeanfrancois.dube, yujiang.wang

[CL 23191080 by sebastien lussier in ue5-main branch]
2022-11-18 03:13:36 -05:00
Devin Doucette
3d43db2d10 Fixed a crash on exit when init fails early
If PreInit fails before setting the command line, AppExit will fail in its last step because it attempts to access the command line.

#preflight 63755f97232e3d12cb57a744
#rb Joe.Pribele

[CL 23184789 by Devin Doucette in ue5-main branch]
2022-11-17 17:09:36 -05:00
Stu McKenna
11b83585ef - Sanitize asin / acos inputs to avoid NaNs
#rb patrick.kelly
#jira UE-170199
#preflight 637671c9aa7d7f87a699e8b0

[CL 23179974 by Stu McKenna in ue5-main branch]
2022-11-17 13:47:46 -05:00
carlmagnus nordin
f815a8a92f IoDispatcher: Fixed crash when requesting reads of 0 bytes
#preflight 6375edf0953c19d43557cb97
#rb per.larsson

[CL 23174498 by carlmagnus nordin in ue5-main branch]
2022-11-17 07:44:38 -05:00
bryan sefcik
d608130583 Tweaked unity sizes.
#jira
[FYI] joe.kirchoff
#preflight 63757482b6636838283838da

[CL 23172508 by bryan sefcik in ue5-main branch]
2022-11-17 00:29:06 -05:00
Jamie Dale
dfa485e6c8 Split the FText comparison API out of FText so that it can be used for FString
FTextComparison now exists to provide static access to the collated comparison functions of FText, without needing to actually create an FText to do the comparison.

This follows the pattern of things like FTextTransformer and FTextChronoFormatter.

#jira
#preflight 6374fd521d25fe8b932dac1d
#rb Leon.Huang

[CL 23164251 by Jamie Dale in ue5-main branch]
2022-11-16 17:37:18 -05:00
steve robb
1f445a2f7a Applied the same SupportsFreezeMemoryImage changes to TArray as to the other containers as in CL# 23153171.
#rb devin.doucette
#jira UE-170263
#preflight 6374edf3ee4d25f90a92d45f

[CL 23154837 by steve robb in ue5-main branch]
2022-11-16 11:14:41 -05:00
steve robb
2723aedc4a Moved all container-level instances of SupportsFreezeMemoryImage out of the class definition so that they can't require the full type definition.
Unified all container freezing function definitions to not use a helper class - neater and removes some PDB symbols.

#rb devin.doucette
#jira UE-170263
#preflight 6374311a32484253055217ef

[CL 23154078 by steve robb in ue5-main branch]
2022-11-16 10:21:23 -05:00
David Harvey
1cab40981d Clang warning fixes
#jira UE-163945
#rnx
#rb Nuno.Leiria
#preflight 6374b4491c114bec05f01873

[CL 23151994 by David Harvey in ue5-main branch]
2022-11-16 05:12:39 -05:00
Helge Mathee
ea718104dd RigVMN: lazy compute - core side
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6374ab540c74adb48bd8bf96

[CL 23151939 by Helge Mathee in ue5-main branch]
2022-11-16 05:05:12 -05:00
florin pascu
76d38017d7 Added ECVF_ExcludeFromPreview to exclude ECVF_Scalability Cvars from the preview
#rb Josh.Adams, Jack.Porter
#jira UE-170009
#preflight 63749013953c19d435dc0d1b

[CL 23151913 by florin pascu in ue5-main branch]
2022-11-16 05:02:20 -05:00
daren cheng
4499f56eda Make PropertyPathHelpers call setters / getters.
Add support for generic structs to be passed to PropertyPathHelpers.
Fix PropertyPath Not working with TEnumAsByte types
Add TIsTEnumAsByte type trait.

#rb Patrick.Boutot Steve.Robb
[FYI] asil.karatas
#preflight 6373e45c953c19d435992ade

[CL 23148054 by daren cheng in ue5-main branch]
2022-11-15 19:45:22 -05:00
joe pribele
bc8fcc7f23 deprecating PRAGMA_DISABLE_OPTIMIZATION and PRAGMA_ENABLE_OPTIMIZATION replaced with
`UE_DISABLE_OPTIMIZATION` for temporary development and `UE_ENABLE_OPTIMIZATION_SHIP` to submit

`UE_DISABLE_OPTIMIZATION` will be an error on the farm in a future changelist
#p4v-preflight-copy 23129238
#preflight 6373dd34ee4d25f90a45aea4

[CL 23139676 by joe pribele in ue5-main branch]
2022-11-15 13:54:44 -05:00
carlmagnus nordin
72c3c99cf1 IoStoreReader: Fixed incorrect data being returned when reading partial chunks
#preflight 63735d0ab663683828ae8c34
#rb per.larsson

[CL 23133948 by carlmagnus nordin in ue5-main branch]
2022-11-15 06:20:34 -05:00
Rafa Lecina
df001c1d21 Support enable ARC in modules
#jira UE-107891
#review @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams  @Jack.Porter
#preflight

[CL 23133821 by Rafa Lecina in ue5-main branch]
2022-11-15 06:02:36 -05:00