Commit Graph

72 Commits

Author SHA1 Message Date
henrik karlsson
4a36cfe8ff Moved operator== to be hidden friend instead of put directly in global namespace
Moved GetTypeHash function to be hidden friend instead of put directly in global namespace.

Note that the function/operator needs to be fully inlined in the type or placed in the cpp. If the function is added as friend but then implemented outside the type then hidden friend optimization won't work.

This should improve compile time somewhat according to msvc devs.

#rb Steve.Robb
#preflight 6360b7052b5338aceb26471b

[CL 22889837 by henrik karlsson in ue5-main branch]
2022-11-01 15:50:27 -04:00
phil popp
ebbf23d3fe Fix crash from malformed printf
#rnx
#rb trivial

[CL 22475281 by phil popp in ue5-main branch]
2022-10-12 02:36:19 -04:00
alfaroh corneyiii
ad525b20a0 Fix Audio Modulation Parameter Mismatch UI Bug
#jira UE-126644
#preflight 6340aee2437603cb0e4f14d8
#rb rob.gay
#lockdown aurel.cordonnier

[CL 22414481 by alfaroh corneyiii in ue5-main branch]
2022-10-07 21:33:37 -04:00
bryan sefcik
1e8df43bc3 Moved AUDIO_SPATIALIZATION_PLUGIN_LLM_SCOPE from AudioDevice.h to IAudioExtensionPlugin.h to improve compile times because AudioDevice.h is expensive to include.
#rb jimmy.smith
#preflight 633ce6911451b83c2a5ede8e

[CL 22346864 by bryan sefcik in ue5-main branch]
2022-10-04 22:35:22 -04:00
igor dallavanzi
f41b2ac7a3 [WaveformTransformations] Add Configuration handling to UWaveformTransformationBase for parameter range checks ecc
#preflight 633470b0b84cbb36d5f6da74
fix for #jira UE-163720

[CL 22260584 by igor dallavanzi in ue5-main branch]
2022-09-29 20:26:06 -04:00
rob gay
08f64dc10a [MetaSounds] Param loop virtualization fixes
- Split default param transmitter to SoundCueTransmitter & ParameterTransmitterBase to avoid generating transmitters for SoundBase child classes that don't support/require one (ex. SoundWaves)
- Move param transmitter to sharedptrs to avoid a bunch of unnecessary copy/clone logic when virtualizing loops
- Remove DefaultParameters field on ActiveSound in favor of shared impl in FParameterTransmitterBase that caches current state of parameters
- Fix for move that clears out active sound's current parameters when sound could have multiple wave instances that need said parameters
#rb phil.popp
#jira UE-164898
#preflight 6334a0a1ee7b13756dcd20ea

[CL 22240385 by rob gay in ue5-main branch]
2022-09-28 22:19:31 -04:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
rob gay
3f94473cc9 ModulationDestinations Upgrade
- Support sets of input modulators
- Support union of modulation heirarchy
#rb alfaroh.corney
#jira UE-163157
#preflight 63191cc3ec45fbf3d708437c

[CL 21892756 by rob gay in ue5-main branch]
2022-09-08 09:18:28 -04:00
phil popp
09335f9aab Add OnAllSourcesProcessed to source data override plugin
#rb Max.Hayes
#jira UE-159924
#preflight 6311114b674863ca8328fa9e

[CL 21747234 by phil popp in ue5-main branch]
2022-09-01 16:33:03 -04:00
phil popp
5fc6f172c9 [MetaSound] Allow Constructor pin to be set from BP
#rb Rob.Gay
#jira UE-153913
#preflight 62fe6e68f7404b55a3fd49f9

[CL 21445924 by phil popp in ue5-main branch]
2022-08-18 13:55:13 -04:00
igor dallavanzi
1d8028f625 Add first and last edited sample indexes to FWaveformTransformationWaveInfo #preflight 62fb5c49cf7afa018b8e6f3e
[CL 21402577 by igor dallavanzi in ue5-main branch]
2022-08-16 05:27:07 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
helen yang
f1dcf29025 Minor MetaSound UX fixes
- Only apply input widget editor setting to new inputs
- Change default input widget to knob
- Don't show input widgets on read only graphs
- Tooltip clarification for setting audio component default parameters on MetaSounds

#jira UE-156767
#jira UE-157740
#jira UE-157782
#jira UE-157782
#rb rob.gay
#preflight 62b9de585d29d0d10ac0e071

[CL 20861733 by helen yang in ue5-main branch]
2022-06-28 13:42:14 -04:00
seth weedin
a3a299e5eb Add data to spat params to allow using the AttenuationDistance (which may differ from distance to listener)
- Work done specifically for SourceEffectSimpleDelay to use it for "DelaySpeedBasedOnDistance" calculations

Impact: Prevents pitch warble when moving the camera around quickly for projects that use an attenuation override

#rb Aaron.McLeran, Ryan.Mangin

#ROBOMERGE-AUTHOR: seth.weedin
#ROBOMERGE-SOURCE: CL 20130485 via CL 20130494 via CL 20130515 via CL 20130536
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20132808 by seth weedin in ue5-main branch]
2022-05-10 21:06:28 -04:00
helen yang
df3edbd5b0 Fix some audio parameters not being added when merging
#jira UE-149891
#rb ryan.mangin
#preflight 62683c85dd35c0d6cab8c7b5

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 19928064 in //UE5/Release-5.0/... via CL 19929280
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19931471 by helen yang in ue5-main branch]
2022-04-26 19:04:28 -04:00
miles flanagan
8c332293cc adding IWaveformTransformation interface to AudioExtentions, and adding WaveformTransformations module to WaveformEditor.
#rb phil.popp, igor.dallavanzi
#jira UE-150314, 150315
#preflight 62683b59430b9997ebe7f00d

[CL 19926462 by miles flanagan in ue5-main branch]
2022-04-26 15:15:19 -04:00
Rob Gay
c30b4fb2ce - Fix for merge code not updating existing parameters properly for SoundCues.
- Fix for instanced variables not caching when any parameterized sound type (Cue or MetaSound) is replayed
#jira UE-148618
#rb ryan.mangin
#fyi sondra.moyls
#fyi randolph.kestner
#fyi seth.weedin
#preflight 625d9b2db21bb49791c1696f
#preflight 625d9b2db21bb49791c1696f

[CL 19789682 by Rob Gay in ue5-main branch]
2022-04-18 13:32:29 -04:00
Maxwell Hayes
4d967c3450 Added missing ModularFeatureList lock/unlock
#jira UE-146734
#rb Aaron.McLeran, Phil.Popp
#preflight 623a53eb88538cd45eef0f33

[CL 19473764 by Maxwell Hayes in ue5-main branch]
2022-03-22 19:14:21 -04:00
rob gay
9ed959dac8 Downgrade seek ensure to log
- Add more logging around failures in ADPCM decode
- Remove superfluous logs
#rb jimmy.smith
#rnx
#jira UE-145250
#preflight 6230cac1cf609c54b1e5ae8e
#p4v-cherrypick 19390151

[CL 19394411 by rob gay in ue5-main branch]
2022-03-15 16:40:51 -04:00
rob gay
1f287a42ac Parameter Update Perf Regression Fix-ups
- Use cached transmissable inputs when initializing/sanitizing parameters
- Update internal API to promote batching & keeping AudioParameters sorted/using faster merge logic where possible
- Swap CitySample vehicle controller to use batched parameter update call
- Clarify When RuntimeData is cached for safety (in InitResources or InitParameters, whichever comes first)
- Alleviate extreme confusion around AudioParameter setters requiring type by adding static conversion functions
#rb helen.yang
#rnx
#jira UE-145211
#preflight 6229424e6e026fc824b24861

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19328764 in //UE5/Release-5.0/... via CL 19329587
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348372 by rob gay in ue5-main branch]
2022-03-10 22:07:08 -05:00
rob gay
9b977d30c6 - Fix upcast copy causing parameters to not be cached properly on proxy by removing unnecessary virtual function
- Fix return value improperly assigning value in MixModulatorNode, causing it always to be 0 or 1 based on if the modulator was registered (as return is if the value was found and assigned, and its a boolean cast when the modulator is found)
- Remove unused parameter proxy ModHandle member
- Don't re-register if parameter already registered
- Remove duplicate validation call
#rb helen.yang
#rnx
#jira UE-144721
#preflight 6221645ca00412627d1bfde2

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19259386 in //UE5/Release-5.0/... via CL 19260159
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263839 by rob gay in ue5-main branch]
2022-03-04 04:11:49 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
jimmy smith
929ebcd8d7 Fix spamming of Triggers by adding new Track type
#jira UE-138615
#rb rob.gay Ludovic.Chabant
#preflight 6216753437178b0175b2317f


#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19095469 via CL 19096552 via CL 19097708 via CL 19098551 via CL 19105431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147043 by jimmy smith in ue5-main branch]
2022-02-25 09:59:46 -05:00
aaron mcleran
e79529af7a Fixing one-shot interface issues
#rb Rob.Gay
#jira UE-139680
#preflight 620d3d228a1ea1600981931f


#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19093707 via CL 19095893 via CL 19096208 via CL 19097039 via CL 19105391
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146717 by aaron mcleran in ue5-main branch]
2022-02-25 09:45:49 -05:00