Commit Graph

635 Commits

Author SHA1 Message Date
danny couture
624b970cdb Add more info to the log when the createwindow function fails and remove unlocalized messagebox that was highly likely to fail to show a window anyway
#rnx
#jira UE-168160
#rb Martin.Sevigny
#preflight 6374e8e1232e3d12cb2a5c25

[CL 23153330 by danny couture in ue5-main branch]
2022-11-16 09:09:41 -05:00
Rafa Lecina
0eb72998ee Add missing release for a property
#jira UE-169916
#review-23134713 @Sam.Zamani, @Bertrand.Carre, @Chris.varnsverry
#preflight

[CL 23135028 by Rafa Lecina in ue5-main branch]
2022-11-15 08:58:17 -05:00
Rafa Lecina
fa8f4245ea Add missing dealloc instance method found by static analysis
#jira UE-169916
#review @Sam.Zamani, @Bertrand.Carre, @Chris.Varnsverry
#preflight

[CL 23133521 by Rafa Lecina in ue5-main branch]
2022-11-15 04:43:10 -05:00
joe pribele
1d8537f20b changed PRAGMA_DISABLE_OPTIMIZATION to UE_DISABLE_OPTIMIZATION_SHIP
#preflight 6372ba60ee4d25f90ae3d207

[CL 23128414 by joe pribele in ue5-main branch]
2022-11-14 17:31:05 -05:00
henrik karlsson
b985fbd1b1 Removed lots of includes in high traffic headers in order to reduce compile times. Headers are still included if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2 is set to 1
List of highlights
* PlayerController - Removed ForceFeedback and and OnlineReplStructs
* Class - Removed Package.h
* World - Pawn, Blueprint and GameInstance
* Actor - CoreNet, HitResult and ActorDatalayer
* EngineBaseTypes - TaskGraphInterface
* AssetManager - AssetData
* Scene/Child/ActorComponent - CoreNet
* AnimInstance - AttributesRuntime, Skeleton, AnimCurveTypes, AnimMontage, BonePose
* BulkData - IoDispatcher
* AssetData - IoDispatcher, LinkerLoad
* SecureHash - AsyncWork
* CanvasTypes - UnrealEngine, StaticMeshResources
* IpAddress - AsyncWork, Stats

#preflight 6363717ece676ae8688f5d8c
#rb none

[CL 22968258 by henrik karlsson in ue5-main branch]
2022-11-03 17:56:44 -04:00
ben hoffman
ed98ecade2 Update the platform input device mapper to expose the Allocate User and Device functions as public, allowing for platforms to allocate new input device ID's and platform user's if they want, making for a little bit easier to use API.
When setting the input device connection state, only call the delegate that there was a connection state change if the state is actually different than the existing one.

#rb david.harvey
#rnx
#preflight 634dd24f9c29024c9853f17e

[CL 22619965 by ben hoffman in ue5-main branch]
2022-10-19 03:06:16 -04:00
pj kack
7a12aa6728 TSet & TMap: Make sure any dynamic hash allocation is released when Empty() is called without additional slack.
Memory improvements on top of performance improvements in 11535961.
Allow the hash allocation to shrink for calls to Empty(), Shrink(), Compact() and CompactStable().
Let TSparseArray::Compact() shrink the data array just as for Shrink() and CompactStable().
Note: The private function TSet::ShouldRehash() is only called from Empty() and ConditionalRehash(), and ConditionalRehash() with bAllowShrinking=true is only called from Relax() via Shrink(), so there should be no impact on other/growth scenarios.
Modify GetAllocatedSize() for TSet, TMap and TSparseArray to only return any dynamically allocated size from the underlying allocators and change return type from uint32 to SIZE_T (just as for TArray and FContainerAllocatorInterface).

#rb johan.torp,steve.robb
#preflight 634952f4ce524ed356dafde7, 63496f80f622f6c4bb1c0321, 634d65df9c29024c982ecf26

[CL 22595144 by pj kack in ue5-main branch]
2022-10-18 04:03:13 -04:00
satoshi-iwaki
1958213835 Fix iOS delegate method name typo for remote notification registration failure. Github PR #8541
#jira UE-132541
#rnx
#rb trivial
#preflight none for iOS notifications

[CL 22582670 by satoshi-iwaki in ue5-main branch]
2022-10-17 18:22:14 -04:00
mathieu dunlay
1896e2a23b Adding a remap type on android 12 and up.
[CL 22536080 by mathieu dunlay in ue5-main branch]
2022-10-14 17:50:33 -04:00
ben hoffman
201d92a399 Depreacte the old IForceFeedbackSystem from 2015 because it is just an empty subclass of IInputInterface. It has a comment for "This class is deprecated in favor of IInputInputface", but none of the references were ever replaced.
#rb david.garza
#rb Nate.Strohmyer
#preflight 6348687357048bdb82c7a77a

[CL 22535172 by ben hoffman in ue5-main branch]
2022-10-14 17:23:47 -04:00
adam kinge
7323541906 Fixes incorrect screen launch rotation due to invalid mask value before IOSView is initialized.
#jira UE-167012
[REVIEW] [at]jack.porter
#preflight 63477b75fa31324bb179aa27
#rnx
#lockdown jack.porter

[CL 22505584 by adam kinge in ue5-main branch]
2022-10-13 11:42:15 -04:00
Rafa Lecina
773a0b6c5d Simplify iOS in app purchases code and fix some small issues
- Replaced delegates to communicate from StoreKit to C++ by an internal Objective-C proxy type that sequences requests/notifications on the proper thread
  - StoreKit calls are made on main thread. There is no documentation about thread safety on SKPaymentQueue API so I did not want to take risks. All notifications to the observer are already made on the main thread
  - C++ plugin code is expected to be run on game thread
  - SKRequests delegate methods are received in a worker thread so they need to be sequenced to the game thread
- Reduced the amount of notification functions between C++ and Objective-C layers
- Remove receipts for finalized purchases
- Removed per user cached transactions because iOS/StoreKit is single user. It was confusing and was already lead to some bugs
- Product quantity was ignored (it is possible to buy several items of the same type in one purchase)
- Hidden some private types
- Added C++ RAII wrapper for Objective-C instances to automatically handle manual retain/release

Tested using StoreKit testing in Xcode: https://developer.apple.com/documentation/xcode/setting-up-storekit-testing-in-xcode
Was able to test consumable, non consumable, interrupted and deferred transactions

#jira UE-163490
#review @Bertrand.Carre, @Axel.Riffard, @Jack.Porter, @Adam.Kinge, @Roman.Dzieciol, @Josh.Markewicz
#preflight 6335cd81a852bd922cf47e33

[CL 22266047 by Rafa Lecina in ue5-main branch]
2022-09-30 03:31:14 -04:00
patrick laflamme
aae0e9dd6a Fixed CIS non-unity ShaderCompileWorker errors reported in WindowsPlatformSplash.cpp.
#jira none
#rb trivial
#preflight trivial

[CL 22145756 by patrick laflamme in ue5-main branch]
2022-09-22 17:35:23 -04:00
patrick laflamme
9fc1447777 Fixed deadlock in the splash screen happening when the main thread goes faster than the splash screen and try to hide the splash before the splash screen thread even created the window.
#jira UE-161578 - Game stuck on splash screen
#rb Vincent.Gauthier
#preflight 632b651a7b582f58abe53440

[CL 22140481 by patrick laflamme in ue5-main branch]
2022-09-22 14:07:38 -04:00
Josh Adams
35f58f3dd4 - Fixed up various threading and menu initialization issues with Programs on Mac
- Moved boilerplate program startup code into a shared Obj-C class, MacProgramDelegate
#rb zack.neyland
#fyi brandon.schaefer,robert.seiver
#preflight 632b45dba4769ad71456b18b

[CL 22116672 by Josh Adams in ue5-main branch]
2022-09-21 13:20:37 -04:00
rex hill
737c7c6832 Fix DebugConsole.ini so it is placed in /Engine/Saved/Config instead of /Engine/Config
#preflight skip

[CL 22067866 by rex hill in ue5-main branch]
2022-09-17 15:27:55 -04:00
henrik karlsson
ec949d0e71 [ApplicationCore]
* WindowsConsoleOutputDevice2 - Changed ::SetThreadDescription to use wrapped function that does not depend on new versions of windows runtime

#rb Mitchell.Fisher

[CL 21998832 by henrik karlsson in ue5-main branch]
2022-09-13 22:43:48 -04:00
rex hill
f6a8d68d78 Moved DebugConsole.ini to EngineUserDir's /Config/DebugConsole.ini
#preflight 63209b46e93a80888c4490d5

[CL 21997832 by rex hill in ue5-main branch]
2022-09-13 21:50:16 -04:00
adam kinge
50b774bb5e Fix iOS15 deprecation warnings.
#fyi axel.riffard
#rb trivial
#rnx
#preflight 631f9337e07c4dc0b12dd0c2

[CL 21972591 by adam kinge in ue5-main branch]
2022-09-12 17:01:54 -04:00
axel riffard
ca0d2c56ac Fix warnings in build health related to iOS 15
#jira UE-163352
#rb none
#preflight 631f266294758d0bf21e5251

[CL 21963790 by axel riffard in ue5-main branch]
2022-09-12 08:41:02 -04:00
axel riffard
c64aa2de93 Catalina, iOS 14 removal
Metal 2.3 removed, Metal 3.0 added for Mac

#jira UE-163352
#rb adam.kinge bertrand.carre
#preflight 631ea7eb94758d0bf2008668

[CL 21960671 by axel riffard in ue5-main branch]
2022-09-11 23:47:08 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
henrik karlsson
1437dc5521 [Core Runtime - WindowsConsoleOutputDevice2]
* Fixed buggy datetime output.
* Added so shell execute can be done from activity texts. Just add [<command>] to the activity and the command(s) will execute the command when clicking on the activity. Example [https://someurl] will trigger the browser to open the linik

#rb self
#preflight 63191935980179553e9ba3ac

[CL 21907370 by henrik karlsson in ue5-main branch]
2022-09-08 19:30:45 -04:00
axel riffard
494b98c831 Remove Catalina support and Metal 2.2 from Mac.
#jira UE-149923
#rb jack.porter
#preflight 6315c60bf448dc6e58121822

[CL 21790515 by axel riffard in ue5-main branch]
2022-09-05 06:05:22 -04:00
calvin zheng
b31b4f0859 Remove/replace uses of master/slave found in ApplicationCore with base folder Runtime
#jira UE-158647
#preflight 63122ba1ec45fbf3d7630327
#rb Zack.Neyland

[CL 21763441 by calvin zheng in ue5-main branch]
2022-09-02 13:25:27 -04:00