Commit Graph

16603 Commits

Author SHA1 Message Date
sebastian nordgren
d5fc3247fe File History no longer hangs forever.
Timelapse now passes in the -l flag to set the line we're interested in.

OutputString is now called as OutputStringThreadSafe, as recommended by documentation.

#review-22858322 @paul.chipchase
#fyi andrew.firth
#preflight 63738087ee4d25f90a1f150d

[CL 23134198 by sebastian nordgren in ue5-main branch]
2022-11-15 07:17:28 -05:00
Rafa Lecina
03b4a563b1 Update FacebookSDK iOS on OnlineSubsystemfacebook
Removed all deprecated functionality and left a common set of functionality on all implementations (REST, Android and IOS)
Removed old Facebook SDK framework and used latest Facebook SDK XCFramework(v15.0.0). New Facebook files added in a different review to avoid noise
Enabled ARC for module. It also needs linking against Swift standard library
Depends on:
 https://p4-swarm.epicgames.net/reviews/22775386: Add support to enable ARC in modules
 https://p4-swarm.epicgames.net/reviews/22810334: Link against Swift standard library
 https://p4-swarm.epicgames.net/changes/23002644: Add support for XCFramework in UBT
 https://p4-swarm.epicgames.net/reviews/23025630: Add Facebook SDK v15.0.0 XCFramework
Moved out Facebook settings additions into Info.plist from UBT and added using an UPL file

#jira UE-162598
#review @Sam.Zamani, @Bertrand.Carre, @Chris.Varnsverry
#preflight

[CL 23133825 by Rafa Lecina in ue5-main branch]
2022-11-15 06:03:38 -05:00
Rafa Lecina
df001c1d21 Support enable ARC in modules
#jira UE-107891
#review @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams  @Jack.Porter
#preflight

[CL 23133821 by Rafa Lecina in ue5-main branch]
2022-11-15 06:02:36 -05:00
Joakim Lindqvist
758d8e4330 UnrealCloudDDC - Tweaked the OpenTelemetry tracing, upgrading to newer libraries that gives us better options to enrich and adding the operation name to scylla.
Removed Azure telemetry exporter as it was a hassle to configure in a optional way, its better if people just use the OTLP path anyway

#preflight none

[CL 23133743 by Joakim Lindqvist in ue5-main branch]
2022-11-15 05:48:07 -05:00
Rafa Lecina
4e08b2ba53 Add support for XCFramework to UBT on iOS
#jira UE-168983
#review-23009903 @Sam.Zamani @Bertrand.Carre @Chris.Varnsverry @Roman.Dzieciol @Josh.Adams @Jack.Porter
#preflight

[CL 23133403 by Rafa Lecina in ue5-main branch]
2022-11-15 04:20:41 -05:00
joe kirchoff
7ec6d6154f FixIncludePaths: Add -IncludeFilter to limit the #includes that are modified
Add progress printing
Disallow relative parent directory pathing, currently breaks some #includes

#rnx
#rb Bryan.Sefcik
#preflight none

[CL 23129418 by joe kirchoff in ue5-main branch]
2022-11-14 18:26:52 -05:00
Rob Cannaday
5feba1c483 Add HttpFwd and OnlineSubsystemMcpFwd to exclude list. They include namespaces and typedefs.
#preflight skip

[CL 23129004 by Rob Cannaday in ue5-main branch]
2022-11-14 18:01:59 -05:00
joe pribele
242962a719 added new macro UE_DISABLE_OPTIMIZATION_SHIP to replace PRAGMA_DISABLE_OPTIMIZATION
will deprecate `PRAGMA_DISABLE_OPTIMIZATION `in a following changelist after converting code to use `UE_DISABLE_OPTIMIZATION_SHIP`

added `UE_CHECK_DISABLE_OPTIMIZATION` to check for
`UE_DISABLE_OPTIMIZATION` being left in by accident

will enable `UE_CHECK_DISABLE_OPTIMIZATION` in a following changelist
#preflight 6372b159953c19d43537b088

[CL 23126725 by joe pribele in ue5-main branch]
2022-11-14 16:37:00 -05:00
Josh Engebretson
4bf2ce7ddb Horde: Add a test stream collection as discovering these from refs is too slow and doesn't cache readily
#jira none
#rnx
#preflight none

[CL 23126427 by Josh Engebretson in ue5-main branch]
2022-11-14 16:29:04 -05:00
jaco vandyk
b138b4e55f Verification of Capsule and Box support functions when used with non uniform scaling
#rb trivial
[FYI] Benn.Gallagher
#preflight 63726a609e3bea8079f76018

[CL 23124848 by jaco vandyk in ue5-main branch]
2022-11-14 15:56:26 -05:00
Wojciech Krywult
c33e67d6dc UBT: Added a log message confirming that a .json file with build actions has been created when using -WriteOutdatedActions command-line argument.
#preflight 63729c77b6636838287c5ec9
#rb none
#rnx

[CL 23124452 by Wojciech Krywult in ue5-main branch]
2022-11-14 15:45:31 -05:00
Wojciech Krywult
74cdb44436 Build: Symbol Server: Added support for source server (source code indexing) for consoles.
Source code indexing allows Visual Studio to automatically fetch the right source code files from Perforce when debugging builds/crashdumps.

Previously, we had this functionality available only on Windows in the form of SrcSrv build task (build graph). This task takes generated pdbs and embeds information about the source code used into them. However, this functionality doesn't translate well into similar features on other platforms.

Resolved by extending SymStore task to handle source indexing in additional to uploading symbols to the symbol store. SrcSrv remains functional, but it still works only on Windows. For this reason, SymStore becomes the preferred solution as it's more general.

Fixed a few additional problems, both in the task itself and our game's build graph.

#preflight 63727a48ee4d25f90ace140b
#rb Robert.Millar
#jira UE-70463

[CL 23123619 by Wojciech Krywult in ue5-main branch]
2022-11-14 14:37:48 -05:00
Ben Marsh
29285ad78f Horde: Disable tailing calls to log RPC server, and output diagnostic messages when updating the corresponding ref.
#preflight none

[CL 23123515 by Ben Marsh in ue5-main branch]
2022-11-14 14:30:25 -05:00
bryan sefcik
d464a46b31 Reorganized the unity logic to take into account the generated cpp files when determining whether to use unity files. Previously the logic wouldn't take into account the number of generated files which meant that modules that had just generated cpp files wouldn't use unity files.
Before:
Unity Files: 6759
Total CPU Time: 77035.734375 s
Total time in Parallel executor: 2062.95 seconds

After:
Unity Files: 6656
Total CPU Time: 76182.40625 s
Total time in Parallel executor: 2047.47 seconds

#jira
[FYI] joe.kirchoff
#preflight 637273a1ee4d25f90acc3712

[CL 23123139 by bryan sefcik in ue5-main branch]
2022-11-14 14:15:09 -05:00
bryan sefcik
4d44e233d7 Added a mode that profiles different unity sizes and returns the best size for each module.
#jira
[FYI] joe.kirchoff

[CL 23123092 by bryan sefcik in ue5-main branch]
2022-11-14 14:14:05 -05:00
Ben Marsh
b37258c839 Horde: Add a slash between blob prefixes and identifiers.
#preflight none

[CL 23122738 by Ben Marsh in ue5-main branch]
2022-11-14 13:53:41 -05:00
Ben Marsh
4631c7ed00 Horde: Add missing TreeNodeAttributes to temp storage classes. Also fix reference to type not exposed through DI.
#preflight none

[CL 23122226 by Ben Marsh in ue5-main branch]
2022-11-14 13:33:08 -05:00
Ben Marsh
f67e4d9966 Horde: Handle multiple logger types when unwrapping the JSON RPC logger.
#preflight none

[CL 23121618 by Ben Marsh in ue5-main branch]
2022-11-14 13:09:34 -05:00
Ben Marsh
fb6642e3d3 Horde: Fix invalid cast when using new logger backend.
#preflight none

[CL 23121370 by Ben Marsh in ue5-main branch]
2022-11-14 12:56:14 -05:00
Wojciech Krywult
5b7ef50b76 UBT: Edit and Continue: Unified the property names used to enable edit and continue.
On some platforms we used bUseLiveCodeEdit, which was expected to be present in the per-platform configuration block. At the same time, on Windows we rely on bSupportEditAndContinue from BuildConfiguration.

Modified the console platforms to use BuildConfiguration.bSupportEditAndContinue for consistency. However, there is some value in being able to control this setting per-platform, so I've left the existing properties and just renamed them bUseLiveCodeEdit -> bSupportEditAndContinue.

As a result, all platforms that support Edit and Continue are affected by BuildConfiguration.bSupportEditAndContinue. However, if XXPlatform.bSupportEditAndContinue is presetnt, it overrides the global.

Removed ClangToolChainOptions.EnableLiveCodeEditing and related code as it turns out it wasn't really used.

#preflight 637274a99e3bea8079f98af5
#rb Joe.Kirchoff

[CL 23120407 by Wojciech Krywult in ue5-main branch]
2022-11-14 12:15:28 -05:00
Wojciech Krywult
3f2f9f9376 UBT: XmlConfigFile: Fixed potential exceptions handling deprecated properties and improved diagnostic messages when using renamed members (NewAttributeName).
#preflight 637272865368a3230a54cb81
#rb Joe.Kirchoff
#rnx

[CL 23120016 by Wojciech Krywult in ue5-main branch]
2022-11-14 12:04:09 -05:00
Josh Adams
7a9968a030 - Fix for bad bundle id for editor builds in installed build projects, related to the plist changes needed for Xcode14
#jira UE-169934
#preflight 6372664db6636838286afa32

[CL 23119760 by Josh Adams in ue5-main branch]
2022-11-14 11:49:56 -05:00
Joakim Lindqvist
d9990b084c UnrealCloudDDC - Reworked all datadog tracing to use OpenTelemetry instead, sending the traces to datadog as OTLP streams instead (this is not fully tested how it looks like on datadog). Added ability to export to Azure monitor as well (though it would be preferable to use the OTLP stream there as well).
Also reworked a few places were we were not using dependency injection to create objects causing a lot of frustration as we added more things that assumed DI.

#preflight 6372532c232e3d12cb5bdd64

[CL 23117833 by Joakim Lindqvist in ue5-main branch]
2022-11-14 10:12:52 -05:00
Tim Smith
1171f486fd Fixed issue in C# UHT where it would fail to generate an error when preprocessor lines appear in an inheritence list.
#rb self
#preflight 637247318f4cb2e4dc90d501

[CL 23117020 by Tim Smith in ue5-main branch]
2022-11-14 08:56:06 -05:00
Helge Mathee
1ecdfaec3f UHT: Fix RigVM related compat issues
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/63721afa5368a3230a3ca9ee

[CL 23116147 by Helge Mathee in ue5-main branch]
2022-11-14 06:25:24 -05:00