Change consist of only forward declaration and additional includes
#preflight 63789c1de30d438849c48188
#rb none
[CL 23218412 by henrik karlsson in ue5-main branch]
This is necessary because although we register an OnRowReleased handler, we also register a Visibility handler in SDetailsViewBase::GetTreeVisibility(). The OnRowReleased delegate is called when the tree next Ticks(), but when the tree is cleared, it also gets its visibility set to Collapsed, which causes the next Tick() to not occur. Since there's no way to force the tree to Tick(), this is the next best thing.
Added a few trace macros.
#jira UE-162823
[REVIEW] [at]patrick.boutot
#rnx
#preflight 6376176b4f460e024c15a9cf
[CL 23174550 by sebastian nordgren in ue5-main branch]
Added IPropertyHandle::GetDoubleMetaData().
Reported on UDN.
#rb lauren.barnes
#preflight 6373878332484253052694ab
[CL 23134410 by sebastian nordgren in ue5-main branch]
* Adding forward declarations
* Adding "inline" in front of const/constexpr variables in headers
* Adding includes
* A few moves of ctor/dtor to cpp file
#preflight 6372b3ac0c74adb48b49f313
#rb none
[CL 23130896 by henrik karlsson in ue5-main branch]
* Added tooltips to Select material's texture in asset browser button in order to help understanding what this is about when there's no texture referenced by the material
* Disabled the button when there's no texture, since it's basically useless then
#rb jeremy.moore
#preflight 63721e42232e3d12cb4e8b48
[CL 23118414 by jonathan bard in ue5-main branch]
Changes from previous submit:
- ExpandedCustomItems uses TStringBuilder::Join()
- FStringPrefixTree::GetAllEntries() uses a const FString& to avoid a potential memcpy crash.
- Added checks to FStringPrefixTree for empty prefixes being added to the tree.
- Fixed bug where re-adding a substring along a node split boundary (eg. "FooFoo", "FooBar", "FooBar") would cause the intermediate node to be marked as a leaf (instead of the child), added tests for it.
[REVIEW] [at]richard.talbotwatkins, [at]paul.chipchase
#rnx
#preflight 636a59dc450be1d9f8261079
[CL 23069417 by sebastian nordgren in ue5-main branch]
This was most apparent with DataTables that used EditConditions that had the EditConditionHides metadata. After clearing the table, the rows would still refresh for a single frame, and the edit condition parser would try to check the edit condition state. However, this would end up calling into FProperty::ContainerPtrToValuePtr(nullptr), which causes a check.
Now, GetValuePtrOfInstance() early outs before making the call.
Reported on UDN.
#review-23009532 @paul.chipchase
#preflight 636a5a9563037c1026442fc9
[CL 23027219 by sebastian nordgren in ue5-main branch]
[FYI] sebastian.nordgren
Original CL Desc
-----------------------------------------------------------------
Switched expanded nodes in SDetailsViewBase to use FStringPrefixTree.
This improved performance in one test case when calling RestoreExpandedItems() from ~500ms to ~100ms.
[REVIEW] [at]paul.chipchase
#rnx
#preflight 63650cc94b0e01486a51eb06
[CL 23019381 by aurel cordonnier in ue5-main branch]
This improved performance in one test case when calling RestoreExpandedItems() from ~500ms to ~100ms.
[REVIEW] [at]paul.chipchase
#rnx
#preflight 63650cc94b0e01486a51eb06
[CL 23011519 by sebastian nordgren in ue5-main branch]
The set "A.B", "A.C", "B" would result in a tree like this, with the asterisked nodes being leaf nodes:
|- A.
| |- B *
| |- C *
|- B *
[REVIEW] [at]paul.chipchase
#rnx
#preflight 6364fed81052c15f13ff64fe
[CL 22985542 by sebastian nordgren in ue5-main branch]
When FPropertyNode::EnsureDataIsValid() returns ChildrenRebuilt, it was only marking itself as bChildrenRebuilt = false.
SDetailsViewBase now calls FPropertyNode::MarkChildrenAsRebuilt, which recursively clears the flag from everything.
[REVIEW] [at]lauren.barnes, [at]patrick.boutot, [at]jay.nakai
#preflight 635a889e0d3a231123cb1f6c
[CL 22810916 by sebastian nordgren in ue5-main branch]
Only shows if a nanite material is set.
Waiting on custom icon, and uses duplicate of content browse icon for now.
[CL 22803519 by jeremy moore in ue5-main branch]
- Updated text properties to respect the MaxLength meta-data
- Updated name properties to respect the MaxLength meta-data if it's smaller than the max length of an FName
#rb Rex.Hill
#rnx
[CL 22803456 by jamie dale in ue5-main branch]
In PropertyNode::FilterNodes, filter the property key node, if present, to prevent this.
#jira: UE-165084
#rb sebastian.nordgren
#preflight 63497bbace524ed356e3c61c
[CL 22580642 by karen jirak in ue5-main branch]
